Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-06 Thread Felipe Contreras
On Thu, Feb 4, 2010 at 11:23 PM, Andrew Morton a...@linux-foundation.org wrote: On Thu, 4 Feb 2010 22:05:59 +0100 Ingo Molnar mi...@elte.hu wrote: Regressions are not limited to 'same config' kernels, last i checked. If that has changed (or if i'm misunderstanding it) then it would be nice to

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-05 Thread Dave Airlie
If it now does not boot up if all its sub-options are enabled, even of some of those sub-options are new, does that count as a driver regression? Sure it does to me ... But it doesn't to anyone else under any reasonable meaning of the word regression. The config option states Choose this

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-05 Thread Ingo Molnar
* Dave Airlie airl...@linux.ie wrote: If it now does not boot up if all its sub-options are enabled, even of some of those sub-options are new, does that count as a driver regression? Sure it does to me ... But it doesn't to anyone else under any reasonable meaning of the word

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-05 Thread Dave Airlie
On Fri, Feb 5, 2010 at 7:00 PM, Ingo Molnar mi...@elte.hu wrote: * Dave Airlie airl...@linux.ie wrote: If it now does not boot up if all its sub-options are enabled, even of some of those sub-options are new, does that count as a driver regression? Sure it does to me ... But it

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-05 Thread Ingo Molnar
* Dave Airlie airl...@gmail.com wrote: On Fri, Feb 5, 2010 at 7:00 PM, Ingo Molnar mi...@elte.hu wrote: * Dave Airlie airl...@linux.ie wrote: If it now does not boot up if all its sub-options are enabled, even of some of those sub-options are new, does that count as a driver

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Ingo Molnar
* Matthew Garrett mj...@srcf.ucam.org wrote: On Thu, Feb 04, 2010 at 08:17:05AM +0100, Ingo Molnar wrote: btw., i just found another bug activated via this same commit, a boot hang after DRM init: The commit in question didn't cause the hang, so reverting it isn't the appropriate

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Linus Torvalds
On Thu, 4 Feb 2010, Ingo Molnar wrote: Well, once i applied the revert i got no more hangs or crashes today, in lots of bootups. This is fully repeatable - if i re-apply that commit with the config i sent the hang happens again. But that's just because when it was in staging, you'd never

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Matthew Garrett
On Thu, Feb 04, 2010 at 08:17:05AM +0100, Ingo Molnar wrote: btw., i just found another bug activated via this same commit, a boot hang after DRM init: The commit in question didn't cause the hang, so reverting it isn't the appropriate fix. -- Matthew Garrett | mj...@srcf.ucam.org

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Ingo Molnar
* Linus Torvalds torva...@linux-foundation.org wrote: On Thu, 4 Feb 2010, Ingo Molnar wrote: Well, once i applied the revert i got no more hangs or crashes today, in lots of bootups. This is fully repeatable - if i re-apply that commit with the config i sent the hang happens again.

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Alex Deucher
On Thu, Feb 4, 2010 at 1:12 PM, Ingo Molnar mi...@elte.hu wrote: * Matthew Garrett mj...@srcf.ucam.org wrote: On Thu, Feb 04, 2010 at 06:54:45PM +0100, Ingo Molnar wrote: But you could claim that it's not a regression because 1) technically the code got introduced in drivers/staging/, and

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Matthew Garrett
On Thu, Feb 04, 2010 at 06:08:26PM +0100, Ingo Molnar wrote: Well, once i applied the revert i got no more hangs or crashes today, in lots of bootups. This is fully repeatable - if i re-apply that commit with the config i sent the hang happens again. If you leave the commit applied, use

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Matthew Garrett
On Thu, Feb 04, 2010 at 07:12:18PM +0100, Ingo Molnar wrote: * Matthew Garrett mj...@srcf.ucam.org wrote: The reason the option was in staging (as has been mentioned before) was because the ABI wasn't felt to be stable enough. Upstream is now willing to commit to that stability, so now

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Ingo Molnar
* Matthew Garrett mj...@srcf.ucam.org wrote: On Thu, Feb 04, 2010 at 07:12:18PM +0100, Ingo Molnar wrote: * Matthew Garrett mj...@srcf.ucam.org wrote: The reason the option was in staging (as has been mentioned before) was because the ABI wasn't felt to be stable enough. Upstream is

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Ingo Molnar
* Matthew Garrett mj...@srcf.ucam.org wrote: On Thu, Feb 04, 2010 at 07:56:03PM +0100, Ingo Molnar wrote: Do you see my argument why any user who is hit by this would categorize this as a kernel regression in an existing driver? No. If a user changes configuration and gets a hang,

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Linus Torvalds
On Thu, 4 Feb 2010, Alex Deucher wrote: And if it crashes, he'll report a bug and we'll fix it. Ok, you have a bug-report. See earlier in the thread: btw., i just found another bug activated via this same commit, a boot hang after DRM init: [9.858352] [drm] Connector 1: [

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Jerome Glisse
On Thu, Feb 04, 2010 at 08:19:35PM +0100, Ingo Molnar wrote: * Matthew Garrett mj...@srcf.ucam.org wrote: On Thu, Feb 04, 2010 at 07:56:03PM +0100, Ingo Molnar wrote: Do you see my argument why any user who is hit by this would categorize this as a kernel regression in an existing

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Ingo Molnar
* Alex Deucher alexdeuc...@gmail.com wrote: On Thu, Feb 4, 2010 at 2:06 PM, Ingo Molnar mi...@elte.hu wrote: * Alex Deucher alexdeuc...@gmail.com wrote: On Thu, Feb 4, 2010 at 1:12 PM, Ingo Molnar mi...@elte.hu wrote: * Matthew Garrett mj...@srcf.ucam.org wrote: On Thu, Feb

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Dave Airlie
On Fri, Feb 5, 2010 at 5:24 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Thu, 4 Feb 2010, Alex Deucher wrote: And if it crashes, he'll report a bug and we'll fix it. Ok, you have a bug-report. See earlier in the thread: btw., i just found another bug activated via this same

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Ingo Molnar
* Jesse Barnes jbar...@virtuousgeek.org wrote: On Thu, 4 Feb 2010 20:32:32 +0100 Ingo Molnar mi...@elte.hu wrote: Nobody has reacted to my related boot hang bugreport yet - and it's detailed and fully reproducible (so i can test any proposed fixes as well in short order). I.e. my limited

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Jesse Barnes
On Thu, 4 Feb 2010 20:32:32 +0100 Ingo Molnar mi...@elte.hu wrote: Nobody has reacted to my related boot hang bugreport yet - and it's detailed and fully reproducible (so i can test any proposed fixes as well in short order). I.e. my limited testing has triggered two separate bugs in the same

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Ingo Molnar
* Jerome Glisse gli...@freedesktop.org wrote: On Thu, Feb 04, 2010 at 08:19:35PM +0100, Ingo Molnar wrote: * Matthew Garrett mj...@srcf.ucam.org wrote: On Thu, Feb 04, 2010 at 07:56:03PM +0100, Ingo Molnar wrote: Do you see my argument why any user who is hit by this would

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Ingo Molnar
* Jesse Barnes jbar...@virtuousgeek.org wrote: [...] That action might hang or crash his kernel, and if that user then reports: Hey, -rc7 just hung on me after enabling this new .config option it offered for the radeon driver i am using, please add this to the list of

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Ingo Molnar
* Matthew Garrett mj...@srcf.ucam.org wrote: On Thu, Feb 04, 2010 at 09:22:54PM +0100, Ingo Molnar wrote: Hey, -rc7 just hung on me after enabling this new .config option it offered for the radeon driver i am using, please add this to the list of regressions. If the

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Andrew Morton
On Thu, 4 Feb 2010 22:05:59 +0100 Ingo Molnar mi...@elte.hu wrote: * Matthew Garrett mj...@srcf.ucam.org wrote: On Thu, Feb 04, 2010 at 09:22:54PM +0100, Ingo Molnar wrote: Hey, -rc7 just hung on me after enabling this new .config option it offered for the radeon driver i

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Dave Airlie
On Fri, Feb 5, 2010 at 7:23 AM, Andrew Morton a...@linux-foundation.org wrote: On Thu, 4 Feb 2010 22:05:59 +0100 Ingo Molnar mi...@elte.hu wrote: * Matthew Garrett mj...@srcf.ucam.org wrote: On Thu, Feb 04, 2010 at 09:22:54PM +0100, Ingo Molnar wrote:   Hey, -rc7 just hung on me

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Matthew Garrett
On Thu, Feb 04, 2010 at 09:22:54PM +0100, Ingo Molnar wrote: Hey, -rc7 just hung on me after enabling this new .config option it offered for the radeon driver i am using, please add this to the list of regressions. If the same configuration options hang on both an old kernel and

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Matthew Garrett
On Thu, Feb 04, 2010 at 10:05:59PM +0100, Ingo Molnar wrote: Regressions are not limited to 'same config' kernels, last i checked. If that has changed (or if i'm misunderstanding it) then it would be nice to hear a clarification about that from Linus. If an option has *never* worked on a

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread david
On Thu, 4 Feb 2010, Ingo Molnar wrote: * Jesse Barnes jbar...@virtuousgeek.org wrote: On Thu, 4 Feb 2010 20:32:32 +0100 Ingo Molnar mi...@elte.hu wrote: Nobody has reacted to my related boot hang bugreport yet - and it's detailed and fully reproducible (so i can test any proposed fixes as

Re: hung bootup with drm/radeon/kms: move radeon KMS on/off switch out of staging.

2010-02-04 Thread Ingo Molnar
* Matthew Garrett mj...@srcf.ucam.org wrote: On Thu, Feb 04, 2010 at 10:05:59PM +0100, Ingo Molnar wrote: Regressions are not limited to 'same config' kernels, last i checked. If that has changed (or if i'm misunderstanding it) then it would be nice to hear a clarification about