[PATCH 2/3] staging/nvec: reimplement on top of tegra i2c driver

2015-01-28 Thread Andrey Danin
Remove i2c controller related code and use tegra i2c driver in slave mode. Signed-off-by: Andrey Danin --- drivers/staging/nvec/nvec.c | 379 ++-- drivers/staging/nvec/nvec.h | 17 +- 2 files changed, 122 insertions(+), 274 deletions(-) diff --git a/driv

[PATCH v2 02/02] STAGING: Fix pcl818.c coding style issue: line over 80 characters

2015-01-28 Thread Simon Guo
Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - line over 80 characters Signed-off-by: Simon Guo --- drivers/staging/comedi/drivers/pcl818.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/

[PATCH v2 01/02] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible

2015-01-28 Thread Simon Guo
Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. - code indent should use tabs where possible It is fixed by reformatting the comment block to usual comment style. And with the reformatting, following coding style problem is also fixed: - please, no space before tabs Signe

Re: [PATCH] staging: emxx_udc: emxx_udc: Removed variables that is never used

2015-01-28 Thread Chris Rorvick
On Wed, Jan 28, 2015 at 4:42 PM, Rickard Strandqvist wrote: > Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. Each of these changes adds a warning ... > diff --git a/drivers/staging/emxx_udc/emxx_udc.c > b/drivers/staging/emxx_

Re: [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf

2015-01-28 Thread Joe Perches
On Wed, 2015-01-28 at 16:05 +0200, Heba Aamer wrote: > This patch fixes the following checkpatch.pl warning: > Prefer seq_puts to seq_printf checkpatch is pretty stupid. Please don't just do what it says. Look further and see what else can be improved. > diff --git a/drivers/staging/lustre/lustr

RE: [RFC] ion:change ion_cma_allocate return error value

2015-01-28 Thread Wang, Yalin
> -Original Message- > From: 'gre...@linuxfoundation.org' [mailto:gre...@linuxfoundation.org] > Sent: Thursday, January 29, 2015 2:45 AM > To: Wang, Yalin > Cc: 'tranmanph...@gmail.com'; 'fabio.este...@freescale.com'; > 'prime.z...@huawei.com'; 'de...@driverdev.osuosl.org'; 'linux- > ker...

Re: [PATCH] staging: lustre: fid: lproc_fid: Removed variables that is never used

2015-01-28 Thread Joe Perches
On Wed, 2015-01-28 at 23:46 +0100, Rickard Strandqvist wrote: > Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. [] > diff --git a/drivers/staging/lustre/lustre/fid/lproc_fid.c > b/drivers/staging/lustre/lustre/fid/lproc_fid.c [] >

[PATCH RESEND V2 2/8] Drivers: hv: vmbus: rename channel work queues

2015-01-28 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov <[mailto:vkuzn...@redhat.com]> All channel work queues are named 'hv_vmbus_ctl', this makes them indistinguishable in ps output and makes it hard to link to the corresponding vmbus device. Rename them to hv_vmbus_ctl/N and make vmbus device names match, e.g. now vmbus_1 devi

[PATCH RESEND V2 8/8] Drivers: hv: vmbus: Teardown clockevent devices on module unload

2015-01-28 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov <[mailto:vkuzn...@redhat.com]> Newly introduced clockevent devices made it impossible to unload hv_vmbus module as clockevents_config_and_register() takes additional reverence to the module. To make it possible again we do the following: - avoid setting dev->owner for clocke

[PATCH RESEND V2 4/8] Drivers: hv: vmbus: avoid double kfree for device_obj

2015-01-28 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov <[mailto:vkuzn...@redhat.com]> On driver shutdown device_obj is being freed twice: 1) In vmbus_free_channels() 2) vmbus_device_release() (which is being triggered by device_unregister() in vmbus_device_unregister(). This double kfree leads to the following sporadic crash

[PATCH RESEND V2 5/8] Drivers: hv: vmbus: teardown hv_vmbus_con workqueue and vmbus_connection pages on shutdown

2015-01-28 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov <[mailto:vkuzn...@redhat.com]> We need to destroy hv_vmbus_con on module shutdown, otherwise the following crash is sometimes observed: [ 76.569845] hv_vmbus: Hyper-V Host Build:9600-6.3-17-0.17039; Vmbus version:3.0 [ 82.598859] BUG: unable to handle kernel paging req

[PATCH RESEND V2 7/8] clockevents: export clockevents_unbind_device instead of clockevents_unbind

2015-01-28 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov <[mailto:vkuzn...@redhat.com]> It looks like clockevents_unbind is being exported by mistake as: - it is static; - it is not listed in include/linux/clockchips.h; - EXPORT_SYMBOL_GPL(clockevents_unbind) follows clockevents_unbind_device() implementation. I think clockeven

[PATCH RESEND V2 3/8] drivers:hv:vmbus drivers:hv:vmbus Allow for more than one MMIO range for children

2015-01-28 Thread K. Y. Srinivasan
From: Jake Oshins <[mailto:ja...@microsoft.com]> This set of changes finds the _CRS object in the ACPI namespace that contains memory address space descriptors, intended to convey to VMBus which ranges of memory-mapped I/O space are available for child devices, and then builds a resource list that

[PATCH RESEND V2 6/8] drivers: hv: vmbus: Teardown synthetic interrupt controllers on module unload

2015-01-28 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov <[mailto:vkuzn...@redhat.com]> SynIC has to be switched off when we unload the module, otherwise registered memory pages can get corrupted after (as Hyper-V host still writes there) and we see the following crashes for random processes: [ 89.116774] BUG: Bad page map in p

[PATCH RESEND V2 1/8] Drivers: hv: vmbus: prevent cpu offlining on newer hypervisors

2015-01-28 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov When an SMP Hyper-V guest is running on top of 2012R2 Server and secondary cpus are sent offline (with echo 0 > /sys/devices/system/cpu/cpu$cpu/online) the system freeze is observed. This happens due to the fact that on newer hypervisors (Win8, WS2012R2, ...) vmbus channel

[PATCH RESEND V2 0/8] Drivers: hv: vmbus: Enable unloading of vmbus driver

2015-01-28 Thread K. Y. Srinivasan
Windows hosts starting with Ws2012 R2 permit re-establishing the vmbus connection from the guest. This patch-set includes patches from Vitaly to cleanup the VMBUS unload path so we can potentially reload the driver. This set also includes a patch from Jake to correctly extract MMIO information on

Re: [HPDD-discuss] [PATCH] staging: lustre: fid: lproc_fid: Removed variables that is never used

2015-01-28 Thread Frank Zago
On 01/28/2015 04:46 PM, Rickard Strandqvist wrote: Variable ar assigned a value that is never used. s/ar/rc/ I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers

Re: [PATCH] staging: xgifb: XGI_main_26: Change variables that is never used

2015-01-28 Thread Rickard Strandqvist
2015-01-28 23:43 GMT+01:00 Aaro Koskinen : > Hi, > > On Wed, Jan 28, 2015 at 10:38:07PM +0100, Rickard Strandqvist wrote: >> Variable ar assigned a value that is never used. >> Instead use the struct variable of the same name. >> >> This was found using a static code analysis program called cppchec

[PATCH] staging: rtl8188eu: core: rtw_efuse: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8188eu/core/rtw_efuse.c |4 ++-- 1 file changed, 2

[PATCH] staging: netlogic: xlr_net: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/netlogic/xlr_net.c |3 +-- 1 file changed, 1 insertion

[PATCH] staging: lustre: include: lustre_lib.h: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/lustre/lustre/include/lustre_lib.h |5 - 1 file ch

[PATCH] staging: media: vino: vino: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/media/vino/vino.c |2 -- 1 file changed, 2 deletions(-

Re: [PATCH] staging: xgifb: XGI_main_26: Change variables that is never used

2015-01-28 Thread Aaro Koskinen
Hi, On Wed, Jan 28, 2015 at 10:38:07PM +0100, Rickard Strandqvist wrote: > Variable ar assigned a value that is never used. > Instead use the struct variable of the same name. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- >

[PATCH] staging: lustre: fid: lproc_fid: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/lustre/lustre/fid/lproc_fid.c |3 +-- 1 file changed,

[PATCH] staging: gdm724x: gdm_usb: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/gdm724x/gdm_usb.c |4 1 file changed, 4 deletions

[PATCH] staging: ft1000: ft1000-usb: ft1000_hw: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/ft1000/ft1000-usb/ft1000_hw.c | 84 +++--

[PATCH] staging: ft1000: ft1000-usb: ft1000_download: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- .../staging/ft1000/ft1000-usb/ft1000_download.c| 45 +---

[PATCH] staging: ft1000: ft1000-usb: ft1000_debug: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 14 ++ 1

[PATCH] staging: ft1000: ft1000-pcmcia: ft1000_hw: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c |9 ++--- 1 file

[PATCH] staging: emxx_udc: emxx_udc: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/emxx_udc/emxx_udc.c |7 +++ 1 file changed, 3 inse

[PATCH] staging: dgnc: dgnc_tty: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/dgnc/dgnc_tty.c |9 ++--- 1 file changed, 2 insert

[PATCH] staging: dgnc: dgnc_cls: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/dgnc/dgnc_cls.c |4 +--- 1 file changed, 1 insertion(+

[PATCH] staging: dgap: dgap: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/dgap/dgap.c |5 + 1 file changed, 1 insertion(+),

[PATCH] staging: cptm1217: clearpad_tm1217: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/cptm1217/clearpad_tm1217.c | 35 +---

Re: [PATCH] staging: comedi: drivers: mite: Removed variables that is never used

2015-01-28 Thread Julia Lawall
On Wed, 28 Jan 2015, Rickard Strandqvist wrote: > Variable ar assigned a value that is never used. The variable is lkar. julia > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard

[PATCH] staging: comedi: drivers: usbduxsigma: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/usbduxsigma.c |3 +-- 1 file changed, 1

[PATCH] staging: comedi: drivers: rtd520: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/rtd520.c |6 ++ 1 file changed, 2 i

[PATCH] staging: comedi: drivers: ni_mio_cs: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/ni_mio_cs.c |3 --- 1 file changed, 3 d

[PATCH] staging: comedi: drivers: ni_atmio: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/ni_atmio.c |2 -- 1 file changed, 2 del

[PATCH] staging: comedi: drivers: mite: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/mite.c |3 +-- 1 file changed, 1 insert

Re: [PATCH v2] staging: comedi: drivers: addi-data: hwdrv_apci1500: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
2015-01-28 22:48 GMT+01:00 Hartley Sweeten : > On Wednesday, January 28, 2015 2:49 PM, Rickard Strandqvist wrote: >> Variable ar assigned a value that is never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called

[PATCH] staging: comedi: drivers: jr3_pci: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/jr3_pci.c |3 +-- 1 file changed, 1 ins

[PATCH] staging: comedi: drivers: dt2815: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/dt2815.c |3 +-- 1 file changed, 1 inse

[PATCH] staging: comedi: drivers: dyna_pci10xx: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/dyna_pci10xx.c |5 ++--- 1 file changed

[PATCH] staging: comedi: drivers: dt2814: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/dt2814.c | 13 - 1 file chang

[PATCH] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/addi_apci_3501.c |3 +-- 1 file changed

RE: [PATCH RESEND 1/8] Drivers: hv: vmbus: prevent cpu offlining on newer hypervisors

2015-01-28 Thread KY Srinivasan
> -Original Message- > From: K. Y. Srinivasan [mailto:k...@microsoft.com] > Sent: Tuesday, January 27, 2015 3:47 PM > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > vkuzn...@redhat.com; t...@linutronix.de

RE: [PATCH v2] staging: comedi: drivers: addi-data: hwdrv_apci1500: Removed variables that is never used

2015-01-28 Thread Hartley Sweeten
On Wednesday, January 28, 2015 2:49 PM, Rickard Strandqvist wrote: > Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist >

[PATCH] staging: comedi: drivers: addi-data: hwdrv_apci3501: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c |3 +-- 1 fi

[PATCH v2] staging: comedi: drivers: addi-data: hwdrv_apci1500: Removed variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c | 12 ++---

Re: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500: Change variables that is never used

2015-01-28 Thread Rickard Strandqvist
2015-01-28 22:42 GMT+01:00 Rickard Strandqvist : > Variable ar assigned a value that is never used. > Instead use the struct variable of the same name. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/comedi/dri

[PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500: Change variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. Instead use the struct variable of the same name. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c | 12 ++-- 1 file cha

[PATCH] staging: xgifb: XGI_main_26: Change variables that is never used

2015-01-28 Thread Rickard Strandqvist
Variable ar assigned a value that is never used. Instead use the struct variable of the same name. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/xgifb/XGI_main_26.c |4 ++-- 1 file changed, 2 insertions(+), 2 delet

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-28 Thread Aya Mahfouz
On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: > On 01/28/2015 09:53 AM, Heba Aamer wrote: > >This patch fixes the following checkpatch.pl warning: > >Prefer ether_addr_copy() over memcpy() > >if the Ethernet addresses are __aligned(2) > > > >I used the following coccinelle script: >

[PATCH] staging/fwserial: use correct vendor/version IDs

2015-01-28 Thread Clemens Ladisch
The driver was using the vendor ID 0xd00d1e from the FireWire core. However, this ID was not registered, and invalid. Instead, use the vendor/version IDs that now are officially assigned to firewire-serial: https://ieee1394.wiki.kernel.org/index.php/IEEE_OUI_Assignments Signed-off-by: Clemens Lad

RE: [PATCH 0/6] staging: comedi: reformat comedi_fops and range comments

2015-01-28 Thread Hartley Sweeten
On Wednesday, January 28, 2015 11:42 AM, Ian Abbott wrote: > 1) staging: comedi: comedi_fops.c: reformat copyright header > 2) staging: comedi: comedi_fops.c: document exported functions > 3) staging: comedi: comedi_fops.c: reformat ioctl handler comments > 4) staging: comedi: range.c: reformat ioc

[PATCH] staging: speakup: Remove unnecessary space

2015-01-28 Thread Bastian Plettner
This patch fixes the checkpath.pl warning: ERROR: space prohibited before that ',' (ctx:WxE) + MSG_FIRST_INDEX , And removes the unnecessary space. Signed-off-by: Bastian Plettner --- drivers/staging/speakup/i18n.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

Re: [PATCH 1/5] staging: fbtft: fix Macros with complex values should be enclosed in parentheses

2015-01-28 Thread Greg KH
On Wed, Jan 28, 2015 at 01:19:25PM +0200, Heba Aamer wrote: > This patch fixes the following checkpatch.pl error: > fix Macros with complex values should be enclosed in parentheses > > Signed-off-by: Heba Aamer > --- > drivers/staging/fbtft/fb_pcd8544.c |2 +- > 1 file changed, 1 insertion(+

Re: [PATCH 3/3] fix space required after that ','

2015-01-28 Thread Greg KH
On Mon, Jan 26, 2015 at 12:24:33PM +0200, Mariam Mohamed Fawzy wrote: > This patch fixes the following in checkpatch.pl error: > space required after that ',' > > Signed-off-by: Mariam Mohamed Fawzy > --- > drivers/staging/fbtft/fb_bd663474.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH 3.19.0-rc5 01/03] STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible

2015-01-28 Thread Greg Kroah-Hartman
On Mon, Jan 26, 2015 at 09:16:28PM +0800, Simon Guo wrote: > Correct one coding style problem(detected by checkpatch.pl) in pcl818.c. > - code indent should use tabs where possible > It is fixed by reformatting the comment block to usual comment style. > > Signed-off-by: Simon Guo > --- > driver

Re: [PATCH v3] staging: rtl8188eu: core: rtw_wlan_util: Remove some unused functions

2015-01-28 Thread Greg Kroah-Hartman
On Sun, Jan 25, 2015 at 06:44:30PM +0100, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: > CAM_empty_entry() get_bsstype() rtw_get_oper_choffset() > rtw_get_oper_bw() is_ap_in_wep() should_forbid_n_rate() > > This was partially found by using a static code analysis

Re: [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf

2015-01-28 Thread Greg KH
On Wed, Jan 28, 2015 at 04:05:33PM +0200, Heba Aamer wrote: > This patch fixes the following checkpatch.pl warning: > Prefer seq_puts to seq_printf > > Signed-off-by: Heba Aamer > --- > drivers/staging/lustre/lustre/osc/lproc_osc.c |8 > 1 file changed, 4 insertions(+), 4 deletions(

Re: [RFC] ion:change ion_cma_allocate return error value

2015-01-28 Thread 'gre...@linuxfoundation.org'
On Tue, Jan 27, 2015 at 02:04:21PM +0800, Wang, Yalin wrote: > This patch change the error return value from -1 to -ENOMEM, > so that userspace can get the correct errno, otherwise, > -1 will be -EPERM, userspace will print permission deny for allocation > failure. > > Signed-off-by: Yalin Wang >

[PATCH 3/6] staging: comedi: comedi_fops.c: reformat ioctl handler comments

2015-01-28 Thread Ian Abbott
The unlocked_ioctl handler calls a different function to handle each supported ioctl command code. Most of these have a block comment indicating which command code it handles, a brief description, and an informal description of the inputs and outputs. These block comments are formatted in various

[PATCH 4/6] staging: comedi: range.c: reformat ioctl handler comment

2015-01-28 Thread Ian Abbott
The unlocked_ioctl handler in "comedi_fops.c" calls a different function to handle each supported ioctl command code. Most of these have a block comment indicating which command code it handles, a brief description, and an informal description of the inputs and outputs. These block comments were

[PATCH 0/6] staging: comedi: reformat comedi_fops and range comments

2015-01-28 Thread Ian Abbott
1) staging: comedi: comedi_fops.c: reformat copyright header 2) staging: comedi: comedi_fops.c: document exported functions 3) staging: comedi: comedi_fops.c: reformat ioctl handler comments 4) staging: comedi: range.c: reformat ioctl handler comment 5) staging: comedi: range.c: reformat copyright

[PATCH 1/6] staging: comedi: comedi_fops.c: reformat copyright header

2015-01-28 Thread Ian Abbott
Use the usual block comment style. Signed-off-by: Ian Abbott --- drivers/staging/comedi/comedi_fops.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 68bfe92.

[PATCH 6/6] staging: comedi: comedi_fops.c: reformat remaining block comments

2015-01-28 Thread Ian Abbott
Reformat remaining block comments to use the usual block comment style. Signed-off-by: Ian Abbott --- drivers/staging/comedi/comedi_fops.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/c

[PATCH 2/6] staging: comedi: comedi_fops.c: document exported functions

2015-01-28 Thread Ian Abbott
Add kerneldoc for exported functions `comedi_dev_put()`, `comedi_dev_get_from_minor()`, `comedi_is_subdevice_running()`, and `comedi_event()`. Signed-off-by: Ian Abbott --- drivers/staging/comedi/comedi_fops.c | 42 1 file changed, 42 insertions(+) diff --gi

[PATCH 5/6] staging: comedi: range.c: reformat copyright comment

2015-01-28 Thread Ian Abbott
Use the usual block comment style. Signed-off-by: Ian Abbott --- drivers/staging/comedi/range.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c index 00e71c7..6a393b2 100644 ---

Re: make allyesconfig i386 build failure with next-20150122 (caused by fb_agm1264k-fl driver)

2015-01-28 Thread Greg Kroah-Hartman
On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote: > On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote: > > make ARCH=i386 allyesconfig fails with > > > > drivers/staging/built-in.o: In function `reset': > > (.text+0x2ae89d): multiple definition of `reset' > > drivers/isdn/buil

[PATCH] staging: comedi: addi_apci_1500: fix array access out of bounds error

2015-01-28 Thread H Hartley Sweeten
The private data 'pm', 'pt', and 'pp' array members hold the trigger mode parameters for ports A and B. Both ports are 8-bits and the arrays are 16-bits. Array index 0 defines the AND mode and index 1 the OR mode parameters for both ports. The valid triggers to start the async command are 0 to 3 w

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-28 Thread Larry Finger
On 01/28/2015 09:53 AM, Heba Aamer wrote: This patch fixes the following checkpatch.pl warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) I used the following coccinelle script: @@ expression E1,E2;constant E3; @@ - memcpy(E1, E2, E3) + ether_addr_copy(E

[PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-28 Thread Heba Aamer
This patch fixes the following checkpatch.pl warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) I used the following coccinelle script: @@ expression E1,E2;constant E3; @@ - memcpy(E1, E2, E3) + ether_addr_copy(E1, E2) pahole showed that the used structs

[PATCH 3.12 156/176] x86, hyperv: Mark the Hyper-V clocksource as being continuous

2015-01-28 Thread Jiri Slaby
From: "K. Y. Srinivasan" 3.12-stable review patch. If anyone has any objections, please let me know. === commit 32c6590d126836a062b3140ed52d898507987017 upstream. The Hyper-V clocksource is continuous; mark it accordingly. Signed-off-by: K. Y. Srinivasan Acked-by: jasow...@redha

[PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf

2015-01-28 Thread Heba Aamer
This patch fixes the following checkpatch.pl warning: Prefer seq_puts to seq_printf Signed-off-by: Heba Aamer --- drivers/staging/lustre/lustre/osc/lproc_osc.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/

[PATCH] staging: fbtft: remove redundant .owner

2015-01-28 Thread Heba Aamer
This patch fixes the following coccicheck warning: No need to set .owner here. The core will do it. Signed-off-by: Heba Aamer --- drivers/staging/fbtft/flexfb.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c index 45574a0..3

Re: [PATCH v3 3/3] Drivers: hv: vmbus: serialize Offer and Rescind offer

2015-01-28 Thread Vitaly Kuznetsov
Dexuan Cui writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Wednesday, January 28, 2015 20:09 PM >> To: Dexuan Cui >> Cc: KY Srinivasan; de...@linuxdriverproject.org; Haiyang Zhang; linux- >> ker...@vger.kernel.org; Jason Wang; Radim Krčmář; Da

RE: [PATCH v3 3/3] Drivers: hv: vmbus: serialize Offer and Rescind offer

2015-01-28 Thread Dexuan Cui
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Wednesday, January 28, 2015 20:09 PM > To: Dexuan Cui > Cc: KY Srinivasan; de...@linuxdriverproject.org; Haiyang Zhang; linux- > ker...@vger.kernel.org; Jason Wang; Radim Krčmář; Dan Carpenter > Subject: Re:

Re: [PATCH v3 3/3] Drivers: hv: vmbus: serialize Offer and Rescind offer

2015-01-28 Thread Vitaly Kuznetsov
Dexuan Cui writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Tuesday, January 20, 2015 23:45 PM >> To: KY Srinivasan; de...@linuxdriverproject.org >> Cc: Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui; Jason Wang; >> Radim Krčmář; Dan C

RE: [PATCH v3 3/3] Drivers: hv: vmbus: serialize Offer and Rescind offer

2015-01-28 Thread Dexuan Cui
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, January 20, 2015 23:45 PM > To: KY Srinivasan; de...@linuxdriverproject.org > Cc: Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui; Jason Wang; > Radim Krčmář; Dan Carpenter > Subject: [PATCH

[PATCH 5/5] staging: fbtft: fix braces {} are not necessary for single statement blocks

2015-01-28 Thread Heba Aamer
This patch fixes the following checkpatch.pl warning: braces {} are not necessary for single statement blocks Signed-off-by: Heba Aamer --- drivers/staging/fbtft/fb_pcd8544.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/st

[PATCH 4/5] staging: fbtft: fix trailing whitespace

2015-01-28 Thread Heba Aamer
This patch fixes the following checkpatch.pl error: trailing whitespace Signed-off-by: Heba Aamer --- drivers/staging/fbtft/fb_pcd8544.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c index 051

[PATCH 3/5] staging: fbtft: fix horizontal spaces errors

2015-01-28 Thread Heba Aamer
This patch fixes the following checkpatch.pl errors: spaces required around that '=' space required after that ';' spaces required around that '<' Signed-off-by: Heba Aamer --- drivers/staging/fbtft/fb_pcd8544.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 2/5] staging: fbtft: fix do not initialise statics to 0 or NULL

2015-01-28 Thread Heba Aamer
This patch fixes the following checkpatch.pl error: fix do not initialise statics to 0 or NULL Signed-off-by: Heba Aamer --- drivers/staging/fbtft/fb_pcd8544.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pc

[PATCH 1/5] staging: fbtft: fix Macros with complex values should be enclosed in parentheses

2015-01-28 Thread Heba Aamer
This patch fixes the following checkpatch.pl error: fix Macros with complex values should be enclosed in parentheses Signed-off-by: Heba Aamer --- drivers/staging/fbtft/fb_pcd8544.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drive

[PATCH 0/5] Fix fbtft/fb_pcd8544.c coding style errors and warnings

2015-01-28 Thread Heba Aamer
This patch set fixes most of the checkpatch.pl coding style errors and warnings found in drivers/staging/fbtft/fb_pcd8544.c Regarding the spaces fixes the git diff -w showed no difference, and the objdiff was empty. Heba Aamer (5): staging: fbtft: fix Macros with complex values should be enclos

[patch added to the 3.12 stable tree] x86, hyperv: Mark the Hyper-V clocksource as being continuous

2015-01-28 Thread Jiri Slaby
From: "K. Y. Srinivasan" This patch has been added to the 3.12 stable tree. If you have any objections, please let us know. === commit 32c6590d126836a062b3140ed52d898507987017 upstream. The Hyper-V clocksource is continuous; mark it accordingly. Signed-off-by: K. Y. Srinivasan Ac

[Patch v2 01/22] ACPICA: Resources: Provide common part for struct acpi_resource_address structures.

2015-01-28 Thread Jiang Liu
From: Lv Zheng struct acpi_resource_address and struct acpi_resource_extended_address64 share substracts just at different offsets. To unify the parsing functions, OSPMs like Linux need a new ACPI_ADDRESS64_ATTRIBUTE as their substructs, so they can extract the shared data. This patch also sync

[PATCH] staging: rtl8712: remove useless printing line

2015-01-28 Thread Heba Aamer
This patch removes an unneeded call to printk. Signed-off-by: Heba Aamer --- drivers/staging/rtl8712/usb_intf.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c index 7d0d171..f1fd7e8 100644 --- a/drivers/staging/rtl87