On Wed, Feb 11, 2015 at 10:00:29AM -0800, Joe Perches wrote:
I'm half tempted to submit some patch like this to
make it difficult to use checkpatch on files outside
of drivers/staging.
o Only allow checkpatch to be used with the -f/--file
option for drivers/staging/
o Add an undocumented
Что всё-таки подарить? = Клевый знак внимания к 14 февраля =
http://www.google.com/url?q=htt%70%3A%2F%2Fvp%6f%64aro%6b.l%75%62i%6d%6f%79.%63%636%39%2er%75%2F%23at%6c%73%63%61zy0%6fk%7a%6c%71%66sa=Dsntz=1usg=AFQjCNGaBtr4u73mMq3TaQAGXIlyg8roFw
___
On Wed, 2015-02-11 at 13:51 +0300, Dan Carpenter wrote:
On Wed, Feb 11, 2015 at 01:40:37AM -0800, Joe Perches wrote:
On Wed, 2015-02-11 at 11:33 +0300, Dan Carpenter wrote:
You can't fight checkpatch.pl.
Sure you can, Ignore it whenever appropriate.
People will just keep sending
When failing to allocate buffer memory, function vnt_download_firmware() goes
through the wrong exit path and fails to release the already requested
firmware. Thus use the correct cleanup. Detected by Coverity CID 1269128.
Signed-off-by: Christian Engelmayer cenge...@gmx.at
---
Compile tested
On Wed, Feb 11, 2015 at 08:32:52AM -0600, Romer, Benjamin M wrote:
On Wed, 2015-02-11 at 11:36 +0300, Dan Carpenter wrote:
On Tue, Feb 10, 2015 at 12:58:35PM -0500, Benjamin Romer wrote:
From: Erik Arfvidson erik.arfvid...@unisys.com
This patch changes serverdown variable to int
add_memory() is supposed to be run with device_hotplug_lock grabbed, otherwise
it can race with e.g. device_online(). ACPI memory hotplug does that already
but e.g. Hyper-V ballooning driver doesn't.
Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com
---
mm/memory_hotplug.c | 6 +-
1 file
On Wed, 2015-02-11 at 11:36 +0300, Dan Carpenter wrote:
On Tue, Feb 10, 2015 at 12:58:35PM -0500, Benjamin Romer wrote:
From: Erik Arfvidson erik.arfvid...@unisys.com
This patch changes serverdown variable to int instead of bool
Why? It looks like bool is more appropriate?
Hi Dan,
If newly added memory is brought online with e.g. udev rule:
SUBSYSTEM==memory, ACTION==add, ATTR{state}=online
the following deadlock is observed (and easily reproducable):
First participant, worker thread doing add_memory():
...
[ 725.491469] 6 locks held by kworker/0:1/27:
[ 725.505037] #0:
add_memory() is supposed to be run with device_hotplug_lock grabbed, otherwise
it can race with e.g. device_online(). Allow external modules (hv_balloon for
now) to lock device hotplug.
Signed-off-by: Vitaly Kuznetsov vkuzn...@redhat.com
---
drivers/base/core.c | 2 ++
1 file changed, 2
On Wed, 2015-02-11 at 21:02 +0100, Richard Weinberger wrote:
On Wed, Feb 11, 2015 at 7:36 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Wed, Feb 11, 2015 at 10:00:29AM -0800, Joe Perches wrote:
I'm half tempted to submit some patch like this to
make it difficult to use checkpatch
On Sat, Jan 31, 2015 at 7:13 AM, Rickard Strandqvist
rickard_strandqv...@spectrumdigital.se wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
On Wed, Feb 11, 2015 at 7:36 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Wed, Feb 11, 2015 at 10:00:29AM -0800, Joe Perches wrote:
I'm half tempted to submit some patch like this to
make it difficult to use checkpatch on files outside
of drivers/staging.
o Only allow checkpatch to
On Wed 2015-02-11 12:20:25, Joe Perches wrote:
On Wed, 2015-02-11 at 21:02 +0100, Richard Weinberger wrote:
On Wed, Feb 11, 2015 at 7:36 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Wed, Feb 11, 2015 at 10:00:29AM -0800, Joe Perches wrote:
I'm half tempted to submit some patch
On Wed, 11 Feb 2015 16:44:20 +0100 Vitaly Kuznetsov vkuzn...@redhat.com wrote:
add_memory() is supposed to be run with device_hotplug_lock grabbed, otherwise
it can race with e.g. device_online(). Allow external modules (hv_balloon for
now) to lock device hotplug.
...
---
On Wed, 2015-02-11 at 21:24 +0100, Pavel Machek wrote:
On Wed 2015-02-11 12:20:25, Joe Perches wrote:
On Wed, 2015-02-11 at 21:02 +0100, Richard Weinberger wrote:
On Wed, Feb 11, 2015 at 7:36 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Wed, Feb 11, 2015 at 10:00:29AM -0800,
On Thu, 2015-02-12 at 01:43 +0300, Dan Carpenter wrote:
On Wed, Feb 11, 2015 at 12:43:03PM -0800, Joe Perches wrote:
Maybe some help/warning text like:
--forceWithout --force, checkpatch will not scan files
using -f or --file outside of
Am 11.02.2015 um 23:43 schrieb Dan Carpenter:
On Wed, Feb 11, 2015 at 12:43:03PM -0800, Joe Perches wrote:
Maybe some help/warning text like:
--forceWithout --force, checkpatch will not scan files
using -f or --file outside of
Fix all the trivial style issues (as reported by checkpatch.pl) not requiring
code refactoring. A following patch is expected to fix the remaining issues by
performing some code refactoring.
Signed-off-by: Daniele Alessandrelli daniele.alessandre...@gmail.com
---
On Mon 2015-02-09 11:07:12, Krzysztof Kozlowski wrote:
On pią, 2015-02-06 at 15:59 +0100, Pavel Machek wrote:
On Fri 2015-02-06 15:43:08, Krzysztof Kozlowski wrote:
On pią, 2015-02-06 at 14:49 +0100, Pavel Machek wrote:
On Fri 2015-01-30 15:47:58, Krzysztof Kozlowski wrote:
Use
This small patchset fixes all the style problems reported by checkpatch.pl on
ft1000-pcmcia/ft1000_hw.c
* Patch 1/2 fixes all trivial issues not requiring code refactoring
* Patch 2/2 fixes all remaining line over 80 characters warnings by means of
some code refactoring. Specifically, the
Add new function ft1000_read_dsp_timer() replacing recurring code block for
reading DSP timer. Such code refactoring solves all remaining line over 80
characters warnings reported by checkpatch.pl.
Signed-off-by: Daniele Alessandrelli daniele.alessandre...@gmail.com
---
On Wed, Feb 11, 2015 at 12:43:03PM -0800, Joe Perches wrote:
Maybe some help/warning text like:
--forceWithout --force, checkpatch will not scan files
using -f or --file outside of drivers/staging/...
Do not use
Good day!
I have a mutual business proposal of mutual interest to share with you, it
involves the transfer of a large sum of money I got your reference in my search
for someone who suits my business proposed.
If you are interested in working with me contact me through my private
On Wed, 2015-02-11 at 11:33 +0300, Dan Carpenter wrote:
On Tue, Feb 10, 2015 at 03:27:11PM +0100, Bas Peters wrote:
@@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct
adapter *adapt, u8 *powerlevel)
ptr++;
}
}
-
On Wed, Feb 11, 2015 at 06:26:27AM +0800, Greg Kroah-Hartman wrote:
On Tue, Feb 10, 2015 at 02:02:14PM +0100, Quentin Lambert wrote:
This patch removes allocation from declaration line because
people are known to gloss over declarations.
Again, who are these lazy people, and why are they
On Tue, Feb 10, 2015 at 03:27:11PM +0100, Bas Peters wrote:
@@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct adapter
*adapt, u8 *powerlevel)
ptr++;
}
}
- rtl88eu_dm_txpower_track_adjust(hal_data-odmpriv, 1, direction,
-
On Tue, Feb 10, 2015 at 12:58:36PM -0500, Benjamin Romer wrote:
From: Erik Arfvidson erik.arfvid...@unisys.com
This patch changes serverchangingstate variable from bool to int
serverchangingstate is a terriblevariablename.
regards,
dan carpenter
That looks kind of uglier than before. Please run your patch throught
scripts/checkpatch.pl --strict.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Feb 10, 2015 at 12:58:35PM -0500, Benjamin Romer wrote:
From: Erik Arfvidson erik.arfvid...@unisys.com
This patch changes serverdown variable to int instead of bool
Why? It looks like bool is more appropriate?
regards,
dan carpenter
___
Coding style improvements based on check_patch.pl:
1) Modified lines over 80 characters to fit.
2) Removed curly braces from a single line if block at
dgnc_check_queue_flow_control().
3) Combined two if statements to reduce nesting in
dgnc_wakeup_writes().
4) Combined and reverted logic in if
I'm sorry. I just realized I sent the wrong patch. This one is
embarrassingly wrong :/
I'm going to resend the whole patchset tonight or tomorrow.
Please excuse me for the mess :/
___
devel mailing list
de...@linuxdriverproject.org
initialiaze lcd parameters only if lcd is enabled.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v2: fix indention of comment
drivers/staging/panel/panel.c | 41 ++---
1 file changed, 22 insertions(+), 19 deletions(-)
diff --git
On Tue, Feb 10, 2015 at 02:34:15PM +0800, Greg Kroah-Hartman wrote:
On Tue, Feb 10, 2015 at 10:50:06AM +0530, Sudip Mukherjee wrote:
But as I've missed this in the past, nevermind, I'll take it as is. Can
you resend your outstanding patches and I'll queue them up after
3.20-rc1 is
On Wed, Feb 11, 2015 at 01:40:37AM -0800, Joe Perches wrote:
On Wed, 2015-02-11 at 11:33 +0300, Dan Carpenter wrote:
You can't fight checkpatch.pl.
Sure you can, Ignore it whenever appropriate.
People will just keep sending patches until something gets merged.
It's rude to ignore patches
On Wednesday, February 11, 2015 12:39:47 PM Andrew Morton wrote:
On Wed, 11 Feb 2015 16:44:20 +0100 Vitaly Kuznetsov vkuzn...@redhat.com
wrote:
add_memory() is supposed to be run with device_hotplug_lock grabbed,
otherwise
it can race with e.g. device_online(). Allow external modules
35 matches
Mail list logo
