[PATCH] Staging: vt6656: Fixed multiple commenting codig style issues.

2016-01-12 Thread maomao xu
Fixed multiple comment blocks that didn't comply with the kernels coding style. Signed-off-by: maomao xu --- drivers/staging/vt6656/main_usb.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb

[PATCH] Staging: vt6656: Fixed multiple commenting codig style issues.

2016-01-12 Thread maomao xu
Fixed multiple comment blocks that didn't comply with the kernels coding style. Signed-off-by: maomao xu --- drivers/staging/vt6656/main_usb.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb

[GIT PULL] Staging driver patches for 4.5-rc1

2016-01-12 Thread Greg KH
The following changes since commit 9f9499ae8e6415cefc4fe0a96ad0e27864353c89: Linux 4.4-rc5 (2015-12-13 17:42:58 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.5-rc1 for you to fetch changes up to 841e3ed977e02

Re: [PATCH 09/26] staging: wilc1000: use unified firmware

2016-01-12 Thread glen lee
On 2016๋…„ 01์›” 13์ผ 08:18, Julian Calaby wrote: Hi Glen, On Tue, Jan 12, 2016 at 6:39 PM, Glen Lee wrote: Use a unified firmware for all mode of operations which are station, ap and p2p. Two firmware are introduced for 1002 and 1003 chipset. Signed-off-by: Glen Lee --- drivers/staging/wilc1

Re: [PATCH 09/26] staging: wilc1000: use unified firmware

2016-01-12 Thread Julian Calaby
Hi Glen, On Tue, Jan 12, 2016 at 6:39 PM, Glen Lee wrote: > Use a unified firmware for all mode of operations which are station, ap and > p2p. Two firmware are introduced for 1002 and 1003 chipset. > > Signed-off-by: Glen Lee > --- > drivers/staging/wilc1000/Makefile | 5 ++--- > drivers/s

Re: [PATCH 2/5] staging: wilc1000: remove typedef from struct wilc_cfg_byte_t

2016-01-12 Thread Chaehyun Lim
Thank you for your comment. I'll resend again this patch after considering your suggestion. regards Chaehyun Lim On Tue, Jan 12, 2016 at 10:00 AM, Joe Perches wrote: > On Tue, 2016-01-12 at 09:32 +0900, Chaehyun Lim wrote: >> This patch removes typedef from struct wilc_cfg_byte_t and renames it

Re: [PATCH v2] staging: comedi: ni_tiocmd: change mistaken use of start_src for start_arg

2016-01-12 Thread Dan Carpenter
Thanks! regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2] staging: comedi: ni_mio_common: use CR_CHAN more consistently

2016-01-12 Thread Spencer E. Olson
Generally, the CR_CHAN macro is/should be used to access the relevant bits for channel identification in cmd->*_arg when the corresponding cmd->*_src==TRIG_EXT, including cmd->convert_arg in this case. This patch does not fix a bug per se, as NISTC_AI_MODE1_CONVERT_SRC() already masks the value su

[RESEND][PATCH] Staging: unisys: fix potential format string leak

2016-01-12 Thread Kees Cook
Since "name" is always used directly, force "%s" for the kthread format string to avoid any potential format string leaks. Signed-off-by: Kees Cook --- drivers/staging/unisys/visorhba/visorhba_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visor

Re: [PATCH v2] staging: comedi: ni_tiocmd: change mistaken use of start_src for start_arg

2016-01-12 Thread Ian Abbott
On 12/01/16 17:33, Spencer E. Olson wrote: This fixes a bug in function ni_tio_input_inttrig(). The trigger number should be compared to cmd->start_arg, not cmd->start_src. Fixes: 6a760394d7eb ("staging: comedi: ni_tiocmd: clarify the cmd->start_arg validation and use") Cc: # 3.17+ Signed-off-

[PATCH v2] staging: comedi: ni_tiocmd: change mistaken use of start_src for start_arg

2016-01-12 Thread Spencer E. Olson
This fixes a bug in function ni_tio_input_inttrig(). The trigger number should be compared to cmd->start_arg, not cmd->start_src. Fixes: 6a760394d7eb ("staging: comedi: ni_tiocmd: clarify the cmd->start_arg validation and use") Cc: # 3.17+ Signed-off-by: Spencer E. Olson --- Added description

Re: [PATCH] staging: ion : Donnot wakeup kswapd in ion system alloc

2016-01-12 Thread Laura Abbott
On 01/12/2016 03:14 AM, Chen Feng wrote: Since ion alloc can be called by userspace,eg gralloc. When it is called frequently, the efficiency of kswapd is to low. And the reclaimed memory is too lower. In this way, the kswapd can use to much cpu resources. With 3.5GB DMA Zone and 0.5 Normal Zone.

Re: [patch] staging: unisys: remove some dead code

2016-01-12 Thread Ben Romer
On 01/07/2016 04:34 AM, Dan Carpenter wrote: queue_delayed_work() returns bool, not negative error codes. It returns false if the work has already been queued or true otherwise. Since we don't care about that, we can just remove the test. Signed-off-by: Dan Carpenter Tested with s-Par, wor

Re: [PATCH] staging: comedi: ni_mio_common: use CR_CHAN more consistently

2016-01-12 Thread Ian Abbott
On 12/01/16 12:07, Dan Carpenter wrote: None of these have a change description. How does using CR_CHAN() help? Does it fix a bug? What are the user visible effects of the bug? (I could figure this out myself, but you'd still have to resend with the information so I haven't). regards, dan car

Re: [PATCH] staging: comedi: ni_pcimio: Adds PXI-6251 to supported boards

2016-01-12 Thread Ian Abbott
On 12/01/16 06:29, Spencer E. Olson wrote: Signed-off-by: Spencer E. Olson --- To: de...@driverdev.osuosl.org Cc: Ian Abbott Cc: H Hartley Sweeten Cc: Greg Kroah-Hartman drivers/staging/comedi/drivers/ni_pcimio.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-)

[PATCH v2 21/28] staging: most: fix retrieval of buffer availability

2016-01-12 Thread Christian Gromm
This patch fixes the function channel_has_mbo that delivers the false information in case two AIMs are using the same tx channel. Signed-off-by: Christian Gromm --- v2: make function channel_has_mbo return 0 instead of false. Reported-by: Sudip Mukherjee drivers/staging/most/aim-cdev/cdev.c

Re: [PATCH 21/28] staging: most: fix retrieval of buffer availability

2016-01-12 Thread Christian Gromm
On Thu, 24 Dec 2015 22:27:13 +0530 Sudip Mukherjee wrote: > On Tue, Dec 22, 2015 at 10:53:02AM +0100, Christian Gromm wrote: > > This patch fixes the function channel_has_mbo that delivers the false > > information in case two AIMs are using the same tx channel. > > > > Signed-off-by: Christian

Re: [PATCH] staging: comedi: ni_mio_common: use CR_CHAN more consistently

2016-01-12 Thread Dan Carpenter
None of these have a change description. How does using CR_CHAN() help? Does it fix a bug? What are the user visible effects of the bug? (I could figure this out myself, but you'd still have to resend with the information so I haven't). regards, dan carpenter __

Re: [PATCH 0/7] staging/wilc1000: Refactor spi read and write functions

2016-01-12 Thread Dan Carpenter
Best to work against staging-next. This doesn't apply any more. Glen, can you guys test/review these patches, please? They're a bit tricky for me. I have low confidence in "the comments say it's fine to set ->rx to NULL." regards, dan carpenter ___

[PATCH] staging: ion : Donnot wakeup kswapd in ion system alloc

2016-01-12 Thread Chen Feng
Since ion alloc can be called by userspace,eg gralloc. When it is called frequently, the efficiency of kswapd is to low. And the reclaimed memory is too lower. In this way, the kswapd can use to much cpu resources. With 3.5GB DMA Zone and 0.5 Normal Zone. pgsteal_kswapd_dma 9364140 pgsteal_kswapd

Re: [PATCH 1/6] staging: wlan-ng: Fixed block comment coding style

2016-01-12 Thread Dan Carpenter
Weird... It applies with patch but not with git am. Read the first paragraph of Documentation/email-clients.txt `cat raw_email.txt | git am` regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverprojec

Re: [PATCH v2 1/7] staging/wilc1000: Introduce linux_spi_msg_init

2016-01-12 Thread Sudip Mukherjee
On Mon, Jan 11, 2016 at 09:13:31PM +0100, Janosch Frank wrote: > Since all spi read and write functions were basically preparing the > same data, moving the preparation into a function decreased line count > a lot. > > This also resolves the following problems: > Zeroing the message ourselves is n

SHORT TERM INVESTMENT IN YOUR COUNTRY!!

2016-01-12 Thread Attorney Jeffrey Carney
My Dear Friend, I am contacting you to partner with you and this is real ok, itโ€™s my desire to strategically collaborate with your firm regarding investment arrangement in your country. Basically, I was forced out of my country due to political reasons and presently ran to another ountry for

[PATCH 2/3] staging: comedi: ni_mio_comon: adds finite regeneration to AO output

2016-01-12 Thread Spencer E. Olson
This patch implements for analog output the reinterpretation of stop_arg when stop_src == TRIG_NONE to allow the user to specify the length of the buffer that should be repeated. The intent is to allow a user to have a specific buffer repeated as-is indefinitely. The contents of the DMA buffer ca

[PATCH 1/3] staging: comedi: mite: enable continuous regeneration of finite samples

2016-01-12 Thread Spencer E. Olson
This change enables the mite DMA controller to only transfer the amount of data needed by a command. By default, the old behavior of transferring the entire comedi DMA data buffer is still in effect. These changes allow a command to only transmit a limited portion of that data buffer as needed.

[PATCH 3/3] staging: comedi: ni_mio_comon: add finite regeneration to dio output

2016-01-12 Thread Spencer E. Olson
This patch continues the implementation of reinterpreting stop_arg when stop_src == TRIG_NONE for national instruments cdio output on e/m-series devices. This is part of a series of patches that allow a user to have a specific buffer repeated as-is indefinitely. The contents of the DMA buffer can

[PATCH 0/3] continuous regeneration of finite samples

2016-01-12 Thread Spencer E. Olson
These patches implement a proposal to very slightly extend the interpretation of cmd->stop_arg when cmd->stop_src == TRIG_NONE. Normally, for output subdevices, when the user specifies cmd->stop_src == TRIG_NONE, the device should continuously output data that must also be continually fed by the u