On Mon, Jul 25, 2016 at 11:04:18PM +0200, Wolfram Sang wrote:
> On Mon, Jul 25, 2016 at 09:22:27PM +0200, Nicholas Mc Guire wrote:
> > Private functions in ks_hostif.c can be declared static.
> >
> > Fixes: 13a9930d15b4 ("staging: ks7010: add driver from Nanonote
> > extra-repository")
> >
> >
On Tue, Jul 26, 2016 at 08:51:14AM +0200, Wolfram Sang wrote:
> On Tue, Jul 26, 2016 at 06:48:00AM +, Nicholas Mc Guire wrote:
> > On Mon, Jul 25, 2016 at 11:04:18PM +0200, Wolfram Sang wrote:
> > > On Mon, Jul 25, 2016 at 09:22:27PM +0200, Nicholas Mc Guire wrote:
> > > > Private functions in
On Mon, Jul 25, 2016 at 10:54:03PM +0200, Wolfram Sang wrote:
> On Mon, Jul 25, 2016 at 09:21:50PM +0200, Nicholas Mc Guire wrote:
> > wait_for_completion_interruptible_timeout return 0 on timeout and
> > -ERESTARTSYS if interrupted. The check for
> > !wait_for_completion_interruptible_timeout()
On Tue, Jul 26, 2016 at 06:48:00AM +, Nicholas Mc Guire wrote:
> On Mon, Jul 25, 2016 at 11:04:18PM +0200, Wolfram Sang wrote:
> > On Mon, Jul 25, 2016 at 09:22:27PM +0200, Nicholas Mc Guire wrote:
> > > Private functions in ks_hostif.c can be declared static.
> > >
> > > Fixes: 13a9930d15b4
>> -if (strncasecmp(buff, "RSSI", length) == 0) {
>> +if (strncasecmp(buff, "RSSI", 0) == 0) {
>> +s8 rssi;
>> +
>
> Um, please think a second about if it makes any sense at all to compare
> zero chars of two strings.
Under whic
On Sat, 2016-07-23 at 14:01 -0400, Oleg Drokin wrote:
> On Jul 23, 2016, at 1:31 PM, Joe Perches wrote:
[]
> > And lustre seems to use types with unnecessary __ prefixes.
> Need to see if this file is included in userspace where the __ is needed.
Maybe it'd be good to change the top level makefile
> From: David Miller [mailto:da...@davemloft.net]
> ...
> From: Dexuan Cui
> Date: Tue, 26 Jul 2016 03:09:16 +
>
> > BTW, during the past month, at least 7 other people also reviewed
> > the patch and gave me quite a few good comments, which have
> > been addressed.
>
> Correction: Several p
From: Dexuan Cui
Date: Tue, 26 Jul 2016 03:09:16 +
> BTW, during the past month, at least 7 other people also reviewed
> the patch and gave me quite a few good comments, which have
> been addressed.
Correction: Several people gave coding style and simple corrections
to your patch.
Very few
> From: David Miller [mailto:da...@davemloft.net]
>
> From: Dexuan Cui
> Date: Sat, 23 Jul 2016 01:35:51 +
>
> > +static struct sock *hvsock_create(struct net *net, struct socket *sock,
> > + gfp_t priority, unsigned short type)
> > +{
> > + struct hvsock_sock *
From: Dexuan Cui
Date: Sat, 23 Jul 2016 01:35:51 +
> +static struct sock *hvsock_create(struct net *net, struct socket *sock,
> + gfp_t priority, unsigned short type)
> +{
> + struct hvsock_sock *hvsk;
> + struct sock *sk;
> +
> + sk = sk_alloc(net, A
From: Colin Ian King
We need to add parentheses around ternary operations because currently
the expression SDF_READABLE | (it->options[2] == 1) always evaluates to
true, meaning s->subdev_flags is always assigned SDF_DIFF. Putting the
parentheses around the ternarary operations results in the int
On Mon, Jul 25, 2016 at 09:22:27PM +0200, Nicholas Mc Guire wrote:
> Private functions in ks_hostif.c can be declared static.
>
> Fixes: 13a9930d15b4 ("staging: ks7010: add driver from Nanonote
> extra-repository")
>
> Signed-off-by: Nicholas Mc Guire
Reviewed-by: Wolfram Sang
drivers/stagi
Hello Markus,
On lun., 2016-07-25 at 18:19 +0200, SF Markus Elfring wrote:
> >> Would you like to support the renaming of a label like "error_out1"
> >> (in the function "ks7010_upload_firmware" for example)?
> >
> > They should be renamed too. Anything using numbers instead of explicit
>
> Inte
On Mon, Jul 25, 2016 at 09:21:50PM +0200, Nicholas Mc Guire wrote:
> wait_for_completion_interruptible_timeout return 0 on timeout and
> -ERESTARTSYS if interrupted. The check for
> !wait_for_completion_interruptible_timeout() would report an interrupt
> as timeout. Further, while HZ/50 will work
From: Markus Elfring
Date: Mon, 25 Jul 2016 22:20:24 +0200
The vfree() function performs also input parameter validation.
Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/rtl8188eu/core/rtw
t be static?
Compile tested with: x86_64_defconfig + CONFIG_STAGING=y
CONFIG_MMC=m, CONFIG_KS7010=m
Patch is against 4.7-rc7 (localversion-next -next-20160725)
drivers/staging/ks7010/ks_hostif.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/d
As both functions reported are private to this file it seems reasonable
to declare them static.
Compile tested with: x86_64_defconfig + CONFIG_STAGING=y
CONFIG_MMC=m, CONFIG_KS7010=m
Patch is against 4.7-rc7 (localversion-next -next-20160725)
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 fi
From: Haiyang Zhang
Date: Fri, 22 Jul 2016 18:14:50 -0700
> From: Haiyang Zhang
>
> Added a condition to avoid bonding devices with same MAC registering
> as VF.
>
> Signed-off-by: Haiyang Zhang
> Reviewed-by: K. Y. Srinivasan
Applied, thanks.
___
On Tue, Jul 12, 2016 at 11:31:24AM -0400, Cathy Avery wrote:
> SR-IOV disabled from the host causes a memory leak.
> pci-hyperv usually first receives a PCI_EJECT notification
> and then proceeds to delete the hpdev list entry in
> hv_eject_device_work(). Later in hv_msi_free() since the
> device i
>> Would you like to support the renaming of a label like "error_out1"
>> (in the function "ks7010_upload_firmware" for example)?
>
> They should be renamed too. Anything using numbers instead of explicit
Interesting …
> Anything using numbers instead of explicit labels should be updated.
Woul
Hi Markus,
On Thu, 21 Jul 2016 22:11:53 +0200, SF Markus Elfring wrote:
> >> How do you generally think about jump label renaming?
> >
> > Renaming from "out0:", "out1:" etc to something meaningful, yes.
>
> I suggest to take another look at such identifiers.
>
> Would you like to support the r
Hi Markus,
On Thu, 21 Jul 2016 09:55:55 +0200, SF Markus Elfring wrote:
> > > How do you think about information from the chapter "7: Centralized
> > > exiting of functions"?
> > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/CodingStyle?id=47ef4ad2684d380dd6
Hi Linus,
I have been using the following patch as a merge resolution in the
merge of the usb tree for a while now. Greg seems to have missed it
when asking you to merge his tree ... It now applies cleanly to your
tree.
Fr
23 matches
Mail list logo
