Re: [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move

On Mon, 2016-12-12 at 17:34 +0100, Greg Kroah-Hartman wrote: > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > > http://daringfireball.net/2007/07/on_top > > On Mon, Dec 12, 2016 at 02:42:29PM +, Ben Evans wrote: >

Re: [PATCH 0/8] Sparse warning fixes in Lustre.

On Dec 7, 2016, at 6:46 PM, Al Viro wrote: > On Wed, Dec 07, 2016 at 05:41:26PM -0500, Oleg Drokin wrote: >> This set of fixes aims at sparse warnings. > > Speaking of the stuff sparse catches there: class_process_proc_param(). > I've tried to describe what I think of that Fine Piece Of Software

[PATCH] staging: Remove slicoss driver

There is now a different driver for the slicoss devices in drivers/net/ethernet/alacritech/. That driver supports the same PCI device IDs as the driver in staging. Both drivers use the same configuration symbol (CONFIG_SLICOSS), which causes build failures for the staging driver. Presumably the dri

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

On Tue, Dec 13, 2016 at 12:55:01AM +, Dilger, Andreas wrote: > On Dec 12, 2016, at 13:00, James Simmons wrote: > > > > > >> On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote: > >>> In order for lustre_idl.h to be usable for both user > >>> land and kernel space it has to use the

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

On Dec 12, 2016, at 13:00, James Simmons wrote: > > >> On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote: >>> In order for lustre_idl.h to be usable for both user >>> land and kernel space it has to use the proper >>> byteorder functions. >> >> Why would userspace need/want all of t

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

On Mon, Dec 12, 2016 at 08:00:02PM +, James Simmons wrote: > > > On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote: > > > In order for lustre_idl.h to be usable for both user > > > land and kernel space it has to use the proper > > > byteorder functions. > > > > Why would userspac

[PATCH net-next 26/27] net/hyperv: enable passing of VLAN.CFI bit

Signed-off-by: Michał Mirosław --- drivers/net/hyperv/netvsc_drv.c | 1 + drivers/net/hyperv/rndis_filter.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 6597d79..4e20f4c 100644 --- a/drivers/net/hyperv/netvsc_drv.c

[PATCH net-next 08/27] net/hyperv: remove use of VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc_drv.c | 13 ++--- drivers/net/hyperv/rndis_filter.c | 4 ++-- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyp

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

> On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote: > > In order for lustre_idl.h to be usable for both user > > land and kernel space it has to use the proper > > byteorder functions. > > Why would userspace need/want all of these inline functions? A uapi > header file should just

Re: [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move

On Mon, 2016-12-12 at 19:41 +, James Simmons wrote: > > On Mon, 2016-12-12 at 17:34 +0100, Greg Kroah-Hartman wrote: [] > > http://wiki.lustre.org/Lustre_Style_Guide_Includes > > > > There is no single mandated code style for this. > > Some people like reverse christmas tree. > > > > Whatever

Re: [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move

> On Mon, 2016-12-12 at 17:34 +0100, Greg Kroah-Hartman wrote: > > A: Top-posting. > > Q: What is the most annoying thing in e-mail? > > > > A: No. > > Q: Should I include quotations after my reply? > > > > http://daringfireball.net/2007/07/on_top > > > > On Mon, Dec 12, 2016 at 02:42:29PM +000

Re: [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move

On 12/12/16, 11:34 AM, "Greg Kroah-Hartman" wrote: >What is this mythical guidelines, and why does it differ from the kernel >source ones? > >And again, why is this patch required? > >thanks, > >greg k-h > Here are the general guidelines for your reading pleasure: http://wiki.lustre.org/Lustre

Re: [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move

A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Mon, Dec 12, 2016 at 02:42:29PM +, Ben Evans wrote: > This was done to conform to the Lustre Coding Guidelines. What is this mythic

Re: [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move

This was done to conform to the Lustre Coding Guidelines. -Ben On 12/10/16, 1:14 PM, "Greg Kroah-Hartman" wrote: >On Sat, Dec 10, 2016 at 01:05:59PM -0500, James Simmons wrote: >> From: Ben Evans >> >> It was found if you sort the headers alphabetically >> that it reduced patch conflicts. Thi

[PATCH 2/2] Staging: ks7010: ks7010_sdio.h: Trailing whitespace

Removed trailing whitespace. Signed-off-by: Manoj Sawai --- drivers/staging/ks7010/ks7010_sdio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_sdio.h index 5820b5c9b684..0165994605ac 100644 --- a/drivers/

[PATCH 1/2] Staging: ks7010: ks7010_sdio.h: Complex macro not in parentheses

Fixed coding style error. Complex macro not inside parentheses. Signed-off-by: Manoj Sawai --- drivers/staging/ks7010/ks7010_sdio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_sdio.h index 0f5fd848e23d.