This patch fixes the race between netvsc_probe() and
rndis_set_subchannel(), which can cause a deadlock.
These are the related 3 paths which show the deadlock:
path #1:
Workqueue: hv_vmbus_con vmbus_onmessage_work [hv_vmbus]
Call Trace:
schedule
schedule_preempt_disabled
On 2018-08-29 22:48, Janusz Krzysztofik wrote:
> Most users of get/set array functions iterate consecutive bits of data,
> usually a single integer, while processing array of results obtained
> from, or building an array of values to be passed to those functions.
> Save time wasted on those
> From: David Miller
> Sent: Wednesday, August 29, 2018 19:09
> > Hi David,
> > I was afraid the call-traces are too detailed. :-)
> >
> > Can you please move the info to before the --- line?
> >
> > Or, should I resend the patch with the commit log updated?
>
> Please resend.
OK. Will do.
--
From: Dexuan Cui
Date: Thu, 30 Aug 2018 00:58:48 +
>> From: David Miller
>> Sent: Wednesday, August 29, 2018 17:49
>>
>> From: Dexuan Cui
>> Date: Wed, 22 Aug 2018 21:20:03 +
>>
>> > ---
>> > drivers/net/hyperv/netvsc_drv.c | 11 ++-
>> > 1 file changed, 10 insertions(+), 1
> From: David Miller
> Sent: Wednesday, August 29, 2018 17:49
>
> From: Dexuan Cui
> Date: Wed, 22 Aug 2018 21:20:03 +
>
> > ---
> > drivers/net/hyperv/netvsc_drv.c | 11 ++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> >
> > FYI: these are the related 3 paths which
From: Dexuan Cui
Date: Wed, 22 Aug 2018 21:20:03 +
> ---
> drivers/net/hyperv/netvsc_drv.c | 11 ++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
>
> FYI: these are the related 3 paths which show the deadlock:
This incredibly useful information belongs in the commit log
Fix a checkpatch warning for the file, fwserial.c that warns about
alignment between parentheses and the line belows code not being
properly aligned with each other.
Signed-off-by: Nicholas Krause
---
drivers/staging/fwserial/fwserial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Wed, Aug 29, 2018 at 04:21:54PM -0500, Larry Finger wrote:
> On 08/29/2018 04:14 PM, Joe Perches wrote:
> > On Wed, 2018-08-29 at 21:35 +0100, John Whitmore wrote:
> > > Rename the bit field element AdvCoding, as it causes a checkpatch issue
> > > with CamelCase naming. As the element is not
On 08/29/2018 04:14 PM, Joe Perches wrote:
On Wed, 2018-08-29 at 21:35 +0100, John Whitmore wrote:
Rename the bit field element AdvCoding, as it causes a checkpatch issue
with CamelCase naming. As the element is not actually used in code it
has been renamed to 'not_used_adv_coding'.
The single
On Wed, 2018-08-29 at 21:35 +0100, John Whitmore wrote:
> Rename the bit field element AdvCoding, as it causes a checkpatch issue
> with CamelCase naming. As the element is not actually used in code it
> has been renamed to 'not_used_adv_coding'.
>
> The single line of code which initialises the
Certain GPIO descriptor arrays returned by gpio_get_array() may contain
information on direct mapping of array members to pins of a single GPIO
chip in hardware order. In such cases, bitmaps of values can be passed
directly from/to the chip's .get/set_multiple() callbacks without
wasting time on
Most users of get/set array functions iterate consecutive bits of data,
usually a single integer, while processing array of results obtained
from, or building an array of values to be passed to those functions.
Save time wasted on those iterations by changing the functions' API to
accept bitmaps.
In order to make use of array info obtained from gpiod_get_array() and
speed up processing of arrays matching single GPIO chip layout, that
information must be passed to get/set array functions. Extend the
functions' API with that additional parameter and update all users.
Pass NULL if a user
Certain GPIO array lookup results may map directly to GPIO pins of a
single GPIO chip in hardware order. If that condition is recognized
and handled efficiently, significant performance gain of get/set array
functions may be possible.
While processing a request for an array of GPIO descriptors,
The goal is to boost performance of get/set array functions while
processing GPIO arrays which represent pins of a signle chip in
hardware order. If resulting performance is close to PIO, GPIO API
can be used for data I/O without much loss of speed.
Created and tested on a low end Amstrad
Rename the bitfield member 'MPDUDensity' to 'mpdu_density', this
clears the checkpatch issue with CamelCase naming.
This is a coding style change which should not have an impact on
runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h| 2
Rename the bitfield member TxSTBC. As it stands the name causes a
checkpatch issue due to its use of CamelCase naming style. Because
the member is not actually used in the code the name has been changed
to 'not_used_tx_stbc'. The two lines of code, one for initialisation
and one for debug logging
Rename the bitfield member 'DssCCk' to 'dss_cck', this clears the
checkpatch issue with CamelCase naming.
This is a coding style change which should not impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +-
Rename the bitfield member 'MaxRxAMPDUFactor' to
'max_rx_ampdu_factor', this clears the checkpatch issue with CamelCase
naming.
The change is a coding style change which should not impact runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
Rename the member variable 'TxBFCap', since it causes a checkpatch
issue with CamelCase naming. The variable has been renamed to
'not_used_tx_bf_cap', since the member is not actually used, apart
from initialisation, which has been removed.
This is a coding style change which should not have an
Rename the member variable 'ExtHTCapInfo', since it causes a
checkpatch issue, due to its use of CamelCase naming. The name has
been changed to 'not_used_ext_ht_cap_info' since the member
variable is not actually used, apart from an initialisation which
has been removed.
This is a coding style
Rename the bitfield member 'Rsvd1', since its name causes a checkpatch
issue due to the use of CamelCase naming. The name has been changed
to 'not_used_rsvd1' since the variable is not actually used in code.
This is a coding style change which should have no impact on runtime
code execution.
Rename the member variable ASCap, as it causes a checkpatch issue
with CamelCase naming. The member has been renamed to
'not_used_as_cap', since it is not actually used in code, apart from
initialisation, which has been removed.
This is a coding style change which should have no impact on runtime
Rename the bitfield member 'Rsvd2', since it causes a checkpatch
issue due to it's use of CamelCase naming. The member has been
renamed to 'not_used_rsvd2', since it is not actually used in the
code.
This is a coding style change which should not impact on runtime
code execution.
Signed-off-by:
Rename the bitfield member variable 'MaxAMSDUSize' to
'max_amsdu_size', this clears the checkpatch issue with CamelCase
naming.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
Rename the bitfield member 'LSigTxopProtect', since it currently
causes a checkpatch issue due to its use of CamelCase naming.
Since the member is not actually used in code it has been renamed
to 'not_used_l_sig_txop_protect', and the singe initialisation line
of code has been removed.
This is
Rename the bitfield member variable 'PSMP', since its uppercase name
conflicts the coding standard on naming. Because the variable is not
actually used in code it has been renamed to 'not_used_psmp'. The one
line of initialisation code has been removed.
This is a coding style change which should
Rename the member 'MCS' to 'cap_mcs', since the uppercase name
conflicts with the coding standard. The 'cap' has been prepended
to make the variable easier to find in the code.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
Rename the bitfield member RxSTBC, since its use of CamelCase naming
causes a checkpatch issue. Because the member is not actually used
in code the variable has been renamed to 'not_used_rx_stbc'. The
single line of code which initialised the member has been removed.
This is a coding style change
Rename the bitfield member DelayBA, since its use of CamelCase naming
causes a checkpatch issue. Since the member is not actually used in
code the name has been changed to 'not_used_delay_ba'. The one line
of initialisation code has been removed.
This is a coding style change which should not
Rename the bit field member GreenField, this change clears the
checkpatch issue with CamelCase naming. As the member is no longer
used the name has been changed to 'not_used_green_field', and the
redundant line of initialisation code has been removed.
This is a coding style change which should
Rename the bitfield member 'ShortGI20Mhz' to 'short_gi20_mhz'. This
change clears the checkpatch issue with CamelCase naming of variables.
The change if purely a coding style change which should have no impact
on runtime code execution.
Signed-off-by: John Whitmore
---
Rename the bit field element AdvCoding, as it causes a checkpatch issue
with CamelCase naming. As the element is not actually used in code it
has been renamed to 'not_used_adv_coding'.
The single line of code which initialises the bit has been removed,
as the field is unused.
This is a purely
Rename the bitfield member 'ShortGI40Mhz' to 'short_gi40_mhz', this
clears the checkpatch issue with CamelCase naming.
This change is a simple coding style change, which should have no
impact on runtime code execution.
Signed-off-by: John Whitmore
---
Rename 'ChlWidth', member variable of the structure ht_capability_ele.
This change is to clear the checkpatch issue with CamelCase naming.
The bitfield's name has been changed to 'chl_width'.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John
This series of patchs is a coding style clean up of the structure
ht_capability_ele. The changes are all simply changes of the member
names, to remove the CamelCase naming.
A number of the member have been renamed with the prefix 'not_used...'
to emphasise the fact that member is not used in
Rename the bitfield name MimoPwrSave, to clear the checkpatch issue
with CamelCase naming, to 'mimo_power_save'.
This is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +-
Hi,
I am trying to contact the right person at your company.
We are providing different kind of imaging services.
We have 30 image editors and on daily basis 1000 images can be processed,
if you want to know
more about us please reply back.
Detail services listed below:
Photos cutting out
PCI host drivers have already matched on compatible strings, so checking
device_type is redundant. Also, device_type is considered deprecated for
FDT though we've still been requiring it for PCI hosts as it is useful
for finding PCI buses.
Cc: Greg Kroah-Hartman
Cc: de...@driverdev.osuosl.org
Hi Linus,
On Wednesday, August 29, 2018 11:06:21 AM CEST Linus Walleij wrote:
> On Tue, Aug 21, 2018 at 1:42 AM Janusz Krzysztofik
wrote:
>
> > This series is a follow up of the former "mtd: rawnand: ams-delta: Use
> > gpio-omap accessors for data I/O" which already contained some changes
> >
On Wednesday, August 29, 2018 2:03:18 PM CEST Miguel Ojeda wrote:
> Hi Janusz,
>
> On Tue, Aug 21, 2018 at 1:43 AM, Janusz Krzysztofik
> wrote:
> > Most users of get/set array functions iterate consecutive bits of data,
> > usually a single integer, while or processing array of results obtained
On Mon, Aug 27, 2018 at 07:33:40PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Aug 23, 2018 at 10:58:09PM +0530, Nishad Kamdar wrote:
> > This patch removes the dead code for N_MSG().
> >
> > Signed-off-by: Nishad Kamdar
> > ---
> > Changes in v5:
> > - Remove commented code for N_MSG()
> > ---
The Hyper-V host API for PCI provides a unique "serial number" which
can be used as basis for sysfs PCI slot table. This can be useful
for cases where userspace wants to find the PCI device based on
serial number.
When an SR-IOV NIC is added, the host sends an attach message
with serial number.
Matching network device based on MAC address is problematic
since a non-VF network device can be created with a duplicate MAC
address causing confusion and problems. The VMBus API provides
a serial number that is a better matching method.
Signed-off-by: Stephen Hemminger
---
The Hyper-V implementation of PCI controller has concept of 32 bit serial number
(not to be confused with PCI-E serial number). This value is sent in the
protocol
from the host to indicate SR-IOV VF device is attached to a synthetic NIC.
Using the serial number (instead of MAC address) to
From: Michael Kelley
Add hooks to enable/disable a per-CPU IRQ for VMbus. These hooks
are in the architecture independent setup and shutdown paths for
Hyper-V, and are needed by Linux guests on Hyper-V on ARM64. The
x86/x64 implementation is null because VMbus interrupts on x86/x64
don't use an
From: Michael Kelley
Add ARM64-specific code to enable Hyper-V. This code includes:
* Detecting Hyper-V and initializing the guest/Hyper-V interface
* Setting up Hyper-V's synthetic clocks
* Making hypercalls using the HVC instruction
* Setting up VMbus and stimer0 interrupts
* Setting up kexec
From: Michael Kelley
Update drivers/hv/Kconfig so CONFIG_HYPERV can be selected on ARM64,
causing the Hyper-V specific code to be built.
Signed-off-by: Michael Kelley
Reviewed-by: James Morris
---
drivers/hv/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
From: Michael Kelley
hyperv-tlfs.h defines Hyper-V interfaces from the Hyper-V Top Level
Functional Spec (TLFS). The TLFS is distinctly oriented to x86/x64,
and Hyper-V has not separated out the architecture-dependent parts into
x86/x64 vs. ARM64. So hyperv-tlfs.h includes information for ARM64
From: Michael Kelley
This series enables Linux guests running on Hyper-V on ARM64
hardware. New ARM64-specific code in arch/arm64/hyperv initializes
Hyper-V, including its synthetic clocks and hypercall mechanism.
Existing architecture independent drivers for Hyper-V's VMbus and
synthetic
On Wed, Aug 29, 2018 at 03:50:02AM -0700, Joe Perches wrote:
> On Wed, 2018-08-29 at 04:42 -0500, Ioana Radulescu wrote:
> > The DPAA2 Ethernet driver supports Freescale/NXP SoCs with DPAA2
> > (DataPath Acceleration Architecture v2). The driver manages
> > network objects discovered on the fsl-mc
> -Original Message-
> From: Dan Carpenter
> Sent: Wednesday, August 29, 2018 2:08 PM
> To: Ioana Ciocoi Radulescu
> Cc: net...@vger.kernel.org; da...@davemloft.net;
> de...@driverdev.osuosl.org; and...@lunn.ch; Horia Geanta
> ; Madalin-cristian Bucur
> ; gre...@linuxfoundation.org;
On Wed, Aug 29, 2018 at 12:06:44PM +, Ioana Ciocoi Radulescu wrote:
> >
> > There are a few static checker warnings for the driver but only the
> > first one looks like a possibly real bug.
>
> Thanks for the report, what tool did you use to get these warnings?
>
These are Smatch warnings,
Hi Janusz,
On Tue, Aug 21, 2018 at 1:43 AM, Janusz Krzysztofik wrote:
> Most users of get/set array functions iterate consecutive bits of data,
> usually a single integer, while or processing array of results obtained
> from or building an array of values to be passed to those functions.
> Save
On Tue, Aug 28, 2018 at 08:26:22PM +0100, Tim Collier wrote:
> Remove braces from an if statement with only a single line in the if
> block.
>
> Signed-off-by: Tim Collier
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git
On Tue, Aug 28, 2018 at 08:26:13PM +0100, Tim Collier wrote:
> checkpatch reported a number of "Avoid CamelCase" issues for macros
> defined in p80211metadef.h (and for files that used these macros).
>
> Renamed the macros to all upper-case (except for
>
On Wed, Aug 29, 2018 at 02:20:33PM +0300, Dan Carpenter wrote:
> Like you mentioned in the 0/4 email, the right thing to do here is just
> to delete all references to ->enabled.
>
Thank you for your response, I'll do that in a future series of patches.
jwhitmore
Like you mentioned in the 0/4 email, the right thing to do here is just
to delete all references to ->enabled.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
There are a few static checker warnings for the driver but only the
first one looks like a possibly real bug.
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c:1116 dpaa2_eth_stop() error:
uninitialized symbol 'dpni_enabled'.
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c:1671 set_fq_affinity()
On Wed, 2018-08-29 at 04:42 -0500, Ioana Radulescu wrote:
> The DPAA2 Ethernet driver supports Freescale/NXP SoCs with DPAA2
> (DataPath Acceleration Architecture v2). The driver manages
> network objects discovered on the fsl-mc bus.
Please use git 'format-patch -M' to make the diff
smaller and
On 21 August 2018 at 01:43, Janusz Krzysztofik wrote:
>
> This series is a follow up of the former "mtd: rawnand: ams-delta: Use
> gpio-omap accessors for data I/O" which already contained some changes
> to gpiolib. Those previous attempts were commented by Borris Brezillon
> who suggested using
The Freescale/NXP DPAA2 Ethernet driver was first included in
drivers/staging, due to its dependencies on two components located
there at the time of its initial submission:
* the fsl-mc bus driver, which was moved to drivers/bus in kernel 4.17
* the dpio driver, which was moved to drivers/soc/fsl
Only call netdev_register() at the end of the probe function,
once all other necessary bits and pieces are properly initialized.
We keep the rest of the netdevice initialization code in place,
at the earlier point of the probing sequence, including the
settings previously done in ndo_init.
From: Colin Ian King
Pointer 'port_priv' is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
variable 'port_priv' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King
---
drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 2 --
On Tue, Aug 21, 2018 at 1:42 AM Janusz Krzysztofik wrote:
> This series is a follow up of the former "mtd: rawnand: ams-delta: Use
> gpio-omap accessors for data I/O" which already contained some changes
> to gpiolib. Those previous attempts were commented by Borris Brezillon
> who suggested
Even though I did introduce the fbtft code in staging a while ago to
stop seeing this being developed out-of-tree, I don't intend to
maintain it, and I don't use it actively. So be honest and remove
myself from the MAINTAINERS file for this subsystem.
Signed-off-by: Thomas Petazzoni
---
66 matches
Mail list logo
