Re: [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

2019-03-29 Thread Greg Kroah-Hartman
On Sat, Mar 30, 2019 at 02:32:35AM +, Zengtao (B) wrote: > >-Original Message- > >From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > >Sent: Saturday, March 30, 2019 12:04 AM > >To: Zengtao (B) > >Cc: labb...@redhat.com; sumit.sem...@linaro.org; > >de...@driverdev.osuosl.org

[PATCH v2 0/2] MT7621 PCIe PHY

2019-03-29 Thread Sergio Paracuellos
This series adds support for the PCIe PHY found in the Mediatek MT7621 SoC. This is the first attempt to get feedback of what is missing in this driver to be promoted from staging. There is also a 'mt7621-pci' driver which is the controller part which is still in staging and is a client of this p

[PATCH v2 2/2] phy: ralink: Add PHY driver for MT7621 PCIe PHY

2019-03-29 Thread Sergio Paracuellos
This patch adds a driver for the PCIe PHY of MT7621 SoC. Signed-off-by: Sergio Paracuellos --- drivers/phy/ralink/Kconfig | 7 + drivers/phy/ralink/Makefile | 1 + drivers/phy/ralink/phy-mt7621-pci.c | 401 3 files changed, 409 insertions(+) cre

[PATCH v2 1/2] dt-bindings: phy: Add binding for Mediatek MT7621 PCIe PHY

2019-03-29 Thread Sergio Paracuellos
Add bindings to describe Mediatek MT7621 PCIe PHY. Signed-off-by: Sergio Paracuellos --- .../bindings/phy/mediatek,mt7621-pci-phy.txt | 28 +++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/mediatek,mt7621-pci-phy.txt diff --git a/D

RE: [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

2019-03-29 Thread Zengtao (B)
>-Original Message- >From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] >Sent: Saturday, March 30, 2019 12:04 AM >To: Zengtao (B) >Cc: labb...@redhat.com; sumit.sem...@linaro.org; >de...@driverdev.osuosl.org; Todd Kjos ; >linux-ker...@vger.kernel.org; dri-de...@lists.freedesktop.

RE: [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

2019-03-29 Thread Zengtao (B)
>-Original Message- >From: Dan Carpenter [mailto:dan.carpen...@oracle.com] >Sent: Friday, March 29, 2019 7:03 PM >To: Zengtao (B) >Cc: labb...@redhat.com; sumit.sem...@linaro.org; >de...@driverdev.osuosl.org; Todd Kjos ; Greg >Kroah-Hartman ; >linux-ker...@vger.kernel.org; dri-de...@lists.

RE: [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

2019-03-29 Thread Zengtao (B)
>-Original Message- >From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] >Sent: Saturday, March 30, 2019 12:02 AM >To: Zengtao (B) >Cc: labb...@redhat.com; sumit.sem...@linaro.org; >de...@driverdev.osuosl.org; Todd Kjos ; >linux-ker...@vger.kernel.org; dri-de...@lists.freedeskto

RE: [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

2019-03-29 Thread Zengtao (B)
Hi laura: >-Original Message- >From: Laura Abbott [mailto:labb...@redhat.com] >Sent: Friday, March 29, 2019 9:27 PM >To: Zengtao (B) ; sumit.sem...@linaro.org >Cc: Greg Kroah-Hartman ; Arve Hjønnevåg >; Todd Kjos ; Martijn Coenen >; Joel Fernandes ; >Christian Brauner ; de...@driverdev.os

Re: [PATCH] staging: wlan-ng: Shorten excessively long p80211 constants

2019-03-29 Thread kbuild test robot
Hi Mikhail, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on v5.1-rc2 next-20190329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [PATCH] staging: rtl8723bs: core: fix line over 80 characters warning

2019-03-29 Thread Mukesh Ojha
On 3/26/2019 11:55 PM, Anirudh Rayabharam wrote: Shorten the expression by re-using the part that was already computed to fix the line over 80 characters warning reported by checkpatch.pl. Signed-off-by: Anirudh Rayabharam --- drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++-- 1 file change

Re: [PATCH] media: staging: use strscpy() instead of strlcpy()

2019-03-29 Thread Mukesh Ojha
On 3/29/2019 8:59 PM, Mauro Carvalho Chehab wrote: There are a few left overs at staging with were still using the deprecated strlcpy() function. Signed-off-by: Mauro Carvalho Chehab s/with/which Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/staging/media/imx/imx-media-dev-co

Re: [PATCH v2] staging: rtl8723bs: core: fix line over 80 characters warning

2019-03-29 Thread Greg KH
On Wed, Mar 27, 2019 at 11:49:07PM +0530, Anirudh Rayabharam wrote: > Checkpatch.pl complains that these lines are over 80 characters. Use the > "psecuritypriv" pointer for consistency, remove unnecessary parantheses > and fix the alignment. > > This patch just cleans up a condition, it doesn't af

Re: [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

2019-03-29 Thread Greg Kroah-Hartman
On Sat, Mar 30, 2019 at 02:40:16AM +0800, Zeng Tao wrote: > There are two reasons for this patch: > 1. There are some potential requirements for ion_alloc in kernel space, > some media drivers need to allocate media buffers from ion instead of > buddy or dma framework, this is more convient and cle

Re: [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

2019-03-29 Thread Greg Kroah-Hartman
On Sat, Mar 30, 2019 at 02:40:16AM +0800, Zeng Tao wrote: > There are two reasons for this patch: > 1. There are some potential requirements for ion_alloc in kernel space, > some media drivers need to allocate media buffers from ion instead of > buddy or dma framework, this is more convient and cle

Re: [PATCH] media: staging: use strscpy() instead of strlcpy()

2019-03-29 Thread Hans Verkuil
On 3/29/19 4:29 PM, Mauro Carvalho Chehab wrote: > There are a few left overs at staging with were still using the > deprecated strlcpy() function. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Hans Verkuil Thanks! Hans > --- > drivers/staging/media/imx/imx-media-dev-common.

[PATCH] media: staging: use strscpy() instead of strlcpy()

2019-03-29 Thread Mauro Carvalho Chehab
There are a few left overs at staging with were still using the deprecated strlcpy() function. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/imx/imx-media-dev-common.c | 4 ++-- drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c | 2 +- 2 files changed, 3 insertions(+),

Re: [PATCH v2 04/14] staging: most: sound: introduce new sound adapter management

2019-03-29 Thread Christian.Gromm
On Fr, 2019-03-29 at 16:50 +0300, Dan Carpenter wrote: > External E-Mail > > > Thanks, I feel like I understand better now. > > Sorry, I don't want to be a jerk and I'm not going to complain again > about this patchset if you resend it with the other stuff I mention > fixed. > > But to me it fe

Re: [PATCH v2 04/14] staging: most: sound: introduce new sound adapter management

2019-03-29 Thread Dan Carpenter
Thanks, I feel like I understand better now. Sorry, I don't want to be a jerk and I'm not going to complain again about this patchset if you resend it with the other stuff I mention fixed. But to me it feels like the API could be improved slightly if you first created the adapter with a name and

Re: [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

2019-03-29 Thread Laura Abbott
On 3/29/19 11:40 AM, Zeng Tao wrote: There are two reasons for this patch: 1. There are some potential requirements for ion_alloc in kernel space, some media drivers need to allocate media buffers from ion instead of buddy or dma framework, this is more convient and clean very for media drivers.

Re: [PATCH v2 04/14] staging: most: sound: introduce new sound adapter management

2019-03-29 Thread Christian.Gromm
On Fr, 2019-03-29 at 13:46 +0300, Dan Carpenter wrote: > External E-Mail > > > On Thu, Mar 28, 2019 at 02:17:32PM +0100, Christian Gromm wrote: > > > > +static int audio_create_sound_card(void) > > +{ > > + int ret; > > + struct sound_adapter *adpt; > > + > > + list_for_each_entry(adpt, &a

Re: [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

2019-03-29 Thread Dan Carpenter
If we're going to export ion_alloc() for other drivers to use then let's make an ion_free() helper function as well. void ion_free(struct dma_buf *dmabuf) { dma_buf_put(dmabuf); } regards, dan carpenter ___ devel mailing list de...@linuxdriverp

Re: [PATCH v2 04/14] staging: most: sound: introduce new sound adapter management

2019-03-29 Thread Dan Carpenter
On Thu, Mar 28, 2019 at 02:17:32PM +0100, Christian Gromm wrote: > +static int audio_create_sound_card(void) > +{ > + int ret; > + struct sound_adapter *adpt; > + > + list_for_each_entry(adpt, &adpt_list, list) { > + if (!adpt->registered) > + goto adpt_a

[PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

2019-03-29 Thread Zeng Tao
There are two reasons for this patch: 1. There are some potential requirements for ion_alloc in kernel space, some media drivers need to allocate media buffers from ion instead of buddy or dma framework, this is more convient and clean very for media drivers. And In that case, ion is the only media

Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

2019-03-29 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+f9f3f388440283da2...@syzkaller.appspotmail.com Tested on: commit: 8c2ffd91 Linux 5.1-rc2 git tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/lin

Re: [PATCH] staging: wlan-ng: Shorten excessively long p80211 constants

2019-03-29 Thread kbuild test robot
Hi Mikhail, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v5.1-rc2 next-20190329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [PATCH v2 04/14] staging: most: sound: introduce new sound adapter management

2019-03-29 Thread Christian.Gromm
On Do, 2019-03-28 at 16:56 +0300, Dan Carpenter wrote: > External E-Mail > > > On Thu, Mar 28, 2019 at 02:17:32PM +0100, Christian Gromm wrote: > > > > +static int audio_create_sound_card(void) > > +{ > > + int ret; > > + struct sound_adapter *adpt; > > + > > + list_for_each_entry(adpt, &a

Re: [PATCH v2 10/14] staging: most: allow speculative configuration

2019-03-29 Thread Dan Carpenter
On Fri, Mar 29, 2019 at 09:15:46AM +, christian.gr...@microchip.com wrote: > > > +static int set_config_and_add_link(struct mdev_link *mdev_link) > > > +{ > > > + int i; > > > + int ret; > > > + > > > + for (i = 0; i < ARRAY_SIZE(set_config_val); i++) { > > > + ret = set_config_val[i](m

Re: [PATCH v2 01/14] staging: most: add new file configfs.c

2019-03-29 Thread Christian.Gromm
On Do, 2019-03-28 at 16:50 +0300, Dan Carpenter wrote: > External E-Mail > > > On Thu, Mar 28, 2019 at 02:17:29PM +0100, Christian Gromm wrote: > > > > +static ssize_t mdev_link_direction_store(struct config_item *item, > > +  const char *page, size_t > > count)

Re: [PATCH v2 10/14] staging: most: allow speculative configuration

2019-03-29 Thread Christian.Gromm
On Do, 2019-03-28 at 17:12 +0300, Dan Carpenter wrote: > External E-Mail > > > On Thu, Mar 28, 2019 at 02:17:38PM +0100, Christian Gromm wrote: > > > > This patch makes the driver accept a link confiiguration eventhough > > no > > device is attached to the bus. Instead the configuration is being

Re: [PATCH] staging: rtl8192u: fix incorrect mask for EEPROMTxPowerLevelCCK setting

2019-03-29 Thread Dan Carpenter
On Fri, Mar 29, 2019 at 12:02:44AM +, Colin King wrote: > From: Colin Ian King > > Currently the lower 8 bits of ret are being masked and left > shifted by 8 bits always leaving a result of zero. The mask > appears to be incorrect and should probably be 0xff00 instead > of 0xff. Fix this. (

Re: [PATCH 3/3] staging: mt7621-pci-phy: change driver to don't use child nodes

2019-03-29 Thread Sergio Paracuellos
Hi Dan, On Fri, Mar 29, 2019 at 8:54 AM Dan Carpenter wrote: > > On Thu, Mar 28, 2019 at 06:55:31PM +0100, Sergio Paracuellos wrote: > > static int mt7621_pci_phy_probe(struct platform_device *pdev) > > { > > struct device *dev = &pdev->dev; > > @@ -299,6 +315,7 @@ static int mt7621_pci_p

Re: [PATCH 3/3] staging: mt7621-pci-phy: change driver to don't use child nodes

2019-03-29 Thread Dan Carpenter
On Thu, Mar 28, 2019 at 06:55:31PM +0100, Sergio Paracuellos wrote: > static int mt7621_pci_phy_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -299,6 +315,7 @@ static int mt7621_pci_phy_probe(struct platform_device > *pdev) > struct resource res; >