[PATCH] staging: rtl8192e: initializing the wep buffer

The "wep" buffer is not initialized. To avoid memory disclosures, the fix initializes it, as peer functions like rtllib_ccmp_set_key do. Signed-off-by: Kangjie Lu --- drivers/staging/rtl8192e/rtllib_crypt_wep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8192e/rtllib_c

Re: [PATCH v2] staging:rtl8723bs: removed unwanted if..else condition

On Thu, Oct 17, 2019 at 07:48:26PM +0530, Aliasgar Surti wrote: > From: Aliasgar Surti > > There is use of if..elseif..else condition which has same logic > in all three blocks. > Removed if..else block and placed log message instead that. > > Signed-off-by: Aliasgar Surti > --- > v2: Fixed ali

Re: [PATCH] staging: wilc1000: potential corruption in wilc_parse_join_bss_param()

On 10/17/19 2:18 AM, Dan Carpenter wrote: > The "rates_len" value needs to be capped so that the memcpy() doesn't > copy beyond the end of the array. > > Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver") > Signed-off-by: Dan Carpenter > --- > drivers/staging/wilc1000/wilc_h

WARNING in bdev_read

Hello, syzbot found the following crash on: HEAD commit:bc88f85c kthread: make __kthread_queue_delayed_work static git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14e25608e0 kernel config: https://syzkaller.appspot.com/x/.config?x=e0ac4d9b35046343 dash

[PATCH] staging: wilc1000: store bss object and use cfg80211_connect_bss()

From: Adham Abozaeid In a fast disconnect/connect sequence, cfg80211_connect_result() can fail to find the bss object which the driver is connecting to. Detailed sequence of events: * Driver is connected in STA mode * Disconnect request arrives from user space. Driver disconnects and calls cfg8

[PATCH v2] staging:rtl8723bs: removed unwanted if..else condition

From: Aliasgar Surti There is use of if..elseif..else condition which has same logic in all three blocks. Removed if..else block and placed log message instead that. Signed-off-by: Aliasgar Surti --- v2: Fixed alignment problem. --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 16 +++

Re: [PATCH] staging:rtl8723bs: removed unwanted if..else condition

On Wed, Oct 16, 2019 at 05:59:50PM +0300, Dan Carpenter wrote: > On Wed, Oct 16, 2019 at 07:37:53PM +0530, Aliasgar Surti wrote: > > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c > > @@ -507,19 +507,9 @@ int rtw_cmd_thread(void *context) > > > >

[PATCH] drivers/staging/fbtft/fb_seps525: New driver for SEPS525 (Syncoam) LCD Controllers

From: Michael Hennerich The SEPS525 is a 160 RGB x 128 Dots, 262K Colors PM-OLED Display Driver and Controller. The controller can be found on the NHD-1.69-160128UGC3 (Newhaven Display International, Inc.). Datasheets: Link: https://www.newhavendisplay.com/appnotes/datasheets/OLEDs/SEPS525.pdf

Re: [PATCH] staging: iio: ad9834: add a check for devm_clk_get

On Wed, 2019-10-16 at 22:25 +0800, Chuhong Yuan wrote: > ad9834_probe misses a check for devm_clk_get and may cause problems. > Add a check like what ad9832 does to fix it. > This could also use a Fixes tag, but not a big deal. Reviewed-by: Alexandru Ardelean > Signed-off-by: Chuhong Yuan > -

[PATCH 6/6] staging: wfx: fix number of available tx_policies

From: Jérôme Pouiller Original API declares 16 tx_policies. But in fact, the 16th is used internally by the firmware. So, only 15 tx_policies are available for driver. Reported-by: Alban Jeantheau Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_api_mib.h | 2 +- 1 file changed, 1 i

Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

Hi Chuhong, many thanks for the patch. On Tue 15 Oct 2019 at 14:59, Chuhong Yuan wrote: > devm_regulator_get may return an error but mipi_csis_phy_init misses > a check for it. > This may lead to problems when regulator_set_voltage uses the unchecked > pointer. > This patch adds a check for devm_r

Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

Hi Marco, On Thu 17 Oct 2019 at 09:10, Marco Felsch wrote: > Hi Rui, > > On 19-10-16 14:43, Rui Miguel Silva wrote: >> Hi Marco, >> On Wed 16 Oct 2019 at 10:06, Marco Felsch wrote: >> > Hi Chuhong, >> > >> > On 19-10-15 21:59, Chuhong Yuan wrote: >> >> devm_regulator_get may return an error but mip

[PATCH 4/6] staging: wfx: fix Oops when CONFIG_OF_NET is not set

From: Jérôme Pouiller In most case, of_get_mac_address() return NULL in case of error. However, if CONFIG_OF_NET is not set, it return -ENODEV. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/

[PATCH 3/6] staging: wfx: fix CONFIG_MMC=m with CONFIG_WFX=y

From: Jérôme Pouiller If CONFIG_MMC=m and CONFIG_WFX=y, compilation complains with undefined references: drivers/staging/wfx/main.o: In function `wfx_core_init': /linux/drivers/staging/wfx/main.c:488: undefined reference to `sdio_register_driver' drivers/staging/wfx/main.o: In function

[PATCH 1/6] staging: wfx: drop module version

From: Jérôme Pouiller wfx_version.h says that this code is same same than driver 2.3.1 hosted on github: https://github.com/siliconlabs/wfx-linux-driver/tree/2.3.1-public However, it is inaccurate, driver in-tree contains multiple small patches ahead 2.3.1. I prefer to drop this confusing

[PATCH 5/6] staging: wfx: fix setting MAC address from DT

From: Jérôme Pouiller MAC address read from chip is unconditionally used even if a MAC address is configured in device tree. Reported-by: Marc Dorval Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/sta

[PATCH 2/6] staging: wfx: relocate wfx_fill_sl_key() in secure_link.h

From: Jérôme Pouiller "Secure link" feature is not available in in-tree driver (because it depends on mbedtls). Thus, secure_link.h only empty functions. Module parameter "slk_key" and associated function wfx_fill_sl_key() had an unjustifiable place in main.c. This patch relocate them to secure_

[PATCH] staging: wilc1000: potential corruption in wilc_parse_join_bss_param()

The "rates_len" value needs to be capped so that the memcpy() doesn't copy beyond the end of the array. Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver") Signed-off-by: Dan Carpenter --- drivers/staging/wilc1000/wilc_hif.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

Hi Rui, On 19-10-16 14:43, Rui Miguel Silva wrote: > Hi Marco, > On Wed 16 Oct 2019 at 10:06, Marco Felsch wrote: > > Hi Chuhong, > > > > On 19-10-15 21:59, Chuhong Yuan wrote: > >> devm_regulator_get may return an error but mipi_csis_phy_init misses > >> a check for it. > >> This may lead to prob

Re: [PATCH] staging: exfat: add exfat filesystem code to staging

On Wednesday 16 October 2019 17:53:43 Valdis Klētnieks wrote: > and may cause problems if Linux says "currently using FAT 2", and the > disk is next used on a Windows 10 box that only looks at FAT 1 You should use same algorithm which is used for FAT32. Primary FAT is first. And all operations

Re: [PATCH] staging: exfat: add exfat filesystem code to staging

On Wednesday 16 October 2019 16:33:17 Sasha Levin wrote: > On Wed, Oct 16, 2019 at 06:03:49PM +0200, Pali Rohár wrote: > > On Wednesday 16 October 2019 10:31:13 Sasha Levin wrote: > > > On Wed, Oct 16, 2019 at 04:03:53PM +0200, Pali Rohár wrote: > > > > On Friday 30 August 2019 09:56:47 Pali Rohár

Re: [PATCH -next] staging: media: cedrus: use devm_platform_ioremap_resource() to simplify code

Hi, On Wed 16 Oct 19, 16:56, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. This is still: Acked-by: Paul Kocialkowski Please collect the tag in your next version, if there's a need for one. Cheers, Paul > Signed-off-by: