Re: [PATCH] staging: mt7621-pci: don't return if get gpio fails

2020-03-21 Thread Greg Ungerer
Hi Sergio, On 21/3/20 1:25 am, Sergio Paracuellos wrote: On Fri, Mar 20, 2020 at 4:08 PM Greg Ungerer wrote: On 21/3/20 12:38 am, Sergio Paracuellos wrote: On Fri, Mar 20, 2020 at 3:30 PM Greg Ungerer wrote: On 20/3/20 2:14 am, Sergio Paracuellos wrote: [snip] rt2880-pinmux pinctrl: pcie

Re: [PATCH] staging: mt7621-pci: don't return if get gpio fails

2020-03-20 Thread Greg Ungerer
Hi Sergio, On 21/3/20 12:38 am, Sergio Paracuellos wrote: On Fri, Mar 20, 2020 at 3:30 PM Greg Ungerer wrote: On 20/3/20 2:14 am, Sergio Paracuellos wrote: [snip] rt2880-pinmux pinctrl: pcie is already enabled mt7621-pci 1e14.pcie: Error applying setting, reverse things back mt7621-pci

Re: [PATCH] staging: mt7621-pci: don't return if get gpio fails

2020-03-20 Thread Greg Ungerer
Hi Sergio, On 20/3/20 2:14 am, Sergio Paracuellos wrote: In some platforms gpio's are not used for reset but for other purposes. Because of that when we try to get them are valid gpio's but are already assigned to do other function. To avoid those kind of problems in those platforms just notice

Re: [PATCH v4 0/6] staging: mt7621-pci: re-do reset boot process

2020-03-19 Thread Greg Ungerer
Hi Sergio, On 19/3/20 11:43 pm, Sergio Paracuellos wrote: On Thu, Mar 19, 2020 at 1:42 PM Greg Ungerer wrote: On 14/3/20 6:09 am, Sergio Paracuellos wrote: Some time ago Greg Ungerer reported some random hangs using the staging mt7621-pci driver: See: * http

Re: [PATCH v4 0/6] staging: mt7621-pci: re-do reset boot process

2020-03-19 Thread Greg Ungerer
Hi Sergio, On 14/3/20 6:09 am, Sergio Paracuellos wrote: Some time ago Greg Ungerer reported some random hangs using the staging mt7621-pci driver: See: * http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2019-June/134947.html Try to fix that is the main motivation

Re: [PATCH v3 0/5] staging: mt7621-pci: re-do reset boot process

2020-03-15 Thread Greg Ungerer
Hi Sergio, On 13/3/20 3:45 pm, Sergio Paracuellos wrote: On Fri, Mar 13, 2020 at 4:51 AM Greg Ungerer wrote: [snip] I applied the patches to the staging git tree for testing. I have seen a couple of different problems on boot up: ... rt2880-pinmux pinctrl: pcie is already enabled mt7621-pci

Re: [PATCH v3 0/5] staging: mt7621-pci: re-do reset boot process

2020-03-12 Thread Greg Ungerer
Hi Sergio, On 12/3/20 7:00 pm, Sergio Paracuellos wrote: Some time ago Greg Ungerer reported some random hangs using the staging mt7621-pci driver: See: * http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2019-June/134947.html Try to fix that is the main motivation

Re: [PATCH v2 0/5] staging: mt7621-pci: re-do reset boot process

2020-03-11 Thread Greg Ungerer
Hi Sergio, On 12/3/20 4:58 am, Sergio Paracuellos wrote: Some time ago Greg Ungerer reported some random hangs using the staging mt7621-pci driver: See: * http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2019-June/134947.html Try to fix that is the main motivation

Re: [PATCH] mtd: rawnand: driver for Mediatek MT7621 SoC NAND flash controller

2019-11-07 Thread Greg Ungerer
Hi Dan, On 7/11/19 9:15 pm, Dan Carpenter wrote: This driver seems like it could be fixed up and go directly into drivers/nand/ instead of staging. Other comments below. Thanks for the feedback, much appreciated. I'll work through it and send out a v2. Regards Greg On Thu, Nov 07, 2019

Re: [PATCH] mtd: rawnand: driver for Mediatek MT7621 SoC NAND flash controller

2019-11-07 Thread Greg Ungerer
On 7/11/19 7:20 pm, René van Dorst wrote: Quoting g...@kernel.org: From: Greg Ungerer Add a driver to support the NAND flash controller of the MediaTek MT7621 System-on-Chip device. (This one is the MIPS based parts from Mediatek). This code is a re-working of the earlier patches

Re: [PATCH] mtd: rawnand: driver for Mediatek MT7621 SoC NAND flash controller

2019-11-07 Thread Greg Ungerer
On 7/11/19 6:40 pm, Greg KH wrote: On Thu, Nov 07, 2019 at 05:35:21PM +1000, g...@kernel.org wrote: From: Greg Ungerer Add a driver to support the NAND flash controller of the MediaTek MT7621 System-on-Chip device. (This one is the MIPS based parts from Mediatek). This code is a re-working

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-06-26 Thread Greg Ungerer
Hi Sergio, On 26/6/19 5:10 pm, Sergio Paracuellos wrote: On Wed, Jun 26, 2019 at 5:31 AM Greg Ungerer wrote: On 25/6/19 10:47 pm, Sergio Paracuellos wrote: On Tue, Jun 25, 2019 at 7:18 AM Sergio Paracuellos wrote: On Tue, Jun 25, 2019 at 7:10 AM Greg Ungerer wrote: On 23/6/19 3:58 pm

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-06-25 Thread Greg Ungerer
Hi Sergio, On 25/6/19 10:47 pm, Sergio Paracuellos wrote: On Tue, Jun 25, 2019 at 7:18 AM Sergio Paracuellos wrote: On Tue, Jun 25, 2019 at 7:10 AM Greg Ungerer wrote: On 23/6/19 3:58 pm, Sergio Paracuellos wrote: On Sun, Jun 23, 2019 at 4:15 AM Brett Neumeier wrote: On Fri, Jun 21, 2019

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-06-24 Thread Greg Ungerer
Hi Sergio, On 23/6/19 3:58 pm, Sergio Paracuellos wrote: On Sun, Jun 23, 2019 at 4:15 AM Brett Neumeier wrote: On Fri, Jun 21, 2019 at 7:35 AM Greg Ungerer wrote: On 21/6/19 4:15 pm, Sergio Paracuellos wrote: This patch series properly handle minor issues in this driver

Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues

2019-06-21 Thread Greg Ungerer
Hi Sergio, On 21/6/19 4:15 pm, Sergio Paracuellos wrote: This patch series properly handle minor issues in this driver. These are: * Disable pcie port clock on pci dirver instead of doing it in the phy driver. The pci driver is the correct place to do this. * Add a missing call to phy_exit

Re: [PATCH 0/4] staging: mt7621-pci: Use gpio perst instead builtin behaviour

2019-06-19 Thread Greg Ungerer
Hi Sergio, On 19/6/19 5:44 pm, Sergio Paracuellos wrote: Some boards seems to ignore builtin perst configuration and use gpio instead. This approach seems to be more common. Hence, update the driver to properly use gpio perst via gpio descriptor's API. For more information refer to [1]. Even

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-06-16 Thread Greg Ungerer
Hi Brett, On 15/6/19 11:53 pm, Brett Neumeier wrote: [snip] For what it's worth -- possibly nothing? -- I grabbed the most recent six versions of the patch from this thread, including the one here, and did test boots of all of them on both a GnuBee PC1 and PC2 (based on 5.1.7). There were no

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-06-06 Thread Greg Ungerer
Hi Sergio, On 6/6/19 3:07 pm, Sergio Paracuellos wrote: On Thu, Jun 6, 2019 at 5:06 AM Greg Ungerer wrote: On 5/6/19 10:28 pm, Sergio Paracuellos wrote: On Wed, Jun 5, 2019 at 7:47 AM Sergio Paracuellos wrote: On Wed, Jun 5, 2019 at 6:01 AM Greg Ungerer wrote: On 4/6/19 7:36 pm, Sergio

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-06-05 Thread Greg Ungerer
Hi Sergio, On 5/6/19 10:28 pm, Sergio Paracuellos wrote: On Wed, Jun 5, 2019 at 7:47 AM Sergio Paracuellos wrote: On Wed, Jun 5, 2019 at 6:01 AM Greg Ungerer wrote: On 4/6/19 7:36 pm, Sergio Paracuellos wrote: On Tue, Jun 4, 2019 at 9:14 AM Greg Ungerer wrote: On 4/6/19 3:06 pm, Sergio

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-06-04 Thread Greg Ungerer
Hi Sergio, On 4/6/19 7:36 pm, Sergio Paracuellos wrote: On Tue, Jun 4, 2019 at 9:14 AM Greg Ungerer wrote: On 4/6/19 3:06 pm, Sergio Paracuellos wrote: On Tue, Jun 4, 2019 at 3:31 AM Greg Ungerer wrote: On 4/6/19 5:59 am, Sergio Paracuellos wrote: On Mon, Jun 3, 2019 at 2:32 PM Greg

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-06-04 Thread Greg Ungerer
Hi Sergio, On 4/6/19 3:06 pm, Sergio Paracuellos wrote: On Tue, Jun 4, 2019 at 3:31 AM Greg Ungerer wrote: On 4/6/19 5:59 am, Sergio Paracuellos wrote: On Mon, Jun 3, 2019 at 2:32 PM Greg Ungerer wrote: On 3/6/19 3:34 pm, Sergio Paracuellos wrote: On Mon, Jun 3, 2019 at 3:26 AM Greg

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-06-03 Thread Greg Ungerer
Hi Sergio, On 4/6/19 5:59 am, Sergio Paracuellos wrote: On Mon, Jun 3, 2019 at 2:32 PM Greg Ungerer wrote: On 3/6/19 3:34 pm, Sergio Paracuellos wrote: On Mon, Jun 3, 2019 at 3:26 AM Greg Ungerer wrote: On 31/5/19 10:37 pm, Sergio Paracuellos wrote: On Thu, May 30, 2019 at 3:46 AM Greg

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-06-03 Thread Greg Ungerer
Hi Sergio, On 3/6/19 3:34 pm, Sergio Paracuellos wrote: On Mon, Jun 3, 2019 at 3:26 AM Greg Ungerer wrote: On 31/5/19 10:37 pm, Sergio Paracuellos wrote: On Thu, May 30, 2019 at 3:46 AM Greg Ungerer wrote: On 30/5/19 10:44 am, Greg Ungerer wrote: On 29/5/19 6:08 pm, Sergio Paracuellos

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-06-02 Thread Greg Ungerer
Hi Sergio, On 31/5/19 10:37 pm, Sergio Paracuellos wrote: On Thu, May 30, 2019 at 3:46 AM Greg Ungerer wrote: On 30/5/19 10:44 am, Greg Ungerer wrote: On 29/5/19 6:08 pm, Sergio Paracuellos wrote: [snip] I have added gpio consumer stuff and reorder a bit the code to be more similar to 4.20

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-05-31 Thread Greg Ungerer
Hi Sergio, On 31/5/19 10:37 pm, Sergio Paracuellos wrote: On Thu, May 30, 2019 at 3:46 AM Greg Ungerer wrote: On 30/5/19 10:44 am, Greg Ungerer wrote: On 29/5/19 6:08 pm, Sergio Paracuellos wrote: [snip] I have added gpio consumer stuff and reorder a bit the code to be more similar to 4.20

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-05-29 Thread Greg Ungerer
Hi Sergio, On 30/5/19 10:44 am, Greg Ungerer wrote: On 29/5/19 6:08 pm, Sergio Paracuellos wrote: [snip] I have added gpio consumer stuff and reorder a bit the code to be more similar to 4.20. I attach the patch. I have not try it to compile it, because my normal environment is in another

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-05-29 Thread Greg Ungerer
Hi Brett, On 30/5/19 12:44 am, Brett Neumeier wrote: On Wed, May 29, 2019 at 3:09 AM Sergio Paracuellos mailto:sergio.paracuel...@gmail.com>> wrote: I have added gpio consumer stuff and reorder a bit the code to be more similar to 4.20. I attach the patch. I have not try it to

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-05-29 Thread Greg Ungerer
Hi Sergio, On 29/5/19 6:08 pm, Sergio Paracuellos wrote: [snip] I have added gpio consumer stuff and reorder a bit the code to be more similar to 4.20. I attach the patch. I have not try it to compile it, because my normal environment is in another computer and I am in the middle of moving

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-05-29 Thread Greg Ungerer
Hi Sergio, On 27/5/19 6:02 pm, Sergio Paracuellos wrote: On Mon, May 27, 2019 at 9:29 AM Greg Ungerer wrote: On 27/5/19 4:35 pm, Sergio Paracuellos wrote: On Mon, May 27, 2019 at 6:37 AM Greg Ungerer wrote: On 24/5/19 3:35 pm, Sergio Paracuellos wrote: On Fri, May 24, 2019 at 2:35 AM Greg

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-05-27 Thread Greg Ungerer
Hi Sergio, On 27/5/19 4:35 pm, Sergio Paracuellos wrote: On Mon, May 27, 2019 at 6:37 AM Greg Ungerer wrote: On 24/5/19 3:35 pm, Sergio Paracuellos wrote: On Fri, May 24, 2019 at 2:35 AM Greg Ungerer wrote: On 23/5/19 3:26 pm, Sergio Paracuellos wrote: On Thu, May 23, 2019 at 4:11 AM Greg

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-05-26 Thread Greg Ungerer
Hi Sergio, On 24/5/19 3:35 pm, Sergio Paracuellos wrote: On Fri, May 24, 2019 at 2:35 AM Greg Ungerer wrote: On 23/5/19 3:26 pm, Sergio Paracuellos wrote: On Thu, May 23, 2019 at 4:11 AM Greg Ungerer wrote: On 22/5/19 4:27 pm, Sergio Paracuellos wrote: [snip] There are some big changes

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-05-23 Thread Greg Ungerer
Hi Sergio, On 23/5/19 3:26 pm, Sergio Paracuellos wrote: On Thu, May 23, 2019 at 4:11 AM Greg Ungerer wrote: On 22/5/19 4:27 pm, Sergio Paracuellos wrote: [snip] There are some big changes between 4.20 and 5.x. One is the use of PERST_N instead of using gpio. This PERT_N stuff is used now

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-05-22 Thread Greg Ungerer
Hi Sergio, On 22/5/19 4:27 pm, Sergio Paracuellos wrote: [snip] There are some big changes between 4.20 and 5.x. One is the use of PERST_N instead of using gpio. This PERT_N stuff is used now on enable ports assuming the link of PCI is properly detected after enabling the phy. And it seems it

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-05-21 Thread Greg Ungerer
Hi Sergio, Thanks for the quick response. On 21/5/19 6:14 pm, Sergio Paracuellos wrote: On Tue, May 21, 2019 at 8:44 AM Greg Ungerer wrote: I am working on a couple of different MedaiTek MT7621 based platforms and am having problems with the PCI bus on those. Big picture is that the PCI bus

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-05-21 Thread Greg Ungerer
Hi Sergio, I am working on a couple of different MedaiTek MT7621 based platforms and am having problems with the PCI bus on those. Big picture is that the PCI bus on my boards worked in linux-4.20 (with the obvious compilation breakage fixed), and it does not work in linux-5.0 or linux-5.1.

Re: [PATCH] staging: mt7621-pinctrl: fix pinmux warning at boot

2019-01-13 Thread Greg Ungerer
Hi Sergio, On 14/1/19 4:45 pm, Sergio Paracuellos wrote: On Mon, Jan 14, 2019 at 6:36 AM Greg Ungerer wrote: Fix unassigned "num_maps" when calling pinctrl_utils_reserve_map() in the satging mt7621-pinctrl driver. Although we do set an initial "map&q

[PATCH] staging: mt7621-pinctrl: fix pinmux warning at boot

2019-01-13 Thread Greg Ungerer
ux pinctrl: krealloc(map) failed rt2880-pinmux pinctrl: can't reserve map: -12 rt2880-pinmux pinctrl: error claiming hogs: -12 rt2880-pinmux pinctrl: could not claim hogs: -12 rt2880-pinmux: probe of pinctrl failed with error -12 Signed-off-by: Greg Ungerer --- drivers/staging/mt7621-pinctrl/pinctrl