I await your urgent response. My present internet connection is very slow in case you received this mail in your spam.

in the World and the Maximum Withdrawal Per Day Is $10,000.00 USD pay day until your total amount $3,500,000.00 withdraw completely. For Further Directives Regarding the Release of Your ATM Card, Contact Director ATM Department, Security Mr James Larry, Email: (mrjameslarry...@yahoo.com) Telephone: +229

Re: [PATCH] staging: rtl8188eu: Add Edimax EW-7811UN V2 to device table

*/ {} /* Terminating entry */ }; Acked-by: Larry Finger Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8723bs: include: Fix coding style errors

variable type and the name, but that is probably the subject of separate patches. Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/1] STAGING - REALTEK RTL8188EU DRIVERS: Fix Coding Style Error

On 7/25/20 1:39 PM, Joe Perches wrote: On Sat, 2020-07-25 at 12:47 -0500, Larry Finger wrote: On 7/25/20 7:20 AM, Anant Thazhemadam wrote: Running the checkpatch.pl script on the file for which patch was created, the following error was found to exist. ERROR: space required after

Re: [PATCH 1/1] STAGING - REALTEK RTL8188EU DRIVERS: Fix Coding Style Error

} In fixing one checkpatch.pl condition, you introduced another - the resulting line is too long. You should fix only one such condition, but you should fix any others that are introduced. You do need to document it. Patch subjects for this driver should be written as "staging:

Re: [PATCH] Staging: rtl8188eu: rtw_mlme: Fix uninitialized variable authmode

s your statement "Then authmode may contain a garbage value and influence the execution flow of this function." is false. Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: r8188eu: remove unused members of struct xmit_buf

ave already fixed 4 places with unnecessary alignment, but, alas, there is no great desire to test them on real hardware. I have now tested on real hardware and it works fine. Acked-by: Larry Finger Larry ___ devel mailing list de...@l

Re: [PATCH] staging: r8188eu: remove unused members of struct xmit_buf

and the driver failed. Apparently, the alignment of some other quantity was affected. I do not think that this change would have that affect; however, you should be testing whenever the changes are more than cosmetic. Larry ___ devel mailing list de

Re: [PATCH] staging: rtl8712: switch to common ieee80211 headers

, or wireless-drivers-next. Where did you intend it to go? Staging is the correct tree. Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8188eu: Add ASUS USB-N10 Nano B1 to device table

The ASUS USB-N10 Nano B1 has been reported as a new RTL8188EU device. Add it to the device tables. Signed-off-by: Larry Finger Reported-by: kovi Cc: Stable --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8188eu/os_dep

[PATCH 1/6] staging: rtl8188eu: Fix potential security hole

("Add files for new driver - part 16"). Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c ind

[PATCH 3/6] staging: rtl8188eu: Fix potential overuse of kernel memory

commit a2c60d42d97c ("Add files for new driver - part 16"). Reported by: Pietro Oliva Cc: Pietro Oliva Cc: Stable Fixes commit a2c60d42d97c ("Add files for new driver - part 16"). Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 2 +- 1 file changed,

[PATCH 2/6] staging: rtl8723bs: Fix potential security hole

f216 ("0taging: Add rtl8723bs sdio wifi driver"). Signed-off-by: Larry Finger --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioc

[PATCH 5/6] staging: rtl8188eu: Remove some unneeded goto statements

, and eliminate the got target. Signed-off-by: Larry Finger Cc: Pietro Oliva --- .../staging/rtl8188eu/os_dep/ioctl_linux.c| 40 ++- 1 file changed, 12 insertions(+), 28 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/drivers/staging/rtl8188eu/os_dep

[PATCH 4/6] staging: rtl8723bs: Fix potential overuse of kernel memory

commit 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver"). Reported by: Pietro Oliva Cc: Pietro Oliva Cc: Stable Fixes: 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver"). Signed-off-by: Larry Finger -# Please enter the commit message for your changes. Lines starting ---

[PATCH 6/6] staging: rtl8723bs: Remove unneeded goto statements

, and eliminate the got target. Signed-off-by: Larry Finger Cc: Pietro Oliva --- .../staging/rtl8723bs/os_dep/ioctl_linux.c| 47 +-- 1 file changed, 12 insertions(+), 35 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep

[PATCH 0/6] staging: rtl8188eu and rtl8723bs - some fixes and cleanups

It was recently reported that staging drivers rtl8188eu and rtl8723bs contained a security flaw because a parameter had not been checked. The following patches fix that flaw and cleans up the routines. Signed-off-by: Larry Finger Larry Finger (6): staging: rtl8188eu: Fix potential security

Re: [PATCH 3/3] staging: rtl8188eu: remove return variable from rtw_pwr_unassociated_idle

/core/rtw_pwrctrl.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) Acked-by: Larry Finger Thanks, Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/3] staging: rtl8188eu: cleanup declarations in rtw_pwrctrl.c

On 11/23/19 9:16 AM, Michael Straube wrote: Replace tabs with spaces in declarations to cleanup whitespace. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) Acked-by: Larry Finger

Re: [PATCH 1/3] staging: rtl8188eu: remove unnecessary parentheses in rtw_pwrctrl.c

On 11/23/19 9:16 AM, Michael Straube wrote: Remove unnecessary parentheses reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Acked-by: Larry Finger Thanks, Larry

Re: [PATCH v2] staging: rtl8188eu: remove dead code/vestigial do..while loop

bcmd_down) && (retry_cnts--)); + adapt->HalData->LastHMEBoxNum = + (h2c_box_num + 1) % RTL88E_MAX_H2C_BOX_NUMS; ret = _SUCCESS; Acked-by: Larry Finger Thanks, Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8188eu: fix HighestRate check in odm_ARFBRefresh_8188E()

uld be with 0x03 according to the max_rate_idx in ODM_RAInfo_Init(). Cc: Larry Finger Cc: Greg Kroah-Hartman Cc: Michael Straube Cc: sta...@vger.kernel.org Signed-off-by: Denis Efremov --- drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH v2] staging: rtl8188eu: fix possible null dereference

if (psta && psta->qos_option) qos_option = true; } else { RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("fw_state:%x is not allowed to xmit frame\n&quo

Re: [PATCH] staging: rtl8188eu: fix possible null dereference

(psta && psta->qos_option) qos_option = true; } else { RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("fw_state:%x is not allowed to xmit frame\n", get_fwstate(pmlmepriv))); This change is a good one, bu

Re: [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step

ed once, thus you could remove the loop and the loop variable bcmd_down. @greg: If you would prefer a two-step process, then this one is OK. Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8188eu: make two arrays static const, makes object smaller

rtl8188eu/core/rtw_ieee80211.o After: text data bss dec hex filename 26612 5776 0 323887e84 rtl8188eu/core/rtw_ieee80211.o (gcc version 9.2.1, amd64) Signed-off-by: Colin Ian King --- Acked-by: Larry Finger Thanks, Larry

Re: [PATCH 2/2] staging: rtl8192e: rtllib_crypt_ccmp.c: Use crypto API ccm(aes)

files changed, 78 insertions(+), 110 deletions(-) Tested-by: Larry Finger This change for the RTL8192E works. I do not have the hardware for testing the equivalent change for r8192u, but as the changes look the same, that one is likely OK as well. Thanks for the change, Larry

Re: [PATCH 1/6] staging: rtl8188eu: add spaces around '+' in usb_halinit.c

deletions(-) If they apply, all six of these are OK. Acked-by: Larry Finger Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: Add rtl8821ce PCIe WiFi driver

ifi driver should require 200K lines of code! Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8*: use help instead of ---help--- in Kconfig

newer than mine. In any case, the changes are harmless. Acked-by: Larry Finger --- drivers/staging/rtl8188eu/Kconfig | 4 ++-- drivers/staging/rtl8192e/Kconfig | 8 drivers/staging/rtl8712/Kconfig | 4 ++-- drivers/staging/rtl8723bs/Kconfig | 2 +- 4 files changed, 9 insert

Re: [PATCH -next] staging: rtl8712: drop pointless static qualifier in r8712_efuse_pg_packet_write()

between calls to this routine. Your fix is correct. Acked-by: Larry Finger Thanks, Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8188eu: Add device code for D-Link DWA-121 rev B1

On 1/7/19 11:28 AM, Michael Straube wrote: This device was added to the stand-alone driver on github. Add it to the staging driver as well. Link: https://github.com/lwfinger/rtl8188eu/commit/a0619a07cd1e Signed-off-by: Michael Straube Acked-by: Larry Finger Thanks, Larry

Re: [PATCH v2] staging: wilc1000: fix cast to restricted __le32

e you sure this is the correct fix? As "frame_type" is input as u16, it seems to me that the frame_type member of struct wilc_reg_frame should be __le16, not __le32. Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.li

[PATCH 1/2] staging: rtl8188eu: Fix module loading from tasklet for CCMP encryption

el Straube Cc: Ivan Safonov Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/core/rtw_security.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c index f7407632e80b.

[PATCH 0/2] Fixes for system freezes for r8188eu

ll be more intrusive. My original attempt failed, thus I am delaying that fix. Cc: Michael Straube Cc: Ivan Safonov Signed-off-by: Larry Finger --- Larry Finger (2): staging: rtl8188eu: Fix module loading from tasklet for CCMP encryption staging: rtl8188eu: Fix module loading from taskl

[PATCH 2/2] staging: rtl8188eu: Fix module loading from tasklet for WEP encryption

el Straube Cc: Ivan Safonov Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/core/rtw_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c index 052656a22821.

[PATCH] MAINTAINERS: Add entry for staging driver r8188eu

This entry was missed when the driver was added. Signed-off-by: Larry Finger --- Greg, Because this driver is in staging, I am sending it to you. I hope that is OK. Larry --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f4855974f325

Re: [PATCH] Revert "staging:r8188eu: use lib80211 CCMP decrypt"

to using lib80211 routines for all decryption/encryption. Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Revert "staging:r8188eu: use lib80211 CCMP decrypt"

. Where did you submit that patch? It certainly was never in my mailbox. Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Revert "staging:r8188eu: use lib80211 CCMP decrypt"

ve been connected to an AES-encrypted AP for nearly 3 hours with no problems. Larry diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c index f7407632e80b..052656a22821 100644 --- a/drivers/staging/rtl8188eu/core/rtw_security.c +++ b/drive

[PATCH] staging: rtl8723bs: Add missing return for cfg80211_rtw_get_station

ded with NetworkManager, but it does no harm in that case. Reported-and-Tested-by: youling257 Cc: linux-wirel...@vger.kernel.org Cc: youling257 Signed-off-by: Larry Finger --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s

[PATCH] staging: rtl8723bs: Fix incorrect sense of ether_addr_equal

ecvframe_attrib().") Cc: Stable Cc: youling257 Cc: u.srikant.patn...@gmail.com Reported-and-tested-by: youling257 Signed-off-by: Larry Finger --- drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal

Re: [PATCH v2] staging: rtl8188eu: Skip unnecessary field checks

Fail; } else { /* check if ssid match */ if (memcmp((void *)(p+2), cur->Ssid.Ssid, cur->Ssid.SsidLength)) ACKed-by: Larry Finger ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverp

Re: [PATCH] staging: rtl8188eu: Avoid null pointer arithmetic

->Ssid.Ssid, cur->Ssid.SsidLength)) ACKed-by: Larry Finger Thanks, Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Your photo work

editing test. Please reply if you have needs for this. Thanks, Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

actual code changes to this driver? Perhaps support for the chipset could be converted to use mac80211 and moved into the directory with the other realtek drivers in drivers/net/wireless/realtek/rtl8xxxu/... Larry? What do you think? First of all, if a variable is not used, then it should

[PATCH v2 2/2] staging: rtl8712u: Fix compiler warning about strncpy

When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. Using strlcpy() rather than strncpy() forces a null at the end and quiets the warning. Signed-off-by: Larry Finger --- v2 - No changes. --- drivers/staging/rtl8712

[PATCH v2 0/2] staging: Fix some warnings from strncpy()

When the size argument in a call to strncpy() is the size of the destimation, gcc8 issues a warning. These patches fix the potential problem. Signed-off-by: Larry Finger v2 - The code is changed to implement the comments of David Laight. Larry Finger (2): staging: rtl8192e: Fix compiler

[PATCH 2/2] staging: rtl8712u: Fix compiler warning about strncpy

When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. Using strlcpy() rather than strncpy() forces a null at the end and quiets the warning. Signed-off-by: Larry Finger --- drivers/staging/rtl8712

[PATCH 1/2] staging: rtl8192e: Fix compiler warning about strncpy

When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. Using strlcpy() rather than strncpy() forces a null at the end and quiets the warning. Signed-off-by: Larry Finger --- drivers/staging/rtl8192e/rtllib_softmac.c

[PATCH 0/2] staging: Fix some warnings from strncpy()

When the size argument in a call to strncpy() is the size of the destimation, gcc8 issues a warning. These patches fix the potential problem by replacing the strncpy() with strlcpy(). Signed-off-by: Larry Finger Larry Finger (2): staging: rtl8192e: Fix compiler warning about strncpy

Re: [PATCH] Staging:rtl8712: Style - Removed inline block comment to fix "Statements should start on a tapstop"

ab. That silences the checkpatch warning without removing the implicit warning that these variables are special. NACK. Keep in mind that when this driver was submitted, it ran checkpatch cleanly. The fact that there are now warnings is due to changes in the tool. Following tho

Re: [PATCH 2/2] staging: fix unneeded_variables warnings

On 08/05/2018 02:35 PM, Umang Parmar wrote: Directly return value and remove unneeded variables. Signed-off-by: Umang Parmar This patch also has the same problem with the subject. Otherwise it is OK. Larry ___ devel mailing list de

Re: [PATCH 1/2] staging: fix possible_condition_with_no_effect warnings

wifi/phydm/phydm_hwconfig.c| 4 +-- drivers/staging/rtlwifi/phydm/phydm_psd.c | 7 + 6 files changed, 16 insertions(+), 46 deletions(-) Why do some of the above have "drivers/staging/..." and others have ".../staging/..."? This looks a bit strange. Otherwis

Re: [BUG] staging: r8822be: RTL8822be can't find any wireless AP

On 07/05/2018 02:36 AM, Pkshih wrote: On Wed, 2018-07-04 at 10:33 -0500, Daniel Drake wrote: On Wed, Jul 4, 2018 at 10:13 AM, Larry Finger wrote: We will have to agree to disagree. I have no idea what the vendors are doing that cause some motherboards to need a different aspm value. What I

Re: [BUG] staging: r8822be: RTL8822be can't find any wireless AP

On 07/04/2018 09:09 AM, Dan Carpenter wrote: On Wed, Jul 04, 2018 at 08:55:00AM -0500, Larry Finger wrote: I do not think this is a bug. It's obviously a bug. The driver should just work by default. As a last resort, we would do something like add quirk or something. I haven't looked

Re: [BUG] staging: r8822be: RTL8822be can't find any wireless AP

vices than would be fixed. For anyone that might read this, the options file should be named /etc/modprobe.d/50-rtl8822be.conf and contain a single line "options rtl8822be aspm=0". Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH][next][V2] staging: r8822be: fix typos in header guard macros

an King <colin.k...@canonical.com> Acked-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtlwifi/phydm/phydm_features.h | 2 +- drivers/staging/rtlwifi/phydm/phydm_kfree.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rt

Re: [PATCH-next] staging: rtl8188eu: Remove unneeded cast

. Signed-off-by: Christopher Diaz Riveros <chris...@gentoo.org> Acked-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/dri

Re: [PATCH] staging: rtlwifi: add identifier names to function definition arguments

made to conform to it now? Besides, you should use checkpatch in an advisory role. NACK. Larry drivers/staging/rtlwifi/wifi.h | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtlwifi/wifi.h b/drivers/staging/rtlwifi/wifi.h index c

Re: [PATCH v2 1/2] staging: rtl8712: Cleanup checkpatch issue WARNING:LONG_LINE

v2 2/2] staging: rtl8712: Cleanup checkpatch issues CODE_INDENT and LEADING_SPACE Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH V2] staging: rtl8188eu: Fix incorrect response to SIOCGIWESSID

is not a wireless interface and therefore it fails to work correctly with it thereafter. This problem was reported and tested at https://github.com/lwfinger/rtl8188eu/issues/234. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- v2 - completed missing subject drivers/staging/rtl

[PATCH] staging: rtl8188eu:

is not a wireless interface and therefore it fails to work correctly with it thereafter. This problem was reported and tested at https://github.com/lwfinger/rtl8188eu/issues/234. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.

Re: [PATCH] staging: rtl8822be: fix missing null check on dev_alloc_skb return

On 11/17/2017 08:50 AM, Colin King wrote: From: Colin Ian King <colin.k...@canonical.com> dev_alloc_skb can potentially return NULL, so add a null check to avoid a null pointer dereference on skb Acked-by: Larry Finger <larry.fin...@lwfinger.net> Larry Detected by Cover

Re: Searching help for Linux support for RTL8812AU

suggestion is that you work to get your device handled by driver rtl8xxxu, which is in the kernel. I have no idea how much effort that would be, but certainly a lot less than converting the Realtek driver. Larry PS: Please keep the list in the Cc as I tend to disregard private requests for consulting

Re: [PATCH] staging: rtl8822be: fix wrong dma unmap len

] Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks Stanislaw. It is amazing how long I can stare at a piece of code without seeing the problem. Larry --- drivers/staging/rtlwifi/rtl8822be/fw.c |2 +- 1 file

[PATCH] rtlwifi: Fix typo in if ... else if ... else construct

The kbuild test robot reports two conditions with no effect (if == else). These are the result of copy and paste typographical errors. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@realtek.com> Cc: Yan-Hsuan Chuang <yhchu...@realtek.com> Cc:

Re: Two rtlwifi drivers?

On 10/11/2017 08:13 AM, Greg Kroah-Hartman wrote: On Wed, Oct 11, 2017 at 12:06:00PM +0300, Kalle Valo wrote: (Sorry for taking so long with the reply, I wanted first to check what the rtlwifi in staging contains.) Larry Finger <larry.fin...@lwfinger.net> writes: On 08/24/2017 07

Re: [PATCH 1/2] staging: rtlwifi: silence underflow warning

ssage should be something like '"Pattern[%d] has bad length of %d\n", i, patterns[i].pattern_len' Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8822be: Keep array subscript no lower than zero

vel]); This condition is caused when a loop falls through. The fix is to pin max_level to be >= 0. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> c: kbuild test robot <fengguang...@intel.com> Fixes: 9ce99b04b5b82fdf11e4c76b60a5f82c1e541297 staging: r8822be: Add

Re: [PATCH 3/3] staging: rtlwifi: remove unused functions

. Remove unused functions. While it is true that those routines are unused in the staging instance of rtlwifi, they are needed in the copy in drivers/net/wireless/... I would prefer to keep the differences between these two versions as small as possible; therefore, NACK Larry . --- drivers

Re: [PATCH 2/3] staging: rtlwifi: use kcalloc instead of multiply

by checkpatch.pl is just plain stupid!! NACK. Larry --- drivers/staging/rtlwifi/efuse.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtlwifi/efuse.c b/drivers/staging/rtlwifi/efuse.c index 6d5e657..d74c80d 100644 --- a/drivers/staging/rtlwifi/efuse.c

[PATCH 2/2] staging: r8822be: Simplify deinit_priv()

Now that the extraneous debugging code is removed, routine deinit_priv() clearly contains code that serves no useful purpose. A null test before a call to kfree() and a spurious cast are also removed. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@re

[PATCH 0/2] staging: r8822be: Remove some left-over debug code

Some useless debugging code from the initial writing of the driver was not removed before it was submitted. That oversight is now fixed and the remaining code in routine deinit_priv() is simplified. Larry Larry Finger (2): staging: r8822be: Remove some dead code staging: r8822be: Simplify

[PATCH 1/2] staging: r8822be: Remove some dead code

The code found inside an #ifdef CONFIG_RTL_DEBUG ... #endif section is left over from debugging of the original driver, and should be deleted. Reported by: Andreas Ziegler <andreas.zieg...@fau.de> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@

Re: [PATCH] staging: r8822be: Fix typo for CONFIG_RTLWIFI_DEBUG

currently testing that change, and will submit the two patches at the same time. Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: r8822be: Fix typo for CONFIG_RTLWIFI_DEBUG

roblem; however, CONFIG_RTLWIFI_DEBUG is not the value that should be used. That one is reserved for the non-staging drivers in drivers/net/wireless/realtek/rtlwifi/. The correct symbol for r8822be is CONFIG_RTLWIFI_DEBUG_ST. Larry --- drivers/staging/rtlwifi/halmac/rtl_halmac.c | 4 ++--

Re: [PATCH] staging: rtl8723bs: remove null check before kfree

On 08/26/2017 03:47 PM, Himanshu Jha wrote: Kfree on NULL pointer is a no-op and therefore checking is redundant. Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com> --- Acked-by: Larry Finger <larry.fin...@lwfinger.net> For some reason not fully explained, gmail is placin

Re: [PATCH] Staging rtlwifi efuse fix up a warning kzalloc

tries to force code that I maintain to use kcalloc over kzalloc. Larry ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: r8822be: remove some dead code

On 08/25/2017 03:42 AM, Dan Carpenter wrote: "hdr" can't be NULL. We take skb->data which is non-NULL and add an offset to get "hdr". Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Thanks. Looks good. Acked-by: Larry Finger <l

Re: [PATCH] staging: rtlwifi: Improve debugging by using debugfs

? Please suggest which driver has the best example of an ethtool -d implementation that we might study. The first version of the debugfs changes were sent to wireless-drivers on July 2. Why are we first hearing of this objection nearly 2 months later? Larry

[PATCH] staging: rtlwifi: Improve debugging by using debugfs

common status. 2. remove obsolete field bt_exist Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Yan-Hsuan Chuang <yhchu...@realtek.com> Cc: Birming Chiu <birm...@realtek.com> Cc: Shaofu <sha...@realtek.co

Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency

but this one with MAC80211 is the correct one. Randy's patch is in the latest pull I did on staging. Do you want an updated patch? Larry --- drivers/staging/rtlwifi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtlwifi/Kconfig b/drivers/staging

Re: [PATCH 3/3] staging: rtlwifi: simplify logical operation

ch more readable. In a followup, I will fix the spelling of polarity, but yours is fine. Acked-by: Larry Finger <larry.fin...@lwfinger.net> Larry --- drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/sta

Re: [PATCH] staging: r8822be: fix null pointer dereference with a null driver_adapter

er before the tracing call so that a non-null driver_adapter is passed instead. Detected by CoverityScan, CID#1454613 ("Explicit null dereferenced") Fixes: 938a0447f094 ("staging: r8822be: Add code for halmac sub-driver") Signed-off-by: Colin Ian King <colin.k...@canonic

Re: [PATCH] staging: rtlwifi: check for array overflow

have added it here as well. Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, Larry diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c index f7f207cbaee3..a30b928d5ee1 100644 --- a/drivers/stagin

Re: Two rtlwifi drivers?

ing. I'm sorry about the fallout affecting you, and I probably should have changed the directory names. In any case, ignore any patches that belong in staging. If I see any that do not include GregKH in the "To" list, I will NACK them and request proper routing. Larry _

Re: Thoughts on staging and on fixing up drivers?

On 08/17/2017 04:07 PM, tedheadster wrote: Larry, you've migrated a bunch of staging code, and tried various approaches. Do you have any lessons on what has worked and what hasn't and if there is anything we can do to make the process better? I am also quite interested in such work. We asked

[PATCH 7/8] staging: r8822be: Add Makefiles and Kconfig for new driver

into a single module r8822be. When this driver is moved to the wireless tree, halmac, phydm, and rtl8822be will become new modules. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@realtek.com> Cc: Yan-Hsuan Chuang <yhchu...@realtek.com> Cc:

[PATCH 8/8] staging: rtlwifi: Reviewers fixes

This commit adds the TODO file and implements some reviewers comments made against some patches to the wireless tree. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@realtek.com> Cc: Yan-Hsuan Chuang <yhchu...@realtek.com> Cc: Birming Chiu <bi

[PATCH 2/8] staging: r8822be: Copy existing btcoexist code into staging

. There are no changes other than removing all EXPORT statements, and the fixing of checkpatch messages. The latter will be backported to the wireless tree. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@realtek.com> Cc: Yan-Hsuan Chuang <yhchu...@realtek.c

[PATCH 0/8] staging: Add new driver for RTL8822BE

the code into the main wireless tree in small pieces. To minimize interference between the rtlwifi drivers in the wireless tree and this new driver, the new one can only be built as a module. In addition, all code is built into a single module. Larry Finger Signed-off-by: Larry Finger <larry.

Re: [PATCH v2 4/4] Staging: rtl8712 : ieee80211.c: fixed camelcase coding style issue

conPeriod); + *(__le16 *)ie = cpu_to_le16(cfg->beacon_period); What you did is not wrong as you set "cfg = _network->Configuration", but your commit message does not mention such refactoring. For that reason, NACK Larry --- drivers/staging/rtl8712/ieee80211.c | 7 ---

Re: [PATCH 4/7] staging: rtl8723bs: Move braces to same line as conditional

| 6 ++ 3 files changed, 10 insertions(+), 20 deletions(-) Fix the over-long lines and add a commit message. Larry diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c index 28d1a229c3a6..2838d5cdd1de 100644 --- a/drivers/s

Re: [PATCH 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses

-blank commit messages also applies. Larry #defineDM_Type_ByFW0 #defineDM_Type_ByDriver1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/m

Re: [PATCH 2/7] staging: rtl8723bs: Wrap multi-line macros in do-while loop

On 04/27/2017 07:09 PM, Justin Vreeland wrote: Signed-off-by: Justin Vreeland <jus...@jvreeland.com> --- The patch is OK, but most maintainers require a non-blank commit message. Larry drivers/staging/rtl8723bs/hal/odm_debug.h | 80 +-- 1 file chang

Re: [PATCH] staging: rtl8723bs: remove null test before kfree

On 04/10/2017 08:43 AM, Aishwarya Pant wrote: kfree(..) on a NULL pointer is a no-op; the null test here is redundant. Detected by coccicheck. Signed-off-by: Aishwarya Pant <aishp...@gmail.com> Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, Larry --- drivers/stagi

Re: [PATCH 06/22] staging: rtl8723bs: Fix various errors in os_dep/ioctl_cfg80211.c

On 04/09/2017 10:28 AM, Bastien Nocera wrote: On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote: Smatch lists the following: CHECK drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:470 rtw_cfg80211_ibss_indicate_connect() error: we

Re: [PATCH] staging: rtl8723bs: core: drop unneeded null tests

ego...@redhat.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Thank you for these patches. Larry Finger has just posted a large cleanup series for the rtl8723bs driver, which will likely conflict with these. Can you rebase and re

[PATCH 21/22] staging: rtl8723bs: Fix indenting problems in core/rtw_odm.c

-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/core/rtw_odm.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_odm.c b/drivers/staging/rtl8723bs/core/rtw_odm.c index 5bc573386ad1..3144e8ec2fa2

  1   2   3   4   5   6   >