*/
{} /* Terminating entry */
};
Acked-by: Larry Finger
Larry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 7/26/20 3:40 AM, Aditya Jain wrote:
On Sun, Jul 26, 2020 at 1:56 PM Greg KH wrote:
On Sun, Jul 26, 2020 at 01:32:15PM +0530, Aditya Jain wrote:
Fixing ERROR: "foo * bar" should be "foo *bar" in hal_phy_cfg.h
as reported by checkpatch.pl
Signed-off-by: Aditya Jain
---
.../staging/rtl87
On 7/25/20 1:39 PM, Joe Perches wrote:
On Sat, 2020-07-25 at 12:47 -0500, Larry Finger wrote:
On 7/25/20 7:20 AM, Anant Thazhemadam wrote:
Running the checkpatch.pl script on the file for which patch was created, the
following error was found to exist.
ERROR: space required after that
On 7/25/20 7:20 AM, Anant Thazhemadam wrote:
Running the checkpatch.pl script on the file for which patch was created, the
following error was found to exist.
ERROR: space required after that ',' (ctx:VxV)
Fixed the above error which was found on line #721 by inserting a blank
space at the appro
On 7/24/20 8:28 AM, Dinghao Liu wrote:
The variable authmode will keep uninitialized if neither if
statements used to initialize this variable are not triggered.
Besides Greg's comment, you need to re-parse this sentence. I realize that
English is probably not your first language, but this one
I have already fixed 4 places with unnecessary alignment, but, alas, there is no
great desire to test them on real hardware.
I have now tested on real hardware and it works fine.
Acked-by: Larry Finger
Larry
___
devel mailing li
On 7/12/20 7:38 AM, Ivan Safonov wrote:
Remove unused members of struct xmit_buf: alloc_sz, ff_hwaddr,
dma_transfer_addr, bpending and last.
Signed-off-by: Ivan Safonov
---
Have you tested this change? Previously with this driver, an unused quantity was
removed from one of the structs and th
On 6/1/20 3:24 PM, Pascal Terjan wrote:
This patch switches to and and
deletes a lot of duplicate definitions plus many unused ones.
Non obvious changes:
- struct ieee80211_ht_cap is different enough that I preferred to keep
(and rename) it for now.
- mcs_rate in translate_scan was not read
The ASUS USB-N10 Nano B1 has been reported as a new RTL8188EU device.
Add it to the device tables.
Signed-off-by: Larry Finger
Reported-by: kovi
Cc: Stable
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep
("Add files for new driver - part 16").
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
ind
commit a2c60d42d97c ("Add files for new driver - part 16").
Reported by: Pietro Oliva
Cc: Pietro Oliva
Cc: Stable
Fixes commit a2c60d42d97c ("Add files for new driver - part 16").
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 2 +-
1 file changed,
f216 ("0taging: Add rtl8723bs sdio wifi driver").
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
b/drivers/staging/rtl8723bs/os_dep/ioc
eliminate the got target.
Signed-off-by: Larry Finger
Cc: Pietro Oliva
---
.../staging/rtl8188eu/os_dep/ioctl_linux.c| 40 ++-
1 file changed, 12 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu/os_dep
commit 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver").
Reported by: Pietro Oliva
Cc: Pietro Oliva
Cc: Stable
Fixes: 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver").
Signed-off-by: Larry Finger
-# Please enter the commit message for your changes. Lines starting
---
eliminate the got target.
Signed-off-by: Larry Finger
Cc: Pietro Oliva
---
.../staging/rtl8723bs/os_dep/ioctl_linux.c| 47 +--
1 file changed, 12 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
b/drivers/staging/rtl8723bs/os_dep
It was recently reported that staging drivers rtl8188eu and rtl8723bs
contained a security flaw because a parameter had not been checked.
The following patches fix that flaw and cleans up the routines.
Signed-off-by: Larry Finger
Larry Finger (6):
staging: rtl8188eu: Fix potential security
/core/rtw_pwrctrl.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
Acked-by: Larry Finger
Thanks,
Larry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 11/23/19 9:16 AM, Michael Straube wrote:
Replace tabs with spaces in declarations to cleanup whitespace.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
Acked-by: Larry Finger
On 11/23/19 9:16 AM, Michael Straube wrote:
Remove unnecessary parentheses reported by checkpatch.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
Acked-by: Larry Finger
Thanks,
Larry
< RTL88E_MESSAGE_BOX_SIZE; cmd_idx++)
+ usb_write8(adapt, msgbox_addr + cmd_idx, *((u8 *)(&h2c_cmd) +
cmd_idx));
- } while ((!bcmd_down) && (retry_cnts--));
+ adapt->HalData->LastHMEBoxNum =
+ (h2c_box_num + 1) %
d be
with 0x03 according to the max_rate_idx in ODM_RAInfo_Init().
Cc: Larry Finger
Cc: Greg Kroah-Hartman
Cc: Michael Straube
Cc: sta...@vger.kernel.org
Signed-off-by: Denis Efremov
---
drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
r->addr3, get_bssid(pmlmepriv), ETH_ALEN);
- if (psta->qos_option)
+ if (psta && psta->qos_option)
qos_option = true;
} else {
RT_TRACE(_module_rt
On 9/25/19 4:32 PM, Connor Kuehl wrote:
Inside a nested 'else' block at the beginning of this function is a
call that assigns 'psta' to the return value of 'rtw_get_stainfo()'.
If 'rtw_get_stainfo()' returns NULL and the flow of control reaches
the 'else if' where 'psta' is dereferenced, then we
On 9/23/19 2:48 PM, Connor Kuehl wrote:
The local variable 'bcmd_down' is always set to true almost immediately
before the do-while's condition is checked. As a result, !bcmd_down
evaluates to false which short circuits the logical AND operator meaning
that the second operand is never reached and
7eb5 rtl8188eu/core/rtw_ieee80211.o
After:
text data bss dec hex filename
26612 5776 0 323887e84 rtl8188eu/core/rtw_ieee80211.o
(gcc version 9.2.1, amd64)
Signed-off-by: Colin Ian King
---
Acked-by: Larry Finger
Thanks,
files changed, 78 insertions(+), 110 deletions(-)
Tested-by: Larry Finger
This change for the RTL8192E works. I do not have the hardware for testing the
equivalent change for r8192u, but as the changes look the same, that one is
likely OK as well.
Thanks for the change,
Larry
ons(+), 38 deletions(-)
If they apply, all six of these are OK.
Acked-by: Larry Finger
Larry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 5/15/19 8:06 AM, Kai-Heng Feng wrote:
at 20:33, Greg KH wrote:
On Wed, May 15, 2019 at 07:54:58PM +0800, Kai-Heng Feng wrote:
at 19:40, Greg KH wrote:
On Wed, May 15, 2019 at 07:24:01PM +0800, Kai-Heng Feng wrote:
The rtl8821ce can be found on many HP and Lenovo laptops.
Users have bee
your Kconfig may be newer than mine. In any
case, the changes are harmless.
Acked-by: Larry Finger
---
drivers/staging/rtl8188eu/Kconfig | 4 ++--
drivers/staging/rtl8192e/Kconfig | 8
drivers/staging/rtl8712/Kconfig | 4 ++--
drivers/staging/rtl8723bs/Kconfig | 2 +-
4 fil
rried over between
calls to this routine. Your fix is correct.
Acked-by: Larry Finger
Thanks,
Larry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 1/7/19 11:28 AM, Michael Straube wrote:
This device was added to the stand-alone driver on github.
Add it to the staging driver as well.
Link: https://github.com/lwfinger/rtl8188eu/commit/a0619a07cd1e
Signed-off-by: Michael Straube
Acked-by: Larry Finger
Thanks,
Larry
On 1/5/19 3:10 AM, Július Milan wrote:
Fixes the following sparse warnings:
drivers/staging/wilc1000/host_interface.c:2360:30: warning:
incorrect type in assignment (different base types)
expected restricted __le32 [addressable] [assigned] [usertype] frame_type
got restricted __le16
el Straube
Cc: Ivan Safonov
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c
b/drivers/staging/rtl8188eu/core/rtw_security.c
index f7407632e80b..05265
ll be more intrusive. My original attempt failed, thus I am
delaying that fix.
Cc: Michael Straube
Cc: Ivan Safonov
Signed-off-by: Larry Finger
---
Larry Finger (2):
staging: rtl8188eu: Fix module loading from tasklet for CCMP
encryption
staging: rtl8188eu: Fix module loading from taskl
el Straube
Cc: Ivan Safonov
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_security.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c
b/drivers/staging/rtl8188eu/core/rtw_security.c
index 052656a22821..bab96
This entry was missed when the driver was added.
Signed-off-by: Larry Finger
---
Greg,
Because this driver is in staging, I am sending it to you. I hope that is OK.
Larry
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f4855974f325
On 1/1/19 1:31 PM, Michael Straube wrote:
I've tested your patch and it solved the issue. No freezes and dmesg looks good.
I noticed that try_then_request_module() is also used in rtw_wep_encrypt() and
rtw_wep_decrypt(). I guess that also could cause problems?
Yes, I believe it would if anyon
On 1/1/19 3:02 AM, Ivan Safonov wrote:
I suggested a patch for loading modules from interruptible mode, but this patch
remained unclaimed (
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-August/124851.html
).
For some reason I thought that this patch had been removed a
On 12/30/18 12:39 PM, Michael Straube wrote:
Commit 6bd082af7e36 ("staging:r8188eu: use lib80211 CCMP decrypt")
is causing hardfreeze whenever the driver tries to connect to my wifi
network. That makes the driver unusable on my system. Reverting the
commit fixes the issue and the driver works pro
NetworkManager, but it
does no harm in that case.
Reported-and-Tested-by: youling257
Cc: linux-wirel...@vger.kernel.org
Cc: youling257
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s
ecvframe_attrib().")
Cc: Stable
Cc: youling257
Cc: u.srikant.patn...@gmail.com
Reported-and-tested-by: youling257
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal
cReqFail;
} else {
/* check if ssid match */
if (memcmp((void *)(p+2), cur->Ssid.Ssid, cur->Ssid.SsidLength))
ACKed-by: Larry Finger
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdri
d *)(p+2), cur->Ssid.Ssid, cur->Ssid.SsidLength))
ACKed-by: Larry Finger
Thanks,
Larry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 08/29/2018 04:14 PM, Joe Perches wrote:
On Wed, 2018-08-29 at 21:35 +0100, John Whitmore wrote:
Rename the bit field element AdvCoding, as it causes a checkpatch issue
with CamelCase naming. As the element is not actually used in code it
has been renamed to 'not_used_adv_coding'.
The single
When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. Using
strlcpy() rather than strncpy() forces a null at the end and quiets the
warning.
Signed-off-by: Larry Finger
---
v2 - No changes.
---
drivers/staging/rtl8712
When the size argument in a call to strncpy() is the size of the
destimation, gcc8 issues a warning. These patches fix the potential
problem.
Signed-off-by: Larry Finger
v2 - The code is changed to implement the comments of David Laight.
Larry Finger (2):
staging: rtl8192e: Fix compiler
When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. This section
is completely reworked to use the known lengths of the strings.
Signed-off-by: Larry Finger
---
v2 - David Laight's comments are implem
When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. Using
strlcpy() rather than strncpy() forces a null at the end and quiets the
warning.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8712
When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. Using
strlcpy() rather than strncpy() forces a null at the end and quiets the
warning.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8192e/rtllib_softmac.c
When the size argument in a call to strncpy() is the size of the
destimation, gcc8 issues a warning. These patches fix the potential
problem by replacing the strncpy() with strlcpy().
Signed-off-by: Larry Finger
Larry Finger (2):
staging: rtl8192e: Fix compiler warning about strncpy
On 08/08/2018 04:22 AM, Greg KH wrote:
On Sun, Aug 05, 2018 at 09:41:06PM +0200, Frank Werner-Krippendorf wrote:
Removed 5 inline comments "/*volatile*/" rtl87x_event.h, to fix
a coding style issue "Statements should start on a tabstop"
detected by checkpatch.pl script.
Signed-off-by: Frank Wer
On 08/05/2018 02:35 PM, Umang Parmar wrote:
Directly return value and remove unneeded variables.
Signed-off-by: Umang Parmar
This patch also has the same problem with the subject. Otherwise it is OK.
Larry
___
devel mailing list
de...@linuxdriverpro
On 08/05/2018 02:35 PM, Umang Parmar wrote:
Remove unnecessary conditions where if and else block had same code.
Signed-off-by: Umang Parmar
The subject should be "staging: rtlwifi: ...". If someone wants to search for
fixes to the modules in drivers/staging/rtlwifi/, your subject would not b
On 07/05/2018 02:36 AM, Pkshih wrote:
On Wed, 2018-07-04 at 10:33 -0500, Daniel Drake wrote:
On Wed, Jul 4, 2018 at 10:13 AM, Larry Finger wrote:
We will have to agree to disagree.
I have no idea what the vendors are doing that cause some motherboards to
need a different aspm value. What I
On 07/04/2018 09:09 AM, Dan Carpenter wrote:
On Wed, Jul 04, 2018 at 08:55:00AM -0500, Larry Finger wrote:
I do not think this is a bug.
It's obviously a bug. The driver should just work by default.
As a last resort, we would do something like add quirk or something. I
haven't
On 07/04/2018 03:03 AM, Jian-Hong Pan wrote:
Hi,
We have an ASUS X530UN (Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz)
laptop equipped with Realtek rtl8822be wireless which cannot find any
access point after WiFi is launched.
Realtek rtl8822be wireless' information:
dev@endless:~/linux-eos$ sudo ls
re, followed
by #define of a different macro [-Wheader-guard]
warning: '__PHYDM_FEATURES_H__' is used as a header guard here, followed
by #define of a different macro [-Wheader-guard]
Fixes: 9ce99b04b5b8 ("staging: r8822be: Add phydm mini driver")
Signed-off-by: Colin
.
Signed-off-by: Christopher Diaz Riveros
Acked-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 32c7225a831e
On 01/28/2018 08:05 AM, Erik Liodden wrote:
Add identifier names to function definition arguments to comply with
the kernel coding style and the naming convention in the rest of the
file.
Issues found by checkpatch.
Signed-off-by: Erik Liodden
---
As far as I am concerned, this patch is mere
On 12/09/2017 05:11 AM, Neil Singh wrote:
Cleanup below checkpatch issue:
WARNING:LONG_LINE: line over 80 characters
1000: FILE: rtl871x_security.c:1000:
+static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint
qc_exists,
Signed-off-by: Neil Singh
---
drivers/staging/rtl8712
not a wireless interface
and therefore it fails to work correctly with it thereafter.
This problem was reported and tested at
https://github.com/lwfinger/rtl8188eu/issues/234.
Signed-off-by: Larry Finger
---
v2 - completed missing subject
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 14
not a wireless interface
and therefore it fails to work correctly with it thereafter.
This problem was reported and tested at
https://github.com/lwfinger/rtl8188eu/issues/234.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 14 --
1 file changed, 4
On 11/17/2017 08:50 AM, Colin King wrote:
From: Colin Ian King
dev_alloc_skb can potentially return NULL, so add a null check to
avoid a null pointer dereference on skb
Acked-by: Larry Finger
Larry
Detected by CoverityScan, CID#1454558 ("Dereference on null return")
Fixes: 7e
On 10/24/2017 08:24 AM, txt.file wrote:
Hey Linux wireless list,
A while ago I bought an ALFA Network AWUS036AC[0] which does not yet
seem to be supported in Linux mainline. I would like to get it supported.
The problem is that I have not that much experience doing software
development.
kind r
]
Signed-off-by: Stanislaw Gruszka
Acked-by: Larry Finger
Thanks Stanislaw. It is amazing how long I can stare at a piece of code without
seeing the problem.
Larry
---
drivers/staging/rtlwifi/rtl8822be/fw.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers
The kbuild test robot reports two conditions with no effect (if == else).
These are the result of copy and paste typographical errors.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
Cc: kbuild-...@01.org
Cc: Julia Lawall
On 10/11/2017 08:13 AM, Greg Kroah-Hartman wrote:
On Wed, Oct 11, 2017 at 12:06:00PM +0300, Kalle Valo wrote:
(Sorry for taking so long with the reply, I wanted first to check what
the rtlwifi in staging contains.)
Larry Finger writes:
On 08/24/2017 07:14 AM, Kalle Valo wrote:
Dan
On 09/29/2017 02:51 AM, Dan Carpenter wrote:
I'm not totally certain that it's necessary to put an upper limit here.
I think it happens at lower levels. But if we are going to do that then
we should have a lower bound as well.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/rtlwifi/
lue[max_level]);
This condition is caused when a loop falls through. The fix is to pin
max_level to be >= 0.
Signed-off-by: Larry Finger
c: kbuild test robot
Fixes: 9ce99b04b5b82fdf11e4c76b60a5f82c1e541297 staging: r8822be: Add phydm
mini driver
---
drivers/staging/rtlwifi/phydm/phydm_dig.
On 09/05/2017 01:53 AM, Tobin C. Harding wrote:
Functions rtl_rfreg_delay() and rtl_bb_delay() are unused within the
driver. Both functions call rtl_addr_delay(), this function is unused
outside of these call sites.The driver (and kernel) code base is cleaner
if unused functions are removed.
Rem
On 09/05/2017 01:53 AM, Tobin C. Harding wrote:
checkpatch emits multiple warnings of type
WARNING:ALLOC_WITH_MULTIPLY: Prefer kcalloc over kzalloc with multiply
Replace two calls to kzalloc() with calls to kcalloc().
I have previously discussed this kind of change. This recommendation by
ch
Now that the extraneous debugging code is removed, routine deinit_priv()
clearly contains code that serves no useful purpose.
A null test before a call to kfree() and a spurious cast are also removed.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc
Some useless debugging code from the initial writing of the driver was not
removed before it was submitted. That oversight is now fixed and the
remaining code in routine deinit_priv() is simplified.
Larry
Larry Finger (2):
staging: r8822be: Remove some dead code
staging: r8822be: Simplify
The code found inside an #ifdef CONFIG_RTL_DEBUG ... #endif section
is left over from debugging of the original driver, and should be
deleted.
Reported by: Andreas Ziegler
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
On 08/30/2017 02:58 AM, Andreas Ziegler wrote:
Indeed, sorry I missed that as well.
So what should we make of that #ifdef? The code inside it doesn't compile
(anymore? I didn't find any development history for that patch except the
original mail), as there is no definition of struct submit_ctx i
On 08/29/2017 06:30 AM, Andreas Ziegler wrote:
The debugging output in deinit_priv is guarded by an #ifdef using
CONFIG_RTL_DEBUG. This symbol does not exist and should be
CONFIG_RTLWIFI_DEBUG instead.
Signed-off-by: Andreas Ziegler
NACK.
Yes, there is a problem; however, CONFIG_RTLWIFI_DEB
On 08/26/2017 03:47 PM, Himanshu Jha wrote:
Kfree on NULL pointer is a no-op and therefore checking is redundant.
Signed-off-by: Himanshu Jha
---
Acked-by: Larry Finger
For some reason not fully explained, gmail is placing ALL your E-mails in my
spam folder. You might wish to explore that
On 08/26/2017 08:01 AM, Yurii Pavlenko wrote:
Hello,
I have attached a small patch to fix a warning "Prefer kcalloc over kzalloc with
multiply"
for efuse.c as part of challenge 10 of Eudyptula.
Best regards,
Yurii Pavlenko
Signed-off-by: Yurii Pavlenko
Before you waste any more of our tim
On 08/25/2017 03:42 AM, Dan Carpenter wrote:
"hdr" can't be NULL. We take skb->data which is non-NULL and add an
offset to get "hdr".
Signed-off-by: Dan Carpenter
Thanks. Looks good.
Acked-by: Larry Finger
Larry
_
On 08/24/2017 08:54 PM, Andrew Lunn wrote:
netdev frowns upon debugfs. You should try to keep this altogether,
making it easy to throw away before the driver is moved out of
staging.
You might want to look at ethtool -d. That will be accepted.
Andrew,
What is the problem with debugfs?
Please
access btcoex's common status.
2. remove obsolete field bt_exist
Signed-off-by: Ping-Ke Shih
Signed-off-by: Larry Finger
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
---
drivers/staging/rtlwifi/debug.c | 226
1 file changed, 1
On 08/23/2017 08:22 AM, Arnd Bergmann wrote:
Like the version in drivers/net/wireless, this driver requires the
MAC80211 framework, otherwise we run into a link error:
ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined!
ERROR: "cfg80211_unlink_bss" [drivers/staging/rtlw
h more readable. In a followup, I will fix the spelling of
polarity, but yours is fine.
Acked-by: Larry Finger
Larry
---
drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtlwifi/btcoexist/halbtc
hat a non-null driver_adapter is passed instead.
Detected by CoverityScan, CID#1454613 ("Explicit null dereferenced")
Fixes: 938a0447f094 ("staging: r8822be: Add code for halmac sub-driver")
Signed-off-by: Colin Ian King
Acked-by: Larry Finger
Thanks,
Larry
---
drivers
e added it here as well.
Signed-off-by: Dan Carpenter
Acked-by: Larry Finger
Thanks,
Larry
diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c
index f7f207cbaee3..a30b928d5ee1 100644
--- a/drivers/staging/rtlwifi/base.c
+++ b/drivers/staging/rtlwifi/base.c
@@ -1414,
On 08/24/2017 07:14 AM, Kalle Valo wrote:
Dan Carpenter writes:
Smatch is distrustful of the "capab" value and marks it as user
controlled. I think it actually comes from the firmware? Anyway, I
looked at other drivers and they added a bounds check and it seems like
a harmless thing to have
On 08/17/2017 04:07 PM, tedheadster wrote:
Larry, you've migrated a bunch of staging code, and tried various
approaches. Do you have any lessons on what has worked and what hasn't
and if there is anything we can do to make the process better?
I am also quite interested in such work. We asked
into a single module r8822be. When this driver is
moved to the wireless tree, halmac, phydm, and rtl8822be will become
new modules.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
---
drivers/staging/Kconfig
This commit adds the TODO file and implements some reviewers comments
made against some patches to the wireless tree.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
---
drivers/staging/rtlwifi/TODO | 8
are no changes other than removing all EXPORT
statements, and the fixing of checkpatch messages. The latter will
be backported to the wireless tree.
Signed-off-by: Larry Finger
Cc: Ping-Ke Shih
Cc: Yan-Hsuan Chuang
Cc: Birming Chiu
Cc: Shaofu
Cc: Steven Ting
---
drivers/staging/rtlwifi
code into the main wireless tree in small pieces.
To minimize interference between the rtlwifi drivers in the wireless tree
and this new driver, the new one can only be built as a module. In
addition, all code is built into a single module.
Larry Finger
Signed-off-by: Larry Finger
Cc: Ping-Ke
On 06/29/2017 01:43 AM, Jaya Durga wrote:
The following variables and struct name
are renamed to avoid camelcase issue
Configuration to configuration
BeaconPeriod to beacon_period
DSConfig to ds_config
ATIMWindowto atim_window
pnic_Config to pnic_config
FHConfig to fh_config
Hop
On 04/27/2017 07:09 PM, Justin Vreeland wrote:
Signed-off-by: Justin Vreeland
---
drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 15 +--
drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 9 +++--
drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 ++
3 files changed, 1
On 04/27/2017 07:09 PM, Justin Vreeland wrote:
Signed-off-by: Justin Vreeland
---
drivers/staging/rtl8723bs/hal/odm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm.h
b/drivers/staging/rtl8723bs/hal/odm.h
index 0b3541a91548..13c4aebd178e 1
On 04/27/2017 07:09 PM, Justin Vreeland wrote:
Signed-off-by: Justin Vreeland
---
The patch is OK, but most maintainers require a non-blank commit message.
Larry
drivers/staging/rtl8723bs/hal/odm_debug.h | 80 +--
1 file changed, 44 insertions(+), 36 deletions(-
On 04/10/2017 08:43 AM, Aishwarya Pant wrote:
kfree(..) on a NULL pointer is a no-op; the null test here is redundant.
Detected by coccicheck.
Signed-off-by: Aishwarya Pant
Acked-by: Larry Finger
Thanks,
Larry
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 6 ++
drivers
On 04/09/2017 10:28 AM, Bastien Nocera wrote:
On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote:
Smatch lists the following:
CHECK drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:470
rtw_cfg80211_ibss_indicate_connect() error: we
: Julia Lawall
Signed-off-by: Fengguang Wu
Thank you for these patches. Larry Finger has just
posted a large cleanup series for the rtl8723bs
driver, which will likely conflict with these.
Can you rebase and resend these patches once Larry's
series has been merged please?
OK, thanks fo
: Larry Finger
---
drivers/staging/rtl8723bs/core/rtw_odm.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_odm.c
b/drivers/staging/rtl8723bs/core/rtw_odm.c
index 5bc573386ad1..3144e8ec2fa2 100644
--- a/drivers/staging/rtl8723bs
/rtw_recv.c:1547 validate_recv_frame() warn:
inconsistent indenting
Signed-off-by: Larry Finger
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c
b/drivers/staging
1 - 100 of 621 matches
Mail list logo
