On Mon, Jan 03, 2022 at 12:11:32PM +0100, Alberto Merciai wrote:
> Replace camelcase field CustomerID to customer_id, compliant
> with linux kernel coding style.
Apologize, don't consider it, wrong branch was used.
Regards,
Alberto Merciai
___
devel
Replace camelcase field CustomerID to customer_id, compliant
with linux kernel coding style.
Signed-off-by: Alberto Merciai
---
drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 +-
drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 2
This commit fixes some checkpatch checks for blank lines before
and after braces in drivers/staging/rtl8188eu/core/rtw_ap.c
Signed-off-by: Benjamin Philip
---
This patch fixes some checkpatch.pl CHECKs for blank lines.
I have tested my changes by compiling them. I also used
checkpatch.pl,
I have built the file without any errors. I did not need to make any changes.
I apologise for not building my changes. I shall not repeat it again.
Should I create a v2 patch and resend, or will we continue from this patch ?
Thanks,
Benjamin Philip
___
On Wed, Jul 21, 2021 at 04:28:09PM +0530, Benjamin Philip wrote:
> This commit fixes some checkpatch checks for blank lines before
> and after braces in drivers/staging/rtl8188eu/core/rtw_ap.c
>
> Signed-off-by: Benjamin Philip
> ---
>
> This patch fixes some checkpatch.pl CHECKs for blank
This commit fixes some checkpatch checks for blank lines before
and after braces in drivers/staging/rtl8188eu/core/rtw_ap.c
Signed-off-by: Benjamin Philip
---
This patch fixes some checkpatch.pl CHECKs for blank lines.
Note: Since all I have done is remove some empty blank lines, I didn't
This driver implements its own routines to allocate, access and free the
private data of its net_device. Use the functionality from the networking
core instead.
Signed-off-by: Martin Kaiser
---
drivers/staging/rtl8188eu/core/rtw_debug.c| 8 +-
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote:
s/pasive/passive/
Also need to s/varable/variable/
Signed-off-by: Bhaskar Chowdhury
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c
s/pasive/passive/
Signed-off-by: Bhaskar Chowdhury
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c
b/drivers/staging/rtl8188eu/core/rtw_mlme.c
index f87dd71934c3..96d15fca48b0 100644
On Fri, Mar 5, 2021 at 12:33 PM Dan Carpenter wrote:
>
> It's good that you're reviewing code...
Right now watching the patches flow feels like I'm just shadowing.
Later, when I get the hang of it, I might try providing something on
my own. I'll just watch things from a distance for the time
On Fri, Mar 05, 2021 at 10:58:17AM -0600, Edmundo Carmona Antoranz wrote:
> On Fri, Mar 5, 2021 at 2:59 AM Dan Carpenter wrote:
> > - if (sec_len > 0 && sec_len <= len) {
> > + if (sec_len > 0 &&
> > +
On Fri, Mar 5, 2021 at 2:59 AM Dan Carpenter wrote:
> - if (sec_len > 0 && sec_len <= len) {
> + if (sec_len > 0 &&
> + sec_len <= len &&
> +
This code has a check to prevent read overflow but it needs another
check to prevent writing beyond the end of the ->ssid[] array.
Fixes: a2c60d42d97c ("staging: r8188eu: Add files for new driver - part 16")
Signed-off-by: Dan Carpenter
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 6
The "ie_len" is a value in the 1-255 range that comes from the user. We
have to cap it to ensure that it's not too large or it could lead to
memory corruption.
Fixes: 9a7fe54ddc3a ("staging: r8188eu: Add source files for new driver - part
1")
Signed-off-by: Dan Carpenter
---
This patch fixes the checkpatch.pl warnings:
WARNING: Block comments use * on subsequent lines
WARNING: Block comments should align the * on each line
Signed-off-by: Suryashankar Das
---
drivers/staging/rtl8188eu/core/rtw_security.c | 72 ---
1 file changed, 29 insertions(+), 43
On Thu, Feb 18, 2021 at 10:50:43PM +0530, Suryashankar Das wrote:
> This patch fixes the checkpatch.pl warnings:
> WARNING: Block comments use * on subsequent lines
> WARNING: Block comments should align the * on each line
>
> Signed-off-by: Suryashankar Das
> ---
>
This patch fixes the checkpatch.pl warnings:
WARNING: Block comments use * on subsequent lines
WARNING: Block comments should align the * on each line
Signed-off-by: Suryashankar Das
---
drivers/staging/rtl8188eu/core/rtw_security.c | 82 +--
1 file changed, 41 insertions(+), 41
On 2/4/21 2:52 AM, Martin Kaiser wrote:
The Edimax EW-7811UN V2 uses an RTL8188EU chipset and works with this
driver.
Signed-off-by: Martin Kaiser
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
The Edimax EW-7811UN V2 uses an RTL8188EU chipset and works with this
driver.
Signed-off-by: Martin Kaiser
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
A netdev xmit function should return NETDEV_TX_OK or NETDEV_TX_BUSY.
Signed-off-by: Martin Kaiser
---
drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c
From: Kaixu Xia
The two bool variables singletone and carrier_sup are always false
and the following if statement can't be true, these code are useless,
so remove them.
Reported-by: Tosk Robot
Signed-off-by: Kaixu Xia
---
drivers/staging/rtl8188eu/hal/phy.c | 7 ---
1 file changed, 7
On Tue, Oct 20, 2020 at 08:17:48AM -0700, Elena Afanasova wrote:
> Reported by checkpatch.pl
>
If I were trying to clean up this driver I would probably take a
different approach.
Just send a patch that introduces line breaks for RT_TRACE() printks.
The RT_TRACE() printks are super ugly, and if
Remove commented defines from ioctl_linux.c. They are included from
include/uapi/linux/wireless.h. Also clears a checkpatch warning.
WARNING: Block comments use * on subsequent lines
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 11 ---
1 file
On Tue, Oct 20, 2020 at 8:56 PM Elena Afanasova wrote:
>
> Reported by checkpatch.pl
Hi Elena,
Thanks for your patches. Your commit log should mention
why are you doing certain changes. Above commit log
doesn't give reviewer/maintainer an idea about what are
you fixing and why that change is
Reported by checkpatch.pl
Signed-off-by: Elena Afanasova
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 118 +++---
1 file changed, 81 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
b/drivers/staging/rtl8188eu/core/rtw_xmit.c
index
This patch fix long lines found by checkpatch.
Signed-off-by: Fan Fei
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 74
1 file changed, 51 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c
b/drivers/staging/rtl8188eu/core/rtw_cmd.c
Commit 515ce733e86e ("staging:r8188eu: Use lib80211 to encrypt (CCMP) tx
frames")
was reverted because it caused scheduling while atomic bugs and hard
freezes. Experimentation showed that there were no freezes and no BUG
messages logged when lib80211_get_crypto_ops() was called directly
rather
Add missing and remove unnecessary blank lines to clear the following
checkpatch issues.
WARNING: Missing a blank line after declarations
CHECK: Please use a blank line after function/struct/union/enum declarations
CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Please don't
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
te:
> > > > > From 4c8c8f3ff7f4d711daea4ac3bb987fcecc7ef1ed Mon Sep 17 00:00:00 2001
> > > > From: Sohom
> > > > Date: Sat, 12 Sep 2020 18:04:56 +0530
> > > > Subject: [RESEND PATCH] staging: rtl8188eu: Fix else after return
> > > > WARNING
> > > > (ch
; From: Sohom
> > > Date: Sat, 12 Sep 2020 18:04:56 +0530
> > > Subject: [RESEND PATCH] staging: rtl8188eu: Fix else after return WARNING
> > > (checkpatch)
> > >
> > > Fixed:
> > > WARNING: else is not generally useful after a
Remove extra indentations to follow kernel coding style and clear
checkpatch warnings.
WARNING: suspect code indent for conditional statements
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 6 +--
.../staging/rtl8188eu/core/rtw_wlan_util.c| 48
On Mon, 2020-09-14 at 17:57 +0300, Dan Carpenter wrote:
> On Sun, Sep 13, 2020 at 12:19:50PM +0530, Sohom Datta wrote:
> > > From 4c8c8f3ff7f4d711daea4ac3bb987fcecc7ef1ed Mon Sep 17 00:00:00 2001
> > From: Sohom
> > Date: Sat, 12 Sep 2020 18:04:56 +0530
> > S
On Sun, Sep 13, 2020 at 12:19:50PM +0530, Sohom Datta wrote:
> >From 4c8c8f3ff7f4d711daea4ac3bb987fcecc7ef1ed Mon Sep 17 00:00:00 2001
> From: Sohom
> Date: Sat, 12 Sep 2020 18:04:56 +0530
> Subject: [RESEND PATCH] staging: rtl8188eu: Fix else after return WARNING
> (chec
Fixed:
WARNING: else is not generally useful after a break or return
1636: FILE: ./rtw_recv.c:1636:
+ return false;
+ else
Separated the return statement into a separate block since
it doesn't seem to depend on the SN_LESS explicity being false.
Signed-off-by: Sohom
---
>From 4c8c8f3ff7f4d711daea4ac3bb987fcecc7ef1ed Mon Sep 17 00:00:00 2001
From: Sohom
Date: Sat, 12 Sep 2020 18:04:56 +0530
Subject: [RESEND PATCH] staging: rtl8188eu: Fix else after return WARNING
(checkpatch)
Fixed:
WARNING: else is not generally useful after a break or return
1636: F
On Sun, Sep 13, 2020 at 12:19:50PM +0530, Sohom Datta wrote:
> >From 4c8c8f3ff7f4d711daea4ac3bb987fcecc7ef1ed Mon Sep 17 00:00:00 2001
> From: Sohom
> Date: Sat, 12 Sep 2020 18:04:56 +0530
> Subject: [RESEND PATCH] staging: rtl8188eu: Fix else after return WARNING
>
Clean up unnecessary whitespace in wpa_set_encryption() by removing
extra spaces and replacing tabs with spaces. Clears a checkpatch error.
ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 12
Use __func__ instead of hardcoded function names to clear
checkpatch warnings.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/os_dep/ioctl_linux.c| 80 +--
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 36 -
drivers/staging/rtl8188eu/os_dep/usb_intf.c |
> I review things in the order that they appear in my inbox so I hadn't
> seen Greg and Larry's comments. You've now stumbled into an area of
> politics where you have conflicting reviews... :P Fortunately, we're
> all of us reasonable people.
>
> I think your patch is correct in that it is
>
> Yes, in this routine, it would be possible for authmode to not be set;
> however,
> later code only compares it to either _WPA_IE_ID_ or _WPA2_IE_ID_. It is
> never
> used in a way that an unset value could make the program flow be different by
> arbitrarily setting the value to zero.
I review things in the order that they appear in my inbox so I hadn't
seen Greg and Larry's comments. You've now stumbled into an area of
politics where you have conflicting reviews... :P Fortunately, we're
all of us reasonable people.
I think your patch is correct in that it is what the
On Fri, Jul 24, 2020 at 08:29:55PM +0800, Dinghao Liu wrote:
> The variable authmode will keep uninitialized if neither if
> statements used to initialize this variable are not triggered.
> Then authmode may contain a garbage value and influence the
> execution flow of this function.
>
> Fix this
On 7/24/20 8:28 AM, Dinghao Liu wrote:
The variable authmode will keep uninitialized if neither if
statements used to initialize this variable are not triggered.
Besides Greg's comment, you need to re-parse this sentence. I realize that
English is probably not your first language, but this
On Fri, Jul 24, 2020 at 08:29:55PM +0800, Dinghao Liu wrote:
> The variable authmode will keep uninitialized if neither if
> statements used to initialize this variable are not triggered.
> Then authmode may contain a garbage value and influence the
> execution flow of this function.
>
> Fix this
The variable authmode will keep uninitialized if neither if
statements used to initialize this variable are not triggered.
Then authmode may contain a garbage value and influence the
execution flow of this function.
Fix this by initializing it to zero.
Signed-off-by: Dinghao Liu
---
Modify equality comparison involving constants by shifting the constant
operand to the right side of the comparison as suggested by
scripts/checkpatch.pl
Signed-off-by: Priti Chattopadhyay
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 4 ++--
1 file changed, 2 insertions(+), 2
Only a single tab space is required after the if statement.
Fix this issue by running scripts/checkpatch.pl on the file.
Signed-off-by: Mrinal Pandey
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On Sun, Jul 19, 2020 at 11:24:37AM +0200, Greg KH wrote:
> On Sat, Jul 18, 2020 at 04:01:25PM +0530, Anoop1507 wrote:
> > From: Anoop S
> >
> > This fixes the following checkpatch.pl warning
> > WARNING: Prefer using '"%s...", __func__' to using 'rtw_tkip_decrypt', this
> > function's name, in
Add spaces around operators in the header files to improve readability
and clear checkpatch issues.
Signed-off-by: Michael Straube
---
.../rtl8188eu/include/hal8188e_rate_adaptive.h | 4 ++--
drivers/staging/rtl8188eu/include/odm_types.h| 6 +++---
On Sat, Jul 18, 2020 at 04:01:25PM +0530, Anoop1507 wrote:
> From: Anoop S
>
> This fixes the following checkpatch.pl warning
> WARNING: Prefer using '"%s...", __func__' to using 'rtw_tkip_decrypt', this
> function's name, in a string.
>
> Signed-off-by: Anoop S
It would be great to have
From: Anoop S
This fixes the following checkpatch.pl warning
WARNING: Prefer using '"%s...", __func__' to using 'rtw_tkip_decrypt', this
function's name, in a string.
Signed-off-by: Anoop S
---
drivers/staging/rtl8188eu/core/rtw_security.c | 2 +-
1 file changed, 1 insertion(+), 1
Clear tabstop style issues reported by checkpatch.
WARNING: Statements should start on a tabstop
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c| 2 +-
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 2 +-
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
On Wed, Jul 15, 2020 at 02:55:59AM +0530, Arpitha wrote:
> Fixing WARNING: Prefer using '"%s...", __func__' to using 'function_name'
> in a string in rtw_ioctl_set.c
>
> Signed-off-by: Arpitha <98.a...@gmail.com>
We need a "full" name for kernel patches, what you use to sign
documents.
Same for
Fixing WARNING: Prefer using '"%s...", __func__' to using 'function_name'
in a string in rtw_ioctl_set.c
Signed-off-by: Arpitha <98.a...@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.
[1]
On Thu, Jul 02, 2020 at 07:15:56AM -0400, B K Karthik wrote:
> added blank spaces to improve code readability. (coding style issue)
>
> Signed-off-by: B K Karthik
> ---
> drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>
added blank spaces to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index
add blank spaces for improved code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_cmd.h
b/drivers/staging/rtl8188eu/include/rtw_cmd.h
index
added blank spaces to improve code readability. (coding style issue)
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
On Thu, Jul 02, 2020 at 12:50:04AM -0400, B K Karthik wrote:
> add blank spaces for improved code readability.
>
> Signed-off-by: B K Karthik
> ---
> drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
added blank spaces to improve code readability. (coding style issue)
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
added blank spaces to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index
On Thu, Jul 02, 2020 at 12:48:42AM -0400, B K Karthik wrote:
> added blank spaces to improve code readability.
>
> Signed-off-by: B K Karthik
> ---
> drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git
add blank spaces for improved code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_cmd.h
b/drivers/staging/rtl8188eu/include/rtw_cmd.h
index
added blank spaces to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
Many defined constants in wifi.h are unused and/or available from
, some with slightly different names. Use the
common ones, rename where necessary and remove unused.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 12 ++---
Remove unused parameter 'padapter' from rtw_os_xmit_resource_alloc().
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 6 +++---
drivers/staging/rtl8188eu/include/xmit_osdep.h | 3 +--
drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 3 +--
3 files changed, 5
On 2020-06-29 10:09, B K Karthik wrote:
removed multiple blank lines to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/ieee80211.h | 9 -
1 file changed, 9 deletions(-)
Hi, those lines are already removed in
commit
removed multiple blank lines to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/ieee80211.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/ieee80211.h
b/drivers/staging/rtl8188eu/include/ieee80211.h
index
added blank space and enclosed a complex valued macro within parentheses for
improved code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/odm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/odm.h
added blank space around arithmetic operators to improve readability
Signed-off-by: B K Karthik
---
.../rtl8188eu/include/hal8188e_rate_adaptive.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/hal8188e_rate_adaptive.h
On Sat, Jun 27, 2020 at 05:15:44PM +0200, Michael Straube wrote:
> @@ -145,21 +138,7 @@ struct bb_reg_def {
>*/
> };
>
> -/*--Define
> structure*/
> -
> -
> -/*Export global
>
Remove unnecessary comments in hal8188e_phy_cfg.h to improve
readability and clear multiple blank lines checkpatch issues.
CHECK: Please don't use multiple blank lines
Signed-off-by: Michael Straube
---
.../rtl8188eu/include/hal8188e_phy_cfg.h | 23 ---
1 file changed, 23
Remove blank lines in header files to clear checkpatch issues.
CHECK: Please don't use multiple blank lines
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/include/drv_types.h | 1 -
drivers/staging/rtl8188eu/include/hal_com.h | 1 -
Fix "Alignment should match open parenthesis" issues reported by
checkpatch.pl for all files under drivers/staging/rtl8188eu/core.
Line rtw_mlme_ext.c:373 is left overlength for readability.
Signed-off-by: Peilin Ye
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 +--
The driver replicates the definitions of rfc1042_header and
bridge_tunnel_header available from cfg80211.h. Use the common
ones from cfg80211.h.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 18 +-
1 file changed, 5 insertions(+), 13 deletions(-)
On Sun, 2020-05-24 at 10:27 +0200, Michael Straube wrote:
> Clean up some array declarations in phy_iq_calibrate() to reduce
> indentation and clear line over 80 characters checkpatch warnings.
Better still would be to mark these as static const
and also mark the functions that use them to take
Clean up some array declarations in phy_iq_calibrate() to reduce
indentation and clear line over 80 characters checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/phy.c | 33 +++--
1 file changed, 17 insertions(+), 16 deletions(-)
diff
On Sat, May 09, 2020 at 03:19:31PM +0800, Qiuhao Li wrote:
> According to Documentation/timers/timers-howto.rst, sleeping for small
> milliseconds should use usleep_range() instead of msleep().
>
> Signed-off-by: Qiuhao Li
> ---
> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 3 ++-
> 1 file
According to Documentation/timers/timers-howto.rst, sleeping for small
milliseconds should use usleep_range() instead of msleep().
Signed-off-by: Qiuhao Li
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Remove some obviously superflous comments.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm.c | 2 --
drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 2 --
drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 3 ---
3 files changed, 7 deletions(-)
diff --git
From: Carlos Guerrero Álvarez
Fixed a checkpatch.pl warning: the constant should be in the right side
of the comparison.
Signed-off-by: Carlos Guerrero Álvarez
---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Cleanup a line over 80 characters by removing an if test that is valid
only for 5 GHz. According to the TODO 5 GHz code should be removed.
- find and remove remaining code valid only for 5 GHz. Most of the obvious
ones have been removed, but things like channel > 14 still exist.
Signed-off-by:
On Sun, Mar 29, 2020 at 12:04:50PM +0200, Michael Straube wrote:
> Refactor while loop in Efuse_GetCurrentSize() to reduce indentation
> level and clear line over 80 characters checkpatch warnings.
>
> Signed-off-by: Michael Straube
Reviewed-by: Dan Carpenter
regards,
dan carpenter
Refactor while loop in Efuse_GetCurrentSize() to reduce indentation
level and clear line over 80 characters checkpatch warnings.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 33 +++---
1 file changed, 16 insertions(+), 17 deletions(-)
diff
Remove all remaining unnecessary parentheses reported by checkpatch.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_ieee80211.c| 4 +-
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 4 +-
drivers/staging/rtl8188eu/hal/odm.c | 52 +-
On 2020-03-26 01:08, Joe Perches wrote:
On Wed, 2020-03-25 at 22:59 +0100, Michael Straube wrote:
Cleanup line over 80 characters by removing unnecessary parentheses.
[]
diff --git a/drivers/staging/rtl8188eu/hal/odm.c
b/drivers/staging/rtl8188eu/hal/odm.c
[]
@@ -590,7 +590,7 @@ void
On Wed, 2020-03-25 at 22:59 +0100, Michael Straube wrote:
> Cleanup line over 80 characters by removing unnecessary parentheses.
[]
> diff --git a/drivers/staging/rtl8188eu/hal/odm.c
> b/drivers/staging/rtl8188eu/hal/odm.c
[]
> @@ -590,7 +590,7 @@ void odm_CCKPacketDetectionThresh(struct
Cleanup line over 80 characters by removing unnecessary parentheses.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/odm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm.c
b/drivers/staging/rtl8188eu/hal/odm.c
index
The ASUS USB-N10 Nano B1 has been reported as a new RTL8188EU device.
Add it to the device tables.
Signed-off-by: Larry Finger
Reported-by: kovi
Cc: Stable
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git
According to the TODO code valid only for 5 GHz should be removed.
- find and remove remaining code valid only for 5 GHz. Most of the obvious
ones have been removed, but things like channel > 14 still exist.
Remove if statement that checks for channel > 14 from rtw_ieee80211.c.
Signed-off-by:
This device was added to the stand-alone driver on github.
Add it to the staging driver as well.
Link: https://github.com/lwfinger/rtl8188eu/commit/2141f244c3e7
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On Wed, Mar 11, 2020 at 01:23:32AM +, Thiago Souza Ferreira wrote:
> Fix "Block comments use * on subsequent lines" warning of
> rtw_mlme_ext.c, found by checkpatch.pl script
>
> Signed-off-by: Thiago Souza Ferreira
> ---
> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 69
Fix checkpatch check: 'informations' may be misspelled - perhaps
'information'? in rtw_mlme_ext.c:1151.
Signed-off-by: Andre Pinto
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
Fix "Block comments use * on subsequent lines" warning of
rtw_mlme_ext.c, found by checkpatch.pl script
Signed-off-by: Thiago Souza Ferreira
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 69 ++-
1 file changed, 35 insertions(+), 34 deletions(-)
diff --git
ving the code
> > > > readability.
> > >
> > > Hello again Shreeya.
> > >
> >
> > I have some questions here...
> >
> > > The subject isn't really quite appropriate as you
> > > are not doing this space around operator ad
reeya.
> >
> I have some questions here...
>
> > The subject isn't really quite appropriate as you
> > are not doing this space around operator addition
> > for the entire subsystem.
> >
> > IMO, the subject should be:
> >
> > [PATCH] stag
ly quite appropriate as you
> are not doing this space around operator addition
> for the entire subsystem.
>
> IMO, the subject should be:
>
> [PATCH] staging: rtl8188eu: rtw_mlme: Add spaces around operators
>
> because you are only performing this change on this
> sin
re not doing this space around operator addition
> for the entire subsystem.
>
> IMO, the subject should be:
>
> [PATCH] staging: rtl8188eu: rtw_mlme: Add spaces around operators
>
> because you are only performing this change on this
> single file.
>
> If you w
1 - 100 of 578 matches
Mail list logo
