Re: [PATCH 3/3] staging: ks7010: add additional goto target

2017-03-07 Thread Dan Carpenter
On Wed, Mar 08, 2017 at 08:10:44AM +1100, Tobin C. Harding wrote: > On Tue, Mar 07, 2017 at 08:19:03PM +0300, Dan Carpenter wrote: > > On Tue, Mar 07, 2017 at 09:31:16AM +1100, Tobin C. Harding wrote: > > @@ -610,12 +610,7 @@ static void ks_sdio_interrupt(struct sdio_func *func) > > >

Re: [PATCH 3/3] staging: ks7010: add additional goto target

2017-03-07 Thread Tobin C. Harding
On Tue, Mar 07, 2017 at 08:19:03PM +0300, Dan Carpenter wrote: > On Tue, Mar 07, 2017 at 09:31:16AM +1100, Tobin C. Harding wrote: > @@ -610,12 +610,7 @@ static void ks_sdio_interrupt(struct sdio_func *func) > > if (atomic_read(&priv->psstatus.status) == > > PS_SNOOZE)

Re: [PATCH 3/3] staging: ks7010: add additional goto target

2017-03-07 Thread Dan Carpenter
On Tue, Mar 07, 2017 at 09:31:16AM +1100, Tobin C. Harding wrote: @@ -610,12 +610,7 @@ static void ks_sdio_interrupt(struct sdio_func *func) > if (atomic_read(&priv->psstatus.status) == > PS_SNOOZE) { > if (cnt_txqbody(priv)) { >

[PATCH 3/3] staging: ks7010: add additional goto target

2017-03-06 Thread Tobin C. Harding
Function contains multiple return sites. Function already contains a goto target that makes a function call before returning, the same function is called (with different arguments) before returning at an internal location. It would be clearer if both functions were called at the same place and labe