Re: [PATCH 6/9] VC04_SERVICES: Add compat ioctl handler for "await completion"

On Fri, 2017-01-20 at 14:00 +0300, Dan Carpenter wrote: > What Greg said.  No one is saying you have to clean this code up, > it's > just that you were adding new code.  I actually didn't really have a > big > issue with any of the patches except #2. > Cool. I guess I was just going through

Re: [PATCH 6/9] VC04_SERVICES: Add compat ioctl handler for "await completion"

What Greg said. No one is saying you have to clean this code up, it's just that you were adding new code. I actually didn't really have a big issue with any of the patches except #2. Also it's not that hard to clean the code. I was looking at this some more and you can use checkpatch.pl to fix

Re: [PATCH 6/9] VC04_SERVICES: Add compat ioctl handler for "await completion"

On Thu, Jan 19, 2017 at 07:12:37PM -0800, Michael Zoran wrote: > On Thu, 2017-01-19 at 15:56 +0300, Dan Carpenter wrote: > > Hm...  I had never used checkpatch.pl --fix until a few minutes ago. > > > > Basically sending a zillion patches is the only way to do anything in > > the linux-kernel. 

Re: [PATCH 6/9] VC04_SERVICES: Add compat ioctl handler for "await completion"

On Thu, 2017-01-19 at 15:56 +0300, Dan Carpenter wrote: > Hm...  I had never used checkpatch.pl --fix until a few minutes ago. > > Basically sending a zillion patches is the only way to do anything in > the linux-kernel.  You're not allowed to break the build, introduce > new compile warnings or

Re: [PATCH 6/9] VC04_SERVICES: Add compat ioctl handler for "await completion"

On Thu, Jan 19, 2017 at 05:12:11AM -0800, Michael Zoran wrote: > On Thu, 2017-01-19 at 13:22 +0100, Greg KH wrote: > > On Thu, Jan 19, 2017 at 04:07:15AM -0800, Michael Zoran wrote: > > > On Thu, 2017-01-19 at 14:34 +0300, Dan Carpenter wrote: > > > > On Thu, Jan 19, 2017 at 03:27:56AM -0800,

Re: [PATCH 6/9] VC04_SERVICES: Add compat ioctl handler for "await completion"

On Thu, 2017-01-19 at 13:22 +0100, Greg KH wrote: > On Thu, Jan 19, 2017 at 04:07:15AM -0800, Michael Zoran wrote: > > On Thu, 2017-01-19 at 14:34 +0300, Dan Carpenter wrote: > > > On Thu, Jan 19, 2017 at 03:27:56AM -0800, Michael Zoran wrote: > > > > On Thu, 2017-01-19 at 13:10 +0300, Dan

Re: [PATCH 6/9] VC04_SERVICES: Add compat ioctl handler for "await completion"

Hm... I had never used checkpatch.pl --fix until a few minutes ago. Basically sending a zillion patches is the only way to do anything in the linux-kernel. You're not allowed to break the build, introduce new compile warnings or bugs. We review tons of these patches and introducing bugs is

Re: [PATCH 6/9] VC04_SERVICES: Add compat ioctl handler for "await completion"

On Thu, Jan 19, 2017 at 04:07:15AM -0800, Michael Zoran wrote: > On Thu, 2017-01-19 at 14:34 +0300, Dan Carpenter wrote: > > On Thu, Jan 19, 2017 at 03:27:56AM -0800, Michael Zoran wrote: > > > On Thu, 2017-01-19 at 13:10 +0300, Dan Carpenter wrote: > > > All these silly white space issues in the

Re: [PATCH 6/9] VC04_SERVICES: Add compat ioctl handler for "await completion"

On Thu, 2017-01-19 at 14:34 +0300, Dan Carpenter wrote: > On Thu, Jan 19, 2017 at 03:27:56AM -0800, Michael Zoran wrote: > > On Thu, 2017-01-19 at 13:10 +0300, Dan Carpenter wrote: > > All these silly white space issues in the existing code could be > > fixed > > in 10 seconds with netbeans or

Re: [PATCH 6/9] VC04_SERVICES: Add compat ioctl handler for "await completion"

On Thu, Jan 19, 2017 at 03:27:56AM -0800, Michael Zoran wrote: > On Thu, 2017-01-19 at 13:10 +0300, Dan Carpenter wrote: > > One thing I will say is that I have scripts to review when people > > pull > > parts of an ioctl into a separate patch.  So when you do that, please > > don't make too many

Re: [PATCH 6/9] VC04_SERVICES: Add compat ioctl handler for "await completion"

On Thu, 2017-01-19 at 13:10 +0300, Dan Carpenter wrote: > One thing I will say is that I have scripts to review when people > pull > parts of an ioctl into a separate patch.  So when you do that, please > don't make too many white space changes if you can avoid it.  Those > confuse my scripts. >

Re: [PATCH 6/9] VC04_SERVICES: Add compat ioctl handler for "await completion"

This is hard to review because it's moving stuff around, and changing stuff and adding new features. I'll review the v2 patch. One thing I will say is that I have scripts to review when people pull parts of an ioctl into a separate patch. So when you do that, please don't make too many white

[PATCH 6/9] VC04_SERVICES: Add compat ioctl handler for "await completion"

Add compat handler for "await_completion" ioctl and move parts in common with the regular ioctl to vchiq_ioctl_await_completion Signed-off-by: Michael Zoran --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 398 ++--- 1 file changed, 267