Re: [PATCH v2] staging: most: Eliminate usage of symbolic permissions

2016-12-01 Thread Greg KH
On Thu, Dec 01, 2016 at 10:20:47AM +0100, Christian Gromm wrote: > On Thu, 1 Dec 2016 09:56:11 +0100 > Greg KH wrote: > > > On Thu, Dec 01, 2016 at 09:50:12AM +0100, Christian Gromm wrote: > > > On Thu, 1 Dec 2016 08:00:57 +0100 > > > Greg KH wrote: > > > > > > > On Wed, Nov 30, 2016 at 10:48:3

Re: [PATCH v2] staging: most: Eliminate usage of symbolic permissions

2016-12-01 Thread Christian Gromm
On Thu, 1 Dec 2016 09:56:11 +0100 Greg KH wrote: > On Thu, Dec 01, 2016 at 09:50:12AM +0100, Christian Gromm wrote: > > On Thu, 1 Dec 2016 08:00:57 +0100 > > Greg KH wrote: > > > > > On Wed, Nov 30, 2016 at 10:48:32PM -0700, Jason Litzinger wrote: > > > > > This is fine, but the fact that the m

Re: [PATCH v2] staging: most: Eliminate usage of symbolic permissions

2016-12-01 Thread Greg KH
On Thu, Dec 01, 2016 at 09:50:12AM +0100, Christian Gromm wrote: > On Thu, 1 Dec 2016 08:00:57 +0100 > Greg KH wrote: > > > On Wed, Nov 30, 2016 at 10:48:32PM -0700, Jason Litzinger wrote: > > > > This is fine, but the fact that the most subsystem feels like it has to > > > > have its own attribu

Re: [PATCH v2] staging: most: Eliminate usage of symbolic permissions

2016-12-01 Thread Christian Gromm
On Thu, 1 Dec 2016 08:00:57 +0100 Greg KH wrote: > On Wed, Nov 30, 2016 at 10:48:32PM -0700, Jason Litzinger wrote: > > > This is fine, but the fact that the most subsystem feels like it has to > > > have its own attribute type is the big problem with this file, that > > > should not be needed at

Re: [PATCH v2] staging: most: Eliminate usage of symbolic permissions

2016-11-30 Thread Greg KH
On Wed, Nov 30, 2016 at 10:48:32PM -0700, Jason Litzinger wrote: > > This is fine, but the fact that the most subsystem feels like it has to > > have its own attribute type is the big problem with this file, that > > should not be needed at all, and hopefully will be fixed up someday soon > > (i.e.

Re: [PATCH v2] staging: most: Eliminate usage of symbolic permissions

2016-11-30 Thread Jason Litzinger
> This is fine, but the fact that the most subsystem feels like it has to > have its own attribute type is the big problem with this file, that > should not be needed at all, and hopefully will be fixed up someday soon > (i.e. it's a requirement before it can get out of staging...) Ok, couple follo

Re: [PATCH v2] staging: most: Eliminate usage of symbolic permissions

2016-11-29 Thread Greg KH
On Fri, Nov 25, 2016 at 03:31:09PM -0700, Jason Litzinger wrote: > Fix checkpatch warnings regarding the use of symbolic permissions. > > Where the MOST_CHANNEL_ATTR macro is used, convert to octal > permissions over symbolic. > > Where _ATTR is used directly, replace with _ATTR_RW/_ATTR_WO and >

[PATCH v2] staging: most: Eliminate usage of symbolic permissions

2016-11-25 Thread Jason Litzinger
Fix checkpatch warnings regarding the use of symbolic permissions. Where the MOST_CHANNEL_ATTR macro is used, convert to octal permissions over symbolic. Where _ATTR is used directly, replace with _ATTR_RW/_ATTR_WO and update the show/store function names appropriately. Signed-off-by: Jason Litz