Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

2015-07-28 Thread Dan Carpenter
On Tue, Jul 28, 2015 at 10:49:52AM -0700, Joshua Clayton wrote: > > Changing the line breaks here is a tiny change on the same line and so > > it's fine. It fits into the one thing per patch rule. > > This is the style I prefer (getting rid of the explicit == true) > > - if ((r8712_is_cckrat

Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

2015-07-28 Thread Joshua Clayton
On Tuesday, July 28, 2015 06:56:38 PM Dan Carpenter wrote: > On Tue, Jul 28, 2015 at 08:50:04AM -0700, Joshua Clayton wrote: > > On Tuesday, July 28, 2015 05:37:16 PM Julia Lawall wrote: > > > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > > > b/drivers/staging/rtl8712/rtl871x_io

Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

2015-07-28 Thread Dan Carpenter
On Tue, Jul 28, 2015 at 08:50:04AM -0700, Joshua Clayton wrote: > On Tuesday, July 28, 2015 05:37:16 PM Julia Lawall wrote: > > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > > b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > > index 83d4bca..1ded691 100644 > > > --- a/drivers

Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

2015-07-28 Thread Julia Lawall
On Tue, 28 Jul 2015, Joshua Clayton wrote: > On Tuesday, July 28, 2015 05:37:16 PM Julia Lawall wrote: > > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > > b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > > index 83d4bca..1ded691 100644 > > > --- a/drivers/staging/rtl8712/r

Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

2015-07-28 Thread Joshua Clayton
On Tuesday, July 28, 2015 05:37:16 PM Julia Lawall wrote: > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > index 83d4bca..1ded691 100644 > > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > +++ b/drivers/staging/rtl8712/r

Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

2015-07-28 Thread Julia Lawall
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > index 83d4bca..1ded691 100644 > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > @@ -204,13 +204,13 @@ static inline char *tra