Re: [PATCH 2/7] staging: sm750fb: remove needless goto statements and lables

On Wed, Nov 04, 2015 at 12:50:30PM +0530, Sudip Mukherjee wrote: > On Sun, Nov 01, 2015 at 10:55:48AM +0200, Mike Rapoport wrote: > > In lynxfb_pci_probe return error immediately in cases no cleanup is > > required. > > > > Signed-off-by: Mike Rapoport > > --- > > NACK. > It should be: > > diff

RE: staging: lustre: provide separate buffers for libcfs_*2str()

Hello Dan, Thanks to report this. This issue was fixed in our code but not up streamed yet. The patch is available http://git.whamcloud.com/?p=fs%2Flustre-release.git;a=commit;h=d47f00d5a420b594b49564b2e00efca4602c3fb5 index 02764bd..c8ce66c 100644 --- a/lustre/obdclass/lprocfs_status.c +++ b/

[PATCH v2 3/7] staging: sm750fb: lynxfb_pci_probe: return actual errors

The lynxfb_pci_probe always returned -ENODEV in case of error. Modify it so that actual error code will be propogated to the caller. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH v2 2/7] staging: sm750fb: disable PCI device if lynxfb_pci_probe fails

In case of error during lynxfb_pci_probe, the function returned without calling pci_disable_device. Fix it by adding pci_disable_device on the error cleanup path. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/

[PATCH v2 5/7] staging: sm750fb: replace dual member of sm750_dev with fb_count

Will be used in futher refactoring of driver _probe and _remove methods. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 24 +--- drivers/staging/sm750fb/sm750.h | 2 +- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/staging/sm750

[PATCH v2 4/7] staging: sm750fb: lynxfb_pci_remove: remove unused variable

The par variable in lynxfb_pci_remove is only assigned a value and never used afterwards. Remove it. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 8f666

[PATCH v2 1/7] staging: sm750fb: remove unused modedb.h

The modedb.h defines unused set of videomodes and can be removed Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/modedb.h | 233 --- drivers/staging/sm750fb/sm750.c | 2 - 2 files changed, 235 deletions(-) delete mode 100644 drivers/staging/sm750f

[PATCH v2 0/7] staging: sm750fb: refactor lynxfb_pci_probe

Hi, These patches refactor the lynxfb_pci_probe along with some minor cleanups v2 changes: * add pci_disable_device on the cleanup path * return actual error rather than ENODEV Mike Rapoport (7): staging: sm750fb: remove unused modedb.h staging: sm750fb: disable PCI device if lynxfb_pci_prob

[PATCH v2 6/7] staging: sm750fb: introduce sm750fb_frambuffer_release

Use a function to unregister framebuffer info and release its resources. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm75

[PATCH v2 7/7] staging: sm750fb: introduce sm750fb_frambuffer_alloc

Split framebuffer allocation and registration into a dedicated function to simplify lynxfb_pci_probe Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 105 +++- 1 file changed, 49 insertions(+), 56 deletions(-) diff --git a/drivers/staging/sm

Re: [PATCH 01/11] staging: rtl8188eu: new temporary variable added to _rtl88e_fill_dummy

On Wed, Nov 04, 2015 at 10:11:19AM +0700, Ivan Safonov wrote: > It makes easier to understand the transition to a simpler function form. > You're really breaking your patches into to small pieces. This patch makes no sense on its own and introduces a static checker warning that n is assigned but

Re: [PATCH 02/11] staging: rtl8188eu: for loop instead of while loop used

On Wed, Nov 04, 2015 at 10:12:12AM +0700, Ivan Safonov wrote: > diff --git a/drivers/staging/rtl8188eu/hal/fw.c > b/drivers/staging/rtl8188eu/hal/fw.c > index d502606..6d6dd15 100644 > --- a/drivers/staging/rtl8188eu/hal/fw.c > +++ b/drivers/staging/rtl8188eu/hal/fw.c > @@ -89,10 +89,8 @@ static v

Re: [PATCH 03/11] staging: rtl8188eu: traversal order of the 'remain' variable values inverted

On Wed, Nov 04, 2015 at 10:12:51AM +0700, Ivan Safonov wrote: > The number of the loop passes has not changed. > > Signed-off-by: Ivan Safonov > --- > drivers/staging/rtl8188eu/hal/fw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8188eu/hal/fw.c

Re: [PATCH 11/11] staging: rtl8188eu: return value and argument types changed in _rtl88e_write_fw function

Really, it's probably easiest to just fold all these patches together as one patch. Re-writing a function is considered "one thing" under the "one thing per patch" rule. Re-writing a file is not considered one thing. Hopefully that's helpful in understanding where the line is. regards, dan carp

Re: [PATCH 11/11] staging: rtl8188eu: return value and argument types changed in _rtl88e_write_fw function

On 11/04/2015 06:29 PM, Dan Carpenter wrote: Really, it's probably easiest to just fold all these patches together as one patch. Re-writing a function is considered "one thing" under the "one thing per patch" rule. Re-writing a file is not considered one thing. Hopefully that's helpful in unde

Re: [PATCH v2 1/7] staging: lustre: remove white space in libcfs_hash.h

On Tue, Nov 03, 2015 at 07:46:07PM -0800, Greg Kroah-Hartman wrote: > On Mon, Nov 02, 2015 at 12:22:07PM -0500, James Simmons wrote: > > Cleanup all the unneeded white space in libcfs_hash.h. > > > > Signed-off-by: James Simmons > > --- > > .../lustre/include/linux/libcfs/libcfs_hash.h | 1

[PATCH v2 1/2] staging: rtl8188eu: for loop instead of while loop used

The range of elements to fill with zeros is determined by using a roundup macro Signed-off-by: Ivan Safonov --- Changes in v2: - Many small patches have been merged into one. drivers/staging/rtl8188eu/hal/fw.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a

[PATCH v2 2/2] staging: rtl8188eu: return value and argument types changed in _rtl88e_write_fw function

Ideally the function should not change the variables outside of its body. Signed-off-by: Ivan Safonov --- Changes in v2: no changes. drivers/staging/rtl8188eu/hal/fw.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/stagi

Re: [PATCH v2 1/2] staging: rtl8188eu: for loop instead of while loop used

These look good. Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/2] staging: rtl8188eu: rarely used macros replaced by their definitions

IS_* macros (except one) occur only once. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/hal_com.c | 14 +++--- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/hal_com.c

[PATCH 2/2] staging: rtl8188eu: unused macros removed

These macros does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 7 -- drivers/staging/rtl8188eu/include/HalVerDef.h | 33 -- 2 files changed, 40 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b

RE: [PATCH v2 1/7] staging: lustre: remove white space in libcfs_hash.h

>On Mon, Nov 02, 2015 at 12:22:07PM -0500, James Simmons wrote: >> Cleanup all the unneeded white space in libcfs_hash.h. >> >> Signed-off-by: James Simmons >> --- >> .../lustre/include/linux/libcfs/libcfs_hash.h | 135 >> ++-- >> 1 files changed, 70 insertions(+), 65 dele

RE: [lustre-devel] [PATCH v2 1/7] staging: lustre: remove white space in libcfs_hash.h

>On Tue, Nov 03, 2015 at 07:46:07PM -0800, Greg Kroah-Hartman wrote: >> On Mon, Nov 02, 2015 at 12:22:07PM -0500, James Simmons wrote: >> > Cleanup all the unneeded white space in libcfs_hash.h. >> > >> > Signed-off-by: James Simmons >> > --- >> > .../lustre/include/linux/libcfs/libcfs_hash.h

[PATCH 00/22] staging: comedi: adv_pci1710: tidy up driver

Now that the PCI-1720 support has been moved to a separate driver, remove some unnecessary boardinfo in this driver and tidy it up a bit. H Hartley Sweeten (22): staging: comedi: adv_pci1710: remove 'has_irq' boardinfo staging: comedi: adv_pci1710: remove 'has_counter' boardinfo staging: com

[PATCH 01/22] staging: comedi: adv_pci1710: remove 'has_irq' boardinfo

All the boards supported by this driver can use an interrupt. Remove the unnecessary boardinfo. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/dri

[PATCH 03/22] staging: comedi: adv_pci1710: don't "reset" board when detaching

Currently this driver calls pci1710_reset() during the (*detach) of the driver. That function does the following: 1) program the control register to stop any operations 2) clears the analog input FIFO 3) clears any pending interrupts 4) sets all the analog output channels to unipolar 5V ra

[PATCH 02/22] staging: comedi: adv_pci1710: remove 'has_counter' boardinfo

All the boards supported by this driver have a counter device. Remove the unnecessary boardinfo. This also fixes the pci1713 and pci1731 subdevice support. Those boards have a counter but did not have the 'has_counter' boardinfo. This prevented the subdevice from being allocated and initialized.

[PATCH 04/22] staging: comedi: adv_pci1710: refactor ai range programming

The gain codes used to program the analog output range are currently stored in const char arrays. The values look a bit "magic" and it's not clear how they associate with the comedi_lrange without looking through user manuals. Refactor the ai range programming to clarify the driver and remove the

[PATCH 07/22] staging: comedi: adv_pci1710: remove 'has_di_do' boardinfo

This member of the boardinfo isn't really necessary. All the boards except the pci1713 have 16 digital inputs and 16 digital outputs. There is already a 'is_pci1713' member in the boardinfo so that can be used to determine the subdevices for the digital inputs and outputs need to be allocated and

[PATCH 06/22] staging: comedi: adv_pci1710: remove 'n_aichan' boardinfo

This member of the boardinfo isn't really necessary. All the boards have analog inputs, the pci1713 has 32 channels the rest have 16 channels. There is already a 'is_pci1713' member in the boardinfo so that can be used to determine the number of channels for the analog input subdevice. Signed-off

[PATCH 08/22] staging: comedi: adv_pci1710: remove 'has_large_fifo' and 'has_diff_ai' boardinfo

The pci1711/31 boards are the only ones that have a smaller FIFO (1K vs 4K) and single-ended analog inputs (no differential). Replace the 'has_large_fifo' and 'has_diff_ai' members of the boardinfo with 'is_pci1711' and use that to determine how to initialize the analog input subdev_flags as well

[PATCH 05/22] staging: comedi: adv_pci1710: define the mux control register bits

For aesthetics, define some macros to set the bits in the mux control register. Also, rename the 'mux_ext' member of the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 14 +- 1 file changed, 9

[PATCH 10/22] staging: comedi: adv_pci1710: rename interrupt_service_pci1710()

Rename this function so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ad

[PATCH 09/22] staging: comedi: adv_pci1710: tidy up boardinfo definition

Remove the unnecessary comments and rename the 'rangelist_ai' member for aesthetics. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/driv

[PATCH 11/22] staging: comedi: adv_pci1710: rename pci171x_insn_counter_config()

Rename this function so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ad

[PATCH 12/22] staging: comedi: adv_pci1710: rename pci171x_d[io]_insn_bits

Rename these functions so they have namespace associated with the driver. For aesthetics, move the functions so they are not located in the middle of the analog input/output support functions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/dr

[PATCH 14/22] staging: comedi: adv_pci1710: support external analog output reference

The analog outputs can use an external reference to create the D/A output range. Add an entry to the comedi_lrange table for it and modify the (*insn_write) to support it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c |

[PATCH 15/22] staging: comedi: adv_pci1710: tidy up analog output subdev_flags

The SDF_GROUND and SDF_COMMON flags are not needed for the analog output subdevice. Just remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

[PATCH 13/22] staging: comedi: adv_pci1710: rename pci171x_ao_insn_write()

Rename this function so it has namespace associated with the driver. For aesthetics, move the function so it is located in the middle of the analog input support functions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c

[PATCH 17/22] staging: comedi: adv_pci1710: ai (*cancel) should not enable software trigger

The (*cancel) operation should do just that. Remove the setting of the SW bit which enables the software trigger. For aesthetics, rename the function so it has namespace associated with the driver and add a couple comments. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman

[PATCH 18/22] staging: comedi: adv_pci1710: tidy up pci1710_reset()

Change the return type to void, this function always succeeds and the caller does not check the return value anyway. Fix the initial programming of the control register. The SW bit enables the software trigger and should not be set here. Setting CNT0 selects the external clock source for counter 0

[PATCH 16/22] staging: comedi: adv_pci1710: post increment 'subdev' in (*auto_attach)

For aesthetics, post-increment the 'subdev' index when used to get a comedi_subdevice pointer instead of incrementing it after the subdevice is initialized. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 18 +---

[PATCH 20/22] staging: comedi: adv_pci1710: fix ai (*insn_read)

An (*insn_read) can only happen if the subdevice is in a non-busy state, i.e. an async command is not running. The board reset and subdevice (*cancel) will ensure that the control bits (devpriv->ctrl) are already cleared. The (*insn_read) only needs to enable the software trigger before reading sa

[PATCH 19/22] staging: comedi: adv_pci1710: fix counter 0 internal clock source

Counters 1 and 2 of the 8254 are cascaeded to create the 32-bit timer used for the analog input pacer trigger. The base clock to these counters is 10 MHz. Counter 0 is available to the user for general purpose use. This counter can use either an internal 1 MHz clock or an external clock. The (*ins

[PATCH 21/22] staging: comedi: adv_pci1710: rename pci171x_ai_{cmd, cmdtest}()

Rename these functions so they have namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/d

[PATCH 22/22] staging: comedi: adv_pci1710: rename pci171x_ai_*()

Rename these functions so they have namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers

Re: [PATCH 2/2] staging: rtl8188eu: unused macros removed

On Wed, Nov 04, 2015 at 09:09:11PM +0700, Ivan Safonov wrote: > These macros does not used. I can not understand this sentance. > > Signed-off-by: Ivan Safonov > --- > drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 7 -- > drivers/staging/rtl8188eu/include/HalVerDef.h | 33 > -

Re: [lustre-devel] [PATCH v2 1/7] staging: lustre: remove white space in libcfs_hash.h

On Wed, Nov 04, 2015 at 03:07:13PM +, Simmons, James A. wrote: > >On Tue, Nov 03, 2015 at 07:46:07PM -0800, Greg Kroah-Hartman wrote: > >> On Mon, Nov 02, 2015 at 12:22:07PM -0500, James Simmons wrote: > >> > Cleanup all the unneeded white space in libcfs_hash.h. > >> > > >> > Signed-off-by: J

Re: [patch] staging: lustre: potential underflow in libcfs_kkuc_group_add()

On Tue, Nov 03, 2015 at 05:49:00PM -0600, Frank Zago wrote: > Yes, but for consistency, all 4 functions should be changed. Thanks for the review. I will send a v2. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://drive

[PATCH 07/10] staging: lustre: Handle nodemask on UMP machines

For UMP and SMP machines the struct cfs_cpt_table are defined differently. In the case handled by this patch nodemask is defined as a integer for the UMP case and as a pointer for the SMP case. This will cause a problem for ost_setup which reads the nodemask directly. Instead we create a UMP versio

[PATCH 05/10] staging: lustre: Fix possible NULL pointer dereference in lprocfs_status.c

From: Dmitry Eremin The imp->imp_connection really could be NULL, we better check for it before dereferencing it in taht call to libcfs_nid2str_r. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6507 Reviewed-on: http://review.whamcloud.com/14808 Reviewed-by: Bo

[PATCH 01/10] staging: lustre: wrong parameter to cfs_hash_keycpy

From: Liang Zhen cfs_hash_rehash_key() passed wrong parameter to cfs_hash_keycpy, hnode should be the second parameter not the third one. Signed-off-by: Liang Zhen Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4362 Reviewed-on: http://review.whamcloud.com/8509 Reviewed-by: Bobi Jam Revie

[PATCH 06/10] staging: lustre: Update module author to OpenSFS

The modinfo data has gone stale for the author information. This patch changes all the MODULE_AUTHOR to OpenSFS. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6204 Reviewed-on: http://review.whamcloud.com/16132 Reviewed-by: Frank Zago Reviewed-by: Andreas Dilge

[PATCH 04/10] staging: lustre: fix buffer overflow of string buffer

From: Dmitry Eremin Buffer overflow of string buffer due to non null terminated string. Use strlcpy() when it's justifiable. Use sizeof(var) instead of constants. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-on: http://review.whamcloud.com/9389

[PATCH 02/10] staging: lustre: remove unnecessary EXPORT_SYMBOL in libcfs

From: frank zago A lot of symbols don't need to be exported at all because they are only used in the module they belong to. Signed-off-by: frank zago Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5829 Reviewed-on: http://review.whamcloud.com/13319 Reviewed-by: James Simmons Reviewed-by:

[PATCH 10/10] staging: lustre: fix 'error handling' issues for libcfs workitem.c

From: Sebastien Buisson Fix 'error handling' issues found by Coverity version 6.5.1: Unchecked return value (CHECKED_RETURN) Calling function without checking return value. Signed-off-by: Sebastien Buisson Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3427 Reviewed-on: http://review.whamc

[PATCH 09/10] staging: lustre: remove page_collection::pc_lock in libcfs

From: Liang Zhen page_collection::pc_lock is supposed to protect race between functions called by smp_call_function(), however we don't have this use-case for ages and page_collection only lives in stack of thread, so it is safe to remove it. Signed-off-by: Liang Zhen Intel-bug-id: https://jira

[PATCH 03/10] staging: lustre: remove libcfs_debug_set_level prototype from libcfs_private.h

From: frank zago The function libcfs_debug_set_level is used only internally so no reason to expose it in libcfs_private.h. This is broken out from LU-5829 patch http://review.whamcloud.com/13319. Signed-off-by: frank zago --- .../lustre/include/linux/libcfs/libcfs_private.h |2 -- 1 fil

[PATCH 08/10] staging: lustre: race condition for check/use cfs_fail_val

From: Fan Yong There are some race conditions when check/use cfs_fail_val. For example: when inject failure stub for LFSCK test as following: 764 if (OBD_FAIL_CHECK(OBD_FAIL_LFSCK_DELAY2) && 765 cfs_fail_val > 0) { 766 struct l_wait_info lwi; 767 768 lwi = LWI_TIMEOUT

RE: [patch] staging: lustre: potential underflow in libcfs_kkuc_group_add()

>On Tue, Nov 03, 2015 at 05:49:00PM -0600, Frank Zago wrote: >> Yes, but for consistency, all 4 functions should be changed. > >Thanks for the review. I will send a v2. Greg merged your original patch so it will be a new patch. ___ devel mailing list d

RE: staging: lustre: provide separate buffers for libcfs_*2str()

>Hello Dan, > >Thanks to report this. This issue was fixed in our code but not up streamed >yet. The patch is available >http://git.whamcloud.com/?p=fs%2Flustre->release.git;a=commit;h=d47f00d5a420b594b49564b2e00efca4602c3fb5 I just pushed a proper patch just a bit ago. ___

[PATCH] Staging: comedi: adv_pci_dio: fixed a comment style

Fixed a comment issue. Signed-off-by: Philippe Loctaux --- drivers/staging/comedi/drivers/adv_pci_dio.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/comedi/drivers/adv_pci_dio.c b/drivers/staging/comedi/drivers/adv_pci_dio.c

Re: [PATCH RESEND 11/12] staging: wilc1000: rename os_context to wilc

On Thu, Oct 29, 2015 at 12:18:51PM +0900, Glen Lee wrote: > This patch rename os_context to wilc because it is used as struct wilc and > move os_private from struct wilc_wlan_os_context_t to struct wilc_wlan_inp_t. > Finally, delete wilc_wlan_os_context_t. > > Signed-off-by: Glen Lee > --- > dri

Re: [PATCH RESEND 12/12] staging: wilc1000: add argument wilc and use it instead of g_linux_wlan

On Thu, Oct 29, 2015 at 12:18:52PM +0900, Glen Lee wrote: > This patch adds new argument wilc to linux_sdio_cmd53 and linux_sdio_cmd52 > , and use it instead of g_linux_wlan. Pass wilc to the functions as well. > The void type wilc will be changed with struct wilc when SDIO and SPI > modules are re

Re: [PATCH V2 02/17] staging: wilc1000: send_config_pkt: add argument struct net_device

On Fri, Oct 30, 2015 at 06:47:08PM +0900, Glen Lee wrote: > This patch adds new argument struct net_device and pass dev to the function > as well. > > Signed-off-by: Glen Lee > --- > drivers/staging/wilc1000/coreconfigurator.c | 3 +- > drivers/staging/wilc1000/coreconfigurator.h | 3 +- > d

Re: [PATCH V2 03/17] staging: wilc1000: wilc_wlan_cfg_get: add argument struct net_device

On Fri, Oct 30, 2015 at 06:47:09PM +0900, Glen Lee wrote: > Adds argument struct net_device and use netdev private data member wilc > instead of g_linux_wlan, pass dev to the functions as well. > > Signed-off-by: Glen Lee > --- > drivers/staging/wilc1000/coreconfigurator.c | 3 ++- > drivers/sta

Re: [PATCH V2 04/17] staging: wilc1000: wilc_wlan_cfg_set: add argument struct net_device

On Fri, Oct 30, 2015 at 06:47:10PM +0900, Glen Lee wrote: > This patch adds new argument net_device and use netdev private data member > wilc instead of g_linux_wlan, pass dev to the functions also. > > Signed-off-by: Glen Lee > --- > drivers/staging/wilc1000/coreconfigurator.c | 3 +- > driver

Re: [PATCH 01/38] staging: wilc1000: rename pu8IPAddr of fuction Handle_set_IPAddress

On Mon, Nov 02, 2015 at 05:50:44PM +0900, Glen Lee wrote: > From: Leo Kim > > This patch renames pu8IPAddr of fuction Handle_set_IPAddress to ip_addr > to avoid CamelCase naming convention. > > Signed-off-by: Leo Kim > Signed-off-by: Glen Lee > --- > drivers/staging/wilc1000/host_interface.c

Re: [PATCH 1/5] staging: wilc1000: change enum variable name with lower case

On Tue, Nov 03, 2015 at 04:20:58PM +0900, Glen Lee wrote: > This patch changes WID_TYPE with wid_type which is preferred style. > > Signed-off-by: Glen Lee > --- > drivers/staging/wilc1000/coreconfigurator.h | 2 +- > drivers/staging/wilc1000/wilc_wlan_if.h | 2 +- > 2 files changed, 2 inser

[PATCH v4] staging: rdma: amso1100: c2: Remove wrapper function

This patch removes the c2_print_macaddr() wrapper function which calls the pr_debug standard kernel function only. c2_print_macaddr() has been replaced by directly calling pr_debug(). Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Removed comment added in previous version Changes

Re: [PATCH] Staging: comedi: adv_pci_dio: fixed a comment style

On Wed, Nov 04, 2015 at 09:36:30PM +0100, Philippe Loctaux wrote: > Fixed a comment issue. What comment issue would that be? And please always use get_maintainer.pl to determine who to cc: patches to. thanks, greg k-h ___ devel mailing list de...@linu

[PATCH v2] staging: rtl8712: rtl871x_sta_mgt: Remove wrapper function

Remove wrapper function mfree_sta_priv_lock() that can be replaced by a direct call to mfree_all_stainfo(). Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Removed trailing whitespace drivers/staging/rtl8712/rtl871x_sta_mgt.c | 9 ++--- 1 file changed, 2 insertions(+), 7 dele

Re: [PATCH V2 01/12] staging: wilc1000: fix return type of host_int_del_beacon

On Fri, Oct 30, 2015 at 08:17:37AM +0900, Chaehyun Lim wrote: > This patch changes return type of host_int_del_beacon from s32 to int. > The result variable gets return value from wilc_mq_send that has return > type of int. It should be changed return type of this function as well > as data type of

Re: [PATCH 07/10] staging: lustre: Handle nodemask on UMP machines

Hi James, [auto build test WARNING on: staging/staging-next] [also build test WARNING on: next-20151104] [cannot apply to: v4.3] url: https://github.com/0day-ci/linux/commits/James-Simmons/staging-lustre-wrong-parameter-to-cfs_hash_keycpy/20151105-024407 config: i386-randconfig-b0-11050505

[staging:staging-testing 2491/2494] drivers/staging/wilc1000/wilc_wlan.c:1954:5: error: conflicting types for 'wilc_wlan_init'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: f0c94bc642d5ff9fbfd18edcf71b9db165e365d3 commit: 30135ce26df214c03c3a9bfe25bcd8f56020bc50 [2491/2494] staging: wilc1000: wilc_wlan_init: add argument struct net_device config: i386-allyesconfig (att

Re: [PATCH 07/10] staging: lustre: Handle nodemask on UMP machines

Hi James, [auto build test WARNING on: staging/staging-next] [also build test WARNING on: next-20151104] [cannot apply to: v4.3] url: https://github.com/0day-ci/linux/commits/James-Simmons/staging-lustre-wrong-parameter-to-cfs_hash_keycpy/20151105-024407 config: m68k-allmodconfig (attached

Re: [PATCH V2 04/17] staging: wilc1000: wilc_wlan_cfg_set: add argument struct net_device

On 2015년 11월 05일 05:46, Greg KH wrote: On Fri, Oct 30, 2015 at 06:47:10PM +0900, Glen Lee wrote: This patch adds new argument net_device and use netdev private data member wilc instead of g_linux_wlan, pass dev to the functions also. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/cor

[PATCH] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

From: Dean Luick Correctly set half-swing for integrated devices. A0 needs all fields set for CcePcieCtrl. B0 and later only need a few fields set. Reviewed-by: Stuart Summers Signed-off-by: Dean Luick Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/chip_registers.h | 11 + driv

Re: [PATCH V2 04/17] staging: wilc1000: wilc_wlan_cfg_set: add argument struct net_device

On Thu, Nov 05, 2015 at 10:39:59AM +0900, glen lee wrote: > >>+int wilc_wlan_cfg_set(struct net_device *dev, int start, u32 wid, u8 > >>*buffer, > >>+ u32 buffer_size, int commit, u32 drvHandler) > >> { > >>wilc_wlan_dev_t *p = &g_wlan; > >>u32 offset; > >>int ret_size

[PATCH 0/3] staging/rdma/hfi1: complete fixes for ECN detection

From: Ira Weiny The following 3 patches fix the ECN detection and add a module parameter to turn the prescan of the receive queue on and off. Arthur Kepner (2): staging/rdma/hfi1: don't cache "prescan head" staging/rdma/hfi1: optionally prescan rx queue for {B,F}ECNs - UC, RC Vennila Megava

[PATCH 3/3] staging/rdma/hfi1: Method to toggle "fast ECN" detection

From: Vennila Megavannan Add a module paramter to toggle prescan/Fast ECN Detection. In addition change the PRESCAN_RXQ Kconfig default to "yes". Reviewed-by: Arthur Kepner Reviewed-by: Mike Marciniszyn Signed-off-by: Vennila Megavannan Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/K

[PATCH 1/3] staging/rdma/hfi1: don't cache "prescan head"

From: Arthur Kepner When HFI1_CAP_DMA_RTAIL is toggled off the "prescan head" can get out of sync with the receive context's "head". This happens when, after prescan_rxq() newly arrived packets are then received, and processed by an RX interrupt handler. This is an unavoidable race, and to avoid

[PATCH 2/3] staging/rdma/hfi1: optionally prescan rx queue for {B, F}ECNs - UC, RC

From: Arthur Kepner To more rapidly respond to Explicit Congestion Notifications, prescan the receive queue, and process FECNs, and BECNs first. When a UC, or RC packet containing a FECN, or BECN is found, immediately react to the ECN (either by returning a CNP, or adjusting the injection rate).

Re: [PATCH RESEND 12/12] staging: wilc1000: add argument wilc and use it instead of g_linux_wlan

On 2015년 11월 05일 05:41, Greg KH wrote: On Thu, Oct 29, 2015 at 12:18:52PM +0900, Glen Lee wrote: This patch adds new argument wilc to linux_sdio_cmd53 and linux_sdio_cmd52 , and use it instead of g_linux_wlan. Pass wilc to the functions as well. The void type wilc will be changed with struct wi

Re: [PATCH RESEND 12/12] staging: wilc1000: add argument wilc and use it instead of g_linux_wlan

On Thu, Nov 05, 2015 at 11:22:47AM +0900, glen lee wrote: > > On 2015년 11월 05일 05:41, Greg KH wrote: > >On Thu, Oct 29, 2015 at 12:18:52PM +0900, Glen Lee wrote: > >>This patch adds new argument wilc to linux_sdio_cmd53 and linux_sdio_cmd52 > >>, and use it instead of g_linux_wlan. Pass wilc to th

[PATCH] staging/rdma/hfi1: Convert dd_dev_info() to hfi1_cdbg() in process startup

From: Sebastian Sanchez Replacing dd_dev_info() for hfi1_cdbg() to avoid generating syslog output for every context that is open by PSM. Reviewed-by: Mitko Haralanov Signed-off-by: Sebastian Sanchez Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/file_ops.c | 10 +- drivers

[PATCH] staging/rdma/hfi1: Clear the QSFP reset that is asserted on FLR

From: Easwar Hariharan The FLR on driver load asserts the QSFP reset pin and the driver does not deassert it after. This patch allows the external QSFP cable to exit reset by writing 1 to all the QSFP pins. Reviewed-by: Dean Luick Signed-off-by: Easwar Hariharan Signed-off-by: Jubin John ---

[PATCH] staging/rdma/hfi1: Enable WFR PCIe extended tags from the driver

From: Vennila Megavannan Some BIOS implementations turn off extended tags in DevCtl (a RW field) even though it was originally set and is advertised in DevCap Fix is to set it in the driver Reviewed-by: Dean Luick Reviewed-by: Mike Marciniszyn Reviewed-by: Ashutosh Dixit Signed-off-by: Vennil

[PATCH] staging/rdma/hfi1: Always download SBus firmware

From: Dean Luick B0 dual port parts require the SBus firmware to always be downloaded. Remove reset of the SBus Master spico. It is not necessary since the SBus firmware download already does that. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- driv

[PATCH] staging/rdma/hfi1: Disable thermal polling before sensor initialization

From: jareer.h.abdel-qader During driver load the thermal sensor needs to be reset prior to initialization of the sensor. This prevents a possible sensor lock up which can cause the wrong temperature value to be reported. This fix leads to remove disabling thermal polling from reset_asic_csrs() f

[PATCH RESEND 02/38] staging: wilc1000: rename firmwareIPAddress of fuction Handle_set_IPAddress

From: Leo Kim This patch renames firmwareIPAddress of fuction Handle_set_IPAddress to firmware_ip_addr to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH RESEND 03/38] staging: wilc1000: remove unused parameter of fuction Handle_get_IPAddress

From: Leo Kim This patch removes parameter pu8IPAddr of fuction Handle_get_IPAddress because it is not used in the function. Remove argument in the function call also. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 inse

[PATCH RESEND 07/38] staging: wilc1000: remove return type of Handle_wait_msg_q_empty

From: Leo Kim This patch changes return type of Handle_wait_msg_q_empty from s32 with void because return value is not used. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drive

[PATCH RESEND 05/38] staging: wilc1000: rename pstrHostIfGetMacAddress of fuction Handle_GetMacAddress

From: Leo Kim This patch renames pstrHostIfGetMacAddress of fuction Handle_GetMacAddress to get_mac_addr to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH RESEND 10/38] staging: wilc1000: linux_wlan: remove unused define CUSTOMER_PLATFORM

From: Leo Kim This patch remove unused define CUSTOMER_PLATFORM from linux_wlan.c. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/stag

[PATCH RESEND 04/38] staging: wilc1000: rename pstrHostIfSetMacAddress of fuction Handle_SetMacAddress

From: Leo Kim This patch renames pstrHostIfSetMacAddress of fuction Handle_SetMacAddress to set_mac_addr to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH RESEND 01/38] staging: wilc1000: rename pu8IPAddr of fuction Handle_set_IPAddress

From: Leo Kim This patch renames pu8IPAddr of fuction Handle_set_IPAddress to ip_addr to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --

[PATCH RESEND 06/38] staging: wilc1000: rename strHostIFCfgParamAttr of fuction Handle_CfgParam

From: Leo Kim This patch renames strHostIFCfgParamAttr of fuction Handle_CfgParam to cfg_param_attr to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 154 -- 1 file changed, 83 inser

[PATCH RESEND 08/38] staging: wilc1000: rename gau8MulticastMacAddrList variable

From: Leo Kim This patch renames gau8MulticastMacAddrList variable to multicast_mac_addr_list to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 5 +++-- drivers/staging/wilc1000/linux_wlan.c | 11 -

[PATCH RESEND 09/38] staging: wilc1000: replace explicit NULL comparisons with !

From: Leo Kim This patch replace explicit NULL comparison with ! or unmark operator to simplify code. Reported by checkpatch.pl for comparison to NULL could be written "!XXX" or "XXX". Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 45 +

  1   2   >