Re: [PATCH v3 2/2] staging: ion: create one device entry per heap

On Tue, Sep 26, 2017 at 07:09:14AM +0200, Daniel Vetter wrote: > On Mon, Sep 25, 2017 at 11:26:27AM -0700, Laura Abbott wrote: > > On 09/20/2017 01:45 AM, Benjamin Gaignard wrote: > > > Instead a getting one common device "/dev/ion" for > > > all the heaps this patch allow to create one device > >

Re: [PATCH 00/18] use ARRAY_SIZE macro

On Sun, Oct 01, 2017 at 08:52:20PM -0400, Jérémy Lefaure wrote: > On Mon, 2 Oct 2017 09:01:31 +1100 > "Tobin C. Harding" wrote: > > > > In order to reduce the size of the To: and Cc: lines, each patch of the > > > series is sent only to the maintainers and lists concerned by the patch. > > > This

[GIT PULL] Staging/IIO driver fixes for 4.14-rc4

The following changes since commit 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e: Linux 4.14-rc1 (2017-09-16 15:47:51 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.14-rc4 for you to fetch changes up to b2e312061c5

Re: [PATCH 0/6] Replace container_of with list_entry

On Sat, Sep 30, 2017 at 12:49:00PM +0530, Srishti Sharma wrote: > Replaces instances of container_of with list_entry to > access current list element. > > Srishti Sharma (6): > Staging: rtl8188eu: core: Use list_entry instead of container_of > Staging: rtl8188eu: core: Use list_entry instead

Re: [PATCH v2] staging: ccree: Convert to platform_{get,set}_drvdata()

On Thu, Sep 21, 2017 at 05:47:42PM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > Platform devices are expected to use wrapper functions, > platform_{get,set}_drvdata() with platform_device as argument, > for getting and setting the driver data. dev_{get,set}_drvdata() > are using &

Re: [PATCH] staging: fbtft: diferenciate between buffer and data types to fix sparse warning

On Wed, Sep 27, 2017 at 06:16:18PM +0100, Alfonso Lima Astor wrote: > sparse was complaning about an incorrect type cast: > drivers/staging/fbtft/fbtft-bus.c:60:1: warning: incorrect type in assignment > (different base types) > drivers/staging/fbtft/fbtft-bus.c:60:1:expected unsigned short [u

Re: [PATCH 2/2] Drivers: hv: vmbus: Expose per-channel interrupts and events counters

On Thu, Sep 21, 2017 at 08:58:50PM -0700, k...@exchange.microsoft.com wrote: > From: Stephen Hemminger > > When investigating performance, it is useful to be able to look at > the number of host and guest events per-channel. This is equivalent > to per-device interrupt statistics. > > Signed-off

Re: [BUG] vt6655: A possible sleep-in-atomic bug in vt6655_suspend

On Mon, Oct 09, 2017 at 09:10:28AM +0800, Jia-Ju Bai wrote: > According to device_main.c, the driver may sleep under a spinlock, > and the function call path is: > vt6655_suspend (acquire the spinlock) > pci_set_power_state > __pci_start_power_transition (drivers/pci/pci.c) > msleep -->

Re: [PATCH] pci: Fix a possible sleep-in-atomic bug in pci_set_power_state

On Mon, Oct 09, 2017 at 04:16:20PM +0800, Jia-Ju Bai wrote: > The drivers vt6655 and gma500 call pci_set_power_state under a spinlock, > which may sleep. > The function call paths are: > gma_power_begin (acquire the spinlock) (drivers/gpu/drm/gma500/power.c) > gma_resume_pci > pci_set_power_

Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

On Mon, Oct 09, 2017 at 01:21:23PM +0200, Martijn Coenen wrote: > On Fri, Sep 1, 2017 at 9:24 AM, Greg KH wrote: > > > > I've now applied patches 1, 2, 7, 9, 11, and 12 from this series to my > > tree, so feel free to rebase on it for the next round of these patches. &g

Re: [PATCH] ANDROID: binder: call poll_wait() unconditionally.

On Mon, Oct 09, 2017 at 02:26:56PM +0200, Martijn Coenen wrote: > Because we're not guaranteed that subsequent calls > to poll() will have a poll_table_struct parameter > with _qproc set. When _qproc is not set, poll_wait() > is a noop, and we won't be woken up correctly. > > Signed-off-by: Martij

Re: [PATCH] staging: rtsx: Add support for RTS5260

On Fri, Oct 13, 2017 at 04:50:35PM +0800, rui_f...@realsil.com.cn wrote: > From: rui_feng > > Add support for new chip rts5260. > In order to support rts5260，the definitions of some internal > registers and workflow have to be modified and are different from its > predecessors and OCP function is

Re: [PATCH] staging: rtsx: Add support for RTS5260

On Fri, Oct 13, 2017 at 10:54:22AM +0100, Lee Jones wrote: > On Fri, 13 Oct 2017, Greg KH wrote: > > > On Fri, Oct 13, 2017 at 04:50:35PM +0800, rui_f...@realsil.com.cn wrote: > > > From: rui_feng > > > > > > Add support for new chip rts5260. > > >

Re: [PATCH] staging: rtsx: Add support for RTS5260

On Fri, Oct 13, 2017 at 11:11:15AM +0100, Lee Jones wrote: > On Fri, 13 Oct 2017, Greg KH wrote: > > > On Fri, Oct 13, 2017 at 10:54:22AM +0100, Lee Jones wrote: > > > On Fri, 13 Oct 2017, Greg KH wrote: > > > > > > > On Fri, Oct 13, 2017 at 04:50

Re: [PATCH v2 01/26] staging: most: rearrange source files

On Fri, Oct 13, 2017 at 04:32:45PM +0200, Christian Gromm wrote: > This patch renames and moves the source files of the driver. Additionally, > it adapts the ABI, Makefiles and Kconfig files of the kernel's build > system. > > Signed-off-by: Christian Gromm > --- > v2: fix patch numeration > Wh

Re: 答复: [PATCH] staging: rtsx: Add support for RTS5260

On Mon, Oct 16, 2017 at 05:58:12AM +, 冯锐 wrote: > > On Fri, Oct 13, 2017 at 10:54:22AM +0100, Lee Jones wrote: > > > On Fri, 13 Oct 2017, Greg KH wrote: > > > > > > > On Fri, Oct 13, 2017 at 04:50:35PM +0800, rui_f...@realsil.com.cn wrote: > > >

Re: [PATCH v3 01/26] staging: most: rearrange source files

On Mon, Oct 16, 2017 at 10:46:08AM +0200, Christian Gromm wrote: > This patch renames and moves the source files of the driver. Additionally, > it adapts the ABI, Makefiles and Kconfig files of the kernel's build > system. Ok, this says _what_ the patch does, but we know that already by looking at

Re: [PATCH v3 02/26] staging: most: integrate driver in kernel's device model

On Mon, Oct 16, 2017 at 10:46:09AM +0200, Christian Gromm wrote: > The following patch adapts the driver to use the device model by: > > - adopting the MOST bus_type > - registering the core as a busdriver > - removing private kobject/kset usage > - removing private lists a

Re: [PATCH v3 17/26] staging: most: change designator for modules interfacing userspace

On Mon, Oct 16, 2017 at 10:46:24AM +0200, Christian Gromm wrote: > A module that is meant to make up the userspace experience of the driver > is no longer referred to as AIM. Instead it is denoted as a component of > the core. Further, it is understood as an integral part of the core, the > purpose

Re: [PATCH 00/26] staging: most: make use of kernel's device model and fix defects

On Mon, Oct 16, 2017 at 10:46:07AM +0200, Christian Gromm wrote: > This patch set integrates the MOST driver to the Linux kernel's device > model and provides bug fixes. Part of this process is moving and renaming > files to get a clearer directory layout. This needs to be reworked a bit better, s

Re: [PATCH v2] Staging: rtl8188eu: core: rtw_ap: Use list_for_each_entry_safe

On Thu, Oct 05, 2017 at 03:16:42PM +0530, Srishti Sharma wrote: > This is a cleanup patch and doesn't change runtime behavior. It > changes an open coded list traversal to use list_for_each_entry_safe. > Done using the following semantic patch by coccinelle. You have sent me two different patches

Re: [PATCH 1/2] staging: check for skb->len in gdm_lte_emulate_arp

On Wed, Oct 18, 2017 at 12:45:57AM +0300, Andrii Vladyka wrote: > check for skb->len in gdm_lte_emulate_arp > > Signed-off-by: Andrii Vladyka > --- > drivers/staging/gdm724x/gdm_lte.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/staging/gdm724x/gdm_lte.c > b/drivers/st

Re: [PATCH] staging: rtlwifi: remove duplicated macros in comments

On Thu, Oct 05, 2017 at 04:44:31PM -0700, Matthew Giassa wrote: > Removing a comment that duplicates definitions for pci_power_t > enumeration, and pointing to the relevant header file (current comment > is also missing PCI_POWER_ERROR). > > Signed-off-by: Matthew Giassa > --- > drivers/staging/

Re: [PATCH] Staging: rtlwifi: phydm: Use setup_timer

On Sat, Oct 07, 2017 at 10:56:25PM +0530, Srishti Sharma wrote: > Use setup_timer to combine initialization of a timer with the > initialization of the timer's function and data fields. Done > using the following semantic patch by coccinelle. > > @r@ > struct timer_list *l; > expression f, d; > @@

Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

On Wed, Oct 04, 2017 at 07:21:10PM +0200, Srinivasan Shanmugam wrote: > Removed all the unnecessary extern from rtl8723bs That's not what this patch does :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailm

Re: [PATCH] Staging: rtl8723bs: core: rtw_recv: fix parenthesis alignment warning in validate_recv_mgnt_frame()

On Thu, Oct 05, 2017 at 03:45:33PM +0200, Srinivasan Shanmugam wrote: > Fix parenthesis alignment warning in validate_recv_mgnt_frame() > > Signed-off-by: Srinivasan Shanmugam > --- > drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch does no

Re: [PATCH] staging: irda: resolve sparse errors due to implicit pci_power_t casts

On Thu, Oct 05, 2017 at 04:38:23PM -0700, Matthew Giassa wrote: > Explicitly casting pci_power_t types to resolve sparse warnings (shown > below). > > Also fixing a related logging bug where pci_power_t is cast to unsigned > (can be negative, i.e. PCI_POWER_ERROR). > > Original sparse report: >

Re: [PATCH v2] staging: wlan-ng: Remove unnecessary parentheses

On Mon, Oct 16, 2017 at 09:48:21PM -0400, Frank A. Cancio Bello wrote: > Remove unnecessary parentheses to comply with preferred coding style for > the linux kernel and avoid the following checkpatch's message: > 'CHECK: Unnecessary parentheses around' > > Credits to checkpatch. > > Signed-off-by

Re: [PATCH v3 02/26] staging: most: integrate driver in kernel's device model

On Wed, Oct 18, 2017 at 04:02:33PM +0200, Christian Gromm wrote: > On 18.10.2017 14:12, Greg KH wrote: > > On Mon, Oct 16, 2017 at 10:46:09AM +0200, Christian Gromm wrote: > > > The following patch adapts the driver to use the device model by: > > > > >

Re: [PATCH v2] staging: wlan-ng: Remove unnecessary parentheses

On Wed, Oct 18, 2017 at 10:46:09AM -0400, Frank A. Cancio Bello wrote: > On Wed, Oct 18, 2017 at 04:17:04PM +0200, Greg KH wrote: > > On Mon, Oct 16, 2017 at 09:48:21PM -0400, Frank A. Cancio Bello wrote: > > > Remove unnecessary parentheses to comply with preferred coding s

Re: Destaging most drivers

On Fri, Oct 20, 2017 at 12:15:56PM +0530, PrasannaKumar Muralidharan wrote: > Hi Christian, > > It has been a couple of years since most was added to the staging > tree. Except for review the TODO list does not mention things that are > required to destage it. Wondering why most is still in stagin

Re: [PATCH 1/3] Drivers: hv: vmbus: Expose per-channel interrupts and events counters

On Thu, Oct 05, 2017 at 05:35:04PM -0700, k...@exchange.microsoft.com wrote: > From: Stephen Hemminger > > When investigating performance, it is useful to be able to look at > the number of host and guest events per-channel. This is equivalent > to per-device interrupt statistics. > > Signed-off

Re: [PATCH 0/3] Drivers: hv: vmbus: Miscellaneous enhancements and fixes

On Thu, Oct 05, 2017 at 05:33:59PM -0700, k...@exchange.microsoft.com wrote: > From: "K. Y. Srinivasan" > > Miscellaneous enhancements and fixes. > > K. Y. Srinivasan (1): > Drivers: hv: vmbus: Make pannic reporting to be more useful > > Stephen Hemminger (2): > Drivers: hv: vmbus: Expose p

Re: [PATCH v3 02/26] staging: most: integrate driver in kernel's device model

On Fri, Oct 20, 2017 at 04:20:33PM +0200, Christian Gromm wrote: > On 18.10.2017 16:29, Greg KH wrote: > > On Wed, Oct 18, 2017 at 04:02:33PM +0200, Christian Gromm wrote: > > > On 18.10.2017 14:12, Greg KH wrote: > > > > On Mon, Oct 16, 2017 at 10:46:09A

Re: Destaging most drivers

On Fri, Oct 20, 2017 at 08:15:23PM +0530, PrasannaKumar Muralidharan wrote: > Hi Greg, > > On 20 October 2017 at 12:40, Greg KH wrote: > > On Fri, Oct 20, 2017 at 12:15:56PM +0530, PrasannaKumar Muralidharan wrote: > >> Hi Christian, > >> > >> It has b

[GIT PULL] Staging/IIO driver fixes for 4.14-rc6

The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f: Linux 4.14-rc4 (2017-10-08 20:53:29 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.14-rc6 for you to fetch changes up to c97d96b4e61

Re: [PATCH] Staging: rtlwifi: pci: fixed coding style issues

On Mon, Oct 23, 2017 at 04:44:24PM +0900, Woohyung Jeon wrote: > Fixed 2 coding style issues. > > There was two coding style issues and they were fixed. > c:2233 - unnecessary parenthesis was there, so removed. > c:652 - prohibited space was there, so removed. That's two different things, please

Re: [PATCH v3 02/26] staging: most: integrate driver in kernel's device model

On Tue, Oct 24, 2017 at 07:39:02PM +0200, Christian Gromm wrote: > On Fri, 20 Oct 2017 16:56:10 +0200 > Greg KH wrote: > > > On Fri, Oct 20, 2017 at 04:20:33PM +0200, Christian Gromm wrote: > > > On 18.10.2017 16:29, Greg KH wrote: > > > > On Wed, Oct 18,

Re: [PATCH 10/17] hyper-v: trace vmbus_open()

On Sun, Oct 29, 2017 at 12:21:09PM -0700, k...@exchange.microsoft.com wrote: > From: Vitaly Kuznetsov > > Add tracepoint to CHANNELMSG_OPENCHANNEL sender. > > Signed-off-by: Vitaly Kuznetsov > Signed-off-by: K. Y. Srinivasan > --- > drivers/hv/channel.c | 2 ++ > drivers/hv/hv_trace.h | 27

Re: [PATCH 10/17] hyper-v: trace vmbus_open()

On Mon, Oct 30, 2017 at 09:16:19AM +0100, Vitaly Kuznetsov wrote: > Greg KH writes: > > > On Sun, Oct 29, 2017 at 12:21:09PM -0700, k...@exchange.microsoft.com wrote: > >> From: Vitaly Kuznetsov > >> > >> Add tracepoint to CHANNELMSG_OPENCHANNEL s

Re: [PATCH 10/17] hyper-v: trace vmbus_open()

On Mon, Oct 30, 2017 at 11:07:01AM +0100, Vitaly Kuznetsov wrote: > Greg KH writes: > > > On Mon, Oct 30, 2017 at 09:16:19AM +0100, Vitaly Kuznetsov wrote: > >> Greg KH writes: > >> > >> > On Sun, Oct 29, 2017 at 12:21:09PM -0700, k...@exchange.microso

Re: [PATCH] hv: kvp: Avoid reading past allocated blocks from KVP file

On Mon, Oct 30, 2017 at 05:08:03PM -0700, Long Li wrote: > From: Paul Meyer > > While reading in more than one block (50) of KVP records, the allocation goes > per block, but the reads used the total number of allocated records (without > resetting the pointer/stream). This causes the records buf

Re: [PATCH 2/2] Drivers: hv: vmbus: Make pannic reporting to be more useful

On Sun, Oct 29, 2017 at 11:33:41AM -0700, k...@exchange.microsoft.com wrote: > From: "K. Y. Srinivasan" > > Hyper-V allows the guest to report panic and the guest can pass additional "pannic" or "panic"? :) I'll go fix it up by hand... {sigh} greg k-h

Re: [PATCH 10/17] hyper-v: trace vmbus_open()

On Mon, Oct 30, 2017 at 10:31:34AM -0400, Steven Rostedt wrote: > On Mon, 30 Oct 2017 11:32:20 +0100 > Greg KH wrote: > > > On Mon, Oct 30, 2017 at 11:07:01AM +0100, Vitaly Kuznetsov wrote: > > > Greg KH writes: > > > > > > > On Mon, Oct 30, 201

Re: [PATCH] hv: kvp: Avoid reading past allocated blocks from KVP file

On Tue, Oct 31, 2017 at 06:10:00PM +, Long Li wrote: > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, October 31, 2017 1:43 AM > > To: Long Li > > Cc: KY Srinivasan ; Haiyang Zhang > > ; Stephen Hemminger ; > > de...@linuxdriverproje

Re: [PATCH v2] hv: kvp: Avoid reading past allocated blocks from KVP file

On Tue, Oct 31, 2017 at 01:02:35PM -0700, Long Li wrote: > From: Paul Meyer > > While reading in more than one block (50) of KVP records, the allocation > goes per block, but the reads used the total number of allocated records > (without resetting the pointer/stream). This causes the records buf

Re: [PATCH v2] staging: rtlwifi: Fix line too long warning

On Tue, Oct 31, 2017 at 12:48:04AM -0400, Kien Ha wrote: > >From aa0f4ae8c325545b1fd794d6bbf8c4d2f64e2ec2 Mon Sep 17 00:00:00 2001 > From: Kien Ha > Date: Fri, 27 Oct 2017 14:07:55 -0400 > Subject: [PATCH v2] staging: rtlwifi: Fix line too long warning Why is all of this here in the "changelog bo

Re: [PATCH v2] hv: kvp: Avoid reading past allocated blocks from KVP file

On Wed, Nov 01, 2017 at 06:39:00PM +, Long Li wrote: > > From: Greg KH [mailto:g...@kroah.com] > > Sent: Tuesday, October 31, 2017 11:50 PM > > To: Long Li > > Cc: KY Srinivasan ; Haiyang Zhang > > ; Stephen Hemminger > > ; de...@linuxdriverproject.org; li

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Tue, Oct 31, 2017 at 07:11:53PM +, Mark Brown wrote: > On Tue, Oct 31, 2017 at 12:03:35PM -0700, Laura Abbott wrote: > > > I'm not a fan of the platform bus but I have mixed feelings about > > creating a dedicated bus type. I guess if we really need a bus > > type we can do it later? > > T

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

On Thu, Aug 31, 2017 at 06:04:30PM +0200, Greg KH wrote: > On Mon, Aug 28, 2017 at 01:54:05PM +0300, laurentiu.tu...@nxp.com wrote: > > From: Stuart Yoder > > > > Move the source files out of staging into their final locations: > > -include files in drivers/staging/f

Re: [PATCH 10/17] hyper-v: trace vmbus_open()

On Wed, Nov 01, 2017 at 05:43:08PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > > Behalf Of Steven Rostedt > > Sent: Tuesday, October 31, 2017 6:10 AM > > To: Greg

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Mon, Nov 06, 2017 at 03:42:04PM +0100, Benjamin Gaignard wrote: > 2017-11-02 12:10 GMT+01:00 Mark Brown : > > On Thu, Nov 02, 2017 at 11:44:07AM +0100, Greg KH wrote: > >> On Tue, Oct 31, 2017 at 07:11:53PM +, Mark Brown wrote: > > > >> > There was a disc

Re: [PATCH] staging: fsl-dpaa2: Fix multiple assignments should be avoided

On Tue, Nov 07, 2017 at 07:45:03PM -0500, Joshua Abraham wrote: > This patch fixes the checkpatch.pl warning: > "CHECK: multiple assignments should be avoided" > > Signed-off-by: Joshua Abraham > --- > drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 ++- > 1 file changed, 2 insertions(+), 1 d

Re: [PATCH net-next] decnet: move to staging

On Mon, Nov 13, 2017 at 07:30:09AM +0100, Jiri Pirko wrote: > Sun, Nov 12, 2017 at 09:02:14PM CET, step...@networkplumber.org wrote: > >Support for Decnet has been orphaned for many years. > >In the interest of reducing the potential bug surface and pre-holiday > >cleaning, move the decnet protocol

Re: [PATCH] ANDROID: binder: show high watermark of alloc->pages.

On Mon, Nov 13, 2017 at 10:06:56AM +0100, Martijn Coenen wrote: > Show the high watermark of the index into the alloc->pages > array, to facilitate sizing the buffer on a per-process > basis. > > Signed-off-by: Martijn Coenen > --- > drivers/android/binder_alloc.c | 4 > drivers/android/bin

Re: [PATCH] ANDROID: binder: fix transaction leak.

On Mon, Nov 13, 2017 at 10:06:08AM +0100, Martijn Coenen wrote: > If a call to put_user() fails, we failed to > properly free a transaction and send a failed > reply (if necessary). > > Signed-off-by: Martijn Coenen > --- > drivers/android/binder.c | 40 +++- >

Re: [PATCH net-next 0/2] retire IPX and Netware file system

On Sun, Nov 12, 2017 at 11:22:25AM -0800, Stephen Hemminger wrote: > Netware has bee dead for years. Time to deprecate IPX and the > Novell file system. > > Stephen Hemminger (2): > ipx: move Novell IPX protocol support into staging > ncpfs: move net/ncpfs to drivers/staging/ncpfs Can you als

[GIT PULL] Staging/IIO driver patches for 4.15-rc1

The following changes since commit bb176f67090ca54869fc1262c913aa69d2ede070: Linux 4.14-rc6 (2017-10-23 06:49:47 -0400) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.15-rc1 for you to fetch changes up to c14dd9d5f8b

Re: [PATCH net-next v2 0/2] retire IPX and NCPFS

On Wed, Nov 15, 2017 at 09:58:33AM +0900, David Miller wrote: > From: Stephen Hemminger > Date: Tue, 14 Nov 2017 08:37:13 -0800 > > > These are both old decrepit protocols that need to be sent > > to pasture. > > These need to go to gregkh and his staging/ tree, not net-next. I'll gladly take t

Re: [PATCH] binder: fix proc->files use-after-free

On Thu, Nov 16, 2017 at 09:48:13AM -0800, Todd Kjos wrote: > > @@ -875,22 +871,34 @@ static void binder_free_thread(struct binder_thread > > *thread); > > static void binder_free_proc(struct binder_proc *proc); > > static void binder_inc_node_tmpref_ilocked(struct binder_node *node); > > > > +st

Re: [PATCH v2] binder: fix proc->files use-after-free

On Thu, Nov 16, 2017 at 09:56:50AM -0800, Todd Kjos wrote: > proc->files cleanup is initiated by binder_vma_close. Therefore > a reference on the binder_proc is not enough to prevent the > files_struct from being released while the binder_proc still has > a reference. This can lead to an attempt to

Re: [PATCH v2] binder: fix proc->files use-after-free

On Thu, Nov 16, 2017 at 12:37:02PM -0800, Todd Kjos wrote: > Sorry about that, do you want a v3 with correct annotations? Nah, this time is fine :) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listin

Re: [PATCH 2/2] drivers: visorbus: move driver out of staging

On Fri, Nov 17, 2017 at 12:27:39PM -0500, David Kershner wrote: > {drivers/staging/unisys/include => include/linux/visorbus}/visorbus.h | 0 > .../staging/unisys/include => include/linux/visorbus}/visorchannel.h | 0 Do we really need two different include/linux .h files for this bus subsystem?

Re: [PATCH 00/50] staging: most: rework driver architecture and fix defects

On Wed, Nov 22, 2017 at 06:30:42PM +0530, PrasannaKumar Muralidharan wrote: > Hi Christian, > > On 21 November 2017 at 19:34, Christian Gromm > wrote: > > This patch set fixes bugs and integrates the driver to the kernel's device > > model by revising its architecture. Part of this change is rear

Re: [PATCH 08/50] staging: most: video: rename module

On Tue, Nov 21, 2017 at 03:04:42PM +0100, Christian Gromm wrote: > This patch renames the folder of the video module. It is needed > to clean up the directory layout of the driver. > > Signed-off-by: Christian Gromm I've applied the first 8 of these patches, but I don't think they do what you wa

Re: [PATCH 20/50] staging: most: core: remove struct device

On Wed, Nov 22, 2017 at 06:31:19PM +0530, PrasannaKumar Muralidharan wrote: > Hi Christian, > > On 21 November 2017 at 19:34, Christian Gromm > wrote: > > This patch takes out the struct device of struct most_aim, because it is > > not needed. > > Patch 9 adds struct device to struct most_aim an

Re: [PATCH 42/50] staging: most: core: fix data type

On Tue, Nov 21, 2017 at 03:05:16PM +0100, Christian Gromm wrote: > This patch fixes the type used to manage the channels of an > registered MOST interface. > > Signed-off-by: Christian Gromm > --- > drivers/staging/most/core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --g

Re: [PATCH 09/50] staging: most: remove proprietary kobjects

On Tue, Nov 21, 2017 at 03:04:43PM +0100, Christian Gromm wrote: > This patch removes the proprietary kobjects used by the driver modules and > replaces them with device structs. The patch is needed to have the driver > being integrated into the kernel's device model. > > Signed-off-by: Christian

Re: [PATCH 20/50] staging: most: core: remove struct device

On Fri, Nov 24, 2017 at 04:10:40PM +0100, Greg KH wrote: > On Wed, Nov 22, 2017 at 06:31:19PM +0530, PrasannaKumar Muralidharan wrote: > > Hi Christian, > > > > On 21 November 2017 at 19:34, Christian Gromm > > wrote: > > > This patch takes out the struct devi

Re: [PATCH] Staging: comedi: adl_pci9118.c : fixed code style issue

On Sat, Nov 18, 2017 at 06:46:38PM +0100, Fabian Baumanis wrote: > Removed uneccessary parantheses which were sorrounding two > if-statements. > > Signed-off-by: Fabian Baumanis > --- >  drivers/staging/comedi/drivers/adl_pci9118.c | 3 +-- >  1 file changed, 1 insertion(+), 2 deletions(-) > > di

Re: [PATCH 00/50] staging: most: rework driver architecture and fix defects

On Tue, Nov 21, 2017 at 03:04:34PM +0100, Christian Gromm wrote: > This patch set fixes bugs and integrates the driver to the kernel's device > model by revising its architecture. Part of this change is rearranging the > directory layout, renaming of files and folders and thereby creating a > clean

Re: [PATCH] staging: fsl-mc: fix uninitialized variable use

On Mon, Nov 27, 2017 at 11:01:34AM +0200, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > Fix this warning triggering on a powerpc build: > warning: 'error' may be used uninitialized in this function > [-Wmaybe-uninitialized] > > Signed-off-by: Laurentiu Tudor > --- You forgot a re

Re: [PATCH] staging: fsl-mc: fix uninitialized variable use

On Mon, Nov 27, 2017 at 09:31:21AM +, Laurentiu Tudor wrote: > > > On 11/27/2017 11:08 AM, Greg KH wrote: > > On Mon, Nov 27, 2017 at 11:01:34AM +0200, laurentiu.tu...@nxp.com wrote: > >> From: Laurentiu Tudor > >> > >> Fix this warning triggerin

Re: [PATCH 2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage.

On Mon, Nov 27, 2017 at 11:30:53AM +, Jeremy Sowden wrote: > Signed-off-by: Jeremy Sowden > --- > .../isp/kernels/eed1_8/ia_css_eed1_8.host.c| 24 > +++--- > 1 file changed, 12 insertions(+), 12 deletions(-) I can never take patches without any changelog text, and so

Re: [PATCH 00/50] staging: most: rework driver architecture and fix defects

On Mon, Nov 27, 2017 at 02:38:34PM +0100, Christian Gromm wrote: > On 24.11.2017 16:31, Greg KH wrote: > > On Tue, Nov 21, 2017 at 03:04:34PM +0100, Christian Gromm wrote: > > > This patch set fixes bugs and integrates the driver to the kernel's device > > > mo

Re: [PATCH 1/2] staging: sm750fb: Fix coding style in ddk750_sii164.h

On Mon, Nov 27, 2017 at 09:37:27AM -0500, Jeremy Lacomis wrote: > On Mon, Nov 27, 2017 at 11:45:00AM +0100, Geert Uytterhoeven wrote: > > On Mon, Nov 27, 2017 at 10:46 AM, Dan Carpenter > > wrote: > > > On Sat, Nov 25, 2017 at 01:26:35PM -0500, Jeremy Lacomis wrote: > > >> This patch to ddk750_sii

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

On Mon, Nov 27, 2017 at 03:32:28PM +, Laurentiu Tudor wrote: > > > On 11/03/2017 05:17 PM, Greg KH wrote: > > On Thu, Aug 31, 2017 at 06:04:30PM +0200, Greg KH wrote: > >> On Mon, Aug 28, 2017 at 01:54:05PM +0300, laurentiu.tu...@nxp.com wrote: > >>> From

Re: [PATCH] staging: pi433: pi433_if.c: fix if/else if and brace coding style issues

On Tue, Nov 14, 2017 at 12:03:51PM -0800, Chase Metzger wrote: > Fix if/else if and braces in function DIO0_irq_handler to comply with > the kernel coding style. > > Signed-off-by: Chase Metzger > --- > drivers/staging/pi433/pi433_if.c | 11 +++ > 1 file changed, 3 insertions(+), 8 delet

Re: [PATCH] staging: irda: annotate irlan_seq_start() and irlan_seq_stop() for sparse

On Tue, Nov 28, 2017 at 02:45:25PM +0200, Andrii Vladyka wrote: > Annotate rcu_read_lock in irlan_seq_start() and rcu_read_unlock in > irlan_seq_stop() for sparse > > Signed-off-by: Andrii Vladyka > Something went really wrong here with your email addr

Re: [PATCH 1/6] staging: pi433: pi433_if.c: fix opening curly brace coding style issues

On Wed, Nov 15, 2017 at 04:35:48PM -0800, Chase Metzger wrote: > Put opening curly braces for if/else/else if statements and for/while loops > on the same line as the statements or loops to comply with the kernel > coding style. > > Signed-off-by: Chase Metzger > --- > drivers/staging/pi433/pi43

Re: [PATCH 4/6] staging: pi433: pi433_if.c: fix space prohibited coding style issues

On Wed, Nov 15, 2017 at 04:35:51PM -0800, Chase Metzger wrote: > Remove unnecessary spaces before and after parenthesis' to comply > with the kernel coding style. > > Signed-off-by: Chase Metzger > --- > drivers/staging/pi433/pi433_if.c | 34 +- > 1 file changed,

Re: [PATCH 0/6] staging: pi433: pi433_if.c: coding style fixes

On Wed, Nov 15, 2017 at 04:35:47PM -0800, Chase Metzger wrote: > Fixes some of the coding style violations to comply with the kernel > coding style. > > Chase Metzger (6): > staging: pi433: pi433_if.c: fix opening curly brace coding style > issues > staging: pi433: pi433_if.c: fix else if/

Re: [PATCH V2] staging: rtl8188eu: Fix incorrect response to SIOCGIWESSID

On Sat, Nov 25, 2017 at 01:32:38PM -0600, Larry Finger wrote: > When not associated with an AP, wifi device drivers should respond to the > SIOCGIWESSID ioctl with a zero-length string for the SSID, which is the > behavior expected by dhcpcd. > > Currently, this driver returns an error code (-1) f

Re: [PATCH] staging: rtl8188eu:

On Sat, Nov 25, 2017 at 11:59:51AM -0600, Larry Finger wrote: > When not associated with an AP, wifi device drivers should respond to the > SIOCGIWESSID ioctl with a zero-length string for the SSID, which is the > behavior expected by dhcpcd. > > Currently, this driver returns an error code (-1) f

Re: [PATCH] staging/media: lirc: style fix - replace hard-coded function names

On Sun, Nov 26, 2017 at 08:49:42PM +0100, Martin Homuth wrote: > This patch fixes the remaining coding style warnings in the lirc module. > > It fixes the following checkpatch.pl warning: > > WARNING: Prefer using '"%s...", __func__' to using 'read', this > function's name, in a string > >From f

Re: [PATCH v6 1/2] staging: ion: reorder include

On Mon, Nov 06, 2017 at 04:59:44PM +0100, Benjamin Gaignard wrote: > Put include in alphabetic order Why??? That should not matter at all. I'll take this, but really, ick ick ick ick ick. ___ devel mailing list de...@linuxdriverproject.org http://driv

Re: [PATCH 4/4] staging: most: Remove a attribute group from a kobject

On Sat, Nov 25, 2017 at 12:09:31PM +0530, Arvind Yadav wrote: > All attribute group created during dim2_sysfs_probe() should be removed > in dim2_sysfs_destroy(). > > Signed-off-by: Arvind Yadav > --- > drivers/staging/most/hdm-dim2/dim2_sysfs.c | 1 + This file is not in the tree anymore. _

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Mon, Nov 06, 2017 at 04:59:45PM +0100, Benjamin Gaignard wrote: > Instead a getting only one common device "/dev/ion" for > all the heaps this patch allow to create one device > entry ("/dev/ionX") per heap. > Getting an entry per heap could allow to set security rules > per heap and global ones

Re: [PATCH v6 1/2] staging: ion: reorder include

On Tue, Nov 28, 2017 at 02:34:00PM +0100, Benjamin Gaignard wrote: > 2017-11-28 14:20 GMT+01:00 Greg KH : > > On Mon, Nov 06, 2017 at 04:59:44PM +0100, Benjamin Gaignard wrote: > >> Put include in alphabetic order > > > > Why??? > > Mainly because the next p

Re: [PATCH] staging: lustre: Fix line over 80 characters

On Tue, Nov 28, 2017 at 05:13:55PM +0300, Dan Carpenter wrote: > On Mon, Nov 27, 2017 at 03:36:58PM +0200, Talat Batheesh wrote: > > This patch fix the line over 80 characters warning that was detected > > using checkpatch.pl script. > > > > Signed-off-by: Talat Batheesh > > --- > > drivers/stag

Re: [PATCH 1/2] Drivers: hv: vmbus: Remove x86-isms from arch independent drivers

On Tue, Nov 14, 2017 at 10:52:07AM -0700, k...@exchange.microsoft.com wrote: > From: Michael Kelley > > hv_is_hypercall_page_setup() is used to check if Hyper-V is > initialized, but a 'hypercall page' is an x86 implementation detail > that isn't necessarily present on other architectures. Rename

Re: [PATCH 2/2] vmbus: make hv_get_ringbuffer_availbytes local

On Tue, Nov 14, 2017 at 10:52:08AM -0700, k...@exchange.microsoft.com wrote: > From: Stephen Hemminger > > hv_get_ringbuffer_availbytes is only used by the debug info > routine so make it static. Also, add READ_ONCE() to avoid any > possible issues with potentially volatile index values. > > Sig

Re: [PATCH 1/2] vmbus: unregister device_obj->channels_kset

On Tue, Nov 14, 2017 at 06:53:32AM -0700, k...@exchange.microsoft.com wrote: > From: Dexuan Cui > > Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info") > > Without the patch, a device can't be thoroughly destroyed, because > vmbus_device_register() -> kset_create_and_add() still holds a re

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Tue, Nov 28, 2017 at 04:26:20PM +, Mark Brown wrote: > On Tue, Nov 28, 2017 at 02:32:17PM +0100, Greg KH wrote: > > > Where is the documentation for the new sysfs files and the new ioctl > > Didn't see any sysfs files in there? New struct devices were created and

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Tue, Nov 28, 2017 at 05:12:23PM +, Mark Brown wrote: > On Tue, Nov 28, 2017 at 06:08:22PM +0100, Greg KH wrote: > > On Tue, Nov 28, 2017 at 04:26:20PM +, Mark Brown wrote: > > > On Tue, Nov 28, 2017 at 02:32:17PM +0100, Greg KH wrote: > > > > > call yo

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On Tue, Nov 28, 2017 at 05:37:53PM +, Mark Brown wrote: > On Tue, Nov 28, 2017 at 06:28:38PM +0100, Greg KH wrote: > > On Tue, Nov 28, 2017 at 05:12:23PM +, Mark Brown wrote: > > > > I think it's reasonable to ask for userspace, I'm querying why it needs &

Re: [PATCH 2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage.

On Wed, Nov 29, 2017 at 11:08:17AM +0200, Sakari Ailus wrote: > Hi Greg, > > On Mon, Nov 27, 2017 at 01:21:25PM +0100, Greg KH wrote: > > On Mon, Nov 27, 2017 at 11:30:53AM +, Jeremy Sowden wrote: > > > Signed-off-by: Jeremy Sowden > > > --- > > > .

Re: [PATCH] staging: android: ion: Check for register_shrinker() failure.

On Wed, Nov 29, 2017 at 10:33:39PM +0900, Tetsuo Handa wrote: > register_shrinker() might return -ENOMEM error since Linux 3.12. > But since callers of ion_device_add_heap() are not ready to receive an > error and it is not simple enough to fix within this patch, this patch > just prints a warning

Re: [PATCH 2/3] staging: irda: Handle return value of platform_get_irq

On Thu, Nov 30, 2017 at 09:13:35PM +0530, Arvind Yadav wrote: > platform_get_irq() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/staging/irda/drivers/pxaficp_ir.c | 10 ++ > 1 file changed, 10 insertions(+) Did you read drivers/staging

Re: staging: pi433: Possible bug in rf69.c

On Thu, Nov 30, 2017 at 06:01:46PM +0100, Marcin Ciupak wrote: > On Sat, Nov 11, 2017 at 01:51:10PM +0200, Marcus Wolf wrote: > Hi Marcus, > > since 4.15-rc1 is out I would like to ask if you are going to provide > your changes anytime soon? > > I would like to send a few patches as well and do n

<    6   7   8   9   10   11   12   13   14   15   >