On Thu, 2015-02-05 at 20:35 +0300, Dan Carpenter wrote:
> On Thu, Feb 05, 2015 at 09:32:55AM -0800, Joe Perches wrote:
> > On Thu, 2015-02-05 at 09:31 -0800, Joe Perches wrote:
> > > On Thu, 2015-02-05 at 20:25 +0300, Dan Carpenter wrote:
> > > > Acked-by: Dan Carpe
On Thu, 2015-02-05 at 20:25 +0300, Dan Carpenter wrote:
> Acked-by: Dan Carpenter
Maybe I should add sparse too... ;)
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, 2015-02-05 at 12:06 -0800, Greg Kroah-Hartman wrote:
> On Thu, Feb 05, 2015 at 08:32:13PM +0100, Paul Bolle wrote:
> > On Thu, 2015-02-05 at 09:57 -0800, Greg Kroah-Hartman wrote:
> > > And _NEVER_ have automated scripts create patches and send them out. I
> > > only know of ONE person/bot
On Sun, 2015-02-08 at 01:49 -0800, Tolga Ceylan wrote:
> Lines over 80 were corrected
[]
> diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c
> b/drivers/staging/rtl8192u/r8190_rtl8256.c
[]
> @@ -37,43 +37,71 @@ void PHY_SetRF8256Bandwidth(struct net_device *dev,
> HT_CHANNEL_WIDTH Bandwidth)
On Mon, 2015-02-09 at 21:45 +0530, Mohammad Jamal wrote:
> This patch adds a static keyword to variable portal_rotor to
> suppress the sparse warning of static declaration
Do please compile the subsystem before sending patches.
> diff --git a/drivers/staging/lustre/lnet/lnet/lib-ptl.c
> b/driver
On Tue, 2015-02-10 at 13:13 +0300, Dan Carpenter wrote:
> > diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
[]
> > @@ -280,8 +280,9 @@ static void oz_free_urb_link(struct oz_urb_link *urbl)
> > */
> > static struct oz_endpoint *oz_ep_alloc(int buffer_size, gfp_t mem_
On Wed, 2015-02-11 at 11:33 +0300, Dan Carpenter wrote:
> On Tue, Feb 10, 2015 at 03:27:11PM +0100, Bas Peters wrote:
> > >> @@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct
> > >> adapter *adapt, u8 *powerlevel)
> > >> ptr++;
> > >> }
> > >>
On Wed, 2015-02-11 at 13:51 +0300, Dan Carpenter wrote:
> On Wed, Feb 11, 2015 at 01:40:37AM -0800, Joe Perches wrote:
> > On Wed, 2015-02-11 at 11:33 +0300, Dan Carpenter wrote:
> > > You can't fight checkpatch.pl.
> >
> > Sure you can, Ignore it whenever appr
On Wed, 2015-02-11 at 21:02 +0100, Richard Weinberger wrote:
> On Wed, Feb 11, 2015 at 7:36 PM, Dan Carpenter
> wrote:
> > On Wed, Feb 11, 2015 at 10:00:29AM -0800, Joe Perches wrote:
> >> I'm half tempted to submit some patch like this to
> >> make it d
On Wed, 2015-02-11 at 21:24 +0100, Pavel Machek wrote:
> On Wed 2015-02-11 12:20:25, Joe Perches wrote:
> > On Wed, 2015-02-11 at 21:02 +0100, Richard Weinberger wrote:
> > > On Wed, Feb 11, 2015 at 7:36 PM, Dan Carpenter
> > > wrote:
> > > > On Wed, Feb 11
On Thu, 2015-02-12 at 01:43 +0300, Dan Carpenter wrote:
> On Wed, Feb 11, 2015 at 12:43:03PM -0800, Joe Perches wrote:
> > Maybe some help/warning text like:
> >
> > --forceWithout --force, checkpatch will not scan files
> >
On Thu, 2015-02-12 at 21:58 -0800, Tolga Ceylan wrote:
> On Wed, Feb 11, 2015 at 2:36 AM, Dan Carpenter
> wrote:
> > That looks kind of uglier than before. Please run your patch throught
> > scripts/checkpatch.pl --strict.
[]
> Running with --strict helped, but now I'm also getting warnings for
The seq_printf return value will eventually be converted to void.
Convert the remaining uses by hand.
Signed-off-by: Joe Perches
---
drivers/staging/lustre/lustre/llite/lproc_llite.c | 34 +---
.../lustre/lustre/obdclass/lprocfs_status.c| 94 +++---
2 files changed
seq_printf should eventually be converted to a void function.
Remove the uses of seq_printf return values and use seq_has_overflowed()
instead.
Joe Perches (3):
staging: lustre: Convert return seq_printf(...) uses to seq_has_overflowed
staging: lustre: Convert uses of "int rc = seq_p
reformatting and typing post conversion
to remove the now unnecessary "int i;" declaration.
Signed-off-by: Joe Perches
---
drivers/staging/lustre/lustre/fid/lproc_fid.c | 23 +++---
drivers/staging/lustre/lustre/llite/lproc_llite.c | 5 +-
drivers/staging/lustre/lustre/mdc/lproc_mdc.c
,
...);
+ return seq_has_overflowed(seq);
With some additional reformatting and typing post conversion
Miscellanea:
o convert an rc++ use to a bool
o use seq_puts with fixed strings where appropriate
Signed-off-by: Joe Perches
---
drivers/staging/lustre/lustre/libcfs/hash.c| 11 +--
drivers
On Mon, 2015-02-16 at 11:24 -0800, Joe Perches wrote:
> seq_printf should eventually be converted to a void function.
>
> Remove the uses of seq_printf return values and use seq_has_overflowed()
> instead.
Please do not apply.
These need conversions not to "return seq_has_ove
On Thu, 2015-02-19 at 21:54 -0800, Tolga Ceylan wrote:
> Resolved space required after that ',' errors reported by checkpatch.
trivia:
> diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c
> b/drivers/staging/rtl8192u/r819xU_firmware.c
[]
> @@ -66,7 +66,7 @@ static bool fw_download_code(stru
On Fri, Feb 20, 2015 at 05:44:01PM +0900, Akira Hayakawa wrote:
> I will wait for ack from dm maintainers.
Are you still copying the contents of every bio to your own memory
buffer before writing it to disk?
- Joe
___
devel mailing list
payloads, rather than copying. It's only the last bit of io
in a burst that should be using this copying slow path.
- Joe
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
lementation would be.
>
> Is there some fancy function that is like memcpy but actually "move"
> the ownership?
When building up your log chunk bio copy the bio_vecs (not the data)
from the original bios. You can't complete the original bios u
On Fri, 2015-02-20 at 16:31 -0800, Tolga Ceylan wrote:
> On Fri, Feb 20, 2015 at 11:47 AM, Tolga Ceylan wrote:
> > On Thu, Feb 19, 2015 at 11:30 PM, Joe Perches wrote:
> >> Might as well remove the unnecessary cast too:
> >> memcpy(skb->cb, &de
tring output to seq_puts
Signed-off-by: Joe Perches
---
drivers/staging/lustre/lustre/llite/lproc_llite.c | 24 ---
.../lustre/lustre/obdclass/lprocfs_status.c| 82 +++---
2 files changed, 54 insertions(+), 52 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/l
The seq_printf return value, because it's frequently misused,
will eventually be converted to void.
See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to
seq_has_overflowed() and make public")
Signed-off-by: Joe Perches
---
drivers/staging/rtl8192e/rtllib_module.c
seq_printf(seq,
...);
...
- return i;
+ return 0;
With some additional reformatting and typing post conversion
to remove the now unnecessary "int i;" declaration.
Signed-off-by: Joe Perches
---
drivers/staging/lustre/lustre/fid/lproc_fid.c | 23 +++---
drivers/st
etter replaced with
not doing that. And "must check return value and Do Something(tm)" is too
strong habit for enough people to cause recurring trouble.
Joe Perches (27):
staging: lustre: Convert "return seq_printf(...)" uses
staging: lustre: Convert seq_ hash functions to retu
The seq_printf return value, because it's frequently misused,
will eventually be converted to void.
See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to
seq_has_overflowed() and make public")
Signed-off-by: Joe Perches
---
drivers/staging/i2o/i2o_proc.c | 18 ++
These functions don't need to return anything.
No caller uses the return value.
Miscellanea:
Integrate the individual strings to reduce object size ~100 bytes.
Signed-off-by: Joe Perches
---
drivers/staging/lustre/include/linux/libcfs/libcfs_hash.h | 4 ++--
drivers/staging/lustre/l
q_puts with fixed strings where appropriate
Signed-off-by: Joe Perches
---
drivers/staging/lustre/lustre/libcfs/hash.c| 11 +--
drivers/staging/lustre/lustre/llite/lproc_llite.c | 88 --
drivers/staging/lustre/lustre/lmv/lproc_lmv.c | 18 +++--
drivers/
On Sat, 2015-02-28 at 15:44 +0100, Matteo Semenzato wrote:
> This patch fixes the following errors:
> spaces required around that '=' (ctx:VxV)
> space required after that ',' (ctx:VxV)
> space required after that ';' (ctx:VxV)
[]
> diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtf
seq_printf(seq,
...);
...
- return i;
+ return 0;
With some additional reformatting and typing post conversion
to remove the now unnecessary "int i;" declaration.
Signed-off-by: Joe Perches
---
drivers/staging/lustre/lustre/fid/lproc_fid.c | 23 +++---
drivers/st
On Mon, 2015-03-02 at 12:37 +0300, Dan Carpenter wrote:
> On Sat, Feb 28, 2015 at 06:59:19AM -0800, Joe Perches wrote:
> > If you're really going to change these, please
> > remove the unnecessary \ line continuations
> > indent the blocks properly and group the bl
On Fri, 2015-03-06 at 11:08 -0500, Jes Sorensen wrote:
> Julia Lawall writes:
> > On Fri, 6 Mar 2015, Jes Sorensen wrote:
> >> Quentin Lambert writes:
> >> > This patch reduces the kernel size by removing error messages that
> >> > duplicate
> >> > the normal OOM message.
> >> > A simplified ver
On Fri, 2015-03-06 at 14:43 -0500, Jes Sorensen wrote:
> Joe Perches writes:
> > On Fri, 2015-03-06 at 11:08 -0500, Jes Sorensen wrote:
> >> Julia Lawall writes:
> >> > On Fri, 6 Mar 2015, Jes Sorensen wrote:
> >> >> Quentin Lambert writes:
&g
On Sun, 2015-03-08 at 19:42 +0300, Mike Krinkin wrote:
> The patch converts code to use %pM specifier instead of pushing
> each byte via stack.
Hello Mike.
> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> b/drivers/staging/rtl8188eu/hal/usb_halinit.c
[]
> @@ -1096,10 +1096,8 @@ stati
On Tue, 2015-03-10 at 16:10 +, Ian Abbott wrote:
> "comedidev.h" includes PCI-specific stuff that gets included by all
> comedi drivers including non-PCI ones. Separate it out into its own
> header "comedi_pci.h". Make the new header include and
> "comedidev.h" so that comedi PCI drivers do
On Tue, 2015-03-10 at 22:34 +0100, Geert Uytterhoeven wrote:
> Gcc < 4.3 doesn't understand binary constants (0b*):
trivia:
> diff --git a/drivers/staging/fbtft/fb_hx8340bn.c
> b/drivers/staging/fbtft/fb_hx8340bn.c
[]
> @@ -156,10 +156,10 @@ static int set_var(struct fbtft_par *par)
> static in
On Tue, 2015-03-10 at 18:26 +, Hartley Sweeten wrote:
> When comedi gets moved out of staging we will need to decide where the
> headers go.
Any idea when that might happen?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linu
On Tue, 2015-03-10 at 23:53 +0100, Mateusz Kulikowski wrote:
> - Replaced printk() with netdev_*()
trivia:
> diff --git a/drivers/staging/rtl8192e/rtllib_wx.c
> b/drivers/staging/rtl8192e/rtllib_wx.c
[]
> @@ -423,11 +421,8 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee,
>
On Wed, 2015-03-11 at 14:03 -0700, Janakarajan Natarajan wrote:
> Addition of blank line after declaration in ft1000_hw.c
> Minor changes to remove {} from single line if and remove extra parenthesis.
> Fixes checkpatch warning for and usage.
Most prefer separate patches for each type of change,
On Fri, 2015-03-13 at 00:53 +0100, Mateusz Kulikowski wrote:
[]
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> index 0e6bdd2..01d2201 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> +++ b/drivers/stagin
On Sun, 2015-03-15 at 23:10 +0530, Yogeswaran Thulasidoss wrote:
If you are going to fix whitespace, please
fix all whitespace issues on the same line.
> diff --git a/drivers/staging/lustre/lustre/obdecho/echo_client.c
> b/drivers/staging/lustre/lustre/obdecho/echo_client.c
[]
> @@ -1274,11 +127
On Mon, 2015-03-16 at 05:47 +0530, Yogeswaran Thulasidoss wrote:
> ---
3 things:
o You need to use a better subject line
try something like:
[PATCH] staging: lustre: echo_client: Use kernel style spacing
o There should be some sort of commit message
o You didn't add your "Signed-off-by:
On Sun, 2015-03-15 at 21:39 +0100, Mateusz Kulikowski wrote:
> Fix checkpatch.pl errors 'Macros with complex values should be enclosed in
> parentheses'.
[]
> diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h
> b/drivers/staging/rtl8192e/rtl819x_HT.h
[]
> @@ -78,7 +78,7 @@ enum chnl_op {
> };
>
On Mon, 2015-03-16 at 22:57 +0100, Mateusz Kulikowski wrote:
> On 13.03.2015 01:27, Joe Perches wrote:
> >
> > Another thing you might consider is to change these
> > embedded function names in another patch to use
> > "%s: ", __func__
> >
> &
On Thu, 2015-03-19 at 23:09 +0530, Amitoj Kaur Chawla wrote:
> The edits have been made to remove C99 Comments and properly indent
> the if-else statements in the file while taking care of the braces according
> to
> Linux coding style.
Please scan your proposed patches with checkpatch
and fix po
On Tue, 2015-03-24 at 16:00 +0300, Dan Carpenter wrote:
> On Tue, Mar 24, 2015 at 08:08:16AM -0400, Nicholas Krause wrote:
> > Just one more question, is that patch going to be merged or should I
> > resubmit
> > it as a series of one patch?
> Don't resubmit. Wait for Greg to mail you. It can t
On Tue, 2015-03-24 at 11:00 +0300, Dan Carpenter wrote:
> None of these are correct. :(
True. Please run your proposed patches through checkpatch
before sending them.
I think it would be an improvement to rework the flow-hiding
TRACE_RET and TRACE_GOTO macros into two separate lines.
It would
Use the standard vsprintf kernel extension to format
mac addresses.
This reduces object code size a bit.
Miscellanea:
o Coalesce formats
o Realign arguments
o Remove the now unused MAC_FMT and MAC_ARG #defines
Signed-off-by: Joe Perches
---
drivers/staging/rtl8723au/core/rtw_ap.c
On Wed, 2015-03-25 at 00:39 +0530, Niranjan Dighe wrote:
> The following files had coding style issues that I tried to address.
> It was mostly about lines spanning more than 80 characters.
[]
> diff --git a/drivers/staging/slicoss/slicoss.c
> b/drivers/staging/slicoss/slicoss.c
[]
> @@ -98,7 +98,
On Tue, 2015-03-24 at 23:14 +0300, Dan Carpenter wrote:
> On Wed, Mar 25, 2015 at 12:39:06AM +0530, Niranjan Dighe wrote:
> > The following files had coding style issues that I tried to address.
> > It was mostly about lines spanning more than 80 characters.
[]
> > diff --git a/drivers/staging/slic
On Tue, 2015-03-24 at 20:28 -0400, Jes Sorensen wrote:
> Joe Perches writes:
> > Create an rt_trace function using %pV to reduce overall code size.
> > Update the macro uses to remove unnecessary and now harmful parentheses.
[]
> This could be further improved by fixing up al
On Tue, 2015-03-24 at 21:28 -0700, Joe Perches wrote:
> Remove these flow hiding macros.
Apologies, this won't compile properly as I neglected to
"git add trace.c" prior to the git commit.
I'll resend later.
__
(chip, arg1, arg2);
+ if (retval) {
+ rtsx_trace(chip);
+ return retval;
+ }
Signed-off-by: Joe Perches
---
drivers/staging/rts5208/ms.c| 250 ---
drivers/staging/rts5208/rtsx_card.c | 96 +-
drivers/staging/rts5208/rtsx_card.h | 8
Macros with hidden flow control are poor form.
Joe Perches (2):
staging: rts5208: Remove TRACE_RET and TRACE_GOTO macros
staging: rts5208: Remove RTSX_READ_REG and RTSX_WRITE_REG macros
drivers/staging/rts5208/Makefile |2 +-
drivers/staging/rts5208/ms.c | 1654
On Thu, 2015-03-26 at 19:52 +0100, Greg KH wrote:
> On Thu, Mar 26, 2015 at 11:52:43PM +0530, Niranjan Dighe wrote:
> > Replace string directly in place of format string and remove pointer
> > variable which was used just once.
[]
> > diff --git a/drivers/staging/slicoss/slicoss.c
> > b/drivers/st
On Thu, 2015-03-26 at 22:32 +0100, Greg KH wrote:
> On Thu, Mar 26, 2015 at 01:52:33PM -0700, Joe Perches wrote:
> > On Thu, 2015-03-26 at 19:52 +0100, Greg KH wrote:
> > > On Thu, Mar 26, 2015 at 11:52:43PM +0530, Niranjan Dighe wrote:
> > > > Replace string directly
On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote:
> On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera
> wrote:
> > This patch fixes the checkpatch.pl warning:
[]
> > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
[]
> > @@ -423,7 +423,8 @@ static void anno
On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote:
> Am 28.03.2015 um 22:18 schrieb Joe Perches:
> > On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote:
> >> On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera
> >> wrote:
> >>> Thi
On Mon, 2015-03-30 at 00:41 +0200, Mateusz Kulikowski wrote:
> Return from rtllib_rx_auth_resp() if auth_parse() fails.
Hello Mateusz. Here are some trivial notes.
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c
> b/drivers/staging/rtl8192e/rtllib_softmac.c
[]
> + /* Dummy
On Mon, 2015-03-30 at 01:21 +0200, Mateusz Kulikowski wrote:
> On 30.03.2015 01:13, Joe Perches wrote:
> > On Mon, 2015-03-30 at 00:41 +0200, Mateusz Kulikowski wrote:
> >> Return from rtllib_rx_auth_resp() if auth_parse() fails.
> >> diff --git a/drivers/staging/rtl819
On Wed, 2015-04-01 at 12:23 -0700, Janakarajan Natarajan wrote:
> I initially sent a single patch on March 11th. It was recommended that I
> send it in a patchset as it did too many things in 1 patch.
> I submitted the v2 patchset on March 12th. After a week of not knowing if
> it was accepted, I r
On Fri, 2015-04-03 at 19:51 +0300, Dan Carpenter wrote:
> On Fri, Apr 03, 2015 at 10:12:11PM +0530, Amitoj Kaur Chawla wrote:
> > Removes variable comparison with 0 by using !.
>
> Sometimes testing for zero makes sense.
> When you write code, you are
> telling a story. If you are talking about
On Sat, 2015-04-04 at 03:23 +0300, Andreas Theodosiou wrote:
> This is a patch to the fb_ili9163.c file that inserts a line break in
> line #92 to make the line fit into the 80 character limit.
[]
> diff --git a/drivers/staging/fbtft/fb_ili9163.c
> b/drivers/staging/fbtft/fb_ili9163.c
[]
> @@ -89,
I meant "if strcmp then". Only serves to
> emphasize my point though. :)
When I read it I understood what you meant, but
I thought the point was everybody makes mistakes.
!strcmp to test equality is still pretty idiomatic.
!memcmp too.
cheers, Joe
_
On Mon, 2016-06-20 at 12:53 -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> Fix paths in the comments.
Why is it useful to have the path or filename embedded
in the file at
all?
___
devel mailing list
de...@linuxdriverproject.org
http://driv
On Thu, 2016-06-23 at 18:57 +0100, Luis de Bethencourt wrote:
> hif_drv->usr_scan_req.net.net_info[i] contains found_net_info structs
> which have the following element:
> u8 bssid[6];
[]
> I am aware this patch gives a few checkpatch.pl warnings about lines being
> over 80 characters. Fixing that
On Sat, 2016-06-25 at 14:53 -0500, Larry Finger wrote:
> All of the rtlwifi family of drivers have a similar routine that acquires
> the hardware info from efuse and initializes a number of variables in the
> driver's private area. A common routine is created for all drivers to use.
[]
> diff --git
On Sat, 2016-06-25 at 14:53 -0500, Larry Finger wrote:
> This driver contains some complicated if ... else if ... else constructions.
> These are replaced by switch statements to improve readability.
[]
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c
> b/drivers/net/wireless/rea
On Mon, 2016-06-27 at 10:52 -0500, Larry Finger wrote:
> This driver contains some complicated if ... else if ... else
> constructions. These are replaced by switch statements to improve
> readability.
[]
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c
> b/drivers/net/wireless/
On Thu, 2016-06-30 at 15:58 +, Dexuan Cui wrote:
> Hyper-V Sockets (hv_sock) supplies a byte-stream based communication
> mechanism between the host and the guest. It's somewhat like TCP over
> VMBus, but the transportation layer (VMBus) is much simpler than IP.
trivia:
> diff --git a/include
On Tue, 2016-07-05 at 09:31 +, Dexuan Cui wrote:
> > > +/* This is the address fromat of Hyper-V Sockets.
> > format
> I suppose you meant I should change
> /* This is ...
> to
> /*
> * This is ...
> I'll fix this.
No, I just meant fromat should be format
___
On Tue, 2016-07-05 at 15:36 -0700, Markus Mayer wrote:
> On 5 July 2016 at 15:14, Joe Perches wrote:
> > On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote:
> > > This series introduces a family of generic string case conversion
> > > functions. This kind of functio
On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote:
> This series introduces a family of generic string case conversion
> functions. This kind of functionality is needed in several places in
> the kernel. Right now, everybody seems to be implementing their own
> copy of this functionality.
>
>
On Mon, 2016-07-11 at 18:17 +0300, Andrey Utkin wrote:
[]
> diff --git a/drivers/media/pci/tw5864/tw5864-core.c
> b/drivers/media/pci/tw5864/tw5864-core.c
[]
> +static const char * const artifacts_warning =
> +"BEWARE OF KNOWN ISSUES WITH VIDEO QUALITY\n"
> +"\n"
> +"This driver was developed by B
On Sun, 2016-07-17 at 20:27 +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 17 Jul 2016 19:12:27 +0200
>
> Prefer usage of the macro "pr_err" over the interface "printk".
> Fix a typo in an error message.
Please and and use pr_fmt
On Sat, 2016-07-23 at 02:37 -0400, Oleg Drokin wrote:
> From: Emoly Liu
unrelated trivial notes:
> diff --git a/drivers/staging/lustre/lustre/obdecho/echo_internal.h
> b/drivers/staging/lustre/lustre/obdecho/echo_internal.h
[]
> @@ -33,9 +33,9 @@
>
> /* The persistent object (i.e. actually s
On Sat, 2016-07-23 at 14:01 -0400, Oleg Drokin wrote:
> On Jul 23, 2016, at 1:31 PM, Joe Perches wrote:
[]
> > And lustre seems to use types with unnecessary __ prefixes.
> Need to see if this file is included in userspace where the __ is needed.
Maybe it'd be good to cha
On Tue, 2016-07-26 at 12:36 -0400, James Simmons wrote:
> From: wang di
>
> 1. client send create request to the master MDT, which
> will allocate FIDs and create slaves. for all of slaves.
>
> 2. Client needs to revalidate slaves during intent getattr
> and open request.
>
> 3. lmv_stripe
On Fri, 2016-07-29 at 14:06 -0700, Nadim almas wrote:
> This patch compresses two lines in to a single line in file rtw_android.c
> if immediate return statement is found. It also removes variable
> bytes_written as it is no longer needed.
>
> It is done using script Coccinelle. And coccinelle us
On Sat, 2016-07-30 at 02:54 -0700, Nadim almas wrote:
> This patch compresses two lines in to a single line in file rtw_android.c
> if immediate return statement is found. It also removes variable
> bytes_written as it is no longer needed.
>
> It is done using script Coccinelle. And coccinelle us
On Mon, 2016-08-08 at 17:35 -0400, Anson Jacob wrote:
> Fix checkpatch.pl warning for trailing */ on a separate line
> Remove '+' postfix and '-' prefix from the start and end of block comments
Those /*+ uses should probably be converted to /** for kernel-doc
> Signed-off-by: Anson Jacob
> ---
>
On Thu, 2016-08-11 at 07:48 +0200, SF Markus Elfring wrote:
> Prefer usage of the macro "pr_err" over the interface "printk".
Not correct
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c
> b/drivers/staging/ks7010/ks7010_sdio.c
[]
> @@ -998,11 +998,11 @@ static int ks7010_sdio_probe(struct sdi
On Sat, 2016-08-13 at 13:10 +0200, SF Markus Elfring wrote:
> > > Prefer usage of the macro "pr_err" over the interface "printk".
> > Not correct
> A checkpatch warning like "PREFER_PR_LEVEL" can point additional
> possibilities out
> for this use case.
> Would you like to introduce any of the hig
On Sat, 2016-08-13 at 21:30 +0200, SF Markus Elfring wrote:
> >
> > I think pr_ is OK if reworking the code
> > to support dev_ is not easy.
> Thanks for this explanation. - It sounds more constructive than the previous
> short
> feedback "Not correct".
How do you need your food prepared?
Do ot
On Sat, 2016-08-13 at 17:26 +0800, sunbing wrote:
> On Aug 12, 2016, at 22:30, Jes Sorensen wrote:
> > sunbing writes:
> > > On Aug 11, 2016, at 23:25, Jes Sorensen wrote:
> > > > Bing Sun writes:
> > > > >
> > > > > Fixed sparse parse error:
> > > > > Expected constant expression in case stat
On Sun, 2016-08-14 at 14:15 +0200, Johannes Berg wrote:
> >
> > It's a sparse defect.
> >
> > Try again after patching sparse with Jes' patch:
> > http://marc.info/?l=linux-sparse&m=147091200720267&w=3
> Mine, not Jes's ;-)
Right, sorry 'bout that.
> But there's another patch going into the ker
Start to rationalize include paths in source code files.
Signed-off-by: Joe Perches
---
drivers/staging/lustre/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/lustre/Makefile b/drivers/staging/lustre/Makefile
index 95ffe33..9d00237 100644
--- a/drivers/staging
Make the include paths a bit easier to find and more
compatible to a future move out of the staging tree.
Signed-off-by: Joe Perches
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h | 6 +++---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 8
drivers
Make it a bit easier to grep and help a future move out of staging.
Joe Perches (2):
staging: lustre: Add include path to Makefile
staging: lustre: Remove .. paths from '#include "' uses
drivers/staging/lustre/Makefile | 3 +++
drivers/staging/lu
On Mon, 2016-08-15 at 14:14 -0700, Joe Perches wrote:
> On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote:
> > On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote:
> > > Start to rationalize include paths in source code files.
> []
> > > diff
On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote:
> > Start to rationalize include paths in source code files.
[]
> > diff --git a/drivers/staging/lustre/Makefile
> > b/drivers/staging/lustre/Makefil
On Tue, 2016-08-16 at 00:07 +0200, Michal Marek wrote:
Hi Michal.
> > Perhaps making a specific directory should also walk up
> > any parent directory Makefiles looking for subdir flags.
> >
> > Is that unreasonable? Any suggestions?
> I suggest to do make drivers/staging/lustre/. If building t
On Tue, 2016-08-16 at 12:53 +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 15, 2016 at 02:14:18PM -0700, Joe Perches wrote:
> > On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote:
> > > On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote:
> > > > Star
On Fri, 2016-08-19 at 20:44 +0100, James Simmons wrote:
> > 1: I'd like to see the lustre #include files separated into
> > only two internal/external directories akin to the
> > include/linux and include/uapi directories used by linux.
[]
> For the first question yes it is reasonable and dev
On Fri, 2016-08-19 at 14:07 -0400, James Simmons wrote:
> Resolved the last remain bug that prevented earlier submission.
> This covers the remaining patches that were missing from the
> upstream client that was in Lustre 2.6 except for the work for
> LU-2484. The work for LU-2484 depends on the st
On Mon, 2016-08-22 at 18:41 +0100, James Simmons wrote:
> On Fri, 2016-08-19 at 20:44 +0100, James Simmons wrote:
Hi again James.
> > I don't _need_ anything, but I think it'd be simpler to
> > have just 2 directories, one for lustre kernel stuff
> > and another for lustre uapi stuff.
> >
> > Th
On Thu, 2016-08-25 at 00:55 +0300, Claudiu Beznea wrote:
> This patch removes duplicate code in p80211req_mibset_mibget()
> by adding p80211req_handle_action() function.
Better would be to remove the prototype and move the
new static to the location of the prototype.
_
On Fri, 2016-08-26 at 20:58 +0300, Claudiu Beznea wrote:
> This patch removes multiple switch-case statements
> with a new macro. The macro will generate the
> corresponding bit mask based on the key index
> received as input.
Can you go a little farther and remove the
#define DIDmib_dot11smt_dot1
On Tue, 2016-08-30 at 22:05 +0300, Moshe Green wrote:
> Fix block comment * prefix and trailing */ warnings found
> by the checkpatch.pl tool in ddk750_chip.c.
[]
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c
> b/drivers/staging/sm750fb/ddk750_chip.c
[]
> @@ -320,8 +320,10 @@ unsigned int c
801 - 900 of 1318 matches
Mail list logo
