[edk2] [Patch] BaseTools: cache the defined Guid tool to improve the performance

2016-03-28 Thread Yonghong Zhu
Current GenFds Tool class GuidSection() is parsing the tools_def.txt for every GUID'ed section that has a GUID defined tool, it cause a bad performance. so this patch cache the defined Guid tool to improve the performance. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

Re: [edk2] [Patch 1/8] MdePkg: Add definition for TCG Storage Core and Opal specs.

2016-03-28 Thread Dong, Eric
Got it, I will update the code before I check in the code. > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, March 29, 2016 9:52 AM > To: Tian, Feng; Dong, Eric; edk2-devel@lists.01.org > Cc: Tian, Feng > Subject: RE: [Patch 1/8] MdePkg: Add definition for TCG Storage Core and

Re: [edk2] [Patch] MdePkg/BaseSynchronizationLib: Do not check timeout if lock released

2016-03-28 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jeff Fan > Sent: Tuesday, March 22, 2016 2:53 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D; Gao, Liming > Subject: [edk2] [Patch]

Re: [edk2] [Patch v2] MdePkg/BaseSynchronizationLib: Add spin lock alignment for IA32/x64

2016-03-28 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Fan, Jeff > Sent: Tuesday, March 22, 2016 3:40 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D; Gao, Liming > Subject: [Patch v2] MdePkg/BaseSynchronizationLib: Add spin lock alignment > for IA32/x64 > >

Re: [edk2] [Patch 1/2] UefiCpuPkg/Cpuid.h: Add CPUID defines and structures for Intel SGX

2016-03-28 Thread Kinney, Michael D
Reviewed-by: Michael Kinney > -Original Message- > From: Fan, Jeff > Sent: Sunday, March 27, 2016 6:59 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Feng Tian > > Subject: [Patch 1/2]

Re: [edk2] [Patch 2/2] UefiCpuPkg/Cpuid.h: Display Intel SGX Resource Enumeration Leaves

2016-03-28 Thread Kinney, Michael D
Reviewed-by: Michael Kinney > -Original Message- > From: Fan, Jeff > Sent: Sunday, March 27, 2016 6:59 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Feng Tian > > Subject: [Patch 2/2]

Re: [edk2] [Patch] BaseTools: Add two new sections for PCD in the build report

2016-03-28 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Wednesday, March 23, 2016 5:39 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Add two new sections for

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-28 Thread Kinney, Michael D
Ard, What is the timer rate in the system you are using? The timer event rate of a UEFI driver can not go any faster or a smaller granularity than the system timer rate. The original formula may be correct, but may not be compensating for the granularity of the timer rate. Is the issue also

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-28 Thread Heyi Guo
On 03/25/2016 01:56 PM, Ard Biesheuvel wrote: On 25 March 2016 at 03:52, Ni, Ruiyu wrote: Heyi, I was not able to remove the blue bar in the beginning of every line if I embedded my reply. So I will directly write down here. 1. I would like to know in what

[edk2] [Patch 2/3] MdeModulePkg/Bds: Free resources after ram disk boot finishes

2016-03-28 Thread Ruiyu Ni
The resource free includes to un-register the ram disk device and free the memory occupied by the ram disk. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Siyuan Fu Cc: Feng Tian ---

[edk2] [Patch 0/3] HTTP Boot to RAM Disk

2016-03-28 Thread Ruiyu Ni
The existing code already supports HTTP boot to RAM Disk. The patch 1/3 is to follow the ACPI spec to use reserved memory instead of BS memory. Patch 2/3 is to fix the memory leak issue when Http Boot finishes or fails. Patch 3/3 is to disable memory type information update in Http Boot to Ram

[edk2] [Patch 1/3] MdeModulePkg/Bds: Allocate reserved memory for RAM Disk boot media

2016-03-28 Thread Ruiyu Ni
Use reserved memory to hold the buffer for the RAM disk to follow the ACPI spec requirement. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Siyuan Fu --- MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 145

[edk2] [Patch 3/3] MdeModulePkg/Bds: Don't save memory type information for ram disk boot

2016-03-28 Thread Ruiyu Ni
Memory type information is required for S4 and ram disk boot doesn't need to support S4. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Siyuan Fu --- MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 8 +--- 1

Re: [edk2] [Patch 1/8] MdePkg: Add definition for TCG Storage Core and Opal specs.

2016-03-28 Thread Yao, Jiewen
Hi Can we add TCG prefix for all data structure to avoid namespace conflict? For example: +typedef struct { + UINT8 Data : 6; + UINT8 Sign : 1; + UINT8 IsZero : 1; +} TINY_ATOM_BITS; +// Security Protocol IDs +#define SECURITY_PROTOCOL_INFO 0x00 +#define

Re: [edk2] [Patch 1/8] MdePkg: Add definition for TCG Storage Core and Opal specs.

2016-03-28 Thread Tian, Feng
PS: please make sure latest GCC build pass before push as a new set-but-not-used option is introduced. Thanks Feng -Original Message- From: Tian, Feng Sent: Tuesday, March 29, 2016 9:42 AM To: Dong, Eric ; edk2-devel@lists.01.org Cc: Tian, Feng

Re: [edk2] [Patch 1/8] MdePkg: Add definition for TCG Storage Core and Opal specs.

2016-03-28 Thread Tian, Feng
Series reviewed-by: Feng Tian Thanks Feng -Original Message- From: Dong, Eric Sent: Monday, March 21, 2016 11:17 AM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [Patch 1/8] MdePkg: Add definition for TCG Storage Core and Opal specs.

Re: [edk2] [PATCH 2/2] ShellPkg/UefiDpLib: Fix a memory leak issue in Dp.

2016-03-28 Thread Zeng, Star
On 2016/3/28 13:38, Zeng, Star wrote: On 2016/3/28 11:03, Cinnamon Shia wrote: The allocated memory of ParamPackage is not freed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia Reviewed-by: Star Zeng Pushed

Re: [edk2] [PATCH 1/2] PerformancePkg/Dp_App: Fix a memory leak issue in Dp.

2016-03-28 Thread Zeng, Star
On 2016/3/28 13:36, Zeng, Star wrote: On 2016/3/28 11:03, Cinnamon Shia wrote: The allocated memory of ParamPackage is not freed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia Reviewed-by: Star Zeng Pushed

Re: [edk2] [PATCH 00/35] remove unused but set variables

2016-03-28 Thread Steele, Kelly
I have built and verified that the firmware built for Quark still POSTs. QuarkPlatformPkg Reviewed-by: Kelly Steele QuarkSocPkg Reviewed-by: Kelly Steele > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: March

Re: [edk2] PCIe memory transaction issue

2016-03-28 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Shaveta Leekha had to walk into mine at 10:47:05 on Monday 28 March 2016 and say: > Thanks Bill ! > Yes I am using "Undi EDK Intel(R) PRO/1000" driver from Intel, > it is for e1000_82575 NIC card. > > Yes, the driver seems to have the

Re: [edk2] PCIe memory transaction issue

2016-03-28 Thread Shaveta Leekha
Replies and doubts in-lined Thanks and Regards, Shaveta -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Shaveta Leekha Sent: Monday, March 28, 2016 11:20 PM To: Andrew Fish ; Bill Paul Cc:

Re: [edk2] PCIe memory transaction issue

2016-03-28 Thread Shaveta Leekha
-Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew Fish Sent: Monday, March 28, 2016 11:14 PM To: Bill Paul Cc: edk2-de...@ml01.01.org Subject: Re: [edk2] PCIe memory transaction issue > On Mar 28, 2016, at 9:55 AM,

Re: [edk2] PCIe memory transaction issue

2016-03-28 Thread Shaveta Leekha
Thanks Bill ! Yes I am using "Undi EDK Intel(R) PRO/1000" driver from Intel, it is for e1000_82575 NIC card. Yes, the driver seems to have the support for 64-bit. Rest of the replies are in-lnlined Vendor-id: device id is: Shell> pci Seg Bus Dev Func --- --- --- 00 00

Re: [edk2] PCIe memory transaction issue

2016-03-28 Thread Andrew Fish
> On Mar 28, 2016, at 9:55 AM, Bill Paul wrote: > > Of all the gin joints in all the towns in all the world, Bill Paul had to > walk > into mine at 09:33:57 on Monday 28 March 2016 and say: > >> Of all the gin joints in all the towns in all the world, Shaveta Leekha had

Re: [edk2] PCIe memory transaction issue

2016-03-28 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Bill Paul had to walk into mine at 09:33:57 on Monday 28 March 2016 and say: > Of all the gin joints in all the towns in all the world, Shaveta Leekha had > to > > walk into mine at 00:29:39 on Monday 28 March 2016 and say: > > Hi, > > >

Re: [edk2] [PATCH] ShellPkg: Refine the comparisons code in ShellPkg.

2016-03-28 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Qiu, Shumin > Sent: Sunday, March 27, 2016 11:48 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin ; Carsey, Jaben > > Subject: [PATCH] ShellPkg: Refine the

Re: [edk2] PCIe memory transaction issue

2016-03-28 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Shaveta Leekha had to walk into mine at 00:29:39 on Monday 28 March 2016 and say: > Hi, > > In PCIe memory transactions, I am facing an issue. > > The scenario is: > Case 1: > In our system, we have allocated 32 bit memory space to one

Re: [edk2] Question about Chipset initialization

2016-03-28 Thread Marvin Häuser
Hello Rafael, Chipset initialization should be done in the PEI phase, along with the initialization of any critical hardware (DRAM, etc.). In DXE, usually the optional devices are initialized (controllers like USB and such). Here is a nice picture of the boot flow from the TianoCore Wiki:

[edk2] Question about Chipset initialization

2016-03-28 Thread Rafael Machado
Hi everyone. I'm doing some studies related to audio at UEFI. To in future enable BIOS to be accessible. This is part of my MSc in Computer Science degree. It's take some time, but I'm not worried. The challenge was already accepted. Currently I'm checking is the chipset is already enabled

Re: [edk2] PCIe memory transaction issue

2016-03-28 Thread Shaveta Leekha
Hi, Has anyone tested Intel E1000 driver with 64-bit Physical address space? Does it support? Regards, Shaveta From: Shaveta Leekha Sent: Monday, March 28, 2016 1:00 PM To: edk2-devel@lists.01.org Subject: PCIe memory transaction issue Hi, In PCIe memory transactions, I am facing an issue.

[edk2] PCIe memory transaction issue

2016-03-28 Thread Shaveta Leekha
Hi, In PCIe memory transactions, I am facing an issue. The scenario is: Case 1: In our system, we have allocated 32 bit memory space to one of the PCI device (E1000 NIC card) during enumeration and BAR programming. When NIC card is getting used to transmit a ping packet, a local buffer is

[edk2] [PATCH] ShellPkg: Refine the comparisons code in ShellPkg.

2016-03-28 Thread Qiu Shumin
For Boolean values not use explicit comparisons to TRUE or FALSE. For non-Boolean comparisons we should use a compare operator. Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin ---