Re: [edk2] [PATCH v2 09/14] IntelFrameworkModulePkg: Fix typos in comments

Reviewed-by: Jeff Fan -Original Message- From: Mudusuru, Giri P Sent: Friday, July 08, 2016 2:21 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [edk2] [PATCH v2 09/14] IntelFrameworkModulePkg: Fix typos in comments - requried to required Cc: Jeff Fan Contributed-under: TianoCor

Re: [edk2] [PATCH v2 14/14] UefiCpuPkg: Fix typos in comments

Reviewed-by: Jeff Fan -Original Message- From: Mudusuru, Giri P Sent: Friday, July 08, 2016 2:21 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [edk2] [PATCH v2 14/14] UefiCpuPkg: Fix typos in comments - becasue to because Cc: Jeff Fan Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH v2 06/14] SecurityPkg: Fix typos in comments

Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Mudusuru, Giri P Sent: Friday, July 08, 2016 2:21 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B Subject: [edk2] [PATCH v2 06/14] SecurityPkg: Fix typos in comments - availabe to available Cc: Cha

Re: [edk2] [PATCH 1/2] Revert "ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable"

Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Thursday, July 7, 2016 10:47 PM > To: Ni, Ruiyu > Cc: edk2-devel-01 ; Gao, Liming > > Subject: Re: [edk2] [PATCH 1/2] Revert > "ShellPkg/UefiShellDebug1Comm

Re: [edk2] [PATCH v2 05/14] CryptoPkg: Fix typos in comments

CryptoPkg: Reviewed-by: Qin Long Best Regards & Thanks, LONG, Qin > -Original Message- > From: Mudusuru, Giri P > Sent: Friday, July 08, 2016 2:21 PM > To: edk2-devel@lists.01.org > Cc: Long, Qin; Ye, Ting > Subject: [edk2] [PATCH v2 05/14] CryptoPkg: Fix typos in comments > > - availa

Re: [edk2] [PATCH 0/4] OvmfPkg: program MSR_IA32_FEATURE_CONTROL from fw_cfg on all processors

Reviewed-by: Jeff Fan Thanks! Jeff -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, July 08, 2016 3:11 AM To: edk2-devel-01 Cc: Fan, Jeff; Justen, Jordan L; Kinney, Michael D Subject: [PATCH 0/4] OvmfPkg: program MSR_IA32_FEATURE_CONTROL from fw_cfg on all

Re: [edk2] [PATCH v2 04/14] Nt32Pkg: Fix typos in comments

Reviewed-by: Ruiyu Ni > -Original Message- > From: Mudusuru, Giri P > Sent: Friday, July 8, 2016 2:21 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [edk2] [PATCH v2 04/14] Nt32Pkg: Fix typos in comments > > - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED > > Cc: Ruiyu Ni > Contri

Re: [edk2] [PATCH] CryptoPkg BaseCryptLib: Avoid passing NULL ptr to function BN_bn2bin()

Reviewed-by: Qin Long Best Regards & Thanks, LONG, Qin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Hao Wu > Sent: Friday, July 08, 2016 12:30 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Ye, Ting; Fu, Siyuan; Long, Qin > Subject:

Re: [edk2] [PATCH v2 00/14] Fix typos in comments and variables

MdeModulePkg looks good to me Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Giri P Mudusuru Sent: Friday, July 8, 2016 2:21 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2 00/14] Fix typos in commen

[edk2] [PATCH v2 13/14] OvmfPkg: Fix typos in comments

- accessibla to accessible - exeuction to execution Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- OvmfPkg/VirtioBlkDxe/VirtioBlk.c | 6 +++--- OvmfPkg/VirtioBlkDxe/VirtioBlk.h | 4 ++--

[edk2] [PATCH v2 11/14] MdePkg: Fix typos in comments

- availabe to available - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED Cc: Liming Gao Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru Reviewed-by: Liming Gao --- MdePkg/Include/Protocol/Cpu.h| 4 ++-- MdePkg/Include/Protocol/Servi

[edk2] [PATCH v2 14/14] UefiCpuPkg: Fix typos in comments

- becasue to because Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru Reviewed-by: Jeff Fan --- UefiCpuPkg/CpuMpPei/Microcode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiCpuPkg/CpuMpPei/Microcode.c b/UefiCpuPkg/Cp

[edk2] [PATCH v2 09/14] IntelFrameworkModulePkg: Fix typos in comments

- requried to required Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru Reviewed-by: Jeff Fan --- IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c| 6 +++--- .../Universal/SectionExtractionDxe/SectionExtraction.c

[edk2] [PATCH v2 03/14] EmulatorPkg: Fix typos in comments

EFI_UNSUPPORTEDT to EFI_UNSUPPORTED Cc: Andrew Fish Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- EmulatorPkg/TimerDxe/Timer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/EmulatorPkg/TimerDxe/Timer.c b/E

[edk2] [PATCH v2 04/14] Nt32Pkg: Fix typos in comments

- EFI_UNSUPPORTEDT to EFI_UNSUPPORTED Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru Reviewed-by: Ruiyu Ni --- Nt32Pkg/TimerDxe/Timer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Nt32Pkg/TimerDxe/Timer.c b/Nt32Pk

[edk2] [PATCH v2 10/14] MdeModulePkg: Fix typos in comments and variables

- abstrated to abstracted - accessibla to accessible - addres to address - apropriate to appropriate - arry to array - availabe to available - avaliable to available - becasue to because - correponding to corresponding - etablished to established - exeuction to execution - e

[edk2] [PATCH v2 12/14] NetworkPkg: Fix typos in comments

- abstrated to abstracted - apropriate to appropriate - availabe to available - ptototypes to prototypes - prococol protocol Cc: Siyuan Fu Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru Reviewed-by: Jiaxin Wu --- NetworkPkg/Dhcp6Dxe/Dhcp6D

[edk2] [PATCH v2 08/14] PcAtChipsetPkg: Fix typos in comments

- EFI_UNSUPPORTEDT to EFI_UNSUPPORTED Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru Reviewed-by: Ruiyu Ni --- PcAtChipsetPkg/8254TimerDxe/Timer.c | 4 ++-- PcAtChipsetPkg/8254TimerDxe/Timer.h | 4 ++-- PcAtChipsetPkg/HpetTimerDxe/Hp

[edk2] [PATCH v2 05/14] CryptoPkg: Fix typos in comments

- availabe to available Cc: Qin Long Cc: Ting Ye Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru Reviewed-by: Qin Long --- CryptoPkg/Library/BaseCryptLib/SysCall/RuntimeMemAllocation.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2] [PATCH v2 07/14] OptionRomPkg: Fix typos in comments

- EFI_OUT_OF_RESORUCES to EFI_OUT_OF_RESOURCES Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru Reviewed-by: Ruiyu Ni --- OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/SimpleNetwork.c | 4 ++-- OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleN

[edk2] [PATCH v2 02/14] EdkCompatibilityPkg: Fix typos in comments

- availabe to available - consummer to consumer - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED - extensiable to extensible Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru Reviewed-by: Liming Gao --- .../Compatibility/PiSmbiosRecordOnDataHubS

[edk2] [PATCH v2 06/14] SecurityPkg: Fix typos in comments

- availabe to available Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru Reviewed-by: Chao Zhang --- SecurityPkg/Hash2DxeCrypto/Driver.c | 4 ++-- SecurityPkg/Hash2DxeCrypto/Driver.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)

[edk2] [PATCH v2 00/14] Fix typos in comments and variables

Changes based on v1 Reduced the length of subject Reverted the iff to if change Updated copyright years Updated reviewed-by info based on v1 Removed StdLib and ShellPkg as it is submitted based on v1 Giri P Mudusuru (14): ArmPkg: Fix typos in comments EdkCompatibilityPkg: Fix typos in comment

[edk2] [PATCH v2 01/14] ArmPkg: Fix typos in comments

EFI_UNSUPPORTEDT to EFI_UNSUPPORTED Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru Reviewed-by: Ard Biesheuvel --- ArmPkg/Drivers/CpuDxe/CpuDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Ar

Re: [edk2] [Patch] SecurityPkg OpalPasswordSmm: Remove useless code.

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Dong, Eric Sent: Friday, July 8, 2016 10:53 AM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [Patch] SecurityPkg OpalPasswordSmm: Remove useless code. EdkII not allow to use #if in source code, also the code in it alrea

Re: [edk2] [PATCH 07/16] SecurityPkg: Series of patches to fix typos - availabe to available

Sure, will send updated V2 patch with copyrights updated Thanks, -Giri > -Original Message- > From: Zhang, Chao B > Sent: Thursday, July 7, 2016 1:34 AM > To: Mudusuru, Giri P ; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH 07/16] SecurityPkg: Series of patches to fix typos > - >

[edk2] [PATCH] MdeModulePkg MemoryProfile: ASSERT to ensure 'DriverInfoData' is not NULL

Code logic ensures that the pointer 'DriverInfoData' will not be NULL when it is used. Add ASSERT as warning for case that will not happen. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/Core/Dxe/Mem/MemoryProfileRecord.c | 1 + Md

[edk2] [PATCH] CryptoPkg BaseCryptLib: Avoid passing NULL ptr to function BN_bn2bin()

This commit modifies the code logic to avoid passing NULL pointer to function BN_bn2bin(). Cc: Long Qin Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- CryptoPkg/Library/BaseCryptLib/Pk/CryptDh.c | 8 ++-- 1 file changed, 6 inser

Re: [edk2] UEFI driver for USB CDC ACM Serial device

Thank you so much, Feng. Regards, Keshava On Fri, 8 Jul 2016 at 07:14 Tian, Feng wrote: > No other nearer drivers you can refer to except this one. > > Thanks > Feng > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of GN > Keshava > Sent: Frida

Re: [edk2] [Patch] Vlv2TbltDevicePkg:Fixed system can't save time when RTC power failure.

Reviewed-by: David Wei Thanks, David Wei Intel SSG BIOS Team -Original Message- From: Lu, ShifeiX A Sent: Thursday, July 07, 2016 5:49 PM To: edk2-devel@lists.01.org Cc: Wei; Wei, David Subject: [Patch] Vlv2TbltDevicePkg:Fixed system can't save time

[edk2] [Patch] SecurityPkg OpalPasswordSmm: Remove useless code.

EdkII not allow to use #if in source code, also the code in it already unused. so just remove this code. Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalNvmeMode.c | 9 - 1 file changed, 9 deleti

Re: [edk2] [PATCH] MdeModulePkg MemoryProfile.h:two bytes of Reserved[4] as ActionStringOffset

Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star Zeng > Sent: Friday, July 8, 2016 10:41 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star > Subject: [edk2] [PATCH] MdeModulePkg MemoryProfi

[edk2] [PATCH] MdeModulePkg MemoryProfile.h:two bytes of Reserved[4] as ActionStringOffset

At 94092aa60341a3e4b1e1ea7c362781b8404ac538, we extended MEMORY_PROFILE_ALLOC_INFO to add ActionStringOffset and Reserved2[6] fields, that was not aware the Reserved[4] field can be reused to have better memory profile database size efficiency. With the patch, PcdMemoryProfilePropertyMask|0x3 and

Re: [edk2] [PATCH V2 0/7] Introduce three new toolchains in edk2

Hi Ard, I've put v2 in the subject and change the branch name to https://github.com/shijunjing/edk2/commits/llvm_v2 . You can review all my serial patches in the branch link, and let me know if you need me send the patches in the mail list again. Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +8

[edk2] [PATCH V2 0/7] Introduce three new toolchains in edk2

Please review my new commits in public branch: https://github.com/shijunjing/edk2/commits/llvm_v2 I did below enhancements according feedback to V1(https://github.com/shijunjing/edk2/commits/review5): 1. Remove the Quark platform work around and code clean work from this serial patches. 2. Seper

[edk2] [Patch] BaseTools: Fix report generation failure on case sensitive file system

Since in GenFds phase, the generate FV all use upper letter. In the build report, we should use the upper letter FV name to combine the file path. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/build/BuildReport.py

Re: [edk2] [PATCH 11/16] MdeModulePkg: Series of patches to fix typos

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Mudusuru, Giri P Sent: Thursday, July 7, 2016 3:48 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Tian, Feng Subject: [edk2] [PATCH 11/16] MdeModulePkg: Series of patches to fix typos - abstrated to abstracted - accessib

Re: [edk2] [PATCH 02/16] EdkCompatibilityPkg: Series of patches to fix typos - availabe to available - consummer to consumer - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED - extensiable to extensible

Reviewed-by: Liming Gao > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 07, 2016 3:48 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 02/16] EdkCompatibilityPkg: Series of patches to fix > typos - availabe to available - consummer to consu

Re: [edk2] [PATCH 12/16] MdePkg: Series of patches to fix typos - availabe to available - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED

Reviewed-by: Liming Gao > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 07, 2016 3:48 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D > > Subject: [edk2] [PATCH 12/16] MdePkg: Series of patches to fix typos - > availabe to available - EFI_UNSUP

Re: [edk2] UEFI driver for USB CDC ACM Serial device

No other nearer drivers you can refer to except this one. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of GN Keshava Sent: Friday, July 8, 2016 1:51 AM To: Tian, Feng ; edk2-devel@lists.01.org Subject: Re: [edk2] UEFI driver for USB C

Re: [edk2] [PATCH] MdePkg Base.h: Fix typo funcation to function

Reviewed-by: Liming Gao > -Original Message- > From: Zeng, Star > Sent: Friday, July 08, 2016 9:34 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Gao, Liming ; > Kinney, Michael D ; Yao, Jiewen > > Subject: [PATCH] MdePkg Base.h: Fix typo funcation to function > > Cc: Liming Gao >

[edk2] [PATCH] MdePkg Base.h: Fix typo funcation to function

Cc: Liming Gao Cc: Michael D Kinney Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- MdePkg/Include/Base.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index cbd9e

Re: [edk2] [PATCH 11/16] MdeModulePkg: Series of patches to fix typos

Reviewed-by: Star Zeng -Original Message- From: Mudusuru, Giri P Sent: Thursday, July 7, 2016 3:48 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Tian, Feng Subject: [edk2] [PATCH 11/16] MdeModulePkg: Series of patches to fix typos - abstrated to abstracted - accessibla to accessi

Re: [edk2] [PATCH 14/16] OvmfPkg: Series of patches to fix typos - accessibla to accessible - exeuction to execution - iff to if

Thanks Laszlo for your comments. Will send updated patch addressing your comments. Thanks, -Giri > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, July 7, 2016 2:00 AM > To: Mudusuru, Giri P > Cc: edk2-de...@ml01.01.org; Justen, Jordan L > Subject:

Re: [edk2] [PATCH 13/16] NetworkPkg: Series of patches to fix typos

Reviewed-By: Wu Jiaxin Best Regards! Jiaxin > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 7, 2016 3:48 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: [edk2] [PATCH 13/16] NetworkPkg: Series of patches to fix typos > > - abstrated to ab

Re: [edk2] [PATCH 4/4] OvmfPkg: add PciHotPlugInitDxe

On 07/08/16 01:38, Jordan Justen wrote: > On 2016-07-07 15:55:34, Ni, Ruiyu wrote: >> I vote for separate driver:) it's more clean and easy to maintain. >> > > (sigh) I guess that is the nature of EDK II. Big, but modular! :) It's > not like this decision is going to make OVMF compete with seabios

Re: [edk2] [PATCH 4/4] OvmfPkg: add PciHotPlugInitDxe

On 2016-07-07 15:55:34, Ni, Ruiyu wrote: > I vote for separate driver:) it's more clean and easy to maintain. > (sigh) I guess that is the nature of EDK II. Big, but modular! :) It's not like this decision is going to make OVMF compete with seabios on size or speed, so: Acked-by: Jordan Justen

Re: [edk2] [PATCH 4/4] OvmfPkg: add PciHotPlugInitDxe

I vote for separate driver:) it's more clean and easy to maintain. Thanks, Ray > 在 2016年7月8日，上午1:59，Laszlo Ersek 写道： > >> On 07/07/16 19:36, Jordan Justen wrote: >>> On 2016-06-30 18:10:53, Laszlo Ersek wrote: >>> +EFI_STATUS >>> +EFIAPI >>> +DriverInitialize ( >>> + IN EFI_HANDLE ImageH

Re: [edk2] Firmware Management Protocol: CHAR16* fields in EFI_FIRMWARE_IMAGE_DESCRIPTOR

Hey Andrew, I have missed that it's not about the protocol directly, but about a returned data structure, so please excuse me! Thanks, Marvin. > -Original Message- > From: af...@apple.com [mailto:af...@apple.com] > Sent: Thursday, July 7, 2016 10:33 PM > To: Marvin H?user > Cc: edk2-de

Re: [edk2] Firmware Management Protocol: CHAR16* fields in EFI_FIRMWARE_IMAGE_DESCRIPTOR

On 7/7/2016 2:06 PM, Andrew Fish wrote: Probably worth brining it up with the UEFI Forum. Thanks, I've just emailed them. -- Bruce ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Firmware Management Protocol: CHAR16* fields in EFI_FIRMWARE_IMAGE_DESCRIPTOR

On 7/7/2016 2:27 PM, Marvin H?user wrote: I don't think these strings can ever be statically allocated. If pointers to stack variables were used, the strings would be theoretically invalid the moment the exposing function returns. Furthermore they can't be part oft he struct itself as that wo

Re: [edk2] Firmware Management Protocol: CHAR16* fields in EFI_FIRMWARE_IMAGE_DESCRIPTOR

> On Jul 7, 2016, at 1:27 PM, Marvin H?user wrote: > > Hey Bruce, > > Sorry if I am wasting your time, but where exactly is the problem? > > I don't think these strings can ever be statically allocated. If pointers to > stack variables were used, the strings would be theoretically invalid the

Re: [edk2] Firmware Management Protocol: CHAR16* fields in EFI_FIRMWARE_IMAGE_DESCRIPTOR

Hey Bruce, Sorry if I am wasting your time, but where exactly is the problem? I don't think these strings can ever be statically allocated. If pointers to stack variables were used, the strings would be theoretically invalid the moment the exposing function returns. Furthermore they can't be pa

Re: [edk2] Firmware Management Protocol: CHAR16* fields in EFI_FIRMWARE_IMAGE_DESCRIPTOR

> On Jul 7, 2016, at 12:35 PM, Bruce Cran wrote: > > Before I go hassling the USWG, I thought I'd check here in case anyone knows. > > In the Firmware Management Protocol introduced in UEFI 2.3, there's a > EFI_FIRMWARE_IMAGE_DESCRIPTOR structure that has two CHAR16* fields, > 'ImageIdName' a

Re: [edk2] [PATCH 4/4] OvmfPkg/PlatformPei: program MSR_IA32_FEATURE_CONTROL from fw_cfg

On 07/07/16 21:10, Laszlo Ersek wrote: > Under certain circumstances, QEMU exposes the "etc/msr_feature_control" > fw_cfg file, with a 64-bit little endian value. The firmware is supposed > to write this value to MSR_IA32_FEATURE_CONTROL (0x3a), on all processors, > on the normal and the S3 resume

[edk2] Firmware Management Protocol: CHAR16* fields in EFI_FIRMWARE_IMAGE_DESCRIPTOR

Before I go hassling the USWG, I thought I'd check here in case anyone knows. In the Firmware Management Protocol introduced in UEFI 2.3, there's a EFI_FIRMWARE_IMAGE_DESCRIPTOR structure that has two CHAR16* fields, 'ImageIdName' and 'VersionName'. The UEFI spec doesn't say anything about me

[edk2] [PATCH 0/4] OvmfPkg: program MSR_IA32_FEATURE_CONTROL from fw_cfg on all processors

This series fixes : RFE: OvmfPkg: Set MSR_IA32_FEATURE_CONTROL by following QEMU fw_cfg file The Request for Enhancement is very detailed (thankfully), so I will not copy details here. I will describe the patch series in brief: Patches #1 and #2 enabl

[edk2] [PATCH 2/4] OvmfPkg: increase the S3 permanent PEI RAM size by 8.5 MB

When setting PcdCpuMaxLogicalProcessorNumber to 255, then CpuMpPei seems to require a bit more than 8MB of permanent PEI RAM in the PrepareAPStartupVector() function. (With the default PCD value of 64, it needs one quarter of that: approximately 2MB.) On the S3 resume path, we install only 32 KB o

[edk2] [PATCH 3/4] OvmfPkg: include UefiCpuPkg/CpuMpPei

In the next patch we're going to put EFI_PEI_MP_SERVICES_PPI to use. CpuMpPei uses the following PCDs from gUefiCpuPkgTokenSpaceGuid, beyond those already used by CpuDxe: - PcdCpuMicrocodePatchAddress and PcdCpuMicrocodePatchRegionSize: these control whether CpuMpPei performs microcode update.

[edk2] [PATCH 4/4] OvmfPkg/PlatformPei: program MSR_IA32_FEATURE_CONTROL from fw_cfg

Under certain circumstances, QEMU exposes the "etc/msr_feature_control" fw_cfg file, with a 64-bit little endian value. The firmware is supposed to write this value to MSR_IA32_FEATURE_CONTROL (0x3a), on all processors, on the normal and the S3 resume boot paths. Utilize EFI_PEI_MPSERVICES_PPI to

[edk2] [PATCH 1/4] OvmfPkg/PlatformPei: create one memory HOB at S3 resume too, for CpuMpPei

CpuMpPei will have to place the AP startup vector in memory under 1MB. For this, CpuMpPei borrows memory under 1MB, but it needs a memory resource descriptor HOB to exist there even on the S3 resume path (see the GetWakeupBuffer() function). Produce such a HOB as an exception on the S3 resume path.

Re: [edk2] multiprocessing in PEI?

On 07/07/16 20:02, Kinney, Michael D wrote: > Laszlo, > > Good feedback. As I mentioned earlier, we are cleaning up these modules. We > can make sure everything is consistent for the "borrow" case. > > I agree it would be better to "borrow" a page that is not being used by > any other PEIM. We

Re: [edk2] [PATCH 06/16] StdLib: Series of patches to fix typos - availabe to available

Thanks Daryl. These seem to be implementation typos. I just cross checked in spec and it looks good. Thanks, -Giri > -Original Message- > From: Daryl McDaniel [mailto:edk2-li...@mc2research.org] > Sent: Thursday, July 7, 2016 9:42 AM > To: Carsey, Jaben ; Mudusuru, Giri P > ; edk2-devel@

Re: [edk2] multiprocessing in PEI?

Laszlo, Good feedback. As I mentioned earlier, we are cleaning up these modules. We can make sure everything is consistent for the "borrow" case. I agree it would be better to "borrow" a page that is not being used by any other PEIM. We will consider ASSERT() if there is no free memory. Mike

Re: [edk2] [PATCH 4/4] OvmfPkg: add PciHotPlugInitDxe

On 07/07/16 19:36, Jordan Justen wrote: > On 2016-06-30 18:10:53, Laszlo Ersek wrote: >> +EFI_STATUS >> +EFIAPI >> +DriverInitialize ( >> + IN EFI_HANDLE ImageHandle, >> + IN EFI_SYSTEM_TABLE *SystemTable >> + ) >> +{ >> + EFI_STATUS Status; >> + >> + if (!FeaturePcdGet (PcdPciBusHotplug

Re: [edk2] UEFI driver for USB CDC ACM Serial device

Thanks Feng. Even I felt the same way. Just wanted to know if there is any other such, more nearer driver available in UEFI for USB to serial or USB CDC driver source code? Please confirm... If not, I will go with ftdi driver. Thanks. With regards, Keshava On 7 ಜು., 2016 ಗು. 12:48 PM Tian, Feng

Re: [edk2] multiprocessing in PEI?

On 07/07/16 19:33, Kinney, Michael D wrote: > Laszlo, > > If all memory below 640K is allocated for use by other PEIMs, the "borrow" > technique can still work > for the CpuMpPeim. > > If we add the scanning code for 2B, we will just ignore the result anyways if > all memory below > 640K is al

Re: [edk2] [PATCH 4/4] OvmfPkg: add PciHotPlugInitDxe

On 2016-06-30 18:10:53, Laszlo Ersek wrote: > +EFI_STATUS > +EFIAPI > +DriverInitialize ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ) > +{ > + EFI_STATUS Status; > + > + if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) { > +DEBUG ((EFI_D_WARN, > +

Re: [edk2] multiprocessing in PEI?

Laszlo, If all memory below 640K is allocated for use by other PEIMs, the "borrow" technique can still work for the CpuMpPeim. If we add the scanning code for 2B, we will just ignore the result anyways if all memory below 640K is already allocated. So we will add logic with no value. I think

[edk2] [PATCH] ArmPkg/ArmGicLib: manage GICv3 SPI state at the distributor

Unlike SGIs and PPIs, which are private to the CPU and are managed at the redistributor level (which is also a per-CPU construct), shared interrupts (SPIs) are shared between all CPUs, and therefore managed at the distributor level. Reported-by: Narinder Dhillon Contributed-under: TianoCore Contr

Re: [edk2] [staging/HTTPS-TLS][PATCH 0/2] Live Certificate support and code refine.

Jiaxin, This is a nice feature but we need to add a setting to control whether to throw up a prompt in the first place. I can imagine our enterprise customers only ever wanting to trust the root certificates that they installed. In case of a UEFI script running, they would not want th

Re: [edk2] [PATCH 0/4] PCI resource reservation changes for better hotpluggability

Ping -- do you guys (esp. package maintainers) have any further feedback for this series? Presently I have one R-b from Ray for patch #1. Two MdeModulePkg patches plus one OvmfPkg patch need reviews. I have two small changes queued already for v2 (noted in the thread) -- if you would like to see

Re: [edk2] [PATCH] ArmPlatformPkg: Set Juno debug serial port defaults

On Thu, Jul 07, 2016 at 05:24:54PM +0100, Ryan Harkin wrote: > On 7 July 2016 at 17:01, Ryan Harkin wrote: > > On 7 July 2016 at 16:59, Leif Lindholm wrote: > >> On Fri, Jul 01, 2016 at 12:52:06PM +0100, evan.ll...@arm.com wrote: > >>> From: Evan Lloyd > >>> > >>> Juno has several serial ports,

Re: [edk2] [PATCH 06/16] StdLib: Series of patches to fix typos - availabe to available

Someone should also check the UEFI file where these return values are defined and make sure that the typo isn't there too. Reviewed-by: Daryl McDaniel Daryl McDaniel > -Original Message- > From: Carsey, Jaben [mailto:jaben.car...@intel.com] > Sent: Thursday, July 07, 2016 7:47 AM > To

Re: [edk2] [PATCH] ArmPlatformPkg: Set Juno debug serial port defaults

On 7 July 2016 at 17:01, Ryan Harkin wrote: > On 7 July 2016 at 16:59, Leif Lindholm wrote: >> On Fri, Jul 01, 2016 at 12:52:06PM +0100, evan.ll...@arm.com wrote: >>> From: Evan Lloyd >>> >>> Juno has several serial ports, one of which may be used for a remote >>> debug interface (e.g. gdb, WinD

Re: [edk2] [PATCH] ArmPlatformPkg: Set Juno debug serial port defaults

On Fri, Jul 01, 2016 at 12:52:06PM +0100, evan.ll...@arm.com wrote: > From: Evan Lloyd > > Juno has several serial ports, one of which may be used for a remote > debug interface (e.g. gdb, WinDbg). The debug serial port needs to > be distinct from that used for UEFI trace to prevent corruption o

Re: [edk2] [PATCH] ArmPlatformPkg: Set Juno debug serial port defaults

On 7 July 2016 at 16:59, Leif Lindholm wrote: > On Fri, Jul 01, 2016 at 12:52:06PM +0100, evan.ll...@arm.com wrote: >> From: Evan Lloyd >> >> Juno has several serial ports, one of which may be used for a remote >> debug interface (e.g. gdb, WinDbg). The debug serial port needs to >> be distinct

Re: [edk2] [PATCH 0/7] Introduce three new toolchains in edk2

On 7 July 2016 at 17:36, Shi, Steven wrote: > Please review my new commits in public branch: > https://github.com/shijunjing/edk2/commits/review6 > I'm sorry, but that is not how it works. You need to send them to the mailing list. Also, please put v2 (or v3 or whatever) in the subject so it is

Re: [edk2] [PATCH 1/7] BaseTools: Enable three new toolchains

Hi Jordan, I've separated this patch to 3 commits and post a public branch for them: https://github.com/shijunjing/edk2/commits/review6 . Please take a look. Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522 > -Original Message- > From: Shi, Steven > Sent: Mo

[edk2] [PATCH 0/7] Introduce three new toolchains in edk2

Please review my new commits in public branch: https://github.com/shijunjing/edk2/commits/review6 I did below enhancements according feedback: 1. Remove the Quark platform work around and code clean work from this serial patches. 2. Seperate three toolchains to three different patches. 3. Seperat

Re: [edk2] [PATCH] ArmPlatformPkg: Set Juno debug serial port defaults

On 1 July 2016 at 13:52, wrote: > From: Evan Lloyd > > Juno has several serial ports, one of which may be used for a remote > debug interface (e.g. gdb, WinDbg). The debug serial port needs to > be distinct from that used for UEFI trace to prevent corruption of > debugger protocol messaging. >

Re: [edk2] [PATCH v1 1/1] ShellPkg:Ping: Ping command hangs with intermittent packet losses

Reviewed-by: Jaben Carsey And push. 80f7a8f5f9d21f8315d39be0f5651ce7160594fc > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Subramanian, Sriram (EG Servers Platform SW) > Sent: Thursday, July 07, 2016 1:14 AM > To: Hegde, Nagaraj P ; edk2-

Re: [edk2] [PATCH] add top-level .gitattributes file, dealing with .depex

On 07/07/16 16:24, Leif Lindholm wrote: > Git tends to see .depex files as text, causing hideous patches being > generated (and breaking PatchCheck.py). > > Add a .gitattributes file instructing git to treat them as binary. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-

Re: [edk2] [PATCH 1/2] Revert "ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable"

On 7 July 2016 at 06:36, Ruiyu Ni wrote: > This reverts commit e36ed7a84b2768443de22371f0aad5cf502328b1. > The above commit fixed a build failure in > "ShellPkg: Make the USB mouse behavior in 'edit' consistent with > 'hexedit'.". > Since the next patch will revert the USB mouse behavior fix, > th

Re: [edk2] [PATCH 16/16] ShellPkg: Series of patches to fix typos - apropriate to appropriate

Reviewed-by: Jaben Carsey > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 07, 2016 12:48 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Qiu, Shumin > > Subject: [edk2] [PATCH 16/16] ShellPkg: Series of patches to fix typos - > apropriate to appropriate > Impo

Re: [edk2] [PATCH 06/16] StdLib: Series of patches to fix typos - availabe to available

Reviewed-by: Jaben Carsey > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 07, 2016 12:48 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Daryl McDaniel li...@mc2research.org> > Subject: [edk2] [PATCH 06/16] StdLib: Series of patches to fix typos - > availabe

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

We should see why If and Else are using this different API for sure. I don't remember why. I would be happy to remove it completely if there is no objection. -Jaben > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, July 07, 2016 1:20 AM > To: Carsey, Jaben > Cc: Carsey, Jaben ;

Re: [edk2] [PATCH 1/2] Revert "ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable"

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Wednesday, July 06, 2016 9:37 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Gao, Liming ; Ard > Biesheuvel > Subject: [edk2] [PATCH 1/2] Revert

Re: [edk2] [PATCH 2/2] Revert "ShellPkg: Make the USB mouse behavior in 'edit' consistent with 'hexedit'."

Hehe... no problem. Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, July 06, 2016 9:52 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [PATCH 2/2] Revert "ShellPkg: Make the USB mouse behavior in > 'edit' consistent with 'hexedit'.

[edk2] [PATCH] add top-level .gitattributes file, dealing with .depex

Git tends to see .depex files as text, causing hideous patches being generated (and breaking PatchCheck.py). Add a .gitattributes file instructing git to treat them as binary. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- .gitattributes | 1 + 1 file c

Re: [edk2] Intel FSP Firmware Volume content

Hi Marvin I'm also starting my studies on FSP, but I think I can help with at least one of the questions. About the two Sec cores. The existence of two sec cores represents what is called "FSP Normal Boot" There is the main sec core, and another sec core that is placed inside the FspInitPei. They

Re: [edk2] Build fails due to missing NASM

Hi Laszlo, I agree that being on this list helps a lot in different ways. In my opinion the main benefit of a mailing lists is the room for discussion. Results of discussions should then be placed into the documentation. So further on, no one have to read the discussion in the archive again beca

Re: [edk2] Build fails due to missing NASM

Hi Liming, yes, that would be great. Thank you. Peter -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Thursday, July 07, 2016 11:22 AM To: Kirmeier, Peter; edk2-devel@lists.01.org Subject: RE: Build fails due to missing NASM Peter: Thanks for your suggestion.

Re: [edk2] [PATCH 1/7] BaseTools: Enable three new toolchains

On Tue, Jun 28, 2016 at 4:18 PM, Shi, Steven wrote: > +DEFINE CLANG38_ALL_CC_FLAGS = -c -fshort-wchar -fno-strict-aliasing > -Wall -Werror -Wno-array-bounds -Wno-empty-body -ffunction-sections > -fdata-sections -include AutoGen.h -DSTRING_ARRAY_NAME=$(BASE_NAME)Strings > -fno-stack-protecto

[edk2] [Patch] Vlv2TbltDevicePkg:Fixed system can't save time when RTC power failure.

This patch re-implemented SetTime runtime service for special usage on MinnowBoard Max which may have no RTC battery present. While user sets system time, SetTime service not only sets the time into RTC, but also saves it in UEFI variable. The next time when power failure occurred and RTC system

Re: [edk2] [PATCH 01/16] ArmPkg: Series of patches to fix typos

On 7 July 2016 at 09:47, Giri P Mudusuru wrote: > - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Giri P Mudusuru Reviewed-by: Ard Biesheuvel > --- > ArmPkg/Drivers/CpuDxe/CpuDxe.c |

Re: [edk2] Build fails due to missing NASM

On 07/07/16 11:08, peter.kirme...@ts.fujitsu.com wrote: > Hi Liming, > > yes I see, but there are lots of people not reading every single > patch note of this email list or don't even are part of the list. People who consume edk2 (even as proprietary downstreams) should definitely be on this list

Re: [edk2] Build fails due to missing NASM

Peter: Thanks for your suggestion. I think we can add the dependency check in edksetup.bat/edksetup.sh. If nasm is not installed, setup script will report warning message to user. Meanwhile, we can update wiki https://github.com/tianocore/tianocore.github.io/wiki/Getting%20Started%20with%20EDK

Re: [edk2] multiprocessing in PEI?

On 07/07/16 10:56, Fan, Jeff wrote: > Laszlo, > > Any PEI module cannot allocate the memory < 1MB range if using PEI memory > allocation services only. Okay. > If other PEI module wants to allocate the memory by scanning memory resource > HOB, it has to follow the same rule with the CpuMpPei d

Re: [edk2] Build fails due to missing NASM

Hi Liming, yes I see, but there are lots of people not reading every single patch note of this email list or don't even are part of the list. However, also newcomers who don't know the past (or this email list at all) won't know anything about such changes happening in the background. Therefore

  1   2   >