Re: [edk2] [patch 0/3] TcpDriver use EFI_D_NET for DEBUG maessage

2016-09-22 Thread Subramanian, Sriram (EG Servers Platform SW)
Series Reviewed-by: Sriram Subramanian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Friday, September 23, 2016 11:10 AM To: edk2-devel@lists.01.org Subject: [edk2] [patch 0/3] TcpDriver use EFI_D_NET for

[edk2] [patch 3/3] MdePkg:Correct the comment for the DEBUG_NET.

2016-09-22 Thread Zhang Lubo
Generalize the comment for the DEBUG_NET #define DEBUG_NET 0x4000 // SNP Driver to Network IO Driver. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Cc: Hegde Nagaraj P Cc: Subramanian Sriram

[edk2] [patch 2/3] MdeModulePkg:TcpDriver need to use EFI_D_NET for DEBUG maessage.

2016-09-22 Thread Zhang Lubo
Tcp driver need to use EFI_D_NET to log DEBUG message, So it becomes easy to separate/filter out debug messages from network stack versus generic EFI_D_INFO debugs. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Cc: Hegde Nagaraj P

[edk2] [patch 1/3] NetworkPkg: TcpDriver use EFI_D_NET for DEBUG maessage.

2016-09-22 Thread Zhang Lubo
Tcp driver need to use EFI_D_NET to log DEBUG message, So it becomes easy to separate/filter out debug messages from network stack versus generic EFI_D_INFO debugs. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Cc: Hegde Nagaraj P

[edk2] [patch 0/3] TcpDriver use EFI_D_NET for DEBUG maessage

2016-09-22 Thread Zhang Lubo
Zhang Lubo (3): NetworkPkg: TcpDriver use EFI_D_NET for DEBUG maessage. MdeModulePkg:TcpDriver need to use EFI_D_NET for DEBUG maessage. MdePkg:Correct the comment for the DEBUG_NET. MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.c | 46 +++---

Re: [edk2] [PATCH] MdePkg/BaseMemoryLibOptDxe ARM AARCH64: fix thinko in SetMem##

2016-09-22 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, September 22, 2016 4:54 PM > To: edk2-devel@lists.01.org; Gao, Liming > Cc: ler...@redhat.com; leif.lindh...@linaro.org;

Re: [edk2] [PATCH] MdePkg/BaseMemoryLibOptDxe ARM AARCH64: fix thinko in SetMem##

2016-09-22 Thread Laszlo Ersek
On 09/22/16 10:54, Ard Biesheuvel wrote: > The new InternalMemSetMem##() implementations for ARM and AARCH64 in > BaseMemoryLibOptDxe fail to take into account that the 'length' argument > is not in bytes, but in number of items to be copied. So multiply by the > item size before proceeding. > >

Re: [edk2] Help Required legacy booting from an EFI

2016-09-22 Thread Laszlo Ersek
On 09/22/16 13:25, Saqib Khan wrote: > okay so i started with "MdeModulePkg\Application\BootManagerMenuApp" > addded follwoing package in inf file > > 1. IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec > 2. IntelFrameworkPkg/IntelFrameworkPkg.dec > > and follwing libraries > > 1.

[edk2] [PATCH v2] MdeModulePkg FormBrowserEx: Change its structure name with EDKII_ prefix

2016-09-22 Thread Liming Gao
EDKII implementation protocol should be with EDKII_ prefix. V2: add gEdkiiFormBrowserExProtocolGuid to align its structure name. Cc: Eric Dong Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao

Re: [edk2] [PATCH 00/45] Add capsule update and recovery sample.

2016-09-22 Thread Gao, Liming
Jiewen: In MdeModulePkg, the below INF files have wrong PPI/Protocol/PCD usages. Please correct them. MdeModulePkg\Universal\SystemBiosUpdate\SystemBiosReportDxe.inf MdeModulePkg\Universal\RecoveryModuleLoadPei\RecoveryModuleLoadPei.inf

Re: [edk2] [PATCH] NetworkPkg: Fix RSOD issue in Ip6Dxe

2016-09-22 Thread Wu, Jiaxin
Gary, Can you make a detail description about the issue? Forgive my ignorance, I don't know 'RSOD' exactly mean here. > Avoid the Ip6NdFasterTimerTicking is executed again before the previous > Ip6NdFasterTimerTicking is done. > When user presses hotkey between the below line, it makes the

Re: [edk2] NOOPT OVMF build (or otherwise with optimizations disabled)

2016-09-22 Thread Gao, Liming
Thanks! Ok for yonghong. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, September 23, 2016 10:44 AM > To: Gao, Liming ; Bruce Cran ; > edk2-de...@ml01.01.org > Cc: Ard Biesheuvel ;

Re: [edk2] NOOPT OVMF build (or otherwise with optimizations disabled)

2016-09-22 Thread Zhu, Yonghong
Yes, I will follow up. Best Regards, Zhu Yonghong -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, September 23, 2016 10:44 AM To: Gao, Liming ; Bruce Cran ; edk2-de...@ml01.01.org Cc: Ard Biesheuvel

Re: [edk2] NOOPT OVMF build (or otherwise with optimizations disabled)

2016-09-22 Thread Laszlo Ersek
On 09/22/16 06:52, Gao, Liming wrote: > Laszlo: > Yes. GCC tool chain has no NOOPT setting in tools_def.txt. Could you > help submit one bug in Bugzilla? I filed . Since all (open?) BaseTools BZs seem to be assigned to Yonghong at the moment, I

Re: [edk2] [PATCH] SecurityPkg Tcg2Pei: Fix GCC build failure caused by 5919a9600e07

2016-09-22 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star Zeng > Sent: Friday, September 23, 2016 10:07 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zhang, Chao B >

Re: [edk2] [Patch] BaseTools: handling the case that map file is not exist

2016-09-22 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Thursday, September 22, 2016 9:57 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2]

[edk2] [PATCH] ArmPkg/Library/ArmDmaLib: Deallocate Map buffer in case of error

2016-09-22 Thread Daniil Egranov
The patch is fixing memory leak in case of errors. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daniil Egranov --- ArmPkg/Library/ArmDmaLib/ArmDmaLib.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[edk2] [PATCH 2/2] ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe: Fix for PCI Dual Address Cycle

2016-09-22 Thread Daniil Egranov
The fix handles the PCI Dual Address Cycle Attribute case. It allows drivers using PCI DAC run on Juno. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daniil Egranov --- .../ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c | 9

[edk2] [PATCH 0/2] Juno PCI fixes

2016-09-22 Thread Daniil Egranov
The patches fixing the case where driver is using PCI DAC and replacing PCI DMA related calls to the ArmDmaLib with their Null implementations as the PCI on Juno is DMA coherent. Daniil Egranov (2): ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe: Remove dependency on ArmDmaLib

[edk2] [PATCH 1/2] ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe: Remove calls to ArmDmaLib

2016-09-22 Thread Daniil Egranov
The PCI on Juno is DMA coherent, which means it should not be using ArmDmaLib for PCI DMA. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daniil Egranov --- ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf | 2 +- 1 file

Re: [edk2] [PATCH] NetworkPkg: Fix RSOD issue in Ip6Dxe

2016-09-22 Thread Li, Gary (HPS SW)
Hi Ting, This issue can be reproduce by switching POST hotkey quickly and repeatedly. Regards, Gary Li Platform SW Engineering Servers Office: +886 (2) 8722 9977 -Original Message- From: Ye, Ting [mailto:ting...@intel.com] Sent: Thursday, September 22, 2016 4:48 PM To: Li, Gary (HPS

Re: [edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Pete Batard
Hi Andrew, On 2016.09.22 21:27, Andrew Fish wrote: It seems like tracking the PUSHes would work? First of all, as got pointed out by Ard, I need to mention that much of my earlier analysis results, which you quoted, were due to a misread of the specs, as it does mandates pushing 32 bit

Re: [edk2] [PATCH] ShellPkg: Add '-nc' flag support in 'disconnect' command

2016-09-22 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey And commited. > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Thursday, September 22, 2016 12:49 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Tapan Shah >

Re: [edk2] [PATCH] ShellPkg: Expand special output file to include "NULL" and case insensitive

2016-09-22 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey And commited. > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Thursday, September 22, 2016 12:13 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Tapan Shah >

Re: [edk2] [PATCH] ShellPkg: Remove current working dir path ".; " from 'path' variable

2016-09-22 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey And commited. > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Wednesday, September 21, 2016 2:30 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Tapan Shah >

Re: [edk2] [PATCH] ShellPkg: Add Persistent Memory support in 'memmap' command

2016-09-22 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey And commited. > -Original Message- > From: Shah, Tapan [mailto:tapands...@hpe.com] > Sent: Thursday, September 22, 2016 2:15 PM > To: Carsey, Jaben ; edk2-devel@lists.01.org > Subject: RE: [PATCH] ShellPkg: Add

Re: [edk2] [PATCH] ShellPkg: Add Persistent Memory support in 'memmap' command

2016-09-22 Thread Carsey, Jaben
Can you reply with your attestation and signed off by lines? > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Thursday, September 22, 2016 1:16 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Tapan Shah > >

[edk2] [RFC V2] EDK2 Platform Proposal

2016-09-22 Thread Kinney, Michael D
Hello, Here is the V2 version of the proposal for the edk2-platforms repo. Changes from V1: * edk2-platform is not a fork of edk2. * edk2-platforms branches contain CPU, Chipset, SoC, and platform specific packages * edk2-plaforms/master contains all open platforms

Re: [edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Andrew Fish
> On Sep 22, 2016, at 4:05 AM, Pete Batard wrote: > > On 2016.09.22 11:06, Ard Biesheuvel wrote: >> However, there is a fundamental issue with EBC on ARM that has not >> been addressed yet, which makes EBC support problematic: >> ARM uses natural alignment for 64-bit types, which

[edk2] [PATCH] ShellPkg: Add Persistent Memory support in 'memmap' command

2016-09-22 Thread Tapan Shah
As per ECR 1416, latest UEFI Shell 2.2 Specification has added Persistent Memory support in 'memmap' command. --- ShellPkg/Library/UefiShellDebug1CommandsLib/MemMap.c| 13 ++--- .../UefiShellDebug1CommandsLib.uni | 3 ++- 2 files changed, 12

[edk2] [PATCH] ShellPkg: Add '-nc' flag support in 'disconnect' command

2016-09-22 Thread Tapan Shah
As per ECR 1416, latest UEFI Shell 2.2 specification: Define a behavior where 'disconnect -r' will disconnect drivers from all devices but it will reconnect all consoles. If -nc flag is used (e.g. 'disconnect -r -nc') then disconnect drivers from all devices and don't reconnect consoles.

Re: [edk2] flat mapping vs identity mapping on ARM

2016-09-22 Thread valerij zaporogeci
Thank you, Ard and Andrew. ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH] ShellPkg: Expand special output file to include "NULL" and case insensitive

2016-09-22 Thread Tapan Shah
As per ECR 1349 change in UEFI Shell Specification 2.2, expanding a special output file name to include "NULL". Previously it only supported "NUL" as a special output file and it was case sensitive. With this change both "NUL" and "NULL" are special output file and checked as case insensitive.

Re: [edk2] Issues with HTTPS Boot

2016-09-22 Thread Palmer, Thomas
Naveen, I may be interpreting this OpenSSL error code incorrectly, so if anyone has experience with this please chime in ... Looking at 1.02.h, the 0x105 reason corresponds with SSL_R_WRONG_CIPHER_RETURNED. This happens in two places in s3_clnt.c. This would indicate that the TLS

Re: [edk2] [PATCH] ShellPkg: Expand special output file to include "NULL" and case insensitive

2016-09-22 Thread Carsey, Jaben
Tapan, I do not think we should tie UefiShellLib into UefiShellCommandLib. The problem is that UefiShellLib is for internal commands, the shell itself, and shell applications. The UefiShellCommandLib is only for internal commands. What amount of work would it take to keep these libraries

[edk2] [PATCH] ShellPkg: Expand special output file to include "NULL" and case insensitive

2016-09-22 Thread Tapan Shah
As per ECR 1349 change in UEFI Shell Specification 2.2, expanding a special output file name to include "NULL". Previously it only supported "NUL" as a special output file and it was case sensitive. With this change both "NUL" and "NULL" are special output file and checked as case insensitive.

Re: [edk2] flat mapping vs identity mapping on ARM

2016-09-22 Thread Andrew Fish
> On Sep 22, 2016, at 8:03 AM, Ard Biesheuvel wrote: > > On 22 September 2016 at 15:30, valerij zaporogeci > wrote: >> In the ARM architecture, there is such a thing - "flat mapping", where >> MMU stage 1 is disabled

Re: [edk2] flat mapping vs identity mapping on ARM

2016-09-22 Thread Ard Biesheuvel
On 22 September 2016 at 16:19, valerij zaporogeci wrote: > 2016-09-22 18:03 GMT+03:00, Ard Biesheuvel : >> On 22 September 2016 at 15:30, valerij zaporogeci >> wrote: >>> In the ARM architecture, there is such a thing - "flat

Re: [edk2] flat mapping vs identity mapping on ARM

2016-09-22 Thread Ard Biesheuvel
On 22 September 2016 at 16:22, Ard Biesheuvel wrote: > On 22 September 2016 at 16:19, valerij zaporogeci wrote: >> 2016-09-22 18:03 GMT+03:00, Ard Biesheuvel : >>> On 22 September 2016 at 15:30, valerij zaporogeci

Re: [edk2] Issues with HTTPS Boot

2016-09-22 Thread Samer El Haj Mahmoud
Naveen, Are you using the latest code form the edk2-staging branch? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Santhapur Naveen Sent: Thursday, September 22, 2016 7:07 AM To: Palmer, Thomas ; edk2-devel@lists.01.org

Re: [edk2] flat mapping vs identity mapping on ARM

2016-09-22 Thread Ard Biesheuvel
On 22 September 2016 at 15:30, valerij zaporogeci wrote: > In the ARM architecture, there is such a thing - "flat mapping", where > MMU stage 1 is disabled and the mapping done is 1:1 and attributes set > to the predefined values. What do you mean by 'attributes set to the

[edk2] flat mapping vs identity mapping on ARM

2016-09-22 Thread valerij zaporogeci
In the ARM architecture, there is such a thing - "flat mapping", where MMU stage 1 is disabled and the mapping done is 1:1 and attributes set to the predefined values. Did I understand right, that this is NOT what UEFI means by "identity mapping" with MMU enabled? And in the latter case there is

Re: [edk2] Issues with HTTPS Boot

2016-09-22 Thread Santhapur Naveen
Hi Thomas, Regarding your previous question about the server certificates, please find my response as below: Do you have the appropriate certificate installed in UEFI for the target TLS server? Yes, I do have the appropriate certificate installed on my server. I have followed

[edk2] [Patch] BaseTools: handling the case that map file is not exist

2016-09-22 Thread Yonghong Zhu
We meet a case that add the library inf file which has the uni file in the [Sources] section, for this case there will no map file exist, it cause build tools report Traceback error. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

Re: [edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Ard Biesheuvel
On 22 September 2016 at 12:26, Pete Batard wrote: > On 2016.09.22 12:14, Ard Biesheuvel wrote: >> >> For X64 and AARCH64, the issue does not exist because the EBC spec >> mandates that all function arguments are widened to the native word >> size. So when executing on a 64-bit

Re: [edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Pete Batard
On 2016.09.22 12:14, Ard Biesheuvel wrote: For X64 and AARCH64, the issue does not exist because the EBC spec mandates that all function arguments are widened to the native word size. So when executing on a 64-bit architecture, the EBC stack looks differently from what you describe above, and

Re: [edk2] Help Required legacy booting from an EFI

2016-09-22 Thread Saqib Khan
okay so i started with "MdeModulePkg\Application\BootManagerMenuApp" addded follwoing package in inf file 1. IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec 2. IntelFrameworkPkg/IntelFrameworkPkg.dec and follwing libraries 1. LegacyBootManagerLib 2. LegacyBootMaintUiLib and

Re: [edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Ard Biesheuvel
On 22 September 2016 at 12:05, Pete Batard wrote: > On 2016.09.22 11:06, Ard Biesheuvel wrote: >> >> However, there is a fundamental issue with EBC on ARM that has not >> been addressed yet, which makes EBC support problematic: >> ARM uses natural alignment for 64-bit types, which

Re: [edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Pete Batard
On 2016.09.22 11:06, Ard Biesheuvel wrote: However, there is a fundamental issue with EBC on ARM that has not been addressed yet, which makes EBC support problematic: ARM uses natural alignment for 64-bit types, which means it leaves gaps in the stack frame, and the thunking code has no way of

Re: [edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Ard Biesheuvel
On 22 September 2016 at 11:06, Ard Biesheuvel wrote: > On 22 September 2016 at 10:43, Pete Batard wrote: >> Hi, >> >> The following is an updated/fixed version of the patch(es), put forward by >> Ard Biesheuvel on August 9 ([1], [2]), and re-submitted for

Re: [edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Ard Biesheuvel
On 22 September 2016 at 10:43, Pete Batard wrote: > Hi, > > The following is an updated/fixed version of the patch(es), put forward by > Ard Biesheuvel on August 9 ([1], [2]), and re-submitted for formal > inclusion, so that the EDK2 can provide EBC functionality for all of IA32, >

[edk2] [PATCH 0/1] MdeModulePkg/EbcDxe: add ARM support

2016-09-22 Thread Pete Batard
Hi, The following is an updated/fixed version of the patch(es), put forward by Ard Biesheuvel on August 9 ([1], [2]), and re-submitted for formal inclusion, so that the EDK2 can provide EBC functionality for all of IA32, IA64, X64, AARCH64 and ARM at last. This updated patch now includes

[edk2] [PATCH] MdePkg/BaseMemoryLibOptDxe ARM AARCH64: fix thinko in SetMem##

2016-09-22 Thread Ard Biesheuvel
The new InternalMemSetMem##() implementations for ARM and AARCH64 in BaseMemoryLibOptDxe fail to take into account that the 'length' argument is not in bytes, but in number of items to be copied. So multiply by the item size before proceeding. Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH] NetworkPkg: Fix RSOD issue in Ip6Dxe

2016-09-22 Thread Ye, Ting
Hi Gary, Do you mind sharing more details about how to reproduce this issue? We are not clear why this would happen. It seems the code should continue executing the previous Ip6NdFasterTimerTicking function rather than dispatching the new timer event. Thanks, Ye Ting -Original

Re: [edk2] [PATCH] ArmVirtPkg: move all platforms to MdePkg/ BaseMemoryLib implementations

2016-09-22 Thread Ard Biesheuvel
On 22 September 2016 at 04:32, Laszlo Ersek wrote: > Hi Ard, > > On 09/13/16 19:28, Ard Biesheuvel wrote: >> The BaseMemoryLibStm implementation under ArmPkg/ is being deprecated, >> in favor of the generic versions under MdePkg, now that ARM and AARCH64 >> support has been

[edk2] [PATCH] NetworkPkg: Fix RSOD issue in Ip6Dxe

2016-09-22 Thread Gary Li
Avoid the Ip6NdFasterTimerTicking is executed again before the previous Ip6NdFasterTimerTicking is done. When user presses hotkey between the below line, it makes the Ip6NdFasterTimerTicking is dispatched again before the previous Ip6NdFasterTimerTicking is done. Therefore, the DelayNode node

[edk2] Tianocore Bugzilla server links updated

2016-09-22 Thread Kinney, Michael D
Hello, I have updated the links to the Tianocore Bugzilla on the Tianocore.org web site and Tianocore.org wiki pages. The new address for the Tianocore Bugzilla server is: https://bugzilla.tianocore.org I have also updated the edk2-b...@lists.01.org mailing list to forward emails from