Re: [edk2] [v3] UefiCpuPkg: Move GetProcessorLocation() to LocalApicLib library

On 10/28/16 23:17, Duran, Leo wrote: > Replies below. > Thanks. > >> -Original Message- >> From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] >> Sent: Friday, October 28, 2016 4:12 PM >> To: Duran, Leo ; edk2-devel@lists.01.org >> Cc: Gao, Liming

Re: [edk2] [v3] UefiCpuPkg: Move GetProcessorLocation() to LocalApicLib library

Replies below. Thanks. > -Original Message- > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > Sent: Friday, October 28, 2016 4:12 PM > To: Duran, Leo ; edk2-devel@lists.01.org > Cc: Gao, Liming ; ler...@redhat.com; Fan, Jeff >

Re: [edk2] [v3] UefiCpuPkg: Move GetProcessorLocation() to LocalApicLib library

Leo, I tested your patch on Quark and it builds and boots. Here is a slightly updated version of the patch that makes the following changes: * Follow Jeff Fan suggestion to pass in Package, Core, Thread as 3 parameters. This removes the dependency on PiPei.h and MpService.h from

[edk2] [PATCH] ShellPkg: print only valid characters for file overwrite prompt

When copy command prompts to overwrite an existing file, pressing backspace continuously removes everything including the shell prompt. So print only valid characters for file overwrite prompt. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tapan Shah

Re: [edk2] LocalApicLib: Why two separate directories?

On 10/28/16 21:28, Kinney, Michael D wrote: > Leo, > > Your observation is correct, but the reason not to make this change now is > the DSC file changes required that would break platform builds. As Laszlo > points out, it is possible to do this type of change and coordinate update > to all

Re: [edk2] LocalApicLib: Why two separate directories?

> -Original Message- > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > Sent: Friday, October 28, 2016 2:28 PM > To: Duran, Leo ; edk2-de...@ml01.01.org; Kinney, > Michael D > Cc: Fan, Jeff ; Gao, Liming

Re: [edk2] LocalApicLib: Why two separate directories?

Thanks Lazlo. The process as you described it makes a lot of sense. However, I worry about the effect on external consumers of EDK2 once "old" is removed. Leo. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, October 28, 2016 2:22 PM > To: Duran,

Re: [edk2] LocalApicLib: Why two separate directories?

Leo, Your observation is correct, but the reason not to make this change now is the DSC file changes required that would break platform builds. As Laszlo points out, it is possible to do this type of change and coordinate update to all platforms in edk2/master. However, there are many other

Re: [edk2] LocalApicLib: Why two separate directories?

On 10/28/16 21:03, Duran, Leo wrote: > All, > Just a quick observation to request comments: > > Since a lot of the code in BaseXApicX2ApicLib.c and BaseXApicLib is > the same, how about we merge the common code and build the libraries > from the same directory? > >

[edk2] LocalApicLib: Why two separate directories?

All, Just a quick observation to request comments: Since a lot of the code in BaseXApicX2ApicLib.c and BaseXApicLib is the same, how about we merge the common code and build the libraries from the same directory? UefiCpuPkg/Library/LocalApilLib/ - LocalApicLib.c --> common code -

Re: [edk2] [v3] UefiCpuPkg: Move GetProcessorLocation() to LocalApicLib library

On 10/28/16 19:38, Leo Duran wrote: > 1) Remove SmmGetProcessorLocation() from PiSmmCpuDxeSmm driver. > 2) Remove ExtractProcessorLocation() from MpInitLib library. > 3) Add GetProcessorLocation() to BaseXApicLib and BaseXApicX2ApicLib. > > Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [v3] UefiCpuPkg: Move GetProcessorLocation() to LocalApicLib library

1) Remove SmmGetProcessorLocation() from PiSmmCpuDxeSmm driver. 2) Remove ExtractProcessorLocation() from MpInitLib library. 3) Add GetProcessorLocation() to BaseXApicLib and BaseXApicX2ApicLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran

Re: [edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to LocalApicLib library

Sorry, the file mode looks wrong again I will fix this. Leo. > -Original Message- > From: Duran, Leo > Sent: Friday, October 28, 2016 12:08 PM > To: edk2-devel@lists.01.org > Cc: liming@intel.com; ler...@redhat.com; jeff@intel.com; > michael.d.kin...@intel.com; Duran, Leo

[edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to LocalApicLib library

1) Remove SmmGetProcessorLocation() from PiSmmCpuDxeSmm driver. 2) Remove ExtractProcessorLocation() from MpInitLib library. 3) Add GetProcessorLocation() to BaseXApicLib and BaseXApicX2ApicLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran

Re: [edk2] [shell] AliasLower never used in InternalSetAlias

I am in complete agreement. The implementation must meet the spec constraints. > -Original Message- > From: Tim Lewis [mailto:tim.le...@insyde.com] > Sent: Friday, October 28, 2016 10:04 AM > To: Carsey, Jaben ; edk2-devel@lists.01.org > Subject: RE: [shell]

Re: [edk2] [shell] AliasLower never used in InternalSetAlias

Sure. I think we should adjust the specification in this case. My problem has been when someone says "but the EDK2 version does X" Tim -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, October 28, 2016 9:59 AM To: Tim Lewis ;

Re: [edk2] [shell] AliasLower never used in InternalSetAlias

I agree with the goal of being more closely matched to the spec. I think that some things we need to adjust the spec, others we adjust the code, and others may go beyond the spec. We have no prohibition that an implementation cannot have additional features as long as they do not violate the

Re: [edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to LocalApicLib library

Reply below. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, October 28, 2016 11:38 AM > To: Duran, Leo ; edk2-de...@ml01.01.org > Cc: liming@intel.com > Subject: Re: [edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to >

Re: [edk2] [shell] AliasLower never used in InternalSetAlias

Jaben -- 1) I'm not talking about desired behavior, I'm talking about spec behavior. As an external user of GetAlias() and SetAlias() (and a non-EDK2 shell implementer), I have become aware of a number of places where the EDK2 shell makes assumptions. The spec requirement is that commands are

Re: [edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to LocalApicLib library

On 10/28/16 18:26, Leo Duran wrote: > 1) Remove SmmGetProcessorLocation() from PiSmmCpuDxeSmm driver. > 2) Remove ExtractProcessorLocation() from MpInitLib library. > 3) Add GetProcessorLocation() to BaseXApicLib and BaseXApicX2ApicLib. > > Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH] UefiCpuPkg: GetProcessorLocation()

This patch moves code that uses Intel-specific CPUID to a common library. Leo Duran (1): UefiCpuPkg: Move GetProcessorLocation() to LocalApicLib library UefiCpuPkg/Include/Library/LocalApicLib.h | 18 +++ UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c | 130 +

[edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to LocalApicLib library

1) Remove SmmGetProcessorLocation() from PiSmmCpuDxeSmm driver. 2) Remove ExtractProcessorLocation() from MpInitLib library. 3) Add GetProcessorLocation() to BaseXApicLib and BaseXApicX2ApicLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran

Re: [edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to SmmCpuFeaturesLib library.

Hi Laszlo, Quark DSC files do map the LocalApicLib, so I think the proposal to add GetProcessorLocation() to the LocalApicLib class and instances makes sense. Thanks, Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, October 28, 2016 3:29 AM >

Re: [edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to SmmCpuFeaturesLib library.

OK, the LocalApicLib patch is coming... please stay tuned. Leo. > -Original Message- > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > Sent: Friday, October 28, 2016 10:29 AM > To: Laszlo Ersek ; Fan, Jeff ; > Duran, Leo

Re: [edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to SmmCpuFeaturesLib library.

Jeff, That's exactly what I'm doing. Thanks. Leo > -Original Message- > From: Fan, Jeff [mailto:jeff@intel.com] > Sent: Friday, October 28, 2016 10:33 AM > To: Duran, Leo ; Kinney, Michael D > ; Laszlo Ersek > Cc:

Re: [edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to SmmCpuFeaturesLib library.

Leo, Please try to use the copy of GetProcessorLocation() from MpInitLib implementation. After GetProcessorLocation() added into Local APIC library, you could remove both of copies from MpInitLib and PiSmmCpuDxeSmm driver. Thanks! Jeff -Original Message- From: Duran, Leo

Re: [edk2] [PATCH] ArmPlatformPkg/ArmVExpressFastBootDxe: clean up code and comments

On 10/28/16 17:13, Ard Biesheuvel wrote: > This module contains an implementation of the Android Fastboot Platform > protocol. So follow common Tianocore practice, and duplicate the per-method > comment blocks from the interface definition into the implementation. > > In addition, let's make all

Re: [edk2] [PATCH v2 0/9] EmbeddedPkg: eliminate calls to deprecated functions

On 28 October 2016 at 11:44, Ard Biesheuvel wrote: > This series prepares EmbeddedPkg for building with the preprocess symbol > DISABLE_NEW_DEPRECATED_INTERFACES defined, by adding missing components > to EmbeddedPkg (#3), fixing broken code or code that relies on

Re: [edk2] [PATCH 1/3] ArmPkg RVCT: add ADRL/LDRL macro equivalents

On Fri, Oct 28, 2016 at 12:42:52PM +0100, Ard Biesheuvel wrote: > The GCC ARM builds have access to ADRL/LDRL macros that emit relative > symbol references, i.e., references that do not require fixing up at > load time (or FV generation time for XIP modules) > > Implement equivalent functionality

Re: [edk2] [PATCH v2 1/2] ArmPlatformPkg/ArmVExpressFastBootDxe: eliminate deprecated string functions

On Fri, Oct 28, 2016 at 04:14:43PM +0100, Ard Biesheuvel wrote: > On 28 October 2016 at 16:13, Leif Lindholm wrote: > > On Fri, Oct 28, 2016 at 04:02:21PM +0100, Ard Biesheuvel wrote: > >> On 28 October 2016 at 15:48, Leif Lindholm > >> wrote:

Re: [edk2] [PATCH] ArmPlatformPkg/ArmVExpressFastBootDxe: clean up code and comments

On Fri, Oct 28, 2016 at 04:13:17PM +0100, Ard Biesheuvel wrote: > This module contains an implementation of the Android Fastboot Platform > protocol. So follow common Tianocore practice, and duplicate the per-method > comment blocks from the interface definition into the implementation. > > In

Re: [edk2] [PATCH 3/3] ArmPkg: remove LoadConstantXxx() asm macros

On Fri, Oct 28, 2016 at 12:42:54PM +0100, Ard Biesheuvel wrote: > This is ancient cruft that is no longer used, so remove it. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

Re: [edk2] [PATCH 2/3] ArmPlatformPkg/PrePi RVCT: use relative reference to mSystemMemoryEnd

On Fri, Oct 28, 2016 at 12:42:53PM +0100, Ard Biesheuvel wrote: > Bring the RVCT version of the PrePi entry point code in line with the > GCC version, by using a relative rather than an absolute reference to > the mSystemMemoryEnd variable. > > Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH v2 1/2] ArmPlatformPkg/ArmVExpressFastBootDxe: eliminate deprecated string functions

On 28 October 2016 at 16:13, Leif Lindholm wrote: > On Fri, Oct 28, 2016 at 04:02:21PM +0100, Ard Biesheuvel wrote: >> On 28 October 2016 at 15:48, Leif Lindholm wrote: >> > On Fri, Oct 28, 2016 at 11:48:40AM +0100, Ard Biesheuvel wrote: >> >>

Re: [edk2] [PATCH v2 1/2] ArmPlatformPkg/ArmVExpressFastBootDxe: eliminate deprecated string functions

On Fri, Oct 28, 2016 at 04:02:21PM +0100, Ard Biesheuvel wrote: > On 28 October 2016 at 15:48, Leif Lindholm wrote: > > On Fri, Oct 28, 2016 at 11:48:40AM +0100, Ard Biesheuvel wrote: > >> Get rid of functions that are no longer available when defining > >>

[edk2] [PATCH] ArmPlatformPkg/ArmVExpressFastBootDxe: clean up code and comments

This module contains an implementation of the Android Fastboot Platform protocol. So follow common Tianocore practice, and duplicate the per-method comment blocks from the interface definition into the implementation. In addition, let's make all methods and the procotol struct STATIC, given that

Re: [edk2] [PATCH v2 1/2] ArmPlatformPkg/ArmVExpressFastBootDxe: eliminate deprecated string functions

On 28 October 2016 at 15:48, Leif Lindholm wrote: > On Fri, Oct 28, 2016 at 11:48:40AM +0100, Ard Biesheuvel wrote: >> Get rid of functions that are no longer available when defining >> DISABLE_NEW_DEPRECATED_INTERFACES >> >> Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH v2 2/2] ArmPlatformPkg/BootMonFs: eliminate deprecated string functions

On Fri, Oct 28, 2016 at 11:48:41AM +0100, Ard Biesheuvel wrote: > Get rid of functions that are no longer available when defining > DISABLE_NEW_DEPRECATED_INTERFACES > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH v2 1/2] ArmPlatformPkg/ArmVExpressFastBootDxe: eliminate deprecated string functions

On Fri, Oct 28, 2016 at 11:48:40AM +0100, Ard Biesheuvel wrote: > Get rid of functions that are no longer available when defining > DISABLE_NEW_DEPRECATED_INTERFACES > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH v2 8/9] EmbeddedPkg/MmcDxe: eliminate deprecated string function calls

On Fri, Oct 28, 2016 at 11:44:37AM +0100, Ard Biesheuvel wrote: > Get rid of calls to unsafe string functions. These are deprecated and may > be removed in the future. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH v2 9/9] EmbeddedPkg: enable -DDISABLE_NEW_DEPRECATED_INTERFACES

On Fri, Oct 28, 2016 at 11:44:38AM +0100, Ard Biesheuvel wrote: > Define DISABLE_NEW_DEPRECATED_INTERFACES on the compiler command line by > default, to prevent deprecated interfaces from being used in core EDK2 > code. > > Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=164 >

Re: [edk2] [PATCH v2 7/9] EmbeddedPkg/EfiFileLib: eliminate deprecated string function calls

On Fri, Oct 28, 2016 at 11:44:36AM +0100, Ard Biesheuvel wrote: > Get rid of calls to unsafe string functions. These are deprecated and may > be removed in the future. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel >

Re: [edk2] [PATCH v2 2/2] ArmPlatformPkg/BootMonFs: eliminate deprecated string functions

On 10/28/16 12:48, Ard Biesheuvel wrote: > Get rid of functions that are no longer available when defining > DISABLE_NEW_DEPRECATED_INTERFACES > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to SmmCpuFeaturesLib library.

Jeff, et al, Do we also remove GetProcessorLocation() from MpInitLib? Leo > -Original Message- > From: Fan, Jeff [mailto:jeff@intel.com] > Sent: Thursday, October 27, 2016 11:43 PM > To: Duran, Leo ; Kinney, Michael D > ;

Re: [edk2] [PATCH v2 6/9] EmbeddedPkg/Ebl: eliminate deprecated string function calls

On Fri, Oct 28, 2016 at 11:44:35AM +0100, Ard Biesheuvel wrote: > Get rid of calls to unsafe string functions. These are deprecated and may > be removed in the future. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH v2 1/2] ArmPlatformPkg/ArmVExpressFastBootDxe: eliminate deprecated string functions

On 10/28/16 12:48, Ard Biesheuvel wrote: > Get rid of functions that are no longer available when defining > DISABLE_NEW_DEPRECATED_INTERFACES > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH v2 5/9] EmbeddedPkg/AndroidFastboot: eliminate deprecated string function calls

On 10/28/16 15:52, Leif Lindholm wrote: > On Fri, Oct 28, 2016 at 02:40:59PM +0100, Ard Biesheuvel wrote: >> On 28 October 2016 at 14:36, Leif Lindholm wrote: >>> On Fri, Oct 28, 2016 at 11:44:34AM +0100, Ard Biesheuvel wrote: Get rid of calls to unsafe string

Re: [edk2] [PATCH v2 5/9] EmbeddedPkg/AndroidFastboot: eliminate deprecated string function calls

On 28 October 2016 at 14:52, Leif Lindholm wrote: > On Fri, Oct 28, 2016 at 02:40:59PM +0100, Ard Biesheuvel wrote: >> On 28 October 2016 at 14:36, Leif Lindholm wrote: >> > On Fri, Oct 28, 2016 at 11:44:34AM +0100, Ard Biesheuvel wrote: >> >>

Re: [edk2] [RFC] [MdePkg] UefiLib: CreatePopUp

Hi Eric, My goal is to facilitate CreatePopUp customization. Since UI is one of the most customizable areas in the firmware projects, an ability to easily replace UI element would be useful. Thank you for providing the presentation. I agree with the problem statement. It describes some of the

Re: [edk2] [PATCH v2 5/9] EmbeddedPkg/AndroidFastboot: eliminate deprecated string function calls

On Fri, Oct 28, 2016 at 02:40:59PM +0100, Ard Biesheuvel wrote: > On 28 October 2016 at 14:36, Leif Lindholm wrote: > > On Fri, Oct 28, 2016 at 11:44:34AM +0100, Ard Biesheuvel wrote: > >> Get rid of calls to unsafe string functions. These are deprecated and may > >> be

Re: [edk2] [PATCH v2 5/9] EmbeddedPkg/AndroidFastboot: eliminate deprecated string function calls

On 10/28/16 15:36, Leif Lindholm wrote: > On Fri, Oct 28, 2016 at 11:44:34AM +0100, Ard Biesheuvel wrote: >> Get rid of calls to unsafe string functions. These are deprecated and may >> be removed in the future. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard

Re: [edk2] [PATCH v2 5/9] EmbeddedPkg/AndroidFastboot: eliminate deprecated string function calls

On 28 October 2016 at 14:36, Leif Lindholm wrote: > On Fri, Oct 28, 2016 at 11:44:34AM +0100, Ard Biesheuvel wrote: >> Get rid of calls to unsafe string functions. These are deprecated and may >> be removed in the future. >> >> Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH v2 8/9] EmbeddedPkg/MmcDxe: eliminate deprecated string function calls

On 10/28/16 12:44, Ard Biesheuvel wrote: > Get rid of calls to unsafe string functions. These are deprecated and may > be removed in the future. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH v2 5/9] EmbeddedPkg/AndroidFastboot: eliminate deprecated string function calls

On Fri, Oct 28, 2016 at 11:44:34AM +0100, Ard Biesheuvel wrote: > Get rid of calls to unsafe string functions. These are deprecated and may > be removed in the future. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH v2 6/9] EmbeddedPkg/Ebl: eliminate deprecated string function calls

On 10/28/16 12:44, Ard Biesheuvel wrote: > Get rid of calls to unsafe string functions. These are deprecated and may > be removed in the future. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH v2 5/9] EmbeddedPkg/AndroidFastboot: eliminate deprecated string function calls

On 10/28/16 12:44, Ard Biesheuvel wrote: > Get rid of calls to unsafe string functions. These are deprecated and may > be removed in the future. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH v2 4/9] EmbeddedPkg/GdbDebugAgent: fix VOID* cast of incorrect size

On Fri, Oct 28, 2016 at 11:44:33AM +0100, Ard Biesheuvel wrote: > The result of PcdGet64() can only be cast to VOID* on 64-bit platforms, > so add an intermediate UINTN cast to make this code build again on 32 bit. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard

Re: [edk2] [PATCH v2 3/9] EmbeddedPkg: add missing modules

On Fri, Oct 28, 2016 at 11:44:32AM +0100, Ard Biesheuvel wrote: > Add modules that live under EmbeddedPkg but were missing from the > [Components] section of the package .dsc file > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH v2 2/9] EmbeddedPkg: remove unused PrePiHobListPointerLib

On Fri, Oct 28, 2016 at 11:44:31AM +0100, Ard Biesheuvel wrote: > Remove this unused version: all existing platforms use the one under > ArmPlatformPkg instead. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel Reviewed-by:

Re: [edk2] [PATCH v2 1/9] EmbeddedPkg/AndroidFastbootTransportTcpDxe: remove broken hostname handling

On Fri, Oct 28, 2016 at 11:44:30AM +0100, Ard Biesheuvel wrote: > The fastboot TCP connection setup routine retrieves a hostname from a > UEFI variable 'hostname' that is scoped under a GUID gEfiHostnameVariableGuid > whose definition is missing from the code. Since the hostname is only printed >

[edk2] [PATCH 2/3] ArmPlatformPkg/PrePi RVCT: use relative reference to mSystemMemoryEnd

Bring the RVCT version of the PrePi entry point code in line with the GCC version, by using a relative rather than an absolute reference to the mSystemMemoryEnd variable. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH 3/3] ArmPkg: remove LoadConstantXxx() asm macros

This is ancient cruft that is no longer used, so remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/Include/AsmMacroIoLib.h | 33 ArmPkg/Include/AsmMacroIoLib.inc | 10 --

[edk2] [PATCH 0/3] ArmPkg/ArmPlatformPkg: some cleanups

A couple of remaining cleanups I had in my queue. Ard Biesheuvel (3): ArmPkg RVCT: add ADRL/LDRL macro equivalents ArmPlatformPkg/PrePi RVCT: use relative reference to mSystemMemoryEnd ArmPkg: remove LoadConstantXxx() asm macros ArmPkg/Include/AsmMacroIoLib.h| 33

[edk2] [PATCH 1/3] ArmPkg RVCT: add ADRL/LDRL macro equivalents

The GCC ARM builds have access to ADRL/LDRL macros that emit relative symbol references, i.e., references that do not require fixing up at load time (or FV generation time for XIP modules) Implement equivalent functionality for RVCT: note that this does not use movw/movt pairs, but the more

Re: [edk2] [PATCH v3 0/6] ArmPkg: eliminate calls to deprecated functions

On 28 October 2016 at 10:28, Ard Biesheuvel wrote: > This series prepares ArmPkg for building with the preprocess symbol > DISABLE_NEW_DEPRECATED_INTERFACES defined, by adding missing components > to ArmPkg (#1), fixing broken code or code that relies on deprecated >

Re: [edk2] [PATCH] ArmPkg: Assign the real INTID value for sanity check

Hi Dennis, On 21 October 2016 at 07:40, Dennis Chen wrote: > Current implementation doesn't assign the INTID value readed from > GICC_IAR to the @InterruptId parameter in case of GICv3, thus make > the sanity check of the INTID in the caller becomes untrustworthy, this >

Re: [edk2] [PATCH v3 6/6] ArmPkg: enable -DDISABLE_NEW_DEPRECATED_INTERFACES

On Fri, Oct 28, 2016 at 10:28:16AM +0100, Ard Biesheuvel wrote: > Define DISABLE_NEW_DEPRECATED_INTERFACES on the compiler command line by > default, to prevent deprecated interfaces from being used in core EDK2 > code. > > Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=164 >

Re: [edk2] [PATCH v3 5/6] ArmPkg/BdsLib: eliminate calls to deprecated string functions

On Fri, Oct 28, 2016 at 10:28:15AM +0100, Ard Biesheuvel wrote: > Remove calls to deprecated string functions like AsciiStrCpy() and > UnicodeStrToAsciiStr() > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > Reviewed-by:

Re: [edk2] [PATCH v3 4/6] ArmPkg/SemihostFs: eliminate calls to deprecated string functions

On Fri, Oct 28, 2016 at 10:28:14AM +0100, Ard Biesheuvel wrote: > Remove calls to deprecated string functions like AsciiStrCpy() and > UnicodeStrToAsciiStr() > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > Reviewed-by:

Re: [edk2] [PATCH v3 3/6] ArmPkg/LinuxLoader: eliminate calls to deprecated string functions

On Fri, Oct 28, 2016 at 10:28:13AM +0100, Ard Biesheuvel wrote: > Remove calls to deprecated string functions like AsciiStrCpy() and > UnicodeStrToAsciiStr() > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > Tested-by: Ryan

[edk2] [PATCH v2 2/2] ArmPlatformPkg/BootMonFs: eliminate deprecated string functions

Get rid of functions that are no longer available when defining DISABLE_NEW_DEPRECATED_INTERFACES Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/FileSystem/BootMonFs/BootMonFsDir.c| 8 +++-

[edk2] [PATCH v2 1/2] ArmPlatformPkg/ArmVExpressFastBootDxe: eliminate deprecated string functions

Get rid of functions that are no longer available when defining DISABLE_NEW_DEPRECATED_INTERFACES Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmVExpressPkg/ArmVExpressFastBootDxe/ArmVExpressFastBoot.c | 9

[edk2] [PATCH v2 0/2] ArmPlatformPkg: remove deprecated string function calls

ArmPlatformPkg no longer has its own .dsc, but we can still clean up some uses of deprecated string functions, so that users of ArmPlatformPkg can define DISABLE_NEW_DEPRECATED_INTERFACES v2: - incorporated feedback from Laszlo Ard Biesheuvel (2): ArmPlatformPkg/ArmVExpressFastBootDxe:

Re: [edk2] [patch] NetworkPkg: Add error handling logic when using AllocateZeorPool

On 10/27/16 09:41, Zhang Lubo wrote: > Add error handling logic if failed to apply new memory. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Zhang Lubo > Cc: Fu Siyuan > Cc: Wu Jiaxin > --- >

[edk2] [PATCH v2 7/9] EmbeddedPkg/EfiFileLib: eliminate deprecated string function calls

Get rid of calls to unsafe string functions. These are deprecated and may be removed in the future. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Laszlo Ersek ---

[edk2] [PATCH v2 5/9] EmbeddedPkg/AndroidFastboot: eliminate deprecated string function calls

Get rid of calls to unsafe string functions. These are deprecated and may be removed in the future. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/Application/AndroidFastboot/AndroidBootImg.c | 3 ++-

[edk2] [PATCH v2 6/9] EmbeddedPkg/Ebl: eliminate deprecated string function calls

Get rid of calls to unsafe string functions. These are deprecated and may be removed in the future. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/Ebl/Command.c | 2 +- EmbeddedPkg/Ebl/Dir.c | 4 ++--

[edk2] [PATCH v2 9/9] EmbeddedPkg: enable -DDISABLE_NEW_DEPRECATED_INTERFACES

Define DISABLE_NEW_DEPRECATED_INTERFACES on the compiler command line by default, to prevent deprecated interfaces from being used in core EDK2 code. Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=164 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH v2 8/9] EmbeddedPkg/MmcDxe: eliminate deprecated string function calls

Get rid of calls to unsafe string functions. These are deprecated and may be removed in the future. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/Universal/MmcDxe/Diagnostics.c | 4 ++-- 1 file changed, 2

[edk2] [PATCH v2 4/9] EmbeddedPkg/GdbDebugAgent: fix VOID* cast of incorrect size

The result of PcdGet64() can only be cast to VOID* on 64-bit platforms, so add an intermediate UINTN cast to make this code build again on 32 bit. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Laszlo Ersek

[edk2] [PATCH v2 0/9] EmbeddedPkg: eliminate calls to deprecated functions

This series prepares EmbeddedPkg for building with the preprocess symbol DISABLE_NEW_DEPRECATED_INTERFACES defined, by adding missing components to EmbeddedPkg (#3), fixing broken code or code that relies on deprecated functionality (#1 - #2, #4 - #8), and finally adds

[edk2] [PATCH v2 2/9] EmbeddedPkg: remove unused PrePiHobListPointerLib

Remove this unused version: all existing platforms use the one under ArmPlatformPkg instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/EmbeddedPkg.dec | 1 -

[edk2] [PATCH v2 1/9] EmbeddedPkg/AndroidFastbootTransportTcpDxe: remove broken hostname handling

The fastboot TCP connection setup routine retrieves a hostname from a UEFI variable 'hostname' that is scoped under a GUID gEfiHostnameVariableGuid whose definition is missing from the code. Since the hostname is only printed and then discarded, let's just drop the whole thing. Contributed-under:

Re: [edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to SmmCpuFeaturesLib library.

On 10/28/16 06:43, Fan, Jeff wrote: > Leo, > > Got it. Could you please create the patch to add GetProcessorLocation() in > Local APIC Lib? > > There are two library instances required to be updated > UefiCpuPkg\Library\BaseXApicLib > UefiCpuPkg\Library\BaseXApicX2ApicLib > > Then you

Re: [edk2] [PATCH 40/47] SecurityPkg/AuthVariableLib: rebase to ARRAY_SIZE()

On 10/28/16 10:36, Zhang, Chao B wrote: > Reviewed-by: Chao Zhang Thank you. I committed the series yesterday, with Star's and Jordan's R-bs for this patch. I hope that's okay. Thanks! Laszlo > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 27,

[edk2] [PATCH v3 5/6] ArmPkg/BdsLib: eliminate calls to deprecated string functions

Remove calls to deprecated string functions like AsciiStrCpy() and UnicodeStrToAsciiStr() Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Laszlo Ersek Tested-by: Ryan Harkin

[edk2] [PATCH v3 6/6] ArmPkg: enable -DDISABLE_NEW_DEPRECATED_INTERFACES

Define DISABLE_NEW_DEPRECATED_INTERFACES on the compiler command line by default, to prevent deprecated interfaces from being used in core EDK2 code. Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=164 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH v3 4/6] ArmPkg/SemihostFs: eliminate calls to deprecated string functions

Remove calls to deprecated string functions like AsciiStrCpy() and UnicodeStrToAsciiStr() Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Laszlo Ersek Tested-by: Ryan Harkin

[edk2] [PATCH v3 1/6] ArmPkg: add missing components

ArmPkg.dsc was a bit out of date, and some modules added over the past years had not been added to its [Components] section yet. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Tested-by: Ryan Harkin

[edk2] [PATCH v3 2/6] ArmPkg/ArmCortexA9Lib RVCT: remove incompatible GCC include

Drop the include of AsmMacroIoLib.h, which contains GCC preprocessor macros that RVCT does not use or require, given it has its own AsmMacroIoLib.inc Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Tested-by: Ryan Harkin

[edk2] [PATCH v3 0/6] ArmPkg: eliminate calls to deprecated functions

This series prepares ArmPkg for building with the preprocess symbol DISABLE_NEW_DEPRECATED_INTERFACES defined, by adding missing components to ArmPkg (#1), fixing broken code or code that relies on deprecated functionality (#2 - #5), and finally adds -DDISABLE_NEW_DEPRECATED_INTERFACES to the CC

Re: [edk2] [PATCH 40/47] SecurityPkg/AuthVariableLib: rebase to ARRAY_SIZE()

Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, October 27, 2016 5:08 PM To: Zeng, Star; Zhang, Chao B Cc: edk2-devel-01 Subject: Re: [edk2] [PATCH 40/47] SecurityPkg/AuthVariableLib: rebase to

Re: [edk2] [Patch 0/2] Fix the wrong Timer event check

Reviewed-by: Fu Siyuan siyuan...@intel.com > -Original Message- > From: Wu, Jiaxin > Sent: Friday, October 28, 2016 2:34 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Zhang, > Lubo > Subject: [Patch 0/2]

Re: [edk2] [Patch 0/2] Fix the wrong Timer event check

Series Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Friday, October 28, 2016 2:34 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Zhang, Lubo Subject: [Patch 0/2] Fix the

[edk2] [PATCH V6 3/7] UefiCpuPkg/UefiCpuPkg.dec: Add Microcode capsule related definition.

1) Add Microcode capsule related GUID. gMicrocodeFmpImageTypeIdGuid 2) Add Microcode capsule related library. MicrocodeFlashAccessLib Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney

[edk2] [PATCH V6 0/7] Add MicrocodeUpdate support.

This is series 3 of the whole capsule solution. Version 6. According to feedback, we split the big patch series to smaller one. Series 3: Microcode Update (UefiCpuPkg) MicrocodeFlashAccessLib MicrocodeUpdate driver. The code is also in https://github.com/jyao1/edk2 V6 is at

[edk2] [PATCH V6 7/7] UefiCpuPkg/UefiCpuPkg.dsc: Add MicrocodeCapsule related component.

Add Microcode capsule related component to check build. Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang

[edk2] [PATCH V6 1/7] UefiCpuPkg/Include: Add Microcode FMP definition.

It defined ImageTypeId for Microcode. Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under:

[edk2] [PATCH V6 6/7] UefiCpuPkg/MicrocodeUpdate: Add Microcode FMP build sample

This folder provides the sample build for Microcode FMP. The INF is to convert the text format Microcode to binary. The DSC/FDF is to convert the Microcode binary to Microcode FMP. Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc:

[edk2] [PATCH V6 4/7] UefiCpuPkg/MicrocodeFlashAccessLib: Add NULL MicrocodeFlashAccessLib.

Add NULL instance to pass build. Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore

  1   2   >