[edk2] 答复: FCE tool parse edk2 bios fd( build by linux gcc) failed

HI, Liming, Thanks for your fast and kindly reply. I will try the latest edk2 as your suggestion. BR, Robin. -邮件原件- 发件人: Gao, Liming [mailto:liming@intel.com] 发送时间: 2017年2月24日 15:43 收件人: xujiawu; edk2-de...@ml01.01.org 抄送: 'Daisy Wang' 主题: RE: [edk2] FCE tool parse edk2 bios fd( buil

Re: [edk2] FCE tool parse edk2 bios fd( build by linux gcc) failed

I know BaseTools has one issue to parse GCC map file. It may cause this issue. But, BaseTools issue has been fixed in edk2 3e7e8571da891122c6821ebc428ce6dbd8a35ff3. Could you try the latest edk2 trunk? Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists

Re: [edk2] Should Path Name in File Path Media Device Path node be NULL terminated?

UEFI spec clearly say: "Path Name" is A NULL-terminated Path string including directory and file names. The length of this string n can be determined by subtracting 4 from the Length entry. A device path may contain one or more of these nodes. Each node can optionally add a "\" separator to the

[edk2] [PATCH v3] BaseTools: Skip module AutoGen by comparing timestamp.

[Introduction] The BaseTool Build.py AutoGen parse INF meta-file and generate AutoGen.c/AutoGen.h/makefile. When we only change .c .h code, the AutoGen might be not necessary, but Build.py spend a lot of time on it. There's a -u flag to skip all module's AutoGen. In my environment, it save 35%~50%

[edk2] Should Path Name in File Path Media Device Path node be NULL terminated?

Historically grub2 built image paths using two File Path nodes - one for directory and one for file name relative to directory. These nodes had path names that were not NULL terminated. Recently we had bug report that secure boot using grub2 failed. It was tracked down to exactly the fact that pat

[edk2] 撤回: FCE tool retrieve edk2 bios fd( build by linux gcc) failed

xujiawu 将撤回邮件“FCE tool retrieve edk2 bios fd( build by linux gcc) failed”。 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] FCE tool retrieve edk2 bios fd( build by linux gcc) failed

Hello, edk2-devel I want to report a bug about fce tool. But fce tool show error while retrieve the bios fd file (build by linux gcc). Reproduce step: 1. Build OVMF.fd by linux gcc (ubuntu14.04, gcc version 4.85) 2. Fce read -i OVMF.fd 3. Failed and show: error while parse

Re: [edk2] [PATCH v3 2/7] MdePkg IndustryStandard/Scsi.h: Add sense code macro

Linton, Could you let me know where the +#define EFI_SCSI_REQUEST_SENSE_ERROR (0x70) comes from? According to SCSI SPC5r08 spec, the first byte of sense data is the RESPONSE CODE field. And 0x70 means a) the result of an error, exception condition, or protocol specific failure that is asso

[edk2] [patch] NetworkPkg: Add check logic for some variable in iSCSI driver.

Add check logic for some attempt variable to enhance code in iSCSI. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Jiaxin --- NetworkPkg/IScsiDxe/IScsiConfig.c | 75 +-- 1 file changed, 41

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Do not ASSERT on AllocateMemorySpace() error

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Friday, February 24, 2017 2:12 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Tian, Feng ; Laszlo Ersek ; Zeng, Star Subject: [edk2] [PATCH] UefiCpuPk

Re: [edk2] [PATCH 5/5] OvmfPkg: exclude libssl functionality from OpensslLib if TLS_ENABLE=FALSE

On Thu, Feb 23, 2017 at 10:57:44PM +0100, Laszlo Ersek wrote: > The OpensslLibNoSsl library instance (which does not contain libssl > functions) is sufficient for the Secure Boot feature. > > Ease security analsysis by excluding libssl functionality from the > OpensslLib instance we use with TLS_E

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Do not ASSERT on AllocateMemorySpace() error

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Friday, February 24, 2017 2:12 PM To: edk2-devel@lists.01.org Cc: Laszlo Ersek ; Zeng, Star ; Tian, Feng ; Kinney, Michael D Subject: [PATCH] UefiCpuPkg/CpuDxe: Do not ASSERT on AllocateMemorySpace() error Pl

[edk2] [PATCH] UefiCpuPkg/CpuDxe: Do not ASSERT on AllocateMemorySpace() error

Platform PEI may add LOCAL APIC memory mapped space into EFI_HOB_MEMORY_ALLOCATION. Or platform may allocate this range before. So, we skip AllocateMemorySpace()'s return status checking. Instead, we add one DEBUG message for possible trace. https://bugzilla.tianocore.org/show_bug.cgi?id=390 Thi

Re: [edk2] [PATCH 4/5] Nt32Pkg: exclude libssl functionality from OpensslLib if TLS_ENABLE=FALSE

Okay, I can review the patch. Laszlo, Would you like to change the module name (OpensslLibNoSsl or OpensslLibCrypto)? Best Regards, Jiaxin > -Original Message- > From: Ni, Ruiyu > Sent: Friday, February 24, 2017 12:09 PM > To: Laszlo Ersek ; edk2-devel-01 de...@ml01.01.org>; Wu, Jiaxi

Re: [edk2] Tcg2Pei.efi assert after sync to latest trunk

Hi Liming, Thanks! The issue is fixed after I sync basetool fix. At 2017-02-23 21:01:25, "Gao, Liming" wrote: >This is BaseTools regression issue. It is fixed today. Please try it on >tomorrow. > >Thanks >Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@

Re: [edk2] [PATCH 4/5] Nt32Pkg: exclude libssl functionality from OpensslLib if TLS_ENABLE=FALSE

Jiaxin, can you review this patch? Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >Ersek >Sent: Friday, February 24, 2017 5:58 AM >To: edk2-devel-01 >Cc: Ni, Ruiyu ; Tomas Hoger >Subject: [edk2] [PATCH 4/5] Nt32Pkg: exclu

Re: [edk2] [PATCH 3/3] ShellPkg UefiDpLib: Fixed GCC build failure caused by ef22403

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Zeng, Star >Sent: Friday, February 24, 2017 10:10 AM >To: edk2-devel@lists.01.org >Cc: Zeng, Star ; Kinney, Michael D >; Gao, Liming >; Carsey, Jaben ; Ni, Ruiyu > >Subject: [PATCH 3/3] ShellPkg UefiDpLib: Fixed GCC build fa

Re: [edk2] [URGENT-ish PATCH 0/5] ArmVirt- Nt32- Ovmf- CryptoPkg: conditionalize libssl presence in OpensslLib

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Friday, February 24, 2017 6:25 AM > To: Laszlo Ersek > Cc: edk2-devel-01; Gary Lin; Wu, Jiaxin; Justen, Jordan L; Long, Qin; Ni, > Ruiyu; > Ye, Ting; Tomas Hoger > Subject: Re: [URGENT-ish PATCH 0/5] Ar

Re: [edk2] [PATCH] BaseTools: GCC: move most AutoGen.obj contents back to .data section

Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, February 24, 2017 6:29 AM To: Laszlo Ersek Cc: edk2-devel@lists.01.org ; Gao, Liming ; Zhu, Yonghong Subject: Re: [PATCH] BaseTools: GCC: move most AutoGen.obj contents bac

Re: [edk2] [PATCH 0/3] DP: Fix GCC build failure

Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Friday, February 24, 2017 10:10 AM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [PATCH 0/3] DP: Fix GCC build failure Fix GCC build failure caus

Re: [edk2] [RFC PATCH 0/4] RFC: increased memory protection

HI Ard In X86 CPU driver - UefiCpuPkg\CpuDxe, we use a global variable – mIsFlushingGCD. In RefreshGcdMemoryAttributes(), we set mIsFlushingGCD=TRUE. In CpuSetMemoryAttributes(), we check mIsFlushingGCD. If mIsFlushingGCD is TRUE, CpuSetMemoryAttributes() returns immediately without touching cac

[edk2] [PATCH 3/3] ShellPkg UefiDpLib: Fixed GCC build failure caused by ef22403

Cc: Michael Kinney Cc: Liming Gao Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- ShellPkg/Library/UefiDpLib/Dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiDpLib/Dp.c b/ShellPkg/L

[edk2] [PATCH 1/3] MdeModulePkg PerformanceLib: Fix GCC build failure caused by cfb0aba

Cc: Ard Biesheuvel Cc: Liming Gao Cc: Feng Tian Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c | 2 +- MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLib

[edk2] [PATCH 2/3] PerformancePkg Dp_App: Fixed GCC build failure caused by 1393510

Cc: Michael Kinney Cc: Liming Gao Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- PerformancePkg/Dp_App/Dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PerformancePkg/Dp_App/Dp.c b/PerformancePkg/Dp_App/Dp.c index 3

[edk2] [PATCH 0/3] DP: Fix GCC build failure

Fix GCC build failure caused by "Remove TimerLib dependency from DP" patch series. Star Zeng (3): MdeModulePkg PerformanceLib: Fix GCC build failure caused by cfb0aba PerformancePkg Dp_App: Fixed GCC build failure caused by 1393510 ShellPkg UefiDpLib: Fixed GCC build failure caused by ef224

Re: [edk2] [PATCH] MdeModulePkg SmmSmiHandlerProfileLib: Fix GCC build failure

Thank you! Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Friday, February 24, 2017 9:56 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Tian, Feng ; Yao, > Jiewen > Subject: [PATCH] MdeModulePkg SmmSmiHandlerProfileLib: Fix GCC build failure > >

Re: [edk2] [PATCH] MdeModulePkg SmmSmiHandlerProfileLib: Fix GCC build failure

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Zeng, Star Sent: Friday, February 24, 2017 9:56 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Tian, Feng ; Yao, Jiewen Subject: [PATCH] MdeModulePkg SmmSmiHandlerProfileLib: Fix GCC build failure Cc: Feng Tian Cc: Jiewen

[edk2] [PATCH] MdeModulePkg SmmSmiHandlerProfileLib: Fix GCC build failure

Cc: Feng Tian Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/SmmSmiHandlerProfile

Re: [edk2] [PATCH v4 1/3] MdeModulePkg: Add performance property configuration table

Agree, I will send patch for it ASAP. Thanks, Star -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, February 24, 2017 1:30 AM To: Yao, Jiewen Cc: Kinney, Michael D ; edk2-devel@lists.01.org; Carsey, Jaben ; Zeng, Star ; Andrew Fish ; Gao, Liming

Re: [edk2] Improvements to build system etc. for edk2-platforms devel-MinnowBoard3?

One thing we can try is automating the right setting for MAX_CONCURRENT_THREAD_NUMBER. In Windows, there's a command line utility to return the number of logical processors. C:\Users\sample>wmic cpu get numberoflogicalprocessors NumberOfLogicalProcessors 4 This could be

Re: [edk2] [PATCH v2 0/7] ATAPI support on SiI SATA adapter

Hi, Please ignore this patch set, and rather look at the V3 version. I had a stale set of patches in the directory I sent v2 from. Sorry about the noise. Thanks, On 02/23/2017 04:03 PM, Jeremy Linton wrote: The SiI isn't an AHCI compatible adapter so it implements the EFI ATA pass-through

[edk2] [PATCH] Platforms/ARM/Juno: Add SCSI pass-through protocol

Now that the SiI adapter supports ATAPI add the SCSI pass- through protocol. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton --- Platforms/ARM/Juno/ArmJuno.dsc | 3 +++ Platforms/ARM/Juno/ArmJuno.fdf | 2 ++ 2 files changed, 5 insertions(+) diff --git a/Plat

[edk2] [PATCH v3 2/7] MdePkg IndustryStandard/Scsi.h: Add sense code macro

Add some definitions to mask the sense key from sense data, and check the validity of the returned sense data. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton --- MdePkg/Include/IndustryStandard/Scsi.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Mde

[edk2] [PATCH v3 3/7] EmbeddedPkg: SiI3132: Add ScsiProtocol callbacks

Create a new module that adds the callbacks to support the EFI SCSI pass-through protocol. These callbacks wrap around the existing ATA pass-through callbacks. In particular the SCSI command submission routine takes the SCSI command and wraps it with an SATA FIS and sets the protocol to ATAPI. It t

[edk2] [PATCH v3 5/7] EmbeddedPkg: SiI3132: Break out FIS command submission

The existing ATA pass-through routine builds the FIS and handles submission to the hardware. Break out the FIS submission part so that it can be utilized by the SCSI pass-through. Also, tighten up the error handling a bit. Starting with removal of the ASSERTs on errors. ATAPI like SCSI uses check c

[edk2] [PATCH v3 4/7] EmbeddedPkg: SiI3132: Add SCSI protocol support to header

Add EXT_SCSI_PASS_THRU structures to SI3132_PORT structure, along with helpers and new entry points. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton --- EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h | 93 ++-- 1 file changed, 88 inserti

[edk2] [PATCH v3 7/7] EmbeddedPkg: SiI3132: Enable SCSI pass-through protocol

Now that everything is in place, lets export the protocol, build the module, and remove the ATAPI unsupported flags. Now when we detect an ATAPI device on a port we flag it as such. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton --- EmbeddedPkg/Drivers/SataS

[edk2] [PATCH v3 6/7] EmbeddedPkg: SiI3132: Cleanup device node creation

There can be either ATA or ATAPI devices connected to each SATA port. We want to detect if the device is ATA and create a SATA_DP path or a SCSI_DP for ATAPI devices. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton --- .../Drivers/SataSiI3132Dxe/SiI3132AtaPas

[edk2] [PATCH v3 0/7] ATAPI support on SiI SATA adapter

The SiI isn't an AHCI compatible adapter so it implements the EFI ATA pass-through protocol directly. This works for fixed hard drives, but not ATAPI attached devices (CDROM, DVDROM, TAPE, etc). This patch adds read only ATAPI support via the EFI SCSI pass-through protocol, allowing boot from atta

[edk2] [PATCH v3 1/7] EmbeddedPkg: SiI3132: Note that ARM is using this Dxe

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton --- MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf in

Re: [edk2] [PATCH] BaseTools: GCC: move most AutoGen.obj contents back to .data section

On 23 February 2017 at 19:53, Laszlo Ersek wrote: > On 02/23/17 19:30, Ard Biesheuvel wrote: >> The generated AutoGen.c files mostly contain read-only data, but due to >> lacking annotations, all of it is emitted into the .data section by the >> compiler. >> >> Given that GUIDs are UEFI's gaffer t

Re: [edk2] [PATCH 3/5] ArmVirtPkg: resolve OpensslLib to OpensslLibNoSsl

On 23 February 2017 at 21:57, Laszlo Ersek wrote: > The OpensslLibNoSsl library instance (which does not contain libssl > functions) is sufficient for the Secure Boot feature. It would not be > sufficient for HTTPS booting (which requires TLS), but in ArmVirtPkg, we > don't even enable plaintext H

Re: [edk2] [URGENT-ish PATCH 0/5] ArmVirt- Nt32- Ovmf- CryptoPkg: conditionalize libssl presence in OpensslLib

On 23 February 2017 at 21:57, Laszlo Ersek wrote: > In commit 32387e0081db ("CryptoPkg: Enable ssl build in OpensslLib > directly", 2016-12-14), we enabled libssl functionality in > CryptoPkg/OpensslLib unconditionally. > > While that's real convenient, it is also overkill for platforms (or > plat

[edk2] [PATCH v2 7/7] EmbeddedPkg: SiI3132: Enable SCSI pass-through protocol

Now that everything is in place, lets export the protocol, build the module, and remove the ATAPI unsupported flags. Now when we detect an ATAPI device on a port we flag it as such. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton --- EmbeddedPkg/Drivers/SataS

[edk2] [PATCH] Platforms/ARM/Juno: Add SCSI pass-through protocol

Now that the SiI adapter supports ATAPI add the SCSI pass- through protocol. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton --- Platforms/ARM/Juno/ArmJuno.dsc | 3 +++ Platforms/ARM/Juno/ArmJuno.fdf | 2 ++ 2 files changed, 5 insertions(+) diff --git a/Plat

Re: [edk2] [URGENT-ish PATCH 0/5] ArmVirt- Nt32- Ovmf- CryptoPkg: conditionalize libssl presence in OpensslLib

On 02/23/17 22:57, Laszlo Ersek wrote: > In commit 32387e0081db ("CryptoPkg: Enable ssl build in OpensslLib > directly", 2016-12-14), we enabled libssl functionality in > CryptoPkg/OpensslLib unconditionally. > > While that's real convenient, it is also overkill for platforms (or > platform builds

[edk2] [PATCH v2 0/7] ATAPI support on SiI SATA adapter

The SiI isn't an AHCI compatible adapter so it implements the EFI ATA pass-through protocol directly. This works for fixed hard drives, but not ATAPI attached devices (CDROM, DVDROM, TAPE, etc). This patch adds read only ATAPI support via the EFI SCSI pass-through protocol, allowing boot from atta

[edk2] [PATCH v2 5/7] EmbeddedPkg: SiI3132: Break out FIS command submission

The existing ATA pass-through routine builds the FIS and handles submission to the hardware. Break out the FIS submission part so that it can be utilized by the SCSI pass-through. Also, tighten up the error handling a bit. Starting with removal of the ASSERTs on errors. ATAPI like SCSI uses check c

[edk2] [PATCH v2 1/7] EmbeddedPkg: SiI3132: Note that ARM is using this Dxe

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton --- MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf in

[edk2] [PATCH v2 2/7] MdePkg IndustryStandard/Scsi.h: Add sense code macro

Add some definitions to mask the sense key from sense data, and check the validity of the returned sense data. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton --- MdePkg/Include/IndustryStandard/Scsi.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Mde

[edk2] [PATCH v2 4/7] EmbeddedPkg: SiI3132: Add SCSI protocol support to header

Add EXT_SCSI_PASS_THRU structures to SI3132_PORT structure, along with helpers and new entry points. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton --- EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h | 93 ++-- 1 file changed, 88 inserti

[edk2] [PATCH v2 6/7] EmbeddedPkg: SiI3132: Cleanup device node creation

There can be either ATA or ATAPI devices connected to each SATA port. We want to detect if the device is ATA and create a SATA_DP path or a SCSI_DP for ATAPI devices. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton --- .../Drivers/SataSiI3132Dxe/SiI3132AtaPas

[edk2] [PATCH v2 3/7] EmbeddedPkg: SiI3132: Add ScsiProtocol callbacks

Create a new module that adds the callbacks to support the EFI SCSI pass-through protocol. These callbacks wrap around the existing ATA pass-through callbacks. In particular the SCSI command submission routine takes the SCSI command and wraps it with an SATA FIS and sets the protocol to ATAPI. It t

[edk2] [PATCH 2/5] CryptoPkg/OpensslLib: introduce OpensslLibNoSsl instance

Commit 32387e0081db ("CryptoPkg: Enable ssl build in OpensslLib directly", 2016-12-14) pulls OpenSSL's libssl files into the "OpensslLib.inf" library instance unconditionally. If a platform doesn't include the TLS modules, such as - CryptoPkg/Library/TlsLib/TlsLib.inf - NetworkPkg/TlsAuthConfigDx

[edk2] [PATCH 4/5] Nt32Pkg: exclude libssl functionality from OpensslLib if TLS_ENABLE=FALSE

Ease security analsysis by excluding libssl functionality from the OpensslLib instance we use with TLS_ENABLE=FALSE. Cc: Ruiyu Ni Cc: Tomas Hoger Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Notes: I can't build-test this. Nt32Pkg/Nt32Pkg.dsc |

[edk2] [PATCH 5/5] OvmfPkg: exclude libssl functionality from OpensslLib if TLS_ENABLE=FALSE

The OpensslLibNoSsl library instance (which does not contain libssl functions) is sufficient for the Secure Boot feature. Ease security analsysis by excluding libssl functionality from the OpensslLib instance we use with TLS_ENABLE=FALSE. Cc: Gary Lin Cc: Jordan Justen Cc: Tomas Hoger Contribu

[edk2] [PATCH 3/5] ArmVirtPkg: resolve OpensslLib to OpensslLibNoSsl

The OpensslLibNoSsl library instance (which does not contain libssl functions) is sufficient for the Secure Boot feature. It would not be sufficient for HTTPS booting (which requires TLS), but in ArmVirtPkg, we don't even enable plaintext HTTP booting for the time being. Ease security analsysis by

[edk2] [URGENT-ish PATCH 0/5] ArmVirt- Nt32- Ovmf- CryptoPkg: conditionalize libssl presence in OpensslLib

In commit 32387e0081db ("CryptoPkg: Enable ssl build in OpensslLib directly", 2016-12-14), we enabled libssl functionality in CryptoPkg/OpensslLib unconditionally. While that's real convenient, it is also overkill for platforms (or platform builds) that don't want TLS. The impact (beyond wasted bu

[edk2] [PATCH 1/5] CryptoPkg/OpensslLib: refresh OpensslLib.inf, opensslconf.h after 32387e00

Commit 32387e0081db ("CryptoPkg: Enable ssl build in OpensslLib directly", 2016-12-14) removed the "no-queue" configuration option in "process_files.sh", plus it enabled "process_files.sh" to place all libssl source files into "OpensslLib.inf". However, the patch apparently failed to capture two c

Re: [edk2] [PATCH] BaseTools: GCC: move most AutoGen.obj contents back to .data section

On 02/23/17 19:30, Ard Biesheuvel wrote: > The generated AutoGen.c files mostly contain read-only data, but due to > lacking annotations, all of it is emitted into the .data section by the > compiler. > > Given that GUIDs are UEFI's gaffer tape, having writable GUIDs is a > security hazard, and th

Re: [edk2] [RFC PATCH 0/4] RFC: increased memory protection

On 23 February 2017 at 11:45, Yao, Jiewen wrote: > Sounds great. > > I look forward to your V2. > Hello Jiewen, What I am currently struggling with is the fact that we don't use the GCD RO/XP permissions at all. This means that RefreshGcdMemoryAttributes () (or SyncCacheConfig() on ARM) will rem

Re: [edk2] Improvements to build system etc. for edk2-platforms devel-MinnowBoard3?

On 2/23/2017 11:53 AM, Brian J. Johnson wrote: Sorry if I'm bikeshedding... NUMBER_OF_PROCESSORS isn't a good default for those of us who build on servers with hundreds of threads available. The OS, disks, and build.exe/build.py become bottlenecks. Maybe we could put a cap (say, 20) on the

Re: [edk2] Improvements to build system etc. for edk2-platforms devel-MinnowBoard3?

Sorry if I'm bikeshedding... NUMBER_OF_PROCESSORS isn't a good default for those of us who build on servers with hundreds of threads available. The OS, disks, and build.exe/build.py become bottlenecks. Maybe we could put a cap (say, 20) on the default thread limit, so it uses NUMBER_OF_PROCE

[edk2] [PATCH] BaseTools: GCC: move most AutoGen.obj contents back to .data section

The generated AutoGen.c files mostly contain read-only data, but due to lacking annotations, all of it is emitted into the .data section by the compiler. Given that GUIDs are UEFI's gaffer tape, having writable GUIDs is a security hazard, and this was the main rationale for putting AutoGen.obj in

Re: [edk2] [PATCH 1/2] ArmPkg: remove DebugUncachedMemoryAllocationLib

On 23 February 2017 at 17:49, Leif Lindholm wrote: > On Thu, Feb 23, 2017 at 03:48:04PM +, Ard Biesheuvel wrote: >> The debug implementation of the UncachedMemoryAllocationLib library >> class relies on the creation of an uncached alias of a memory range, >> while keeping the original cached m

Re: [edk2] [PATCH 1/2] ArmPkg: remove DebugUncachedMemoryAllocationLib

On Thu, Feb 23, 2017 at 03:48:04PM +, Ard Biesheuvel wrote: > The debug implementation of the UncachedMemoryAllocationLib library > class relies on the creation of an uncached alias of a memory range, > while keeping the original cached mapping, but with read-only attributes > to trap inadverte

Re: [edk2] DxeCore assert during initialization

On 23 February 2017 at 17:51, Laszlo Ersek wrote: > On 02/23/17 18:38, Ard Biesheuvel wrote: >> On 23 February 2017 at 17:33, Laszlo Ersek wrote: >>> On 02/23/17 18:29, Laszlo Ersek wrote: >>> This is with ArmVirtQemu @ c5c9e7e298ed, running on QEMU v2.8.0-1290-gc3618551719b, using TCG

Re: [edk2] DxeCore assert during initialization

On 02/23/17 18:38, Ard Biesheuvel wrote: > On 23 February 2017 at 17:33, Laszlo Ersek wrote: >> On 02/23/17 18:29, Laszlo Ersek wrote: >> >>> This is with ArmVirtQemu @ c5c9e7e298ed, running on QEMU >>> v2.8.0-1290-gc3618551719b, using TCG. >> >> Hm, I have some patches in QEMU, so that hash will

Re: [edk2] [PATCH 2/2] ArmPkg/CpuDxe: remove VirtualUncachedPages protocol and implementation

On Thu, Feb 23, 2017 at 03:48:05PM +, Ard Biesheuvel wrote: > Virtual uncached pages are simply pages that are aliased using mismatched > attributes, which is not allowed by the ARM architecture. So remove the > protocol and its implementation. > > Contributed-under: TianoCore Contribution Agr

Re: [edk2] DxeCore assert during initialization

On 23 February 2017 at 17:33, Laszlo Ersek wrote: > On 02/23/17 18:29, Laszlo Ersek wrote: > >> This is with ArmVirtQemu @ c5c9e7e298ed, running on QEMU >> v2.8.0-1290-gc3618551719b, using TCG. > > Hm, I have some patches in QEMU, so that hash will likely not resolve on > your side. The first ups

Re: [edk2] DxeCore assert during initialization

Hi Ard, 2017-02-23 18:17 GMT+01:00 Ard Biesheuvel : > On 23 February 2017 at 17:16, Marcin Wojtas wrote: >> Hi, >> >> I use Marvell Armada70x0 from mainline OpenPlatformPkg. After updating >> baseline to newest tianocore master branch it turned out that the >> platform fail to boot due to followi

Re: [edk2] DxeCore assert during initialization

On 02/23/17 18:29, Laszlo Ersek wrote: > This is with ArmVirtQemu @ c5c9e7e298ed, running on QEMU > v2.8.0-1290-gc3618551719b, using TCG. Hm, I have some patches in QEMU, so that hash will likely not resolve on your side. The first upstream ancestor is e295a154c2a9. Thanks Laszlo __

Re: [edk2] DxeCore assert during initialization

On 02/23/17 18:17, Ard Biesheuvel wrote: > On 23 February 2017 at 17:16, Marcin Wojtas wrote: >> Hi, >> >> I use Marvell Armada70x0 from mainline OpenPlatformPkg. After updating >> baseline to newest tianocore master branch it turned out that the >> platform fail to boot due to following assert: >

Re: [edk2] [PATCH v4 1/3] MdeModulePkg: Add performance property configuration table

On 3 February 2017 at 05:32, Yao, Jiewen wrote: > Thank you Mike and Star. > > It is good idea to remove TimerLib dependency. > Series Reviewed-by: jiewen@intel.com > This patch breaks the GCC build:

Re: [edk2] [PATCH 00/12] ArmVirtPkg, OvmfPkg: factor out QemuFwCfgS3Lib

On 02/23/17 17:59, Jordan Justen wrote: > On 2017-02-22 17:48:02, Laszlo Ersek wrote: >> The new QemuFwCfgS3Lib class has two goals: >> >> (a) to query whether S3 support was enabled on the QEMU command line, >> >> (b) to save fw_cfg DMA operations that are to be replayed at S3 resume >> time,

Re: [edk2] DxeCore assert during initialization

On 23 February 2017 at 17:16, Marcin Wojtas wrote: > Hi, > > I use Marvell Armada70x0 from mainline OpenPlatformPkg. After updating > baseline to newest tianocore master branch it turned out that the > platform fail to boot due to following assert: > > /home/mw/git/edk2/Build/Armada70x0/DEBUG_GCC4

[edk2] DxeCore assert during initialization

Hi, I use Marvell Armada70x0 from mainline OpenPlatformPkg. After updating baseline to newest tianocore master branch it turned out that the platform fail to boot due to following assert: /home/mw/git/edk2/Build/Armada70x0/DEBUG_GCC48/AARCH64/ArmPlatformPkg/PrePi/PeiMPCore/DEBUG/ArmPlatformPrePiM

Re: [edk2] [PATCH 00/12] ArmVirtPkg, OvmfPkg: factor out QemuFwCfgS3Lib

On 2017-02-22 17:48:02, Laszlo Ersek wrote: > The new QemuFwCfgS3Lib class has two goals: > > (a) to query whether S3 support was enabled on the QEMU command line, > > (b) to save fw_cfg DMA operations that are to be replayed at S3 resume > time, and more easily for the programmer than hackin

Re: [edk2] [PATCH 1/2] ArmPkg: remove DebugUncachedMemoryAllocationLib

On 02/23/17 16:48, Ard Biesheuvel wrote: > The debug implementation of the UncachedMemoryAllocationLib library > class relies on the creation of an uncached alias of a memory range, > while keeping the original cached mapping, but with read-only attributes > to trap inadvertent write accesses. > >

Re: [edk2] [PATCH] OvmfPkg/XenBusDxe: Use EFIAPI for XenStoreVSPrint

On 02/23/17 13:57, Gao, Liming wrote: > Reviewed-by: Liming Gao Reviewed-by: Laszlo Ersek Committed & pushed as c5c9e7e298ed. Thanks! Laszlo > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Anthony PERARD > Sent: Thursday, February 23

[edk2] [PATCH 2/2] ArmPkg/CpuDxe: remove VirtualUncachedPages protocol and implementation

Virtual uncached pages are simply pages that are aliased using mismatched attributes, which is not allowed by the ARM architecture. So remove the protocol and its implementation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/ArmPkg.dec

[edk2] [PATCH 1/2] ArmPkg: remove DebugUncachedMemoryAllocationLib

The debug implementation of the UncachedMemoryAllocationLib library class relies on the creation of an uncached alias of a memory range, while keeping the original cached mapping, but with read-only attributes to trap inadvertent write accesses. This is not a terribly good idea, given that the ARM

Re: [edk2] Tcg2Pei.efi assert after sync to latest trunk

This is BaseTools regression issue. It is fixed today. Please try it on tomorrow. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of wang xiaofeng Sent: Thursday, February 23, 2017 7:21 PM To: edk2-devel@lists.01.org Subject: [edk2] T

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

Laszlo: - VariableGetBestLanguage() [SecurityPkg/VariableAuthenticated/EsalVariableDxeSal/Variable.c] [Liming] It is for IPF arch only. We don't support IPF any longer. So, keep it as-is - SmmBootScriptWrite() [Vlv2TbltDevicePkg/PlatformSmm/SmmScriptSave.c] [Liming] I am not sure MinnowMa

Re: [edk2] [PATCH] OvmfPkg/XenBusDxe: Use EFIAPI for XenStoreVSPrint

Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Anthony PERARD Sent: Thursday, February 23, 2017 8:42 PM To: edk2-devel@lists.01.org Cc: Anthony PERARD ; Justen, Jordan L ; Laszlo Ersek Subject: [edk2] [PATCH] OvmfPkg/Xe

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

On Thu, Feb 23, 2017 at 11:19:03AM +0100, Laszlo Ersek wrote: > On 02/22/17 09:54, Gao, Liming wrote: > > Laszlo: > > In edk2, I find the several functions with VA_LIST have no EFIAPI. > > They may use VA_ARG() or call other functions, but they don't use > > VA_COPY(). In Base.h, VA_ARG() is define

[edk2] [PATCH] OvmfPkg/XenBusDxe: Use EFIAPI for XenStoreVSPrint

... because this function use VA_COPY. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenBusDxe/XenStore.h | 1 + OvmfPkg/XenBusDxe/XenStore.c | 1 + 2 files changed, 2 insertions(+) diff --git a/OvmfPkg/XenBusDxe/XenStore.h b/OvmfPkg/XenBusDxe

Re: [edk2] [RFC PATCH 0/4] RFC: increased memory protection

Sounds great. I look forward to your V2. Thank you Yao Jiewen From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, February 23, 2017 7:39 PM To: Yao, Jiewen Cc: edk2-devel@lists.01.org; af...@apple.com; leif.lindh...@linaro.org; Kinney, Michael D ; Gao, Liming ; ler...@redha

Re: [edk2] [RFC PATCH 0/4] RFC: increased memory protection

On 23 February 2017 at 08:52, Yao, Jiewen wrote: > HI Ard > > Thanks to protect more. :-) > Of course! This is a very important topic for me. > We did consider the idea to remove EXEC attribute for Data page before. But > we got compatibility issue. > > > > We documented some gaps in white paper

Re: [edk2] [RFC PATCH 0/4] RFC: increased memory protection

One thing I am not clear is that why we choose Cpu driver to set the attribute, instead of DxeCore. I think DxeCore might be a better place to perform such protection. Thank you Yao Jiewen From: Yao, Jiewen Sent: Thursday, February 23, 2017 4:52 PM To: Ard Biesheuvel ; edk2-devel@lists.01.org;

[edk2] Tcg2Pei.efi assert after sync to latest trunk

Hi All, I just updated to latest edk2 trunk this afternoon , and meet the following error: Loading PEIM at 0x8FB1000 EntryPoint=0x8FB13CF Tcg2Pei.efi PROGRESS CODE: V03020002 I0 WARNING: Tpm2RegisterTpm2DeviceLib - does not support 286BF25A-C2C3-408C-B3B4-25E6758B7317 registration WA

Re: [edk2] [PATCH 06/12] ArmVirtPkg, OvmfPkg: retire QemuFwCfgS3Enabled() from QemuFwCfgLib

On 23 February 2017 at 01:48, Laszlo Ersek wrote: > At this point we're ready to retire QemuFwCfgS3Enabled() from the > QemuFwCfgLib class, together with its implementations in: > > - ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c > - OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c > > Extend all modu

Re: [edk2] [PATCH 04/12] ArmVirtPkg: resolve QemuFwCfgS3Lib

On 23 February 2017 at 01:48, Laszlo Ersek wrote: > QemuFwCfgS3Enabled() in "ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c" > returns constant FALSE. > > The same implementation is now available factored-out in > "OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Base.c". > > Resolve QemuFwCfgS3Lib to Ba

Re: [edk2] [Patch] BaseTools: Fix the regression issue caused by commit dc4c77

On 02/22/17 17:03, Yonghong Zhu wrote: > In the last commit dc4c77, the _GetHeaderInfo will be called more than > once, which cause the self._ConstructorList.append(Value) append some > duplicate value. > > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by:

Re: [edk2] [RFC PATCH 0/4] RFC: increased memory protection

Hi, On 02/22/17 19:24, Ard Biesheuvel wrote: > Hello all, > > This is a proof of concept implementation that removes all executable > permissions from writable memory regions, which greatly enhances security. > It is based on Jiewen's recent work, which is a step in the right direction, > but sti

Re: [edk2] [Patch 0/2] Ignore duplicated DNS address check

Looks ok to me. Nagaraj will also test with these changes and provide feedback. Series Reviewed-by: Sriram Subramanian -Original Message- From: Jiaxin Wu [mailto:jiaxin...@intel.com] Sent: Thursday, February 23, 2017 11:01 AM To: edk2-devel@lists.01.org Cc: Hegde, Nagaraj P ; Subramania

Re: [edk2] [Patch] BaseTools: add error check for Macro usage in the INF file

On 02/23/17 02:14, Gao, Liming wrote: > Laszlo: > Yonghong has sent the another patch to its regression issue. Could you > verify it? Yes, thanks, I'll check that out soon. (Also, I'm sorry about reporting this after Ard's report; I was very busy last night and sort of looked at Thunderbird in

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

On 02/22/17 09:54, Gao, Liming wrote: > Laszlo: > In edk2, I find the several functions with VA_LIST have no EFIAPI. > They may use VA_ARG() or call other functions, but they don't use > VA_COPY(). In Base.h, VA_ARG() is defined as __builtin_va_arg(), > which is same to native one. You are right;

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirt.dsc.inc: AARCH64: enable DXE image protection feature

On 02/22/17 12:54, Ard Biesheuvel wrote: > Enable the new DXE image protection for all image, i.e., FV images but > also external images that originate from disk or the network, such as > OS loaders. > > This complements work that is underway on the arm64/Linux kernel side, > to emit the OS loader

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Replace EFI_D_xxx with DEBUG_xxx in DEBUG()

On 02/22/17 08:55, Jeff Fan wrote: > Cc: Laszlo Ersek > Cc: Feng Tian > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jeff Fan > --- > UefiCpuPkg/CpuDxe/CpuDxe.c | 8 > UefiCpuPkg/CpuDxe/CpuMp.c | 6 +++--- > 2 files changed, 7 insert

  1   2   >