Re: [edk2] [Patch 0/4 V3] BaseTools: Enable multiple thread to generate FFS file

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Wednesday, November 29, 2017 10:02 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [Patch 0/4 V3] BaseTools: Enable multiple thread to generate >FFS file

Re: [edk2] DHCP Process Starts Even there is NO Media Connected

Please review the patch [Patch] MdeModulePkg/Universal/Network/Dhcp4Dxe: Implantation of handling EFI_NO_MEDIA status code for DHCP4/6.Start() NetworkPkg/Dhcp6Dxe : Implantation of handling EFI_NO_MEDIA status code for DHCP4/6.Start() MdeModulePkg/Universal/Network/Dhcp4Dxe/ Dhcp4Impl.c | 11

Re: [edk2] DHCP Process Starts Even there is NO Media Connected

Hi Jiaxin, I've updated the patch changes for Dhcp6Dxe driver also and attached the same for review. Filed a tracker in TianoCore Bugzilla for this issue and attached the changes for review, https://bugzilla.tianocore.org/show_bug.cgi?id=804 Thanks, Karunakar -Original Message- From:

Re: [edk2] DHCP Process Starts Even there is NO Media Connected

Hi Karunakar, Per your question #3.c, I think it's *unreasonable* to check Media Status for EFI_IP4_CONFIG2_SET_DATA. Even there is no media connected, we still need to set the data instead of return directly. If the EFI_IP4_CONFIG2_SET_DATA.SetData() is to set the DHCP policy, the SetData()

Re: [edk2] edk2 interface deprecation policy

How about the case below for example? They all have comments " This library instance is no longer used and module using this library class should update to directly ..." for a very long time (since 2009) and no one should use them, when could they be removed? Literally, they seems useful, and

[edk2] [PATCH v3 09/11] UefiCpuPkg/CpuDxe: Initialize stack switch for MP

> v3: > a. Remove definition of EXCEPTION_STACK_SWITCH_DATA. > Use CPU_EXCEPTION_INIT_DATA_EX defined in CpuExceptionHandlerLib.h > intead. > b. Call new API InitializeCpuExceptionHandlersEx instead to initialize > stack switch for BSP and AP > v2: >Add code to reserve resources

[edk2] [PATCH v3 10/11] MdeModulePkg/Core/Dxe: Call new API InitializeCpuExceptionHandlersEx instead

> v3: >Newly added Original API InitializeCpuExceptionHandlers is used in DxeMain to initialize exception handlers but it does not support setting up stack switch required by Stack Guard feature. Using the new API instead to make sure Stack Guard feature is applicable to most part of code.

[edk2] [PATCH v3 11/11] MdeModulePkg/DxeIpl: Enable paging for Stack Guard

Stack guard feature makes use of paging mechanism to monitor if there's a stack overflow occurred during boot. This patch will check setting of PCD PcdCpuStackGuard. If it's TRUE, DxeIpl will setup page table and set the page at which the stack base locates to be NOT PRESENT. If stack is used up

[edk2] [PATCH v3 08/11] UefiCpuPkg/MpLib: Add GDTR, IDTR and TR in saved AP data

> v3: >No change > v2: >Add code to save/restore GDTR, IDTR and TR for AP. In current implementation of CPU MP service, AP is initialized with data copied from BSP. Stack switch required by Stack Guard feature needs different GDT, IDT table and task gates for each logic processor. This

[edk2] [PATCH v3 07/11] ArmPkg/ArmExceptionLib: Add implementation of new API

> v3: >Newly added This patch add implementation of following new API introduced into CpuExceptionHandlerLib. Since this lib hasn't support Stack Guard and stack switch, the new method just calls original InitializeCpuExceptionHandlers. EFI_STATUS EFIAPI

[edk2] [PATCH v3 03/11] MdeModulePkg/CpuExceptionHandlerLib.h: Add a new API InitializeCpuExceptionHandlersEx

> v3: > a. Change InitializeCpuExceptionStackSwitchHandlers() to > InitializeCpuExceptionHandlersEx() to be more general. > b. Add structure definition CPU_EXCEPTION_INIT_DATA_EX for new API > v2: >Add prototype definition of InitializeCpuExceptionStackSwitchHandlers() A new API

[edk2] [PATCH v3 01/11] MdeModulePkg/metafile: Add PCD PcdCpuStackGuard

PcdCpuStackGuard is introduced to enable/disable Stack Guard feature. Its value is FALSE by default. This feature is suggested to be enabled only if the cpu driver and CpuExceptionHandlerLib have supported stack switch for the processor used in platform. Otherwise the exception dump message won't

[edk2] [PATCH v3 04/11] MdePkg/BaseLib: Add stack switch related definitions for IA32

> v3: >Move two general macros here from CpuExceptionHandlerLib > v2: >Add new definitions required by stack switch in IA32 The new definitions include two structures IA32_TASK_STATE_SEGMENT IA32_TSS_DESCRIPTOR two macros IA32_GDT_TYPE_TSS IA32_GDT_ALIGNMENT and one API

[edk2] [PATCH v3 05/11] UefiCpuPkg/CpuExceptionHandlerLib: Add stack switch support

> v3: > a. Move more general definitions to BaseLib.h > b. Update code to use new data structure CPU_EXCEPTION_INIT_DATA_EX > c. Implement new API InitializeCpuExceptionHandlersEx for DxeException > d. Add dummy InitializeCpuExceptionHandlersEx for SEC, PEI and SMM > v2: > a. Move common TSS

[edk2] [PATCH v3 06/11] MdeModulePkg/CpuExceptionHandlerLibNull: Add new API implementation

> v3: >Newly added This patch add implementation of new API InitializeCpuExceptionHandlersEx introduced into CpuExceptionHandlerLib on behalf of Stack Guard feature. Cc: Star Zeng Cc: Eric Dong Cc: Jiewen Yao Suggested-by:

[edk2] [PATCH v3 02/11] UefiCpuPkg/UefiCpuPkg.dec: Add two new PCDs for stack switch

> v3: >No change > v2: >Add two new PCDs to configure exception stack switch. Stack switch is required by Stack Guard feature. Following two PCDs are introduced to simplify the resource allocation for initializing stack switch. gUefiCpuPkgTokenSpaceGuid.PcdCpuStackSwitchExceptionList

[edk2] [PATCH v3 00/11] Implement stack guard feature

> v3: > a. Change new API InitializeCpuExceptionStackSwitchHandlers() to > InitializeCpuExceptionHandlersEx(). Related code are updated accordingly. > b. Move EXCEPTION_STACK_SWITCH_DATA to CpuExceptionHandlerLib.h > and change the name to CPU_EXCEPTION_INIT_DATA_EX for the sake > of

[edk2] [platforms: PATCH 3/4] Marvell/Applications: FirmwareUpdate: Fix usage information

fupdate command's usage information referred to a deprecated flag in 'examples' section. Fix this and replace damaged FUpdate.uni file with its proper text version. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2] [platforms: PATCH 2/4] Marvell/Armada: Fix watchdog control base

Proper watchdog control base is 0xf061, so fix the incorrect value. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada/Armada.dsc.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [platforms: PATCH 4/4] Marvell/Drivers: MvPhyDxe: Cleanup the header

This patch removes unused macros defined in MvPhyDxe.h, as well as improves the style and comments. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Drivers/Net/Phy/MvPhyDxe/MvPhyDxe.c | 2 +-

[edk2] [platforms: PATCH 0/4] Armada 7k/8k - misc improvements pt.3

Hi, This patchset contains small fixes and improvements in the Armada platform support (re-enable tftp command, fix watchdog base, clean-up MvPhyDxe header and firmware update command's usage information). Right after these patches get merged, the file structure of the support will be reworked.

[edk2] [platforms: PATCH 1/4] Marvell/Armada: Switch to dynamic tftp command

After removal of the tftp library in EDK2, the tftp was disabled on Armada platform. Re-enable this functionality as a dynamic command. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada/Armada.dsc.inc | 1 +

Re: [edk2] edk2 interface deprecation policy

The negative impact is there will be more and more deprecated codes in the project. We'd better have an exit mechanism for them although some of them may need to be kept for compatibility case by case. Thanks, Star -Original Message- From: edk2-devel

Re: [edk2] edk2 interface deprecation policy

I prefer to remove all deprecated items because I like clean:) But then lots of customer complains may come. So just provide my thoughts: Deprecated items can be separated into: 1. Definitions: E.g.: UgaDraw protocol, DriverConfiguration2 protocol Keep: But harm the newbie developers

Re: [edk2] edk2 interface deprecation policy

Felix: I agree to define the tag to specify the deprecated definition, library and drivers. If so, user can easily know which one is not used any more. But, I think we can still keep them in edk2 project, because they have no negative impact. Thanks Liming >-Original Message- >From:

Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal

Laszlo, Thank you very much for that! I will try to become a talkaholic when writing commit messages next time. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, November 30, 2017 9:16 PM > To: Laszlo Ersek > Cc: Ni,

Re: [edk2] [PATCH] IntelSiliconPkg: Update MicrocodeUpdate build path in dsc

Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Zeng, Star Sent: Friday, December 1, 2017 9:20 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Bi, Dandan ; Yao, Jiewen Subject: [PATCH]

Re: [edk2] [PATCH] IntelSiliconPkg: Update MicrocodeUpdate build path in dsc

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Friday, December 1, 2017 9:20 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Bi, Dandan ; Yao, > Jiewen > Subject: [PATCH]

[edk2] [PATCH] IntelSiliconPkg: Update MicrocodeUpdate build path in dsc

That was missed in 43e12eeac8b125165b8a93c3501925a8893544ef. Cc: Dandan Bi Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- IntelSiliconPkg/IntelSiliconPkg.dsc | 4 ++-- 1 file

Re: [edk2] Enabling boot menu via serial & PXE boot in CorebootPayloadPkg

Hi, Cameron, > Interestingly, my debug build was complaining that it ran out of room when > attempting to fit everything in the UEFIPAYLOAD. > When I strip out the network additions and keep DEBUG on, Tianocore builds but > errors at runtime: > ``` > Failed to add memory space :0xFEE0

Re: [edk2] [RFC v1 00/15] *** Proposal for StandaloneMmPkg ***

On Tue, 2017-11-28 at 07:00 +, Yao, Jiewen wrote: > HI > I am sorry that I missed this mail before. > > I found only 0/15 and 13/15 are in my mail box. :-( > I do not know why others are filtered. This was deliberate as PATCH 13/15 implements MM core code. Rest of them are/were AARCH64

Re: [edk2] edk2 interface deprecation policy

I agree. It would be beneficial to have a mailing list discussion on how to deal with the deprecated item. In some cases it would make sense to tag an interface as deprecated, but keep in the code base for a while (6 month?) before actually deleting it. -Original Message- From:

[edk2] [PATCH RFT] ArmVirtPkg/ArmVirtXen: move from Intel to generic BDS

ArmVirtXen is the only remaining consumer of ArmPlatformPkg's PlatformIntelBdsLib implementation, which is tightly coupled to the deprecated Intel BDS. So move ArmVirtXen to the generic BDS as well, allowing us to get rid of PlatformIntelBdsLib entirely. Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH v2 0/8] OvmfPkg: add the Variable PEIM, defragment the UEFI memmap

As I recall, this enables a modest (non-essential) improvement in fragmentation, at the cost of more ways to configure OVMF to hang during boot. (With info available via debugcon.) I would prefer if were able to always fallback and continue boot. Later, after GOP has started we could visibly warn

[edk2] [PATCH edk2-platforms] Silicon/Fip006Dxe: map NOR_FLASH_INFO FSR flag with instance flag

From: Pipat Methavanitpong Now that we incorporated NorFlashInfoLib into the Fip006Dxe driver, replace the code that explicitly enables flag status register polling for Micron NOR flash with a test of the flags field provided by NorFlashInfoLib, which carries

[edk2] [PATCH edk2-platforms v2] Silicon/SynQuacer: enable coherent DMA for NETSEC and eMMC

As it turns out, it is surprisingly easy to configure both the NETSEC and eMMC devices as cache coherent for DMA, given that they are both behind the same SMMU which is already configured in passthrough mode by the firmware running on the SCP. So update the static SMMU configuration to make

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacerPciHostBridgeLib: enable Gen2 speed

On 29 November 2017 at 19:12, Leif Lindholm wrote: > On Wed, Nov 29, 2017 at 06:44:59PM +, Ard Biesheuvel wrote: >> As it turns out, getting the PCIe controllers to switch to Gen2 speed >> is surprisingly easy. It only involves setting the 'speed change' bit >> in

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacerPciHostBridgeLib: fix weird indentation

On 29 November 2017 at 19:24, Laszlo Ersek wrote: > Hi Ard, > > On 11/29/17 19:35, Ard Biesheuvel wrote: >> Fix the weird indentation in the various #defines in the file containing >> the RC init code. This is a whitespace only change. >> >> Contributed-under: TianoCore

Re: [edk2] [PATCH 6/7] ArmPlatformPkg/PrePi; call all constructors by hand

On 30 November 2017 at 16:45, Leif Lindholm wrote: > On Thu, Nov 30, 2017 at 04:35:41PM +, Ard Biesheuvel wrote: >> On 30 November 2017 at 16:31, Leif Lindholm wrote: >> > On Thu, Nov 30, 2017 at 03:24:52PM +, Ard Biesheuvel wrote: >>

Re: [edk2] [PATCH edk2-platforms] Platform Silicon: remove ArmPlatformInitializeSystemMemory () functions

On 30 November 2017 at 16:34, Leif Lindholm wrote: > On Thu, Nov 30, 2017 at 04:13:06PM +, Ard Biesheuvel wrote: >> The function ArmPlatformInitializeSystemMemory () has been removed from >> ArmPlatformLib, so remove all the [empty] implementations provided by >> the

Re: [edk2] edk2 interface deprecation policy

Felix, I don't think we have one Adding new interfaces does not impact the downstream projects, but depreciating interface can break stuff. Seems like it might at least be a good idea to have a depreciation discussion on the mailing list. I'm open to other suggestions Thanks,

Re: [edk2] [PATCH 6/7] ArmPlatformPkg/PrePi; call all constructors by hand

On Thu, Nov 30, 2017 at 04:35:41PM +, Ard Biesheuvel wrote: > On 30 November 2017 at 16:31, Leif Lindholm wrote: > > On Thu, Nov 30, 2017 at 03:24:52PM +, Ard Biesheuvel wrote: > >> Call ProcessLibraryConstructorList () to invoke all library constructors > >> by

Re: [edk2] [PATCH 6/7] ArmPlatformPkg/PrePi; call all constructors by hand

On 30 November 2017 at 16:31, Leif Lindholm wrote: > On Thu, Nov 30, 2017 at 03:24:52PM +, Ard Biesheuvel wrote: >> Call ProcessLibraryConstructorList () to invoke all library constructors >> by hand rather than calling only some of them explicitly. >> >>

Re: [edk2] [PATCH edk2-platforms] Platform Silicon: remove ArmPlatformInitializeSystemMemory () functions

On Thu, Nov 30, 2017 at 04:13:06PM +, Ard Biesheuvel wrote: > The function ArmPlatformInitializeSystemMemory () has been removed from > ArmPlatformLib, so remove all the [empty] implementations provided by > the various platforms. > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [PATCH 6/7] ArmPlatformPkg/PrePi; call all constructors by hand

On Thu, Nov 30, 2017 at 03:24:52PM +, Ard Biesheuvel wrote: > Call ProcessLibraryConstructorList () to invoke all library constructors > by hand rather than calling only some of them explicitly. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel

[edk2] [PATCH v2 8/8] OvmfPkg/README: document MEM_VARSTORE_EMU_ENABLE and memmap defrag

Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ---

[edk2] [PATCH v2 6/8] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: don't set flash PCDs if SMM or no-emu

... only check them. When OVMF is built with -D SMM_REQUIRE or with -D MEM_VARSTORE_EMU_ENABLE=FALSE then the PCDs are set during the PEI phase, as part of FaultTolerantWritePei's startup (in FlashNvStorageAddressLib's constructor). Cc: Anthony Perard Cc: Ard

[edk2] [PATCH v2 4/8] OvmfPkg: introduce FlashNvStorageAddressLib

An OVMF binary built with -D SMM_REQUIRE or with -D MEM_VARSTORE_EMU_ENABLE=FALSE requires flash to be present at the expected (build-time determined) location; falling back to the emulated varstore is not possible. In such builds, we can replace the settings of the - varstore, - FTW

[edk2] [PATCH v2 7/8] OvmfPkg/PlatformPei: remedy UEFI memory map fragmentation

The Memory Type Information HOB is used for sizing the allocation bins for the various memory types. If the PEI phase does not produce the HOB, and it includes the VariablePei driver, then the DXE IPL PEIM will itself build the HOB, from the "MemoryTypeInformation" non-volatile variable. (The HOB

[edk2] [PATCH v2 3/8] OvmfPkg: conditionally disable reserved memory varstore emulation at build

(All of the below is only relevant for SMM_REQUIRE=FALSE.) For the emulated variable store, PlatformPei allocates reserved memory (as early as possible, so that the address remains the same during reboot), and PcdEmuVariableNvStoreReserved carries the address to EmuVariableFvbRuntimeDxe. In

[edk2] [PATCH v2 5/8] OvmfPkg: include FaultTolerantWritePei and VariablePei

... but only for the -D SMM_REQUIRE and -D MEM_VARSTORE_EMU_ENABLE=FALSE builds, where - FaultTolerantWritePei can immediately consume PcdFlashNvStorageFtwWorkingBase and PcdFlashNvStorageFtwSpareBase, - and VariablePei can immediately consume PcdFlashNvStorageVariableBase64, with the

[edk2] [PATCH v2 0/8] OvmfPkg: add the Variable PEIM, defragment the UEFI memmap

Repo: https://github.com/lersek/edk2.git Branch: memmap_defrag_v2 This version is identical to the v1 seres I posted in March. Some patches of the v1 series have been committed. I've been rebasing and using the rest since, and am now posting it as v2. References: *

[edk2] [PATCH v2 2/8] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: check PcdMemVarstoreEmuEnable

This patch parallels commit b963ec494c48 ("OvmfPkg: QemuFlashFvbServicesRuntimeDxe: adhere to -D SMM_REQUIRE", 2015-11-30) in that if QemuFlashDetected() fails -- because flash is not found --, not only SMM_REQUIRE=TRUE is a wrong build to execute, but MEM_VARSTORE_EMU_ENABLE=FALSE as well. Cc:

[edk2] [PATCH v2 1/8] OvmfPkg: introduce PcdMemVarstoreEmuEnable feature flag

... and the corresponding MEM_VARSTORE_EMU_ENABLE build define, which defaults to TRUE. Setting the build flag to FALSE will later enable the exclusion of the dynamically allocated, emulated, in-memory varstore. Cc: Anthony Perard Cc: Ard Biesheuvel

Re: [edk2] [platforms: PATCH v3 0/4] Armada 7k/8k variable support

2017-11-30 16:51 GMT+01:00 Leif Lindholm : > On Tue, Nov 28, 2017 at 09:19:09AM +0100, Marcin Wojtas wrote: >> Hi, >> >> I submit v3 of the Armada variable support with the MvFvbDxe >> driver improved according to the recent review. The biggest >> changes are a proper

[edk2] [PATCH edk2-platforms] Platform Silicon: remove ArmPlatformInitializeSystemMemory () functions

The function ArmPlatformInitializeSystemMemory () has been removed from ArmPlatformLib, so remove all the [empty] implementations provided by the various platforms. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

Re: [edk2] [PATCH 0/7] ArmPlatformPkg cleanup - phase II

On 30 November 2017 at 15:55, Leif Lindholm wrote: > On Thu, Nov 30, 2017 at 02:15:02PM +, Ard Biesheuvel wrote: >> Proceed with removing junk from ArmPlatformPkg, and tidying up the bits >> we want to keep. >> >> While we make up our minds how to proceed with the

Re: [edk2] [PATCH 0/7] ArmPlatformPkg cleanup - phase II

On Thu, Nov 30, 2017 at 02:15:02PM +, Ard Biesheuvel wrote: > Proceed with removing junk from ArmPlatformPkg, and tidying up the bits > we want to keep. > > While we make up our minds how to proceed with the migration of > ArmVExpressPkg, and the dependent BootMonFs and ShellCmdRunAxf

Re: [edk2] [platforms: PATCH v3 0/4] Armada 7k/8k variable support

On Tue, Nov 28, 2017 at 09:19:09AM +0100, Marcin Wojtas wrote: > Hi, > > I submit v3 of the Armada variable support with the MvFvbDxe > driver improved according to the recent review. The biggest > changes are a proper implementation of Set/GetAttributes > protocol callbacks. Details can be found

[edk2] [PATCH 7/7] ArmPlatformPkg/PrePi: remove bogus IntelFrameworkModulePkg reference

PrePi does not use anything from IntelFrameworkModulePkg so remove the reference from its [Packages] sections. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/PrePi/PeiMPCore.inf | 1 -

[edk2] [PATCH 6/7] ArmPlatformPkg/PrePi; call all constructors by hand

Call ProcessLibraryConstructorList () to invoke all library constructors by hand rather than calling only some of them explicitly. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/PrePi/PrePi.c | 13 +++--

[edk2] [PATCH 5/7] ArmPlatformPkg/MemoryInitPeiLib: don't reserve primary FV in memory

From: Meenakshi Aggarwal Now that PrePi no longer exposes its internal code via special HOBs, we can remove the special handling of the primary FV, which needed to be reserved so that DXE core could call into the PE/COFF and LZMA libraries in the PrePi module.

[edk2] [PATCH 4/7] ArmPlatformPkg/PrePi: don't expose PE/COFF and LZMA libraries via HOBs

Avoid the need to preserve all memory exposed by PrePi indefinitely by removing the 'feature' that exposes the PE/COFF and LZMA libraries via special HOBs to other modules that may want to reuse the code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 0/7] ArmPlatformPkg/PrePi: stop exposing internal code via HOBs

This removes the code from PrePi and MemoryInitPeiLib that keeps the primary FV around forever so that DXE phase code can reuse some of the code inside the PrePi module. Cc: Udit Kumar Cc: Meenakshi Aggarwal Cc: Sakar Arora

[edk2] [PATCH 3/7] BeagleBoardPkg: clone MemoryInitPeiLib

The common MemoryInitPeiLib implementation preserves the primary FV holding the PrePi module and the compressed secondary FV, and removes the memory it occupies from the memory map, hiding it from the OS. The only platform that actual requires this is BeagleBoardPkg, since it exposes the PeCoff

[edk2] [PATCH 2/7] BeagleBoardPkg: create private PrePi implementation

Clone the PrePi implementation for BeagleBoardPkg, so we can start removing some of the awkward optimizations that we'd rather not keep in reference code. Note that we only clone the unicore ARM flavor, which is all we need for BeagleBoard. In the case of PrePi, it involves libraries included by

[edk2] [PATCH 1/7] EmbeddedPkg BeagleBoardPkg: move special HOB reuse libraries into platform

The BeagleBoard platform uses PeCoffLib and CustomDecompressLib implementations that invoke the library code that resides in the PrePi module via pointers exposed via special GUIDed HOBs. This is a nice hack, but not necessarily something we want to carry in reference code. So as a first step,

Re: [edk2] [PATCH edk2-platforms] Platform: drop tftp shell support from remaining platforms

On Thu, Nov 30, 2017 at 03:02:47PM +, Ard Biesheuvel wrote: > On 30 November 2017 at 15:01, Leif Lindholm wrote: > > Cello, Overdrive, Overdrive1000 and Armada still include the > > now-defunct library implementation of the Shell tftp command. > > Since the command

Re: [edk2] [PATCH edk2-platforms] Platform: drop tftp shell support from remaining platforms

On 30 November 2017 at 15:01, Leif Lindholm wrote: > Cello, Overdrive, Overdrive1000 and Armada still include the > now-defunct library implementation of the Shell tftp command. > Since the command is a nonstandard one anyway, just remove > it from the build for these

Re: [edk2] DHCP Process Starts Even there is NO Media Connected

We saw some problems running Linux UEFI Validation (LUV) at the last UEFI Plugfest that are probably related to this issue. At the time we asked the LUV team to investigate it as a test issue, but it may actually be a stack problem based on this information. Have you filed a tracker in

[edk2] [PATCH edk2-platforms] Platform: drop tftp shell support from remaining platforms

Cello, Overdrive, Overdrive1000 and Armada still include the now-defunct library implementation of the Shell tftp command. Since the command is a nonstandard one anyway, just remove it from the build for these platforms. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif

Re: [edk2] [PATCH v2] Omap35xxPkg: add GetTimeInNanoSecond implementation

On Thu, Nov 30, 2017 at 02:24:24PM +, Ard Biesheuvel wrote: > On 30 November 2017 at 14:22, Leif Lindholm wrote: > > Commit a63be426f8e3 ("ArmPlatformPkg: Store initial timer value") caused > > BeagleBoard to stop building, due to Omap35xxTimerLib lacking an > >

Re: [edk2] [PATCH edk2-platforms] Platform: remove gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec

On 30 November 2017 at 14:31, Leif Lindholm wrote: > On Thu, Nov 30, 2017 at 01:59:47PM +, Ard Biesheuvel wrote: >> Remove references to the ArmPlatformPkg PCD PcdSystemMemoryInitializeInSec, >> which is only used on PrePeiCore platforms anyway, and which has no

Re: [edk2] [PATCH v2] PeiLib : Inform UEFI memory to Linux

On 30 November 2017 at 10:07, Udit Kumar wrote: > Hi Ard, > Sorry for coming back late on this > Are you ok to apply this patch in edk2 > Actually, I recently discovered why this code exists in the first place (I think) The following libraries

Re: [edk2] [PATCH edk2-platforms] Platform: remove gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec

On Thu, Nov 30, 2017 at 01:59:47PM +, Ard Biesheuvel wrote: > Remove references to the ArmPlatformPkg PCD PcdSystemMemoryInitializeInSec, > which is only used on PrePeiCore platforms anyway, and which has no effect > whatsoever given that it decides when ArmPlatformInitializeSystemMemory() >

Re: [edk2] [PATCH edk2-platforms] Platform, Silicon: Update Hisilicon Shell tftp command config

On Thu, Nov 30, 2017 at 01:30:45PM +, Ard Biesheuvel wrote: > On 30 November 2017 at 12:00, Leif Lindholm wrote: > > EDK2 changed the tftp shell command from a library to a > > dynamic command. Update configuration files to reflect this. > > > > Contributed-under:

Re: [edk2] [PATCH v2] Omap35xxPkg: add GetTimeInNanoSecond implementation

On 30 November 2017 at 14:22, Leif Lindholm wrote: > Commit a63be426f8e3 ("ArmPlatformPkg: Store initial timer value") caused > BeagleBoard to stop building, due to Omap35xxTimerLib lacking an > implementation of GetTimeInNanoSecond (). So add one. > > Contributed-under:

[edk2] [PATCH v2] Omap35xxPkg: add GetTimeInNanoSecond implementation

Commit a63be426f8e3 ("ArmPlatformPkg: Store initial timer value") caused BeagleBoard to stop building, due to Omap35xxTimerLib lacking an implementation of GetTimeInNanoSecond (). So add one. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm

Re: [edk2] [PATCH 1/2] Omap35xxPkg: add GetTimeInNanoSecond implementation

On Thu, Nov 30, 2017 at 02:09:33PM +, Ard Biesheuvel wrote: > On 30 November 2017 at 14:07, Leif Lindholm wrote: > > Commit a63be426f8e3 ("ArmPlatformPkg: Store initial timer value") caused > > BeagleBoard to stop building, due to Omap35xxTimerLib lacking an > >

[edk2] [PATCH 3/7] ArmPlatformPkg/ArmPlatformLib: remove ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR

The ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR struct type is defined but never used anywhere. So remove it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/Include/Library/ArmPlatformLib.h | 13 - 1 file

[edk2] [PATCH 4/7] ArmPlatformPkg: remove ArmPlatformInitializeSystemMemory

The function ArmPlatformInitializeSystemMemory() is defined by ArmPlatformLib, but is only ever called when using the PrePeiCore flavor of the startup code. Also, none of the remaining upstream platforms actually implement anything in that function in the first place. So let's just remove it

[edk2] [PATCH 0/7] ArmPlatformPkg cleanup - phase II

Proceed with removing junk from ArmPlatformPkg, and tidying up the bits we want to keep. While we make up our minds how to proceed with the migration of ArmVExpressPkg, and the dependent BootMonFs and ShellCmdRunAxf modules, this series removes the outdated documentation and CTA9x4 code, moves

[edk2] [PATCH 2/7] ArmPlatformPkg: remove unused ArmVExpressLibCTA9x4 code

ArmVExpressLibCTA9x4 is unused, and rather outdated, given that it is the last ArmPlatformLib implementation that executes both in the secure and non-secure worlds, which is a model we no longer support for ARM systems. So remove it. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH 6/7] ArmPlatformPkg: move internal SP805 header into driver directory

Move the internal SP805 watchdog header file into the driver directory. It shouldn't be referenced directly by other modules anyway. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH 7/7] ArmPlatformPkg: move internal PL031 header into driver directory

Move the internal PL031 RTC header file into the driver directory. It shouldn't be referenced directly by other modules anyway. While at it, sort the includes as well. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH 5/7] ArmPlatformPkg: move internal PL061 header into driver directory

Move the internal PL061 GPIO header file into the driver directory. It shouldn't be referenced directly by other modules anyway. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c

Re: [edk2] Enabling boot menu via serial & PXE boot in CorebootPayloadPkg

Hi Benjamin, Thanks for the pointers. >> On networking, you might refer to the Minnow Board v3 source tree, at >> https://github.com/tianocore/edk2-platforms/tree/devel-MinnowBoard3- >> UDK2017 >> >> Minnow Board v3 uses the same SOC as Leaf Hill. You might look at >>

Re: [edk2] [PATCH 2/2] BeagleBoardPkg: add CapsuleLib resolution

On 30 November 2017 at 14:07, Leif Lindholm wrote: > Commit 4bbcc285d5f7 ("ArmPkg/PlatformBootManagerLib: process pending > capsules") added a dependency on CapsuleLib. Add DxeCapsuleLibNull > resolution to BeagleBoardPkg.dsc to resolve this. > > Contributed-under:

Re: [edk2] [PATCH 1/2] Omap35xxPkg: add GetTimeInNanoSecond implementation

On 30 November 2017 at 14:07, Leif Lindholm wrote: > Commit a63be426f8e3 ("ArmPlatformPkg: Store initial timer value") caused > BeagleBoard to stop building, due to Omap35xxTimerLib lacking an > implementation of GetTimeInNanoSecond (). So add one. > > Contributed-under:

[edk2] [PATCH 1/2] Omap35xxPkg: add GetTimeInNanoSecond implementation

Commit a63be426f8e3 ("ArmPlatformPkg: Store initial timer value") caused BeagleBoard to stop building, due to Omap35xxTimerLib lacking an implementation of GetTimeInNanoSecond (). So add one. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm

[edk2] [PATCH 2/2] BeagleBoardPkg: add CapsuleLib resolution

Commit 4bbcc285d5f7 ("ArmPkg/PlatformBootManagerLib: process pending capsules") added a dependency on CapsuleLib. Add DxeCapsuleLibNull resolution to BeagleBoardPkg.dsc to resolve this. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm

[edk2] edk2 interface deprecation policy

Does edk2 have a policy regarding deprecation of interface definition headers? I can see that definition of the UgaDraw protocol that was deprecated years ago (I believe in UEFI 2.0) is still part of the code base; yet, definition of the SMM Communication ACPI Table that was deprecated this year

[edk2] [PATCH edk2-platforms] Platform: remove gArmPlatformTokenSpaceGuid.PcdSystemMemoryInitializeInSec

Remove references to the ArmPlatformPkg PCD PcdSystemMemoryInitializeInSec, which is only used on PrePeiCore platforms anyway, and which has no effect whatsoever given that it decides when ArmPlatformInitializeSystemMemory() is called, which is implemented as an empty function by all these

Re: [edk2] [PATCH edk2-platforms] Platform/ARM: move to new TFTP Shell command implementation

On 30 November 2017 at 11:28, Joakim Bech wrote: > On Thu, Nov 30, 2017 at 10:56:20AM +, Leif Lindholm wrote: >> On Thu, Nov 30, 2017 at 09:07:21AM +, Ard Biesheuvel wrote: >> > Upstream EDK2 has refactored the implementation of the TFTP Shell >> > command so

Re: [edk2] [PATCH edk2-platforms] Platform, Silicon: Update Hisilicon Shell tftp command config

On 30 November 2017 at 12:00, Leif Lindholm wrote: > EDK2 changed the tftp shell command from a library to a > dynamic command. Update configuration files to reflect this. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm

Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal

On 30 November 2017 at 12:22, Laszlo Ersek wrote: > On 11/29/17 14:53, Laszlo Ersek wrote: >> Ray, >> >> On 11/29/17 11:14, Ruiyu Ni wrote: >>> The TFTP command was converted from a NULL class library >>> instance to a dynamic shell command in commit 0961002352e9. >>> >>>

Re: [edk2] [PATCH v4 3/3] BeagleBoardPkg: Fix build failure due to Tftp library removal

On 11/29/17 12:30, Leif Lindholm wrote: > On Wed, Nov 29, 2017 at 06:15:00PM +0800, Ruiyu Ni wrote: >> The TFTP command was converted from a NULL class library >> instance to a dynamic shell command in commit 0961002352e9. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >>

Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal

On 11/29/17 14:53, Laszlo Ersek wrote: > Ray, > > On 11/29/17 11:14, Ruiyu Ni wrote: >> The TFTP command was converted from a NULL class library >> instance to a dynamic shell command in commit 0961002352e9. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ruiyu Ni

Re: [edk2] [PATCH edk2-platforms] Platform/Hisilicon: drop BdsLib inclusion from HiKey .dsc

On Thu, Nov 30, 2017 at 11:13:49AM +, Ard Biesheuvel wrote: > > > > On 30 Nov 2017, at 10:46, Leif Lindholm wrote: > > > > The ArmPkg BdsLib has been dropped from EDK2, and is no longer > > required by the Android*Boot applications - so delete the > > reference to

[edk2] [PATCH edk2-platforms] Platform, Silicon: Update Hisilicon Shell tftp command config

EDK2 changed the tftp shell command from a library to a dynamic command. Update configuration files to reflect this. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- Platform/Hisilicon/D02/Pv660D02.dsc | 6 +++---

  1   2   >