Re: [edk2] [PATCH] SecurityPkg: Tcg2Smm: Fix type casting issue

2018-02-07 Thread Wu, Hao A
Hi Chao, The change is good to me. How about changing the commit title and body into: SecurityPkg/Tcg2Smm: Refine type cast for pointer subtraction Since the pointer subtraction here is not performed by pointers to elements of the same array object. This might lead to potential issues, such

Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-07 Thread Ard Biesheuvel
On 8 February 2018 at 01:35, Laszlo Ersek wrote: > On 02/08/18 00:48, Kinney, Michael D wrote: >> Laszlo, >> >> The BmpSupportLib content was from contributions from >> a capsule related branch. However, the BmpSupportLib >> can be used for UX capsules as well as other places

[edk2] [Patch] BaseTools GenFv: Update error message to describe PE image alignment

2018-02-07 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Source/C/GenFv/GenFvInternalLib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c

Re: [edk2] [PATCH] SourceLevelDebugPkg DebugUsb3: Support IOMMU

2018-02-07 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star Zeng > Sent: Tuesday, February 6, 2018 8:23 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Wu, Hao A

Re: [edk2] [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to DebugAgentIsBsp

2018-02-07 Thread Ni, Ruiyu
Remember to update the copyright year when committing the patch. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, > Ruiyu > Sent: Wednesday, February 7, 2018 11:30 AM > To: Zeng, Star ;

Re: [edk2] [PATCH] UefiCpuPkg/FeaturesLib: don't init MCi_CTL/STATUS when MCA's disabled

2018-02-07 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Ni, Ruiyu Sent: Thursday, February 8, 2018 2:44 PM To: edk2-devel@lists.01.org Cc: Dong, Eric Subject: [PATCH] UefiCpuPkg/FeaturesLib: don't init MCi_CTL/STATUS when MCA's disabled Today's

[edk2] [PATCH] UefiCpuPkg/FeaturesLib: don't init MCi_CTL/STATUS when MCA's disabled

2018-02-07 Thread Ruiyu Ni
Today's McaInitialize() doesn't check State value before initialize MCi_CTL and MCi_STATUS. The patch fixes this issue by only initializing the two kinds of MSRs when State is enabled. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Eric

Re: [edk2] [PATCH v2] UefiCpuPkg/S3Resume: Add more perf entry for S3 phase

2018-02-07 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Bi, Dandan >Sent: Thursday, February 08, 2018 2:20 PM >To: edk2-devel@lists.01.org >Cc: Dong, Eric ; Laszlo Ersek ; >Gao, Liming >Subject: [PATCH v2]

[edk2] [PATCH] SecurityPkg: Tcg2Smm: Fix type casting issue

2018-02-07 Thread Zhang, Chao B
Fix type casting issue when calculating pointers offset Cc: Wu Hao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang --- SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[edk2] [PATCH v2] UefiCpuPkg/S3Resume: Add more perf entry for S3 phase

2018-02-07 Thread Dandan Bi
V2: Just update the commit message. Add more perf entry to hook BootScriptDonePpi/EndOfPeiPpi/ EndOfS3Resume. Add the new perf entry with Identifier PERF_INMODULE_START_ID/PERF_INMODULE_END_ID which are defined in new performance infrastructure (edk2 trunk commit hash value: SHA-1:

Re: [edk2] [Patch V2 1/3] MdeModulePkg/EsrtFmpDxe: Add EsrtFmpDxe module

2018-02-07 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Kinney, Michael D Sent: Thursday, February 8, 2018 6:38 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Sean Brogan ; Yao, Jiewen

Re: [edk2] [Patch] MdeModulePkg/DxeCapsuleLibFmp: Verify nested capsule with FMP

2018-02-07 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Yao, Jiewen Sent: Thursday, February 8, 2018 8:18 AM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric

Re: [edk2] [Patch 01/10] MdeModulePkg: Add BmpSupportLib class and instance

2018-02-07 Thread Zeng, Star
Reviewed-by: Star Zeng to MdeModulePkg change with a minor comment below. Update the comments in MdeModulePkg/Include/Library/BmpSupportLib.h and MdeModulePkg.dec? Provides services to convert a BMP graphics image to a GOP BLT buffer. -> Provides services to convert a BMP

[edk2] [PATCH] ShellPkg/hexedit: Fix a read-after-free bug

2018-02-07 Thread Ruiyu Ni
HDiskImageSetDiskNameOffsetSize() and HFileImageSetFileName() may be called using the current disk name or file name. When this happens, today's implementation firstly frees the memory and then accesses the just-freed memory. The patch fixes this issue by doing nothing when the disk or file name

[edk2] [PATCH] ShellPkg/rm: fix hang when deleting an absolutely-empty directory An ordinary empty directory should contain "." and ".." entries. When an empty directory even doesn't contain "." or ".

2018-02-07 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [edk2] [PATCH v2 1/2] ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with decl.

2018-02-07 Thread Gary Lin
On Wed, Feb 07, 2018 at 11:44:34PM +0100, Laszlo Ersek wrote: > "Compress.h" declares the Compress() function as EFIAPI, but the > definition in "Compress.c" lacks EFIAPI. > > GCC toolchains without LTO do not catch this error because "Compress.c" > does not include "Compress.h"; i.e. the

Re: [edk2] [Patch] BaseTools: Fixed Build failed issue.

2018-02-07 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >BobCF >Sent: Tuesday, February 06, 2018 3:21 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [Patch]

Re: [edk2] [Patch] BaseTools: Fixed incorrect Structure Pcd Value.

2018-02-07 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Wednesday, February 07, 2018 12:10 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Fixed incorrect

Re: [edk2] [Patch] BaseTool: Fixed Pcd issues.

2018-02-07 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Wednesday, February 07, 2018 10:02 AM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTool: Fixed Pcd issues. > >1.

Re: [edk2] [Patch] BaseTools: not specified value of MAX_CONCURRENT_THREAD_NUMBER

2018-02-07 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Thursday, February 08, 2018 9:50 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: not specified value of

Re: [edk2] [PATCH 10/10] MdeModulePkg/ResetSystemPei: Add reset notifications in PEI

2018-02-07 Thread Zeng, Star
On 2018/2/7 20:40, Zeng, Star wrote: On 2018/2/2 14:45, Ruiyu Ni wrote: From: Bret Barkelew The Reset Notification protocol is added in UEFI spec to support reset notification mechanism in the DXE phase. This patch adds similar EDKII specific Reset Notification PPI to

Re: [edk2] [PATCH 09/10] MdeModulePkg: Add ResetSystemPei PEIM

2018-02-07 Thread Zeng, Star
Sorry for the trivial comments. 1. A typo "recurstion" should be "recursion" is in ResetSystem.h for both ResetSystemPei and ResetSystemRuntimeDxe. 2. Should "RUNTIME/runtime/RS" be "PEI" in the comments and code like below? // // Indicate reset system runtime service is called.

[edk2] [Patch V3] Build spec: Add description about auto detect thread number

2018-02-07 Thread Yonghong Zhu
V3: Update the build option help info Add description about enable auto detect thread number when MAX_CONCURRENT_THREAD_NUMBER is not specified. Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=775 Cc: Liming Gao Cc: Michael Kinney Cc:

Re: [edk2] [PATCH 07/10] MdeModulePkg: Add ResetUtility librray class and BASE instance

2018-02-07 Thread Zeng, Star
Sorry for the trivial comments. "@param[in] ResetType Base reset type as defined in UEFI spec." needs to be removed for ResetPlatformSpecificGuid. There is "in in" in the comments for the implementation of GetResetPlatformSpecificGuid(). May should be one "in" only? Thanks, Star On

[edk2] [Patch] BaseTools: not specified value of MAX_CONCURRENT_THREAD_NUMBER

2018-02-07 Thread Yonghong Zhu
V3: Update the build option help info when MAX_CONCURRENT_THREAD_NUMBER is not specified, tool will automatically detect number of processor threads. Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=775 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu

Re: [edk2] [PATCH 07/10] MdeModulePkg: Add ResetUtility librray class and BASE instance

2018-02-07 Thread Zeng, Star
Another minor comments is to remove below sentences in ResetUtilityLib.inf. > +# The application pops up a menu showing all the boot options referenced by > +# BootOrder NV variable and user can choose to boot from one of them. Thanks, Star On 2018/2/7 20:28, Zeng, Star wrote: On

Re: [edk2] [Patch] MdePkg/BaseSafeIntLib: Add SafeIntLib class and instance

2018-02-07 Thread Laszlo Ersek
On 02/08/18 01:32, Laszlo Ersek wrote: > On 12/19/17 20:36, Kinney, Michael D wrote: >> From: Sean Brogan >> >> SafeIntLib provides helper functions to prevent integer overflow >> during type conversion, addition, subtraction, and multiplication. > > I clearly cannot

Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-07 Thread Laszlo Ersek
On 02/08/18 00:48, Kinney, Michael D wrote: > Laszlo, > > The BmpSupportLib content was from contributions from > a capsule related branch. However, the BmpSupportLib > can be used for UX capsules as well as other places that > conversions between BMP and GOP BLT buffers are needed, > so it is

Re: [edk2] [Patch] MdePkg/BaseSafeIntLib: Add SafeIntLib class and instance

2018-02-07 Thread Laszlo Ersek
On 12/19/17 20:36, Kinney, Michael D wrote: > From: Sean Brogan > > SafeIntLib provides helper functions to prevent integer overflow > during type conversion, addition, subtraction, and multiplication. I clearly cannot review such a huge patch, but I've noticed

Re: [edk2] [Patch] MdeModulePkg/DxeCapsuleLibFmp: Verify nested capsule with FMP

2018-02-07 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Kinney, Michael D > Sent: Thursday, February 8, 2018 2:50 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star ; > Dong, Eric ; Kinney, Michael D >

Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-07 Thread Kinney, Michael D
Laszlo, The BmpSupportLib content was from contributions from a capsule related branch. However, the BmpSupportLib can be used for UX capsules as well as other places that conversions between BMP and GOP BLT buffers are needed, so it is a more generic feature. The SafeIntLib was also based on

Re: [edk2] [Patch 10/10] ArmVirtPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-07 Thread Laszlo Ersek
On 02/07/18 23:58, Kinney, Michael D wrote: > From: Michael D Kinney > > https://bugzilla.tianocore.org/show_bug.cgi?id=800 > > Based on content from the following branch/commits: > https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport >

Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-07 Thread Laszlo Ersek
Hi Mike, On 02/07/18 23:58, Kinney, Michael D wrote: > From: Michael D Kinney > > https://bugzilla.tianocore.org/show_bug.cgi?id=800 > > Based on content from the following branch/commits: > https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport >

[edk2] [Patch 08/10] DuetPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-07 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=800 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport

[edk2] [Patch 10/10] ArmVirtPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-07 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=800 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport

[edk2] [Patch 07/10] QuarkPlatformPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-07 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=800 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport

[edk2] [Patch 06/10] Vlv2TbltDevicePkg/Override/GenericBdsLib: Use BmpSupportLib

2018-02-07 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=800 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport

[edk2] [Patch 09/10] EmulatorPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-07 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=800 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport

[edk2] [Patch 03/10] MdeModulePkg/BootGraphicsResourceTableDxe: Use BmpSupportLib

2018-02-07 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=800 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport

[edk2] [Patch 04/10] IntelFrameworkModulePkg/GenericBdsLib: Use BmpSupportLib

2018-02-07 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=800 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport

[edk2] [Patch 02/10] MdeModulePkg/DxeCapsuleLibFmp: Use BmpSupportLib

2018-02-07 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=800 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport

[edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

2018-02-07 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=800 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport

[edk2] [Patch 00/10] Add BmpSupportLib class and instance

2018-02-07 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=800 Branch for review: https://github.com/mdkinney/edk2/commits/Bug_800_BmpSupportLib_V2 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport

[edk2] [Patch 01/10] MdeModulePkg: Add BmpSupportLib class and instance

2018-02-07 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=800 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d

Re: [edk2] [PATCH edk2-platforms v1 13/14] Hisilicon/Library: Add OsBootLib

2018-02-07 Thread Peter Jones
Coming late to the party because Leif called my attention to this thread... On Mon, Jan 29, 2018 at 11:16:21AM +, Leif Lindholm wrote: > This type of system behaviour has been seen multiple times to break > installations in the real world. I can't agree more; that's why there's a pile of

[edk2] [PATCH v2 1/2] ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with decl.

2018-02-07 Thread Laszlo Ersek
"Compress.h" declares the Compress() function as EFIAPI, but the definition in "Compress.c" lacks EFIAPI. GCC toolchains without LTO do not catch this error because "Compress.c" does not include "Compress.h"; i.e. the declaration used by callers such as "EfiCompress.c" is not actually matched

[edk2] [PATCH v2 0/2] sync some function definitions with their declarations

2018-02-07 Thread Laszlo Ersek
Repo: https://github.com/lersek/edk2.git Branch: sync_defs_to_decls_v2 This is version 2 of the series that I posted earlier. Because that series didn't reach the list at all, due to SMTP issues on my end, I'm including the v1 blurb here: > The patches say it all, just a side remark up here: >

[edk2] [PATCH v2 2/2] OvmfPkg/PlatformPei: sync AmdSevInitialize() definition with declaration

2018-02-07 Thread Laszlo Ersek
"Platform.h" declares the AmdSevInitialize() function without EFIAPI, but the definition in "AmdSev.c" includes EFIAPI. GCC toolchains without LTO do not catch this error because "AmdSev.c" does not include "Platform.h"; i.e. the declaration used by callers such as "Platform.c" is not actually

[edk2] [Patch V2 2/3] QuarkPlatformPkg: Switch from EsrtDxe to EsrtFmpDxe

2018-02-07 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=802 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport The EsrtFmpDxe module is a lightweight version of the EsrtDxe module that

[edk2] [Patch V2 0/3] MdeModulePkg/EsrtFmpDxe: Add EsrtFmpDxe module

2018-02-07 Thread Kinney, Michael D
V2: * Add .uni files with module name, abstract, description * Use EfiCreateEventReadyToBootEx() instead of gBS->CreateEventEx() * Change module type from UEFI_DRIVER to DXE_DRIVER with depex TRUE https://bugzilla.tianocore.org/show_bug.cgi?id=802 Branch for review:

[edk2] [Patch V2 1/3] MdeModulePkg/EsrtFmpDxe: Add EsrtFmpDxe module

2018-02-07 Thread Kinney, Michael D
From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=802 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport The EsrtFmpDxe module is a lightweight version of the EsrtDxe module that

[edk2] [Patch] MdeModulePkg/DxeCapsuleLibFmp: Verify nested capsule with FMP

2018-02-07 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=873 Update IsNestedFmpCapsule() to verify the CapsuleGuid in the CapsuleHeader against the installed Firmware Management Protocol instances. The current logic that uses the ESRT Table does not work because capsules are processed before the ESRT

Re: [edk2] [PATCH v2 1/1] MdePkg/Include: Add management mode FV file type and depex.

2018-02-07 Thread Supreeth Venkatesh
Liming, Thanks for your feedback. I have sent v3 of this patch with your feedback, incorporated. Supreeth -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Tuesday, February 6, 2018 9:43 PM To: Supreeth Venkatesh ;

[edk2] [PATCH v3 1/1] MdePkg/Include: Add management mode FV file type and depex.

2018-02-07 Thread Supreeth Venkatesh
As per PI specification v1.6, As per section 2.1.4.1, The following file types exist: Table 3. Defined File Types Name Value EFI_FV_FILETYPE_RAW0x01 EFI_FV_FILETYPE_FREEFORM 0x02 EFI_FV_FILETYPE_SECURITY_CORE 0x03

Re: [edk2] [issue] Arrow key can't be read on tty terminal in release build

2018-02-07 Thread Ard Biesheuvel
On 7 February 2018 at 16:43, Haojian Zhuang wrote: > On 8 February 2018 at 00:13, Ard Biesheuvel wrote: >> On 7 February 2018 at 16:12, Haojian Zhuang >> wrote: >>> On 7 February 2018 at 23:52, Ard Biesheuvel

Re: [edk2] [issue] Arrow key can't be read on tty terminal in release build

2018-02-07 Thread Haojian Zhuang
On 8 February 2018 at 00:13, Ard Biesheuvel wrote: > On 7 February 2018 at 16:12, Haojian Zhuang wrote: >> On 7 February 2018 at 23:52, Ard Biesheuvel >> wrote: >>> On 7 Feb 2018, at 15:50, Haojian Zhuang

Re: [edk2] [edk2-platforms][PATCH] Platform/Hisilicon/HiKey960: add skeleton of HiKey960

2018-02-07 Thread Leif Lindholm
On Wed, Feb 07, 2018 at 11:45:54PM +0800, Haojian Zhuang wrote: > On 7 February 2018 at 01:29, Leif Lindholm wrote: > > On Mon, Feb 05, 2018 at 04:25:52PM +0800, Haojian Zhuang wrote: > >> Add skeleton of HiKey960 platform. > >> > >> Contributed-under: TianoCore

Re: [edk2] [issue] Arrow key can't be read on tty terminal in release build

2018-02-07 Thread Ard Biesheuvel
On 7 February 2018 at 16:12, Haojian Zhuang wrote: > On 7 February 2018 at 23:52, Ard Biesheuvel wrote: >> >>> On 7 Feb 2018, at 15:50, Haojian Zhuang wrote: >>> >>> Hi all, >>> >>> I have an issue on tty terminal.

Re: [edk2] [issue] Arrow key can't be read on tty terminal in release build

2018-02-07 Thread Haojian Zhuang
On 7 February 2018 at 23:52, Ard Biesheuvel wrote: > >> On 7 Feb 2018, at 15:50, Haojian Zhuang wrote: >> >> Hi all, >> >> I have an issue on tty terminal. I setup PL011 serial console as the >> tty terminal on HiKey platform. When it's built

Re: [edk2] [issue] Arrow key can't be read on tty terminal in release build

2018-02-07 Thread Ard Biesheuvel
> On 7 Feb 2018, at 15:50, Haojian Zhuang wrote: > > Hi all, > > I have an issue on tty terminal. I setup PL011 serial console as the > tty terminal on HiKey platform. When it's built in debug mode, arrow > key works well. When it's built in release mode, arrow key

[edk2] [issue] Arrow key can't be read on tty terminal in release build

2018-02-07 Thread Haojian Zhuang
Hi all, I have an issue on tty terminal. I setup PL011 serial console as the tty terminal on HiKey platform. When it's built in debug mode, arrow key works well. When it's built in release mode, arrow key can't work. For example, DOWN key is gotten in terminal with "~[B" value in debug build.

Re: [edk2] [edk2-platforms][PATCH] Platform/Hisilicon/HiKey960: add skeleton of HiKey960

2018-02-07 Thread Haojian Zhuang
On 7 February 2018 at 01:29, Leif Lindholm wrote: > On Mon, Feb 05, 2018 at 04:25:52PM +0800, Haojian Zhuang wrote: >> Add skeleton of HiKey960 platform. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Haojian Zhuang

Re: [edk2] [PATCH edk2-platforms v4 00/15] Improve D0x platforms and bug fix

2018-02-07 Thread Leif Lindholm
On Wed, Feb 07, 2018 at 04:22:34PM +0800, Heyi Guo wrote: > The major features of this patchset include > adding PPTT support, > switching to Generic BDS driver, > adding capsule upgrade support, > open-source version for SnpPlatform and SasPlatform > changing DmaLib to CoherentDmaLib. > >

Re: [edk2] [PATCH edk2-non-osi v3 0/7] Improve D0x platforms and bug fix

2018-02-07 Thread Leif Lindholm
Thanks! For the series: Reviewed-by: Leif Lindholm Pushed as 168344f..1aaec67 On Fri, Feb 02, 2018 at 07:57:21PM +0800, Heyi Guo wrote: > The major features of this patchset: > 1 Upgrade trusted firmware to 1.4 > 2 Workarounds for CVE-2017-5715 on Cortex A57/A72/A73

[edk2] test message

2018-02-07 Thread Laszlo Ersek
Hi All, my deepest apology for spamming the list with a test message. I have been having problems sending emails to the list, both with git-send-email (i.e. patches) and with Thunderbird (i.e. manually written emails). Both kinds have been rejected with SPF (Sender Policy Framework) error

Re: [edk2] [PATCH 10/10] MdeModulePkg/ResetSystemPei: Add reset notifications in PEI

2018-02-07 Thread Zeng, Star
On 2018/2/2 14:45, Ruiyu Ni wrote: From: Bret Barkelew The Reset Notification protocol is added in UEFI spec to support reset notification mechanism in the DXE phase. This patch adds similar EDKII specific Reset Notification PPI to PEI phase to provide the same support.

Re: [edk2] [PATCH 09/10] MdeModulePkg: Add ResetSystemPei PEIM

2018-02-07 Thread Zeng, Star
On 2018/2/2 14:45, Ruiyu Ni wrote: This driver implements Reset2, ResetFilter and ResetHandler PPIs. Cc: Liming Gao Cc: Michael D Kinney Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [Patch V2] INF spec: Add flexible PCD value format into spec

2018-02-07 Thread Yonghong Zhu
V2: update EBNF for Array format. Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu ---

[edk2] [Patch V2] DEC spec: Add flexible PCD value format into spec

2018-02-07 Thread Yonghong Zhu
V2: update EBNF for Array format. Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu ---

[edk2] [Patch V2] Build spec: Add flexible PCD value format into spec

2018-02-07 Thread Yonghong Zhu
V2: update EBNF for Array format. Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu ---

[edk2] [Patch V2] Expression spec: update format to support flexible Pcd format

2018-02-07 Thread Yonghong Zhu
V2: update EBNF for Array format. Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu ---

[edk2] [Patch V2] DSC spec: Add flexible PCD value format into spec

2018-02-07 Thread Yonghong Zhu
V2: update EBNF for Array format. Cc: Liming Gao Cc: Michael Kinney Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu ---

Re: [edk2] [PATCH 07/10] MdeModulePkg: Add ResetUtility librray class and BASE instance

2018-02-07 Thread Zeng, Star
On 2018/2/2 14:45, Ruiyu Ni wrote: From: Michael D Kinney The library class that provides services to generate a GUID specific reset, parse the GUID from a GUID specific reset, and build the ResetData buffer for any type of reset that requires extra data. Cc:

Re: [edk2] [PATCH 08/10] MdePkg/UefiRuntimeLib: Support more module types.

2018-02-07 Thread Zeng, Star
On 2018/2/2 14:45, Ruiyu Ni wrote: Because DxeResetSystemLib links to this library to provide reset system services, change UefiRuntimeLib to support the same set of module types as what DxeResetSystemLib does. Cc: Liming Gao Cc: Michael D Kinney

Re: [edk2] [PATCH 06/10] MdeModulePkg: Add ResetSystemLib instances that call core services

2018-02-07 Thread Zeng, Star
On 2018/2/2 14:45, Ruiyu Ni wrote: From: Michael D Kinney Add a PEI instance of ResetSystemLib that calls the ResetSystem2() service in the PEI Services Table. Add a DXE instance of ResetSystemLib that calls the ResetSystem() service in the UEFI Runtime Services

Re: [edk2] [PATCH 05/10] MdeModulePkg/ResetSystemRuntimeDxe: Add more debug message

2018-02-07 Thread Zeng, Star
On 2018/2/2 14:45, Ruiyu Ni wrote: The patch adds more debug message in ResetSystem(). It also removes unnecessary check of mResetNotifyDepth. Cc: Liming Gao Cc: Michael D Kinney Cc: Star Zeng Contributed-under: TianoCore

Re: [edk2] [PATCH 04/10] MdeModulePkg/ResetSystemRuntimeDxe: Add platform filter and handler

2018-02-07 Thread Zeng, Star
Some minor comments added below except Laszlo's. With them handled, Reviewed-by: Star Zeng On 2018/2/2 14:45, Ruiyu Ni wrote: From: Michael D Kinney Add support for platform specific reset filters and platform specific reset handlers to

Re: [edk2] [PATCH 03/10] MdeModulePkg/PeiMain: Cleanup whitespace in Reset.c

2018-02-07 Thread Zeng, Star
On 2018/2/2 14:45, Ruiyu Ni wrote: From: Michael D Kinney Cc: Liming Gao Reviewed-by: Ruiyu Ni Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney

Re: [edk2] [PATCH 02/10] MdeModulePkg/PeiMain: Always attempt to use Reset2 PPI first

2018-02-07 Thread Zeng, Star
On 2018/2/2 14:45, Ruiyu Ni wrote: From: Michael D Kinney Update PEI Service ResetSystem() to always attempt to use the Reset2 PPI before looking for the Reset PPI. Cc: Liming Gao Reviewed-by: Ruiyu Ni Cc: Star Zeng

Re: [edk2] [PATCH 01/10] MdePkg/PeiServicesLib: Add PeiServicesResetSystem2()

2018-02-07 Thread Zeng, Star
On 2018/2/2 14:45, Ruiyu Ni wrote: From: Michael D Kinney Add the PeiServicesResetSytstem2() function to the PeiServiesLib to call the ResetSystem2() services in the PEI Services Table. Cc: Liming Gao Cc: Ruiyu Ni

Re: [edk2] [Patch] MdePkg BaseCpuLib: Make it pass VS ARM build

2018-02-07 Thread Pete Batard
Thanks Liming. Looks good to me. /Pete On 2018.02.07 01:56, Liming Gao wrote: Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Reviewed-by: Pete Batard --- MdePkg/Library/BaseCpuLib/BaseCpuLib.inf | 4 +++- 1 file

Re: [edk2] [PATCH edk2-platforms v3 13/15] Hisilicon/D05/ACPI: Add ITS PXM

2018-02-07 Thread graeme . gregory
On Tue, Feb 06, 2018 at 03:04:48PM +, Leif Lindholm wrote: > On Fri, Feb 02, 2018 at 08:05:41PM +0800, Heyi Guo wrote: > > Add ITS affinity structure in SRAT. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ming Huang > >

Re: [edk2] [PATCH 2/2] OvmfPkg/PlatformPei: sync AmdSevInitialize() definition with declaration

2018-02-07 Thread Ard Biesheuvel
On 6 February 2018 at 23:01, Laszlo Ersek wrote: > "Platform.h" declares the AmdSevInitialize() function without EFIAPI, but > the definition in "AmdSev.c" includes EFIAPI. > > GCC toolchains without LTO do not catch this error because "AmdSev.c" does > not include

[edk2] [PATCH edk2-platforms v4 12/15] Hisilicon/D03: Replace SP805Watchdog by WatchdogTimer driver.

2018-02-07 Thread Heyi Guo
In SCT test,we find SP805 watchdog driver can't reset when timeout so we use another driver in MdeModulePkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo Signed-off-by: GongChengYa

[edk2] [PATCH edk2-platforms v4 14/15] Hisilicon/D05/ACPI: Add Pcie, HNS and SAS PXM

2018-02-07 Thread Heyi Guo
Add PXM method for Pcie device, HNS device and SAS device. Add STA method for HNS. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: hensonwang Signed-off-by: Ming Huang Signed-off-by: Heyi Guo

[edk2] [PATCH edk2-platforms v4 13/15] Hisilicon/D05/ACPI: Add ITS PXM

2018-02-07 Thread Heyi Guo
Add ITS affinity structure in SRAT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo Reviewed-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

[edk2] [PATCH edk2-platforms v4 15/15] Hisilicon D03/D05: Update firmware version to 18.02

2018-02-07 Thread Heyi Guo
Replace the old string with short one. The old one is too long that can not be show integrallty in Setup nemu. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo Reviewed-by: Leif Lindholm

[edk2] [PATCH edk2-platforms v4 10/15] Hisilicon/PCIe: Disable PCIe ASPM

2018-02-07 Thread Heyi Guo
In order to replace command line parameter pcie_aspm=off, BIOS needs to disable Pcie Aspm support during Pcie initilization. D03 and D05 do not support PCIe ASPM, so we disable it in BIOS. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang

[edk2] [PATCH edk2-platforms v4 06/15] Hisilicon D03/D05: Open SasPlatform source code

2018-02-07 Thread Heyi Guo
This module install a protocol for SasDriverDxe. the protocol include main information of sas controller, like controller ID, enable or disable,base address of registers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jason Zhang Signed-off-by:

Re: [edk2] [patch] MdeModulePkg/PciBusDxe: Fix VS2012 build failure

2018-02-07 Thread Bi, Dandan
Hi Laszlo, Thanks for your comments. I will update the commit message. Regards, Dandan -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, February 7, 2018 4:17 PM To: Zeng, Star ; Bi, Dandan ;

[edk2] [PATCH edk2-platforms v4 09/15] Hisilicon/Smbios: Indicate use of ProcessorFamily2 in type 4 table

2018-02-07 Thread Heyi Guo
modify processorFamily of type 4 to ProcessorFamilyIndicatorFamily2, indicator to obtain the processor family from the Processor Family 2 field. ProcessorFamily2 is already specified as ProcessorFamilyARM in the existing table. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH edk2-platforms v4 07/15] Hisilicon D03/D05: Open SnpPlatform source code

2018-02-07 Thread Heyi Guo
1. This driver install a protocol for SnpPV600Dxe driver. The protocol indicate which ethernet port to use and port sequence. 2. Fixed bug:Confusing Ethernet port sequence. Move the most right Ethernet port (when looking from the front of the chassis) to the first one in BootManage for

[edk2] [PATCH edk2-platforms v4 05/15] Hisilicon D03/D05: Add capsule upgrade support

2018-02-07 Thread Heyi Guo
This module support updating the boot CPU firmware only. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jason Zhang Signed-off-by: Ming Huang Signed-off-by: Heyi Guo Reviewed-by: Ard Biesheuvel

[edk2] [PATCH edk2-platforms v4 08/15] Hilisicon: Change DmaLib to CoherentDmaLib

2018-02-07 Thread Heyi Guo
Unify all D0x(include D06 in further) to cache coherent DmaLib. This can improve boot speed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wang Yue Signed-off-by: Ming Huang Signed-off-by: Heyi Guo

[edk2] [PATCH edk2-platforms v4 04/15] Hisilicon/D0x: Break BMC SetBoot option out into separate library

2018-02-07 Thread Heyi Guo
Modify the feature of BMC set boot option as switching generic BDS. Break BMC SetBoot option out into BmcConfigBootLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo Reviewed-by: Leif

[edk2] [PATCH edk2-platforms v4 01/15] Hisilicon/D05: Move Madt definition to head file

2018-02-07 Thread Heyi Guo
Move definition of Madt struct to head file, so PPTT driver can include it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Signed-off-by: Heyi Guo Reviewed-by: Ard Biesheuvel Reviewed-by:

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Fix Windows 10 S3 failure.

2018-02-07 Thread zwei4
The FSP-S preferred memory region, which is defined in FSP Integration Guide, must be reserved for BIOS S3 resume. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 --- .../PlatformPreMemPei/FvCallback.c | 29

[edk2] [PATCH edk2-platforms v4 03/15] Hisilicon/D0x/BDS: Switch to Generic BDS driver

2018-02-07 Thread Heyi Guo
Hisilicon-specific PlatformBootManagerLib added. It is convenient to add specific feature, like BMC control boot option. Remove Intel BDS from dsc file because it is out of use. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang

[edk2] [PATCH edk2-platforms v4 02/15] Hisilicon/D05: Add PPTT support

2018-02-07 Thread Heyi Guo
Add Processor Properties Topology Table, PPTT include Processor hierarchy node, Cache Type Structure and ID structure. PPTT is needed for lscpu command to show socket information correctly. https://bugs.linaro.org/show_bug.cgi?id=3206 Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH edk2-platforms v4 00/15] Improve D0x platforms and bug fix

2018-02-07 Thread Heyi Guo
The major features of this patchset include adding PPTT support, switching to Generic BDS driver, adding capsule upgrade support, open-source version for SnpPlatform and SasPlatform changing DmaLib to CoherentDmaLib. Comparison of V3: 1 Modify PPTT as the edk2 patch "MdePkg ACPI: Add some macros

  1   2   >