On 03/06/18 01:45, Brian J. Johnson wrote:
> On 03/05/2018 12:22 PM, Laszlo Ersek wrote:
>> PEIMs generally "execute in place" (XIP), i.e. they run from flash, not
>> RAM. In this status they use "temporary RAM" (e.g. CPU caches configured
>> like RAM) for stack & heap; whatever HOBs they produce a
On 6 March 2018 at 05:14, Meenakshi Aggarwal wrote:
> Hi,
>
> I am using Mmc Driver implemented in " EmbeddedPkg/Universal/MmcDxe/" for my
> SD/MMC controller and my controller is not on PCI bus.
>
> I am a bit confused if i should move to SD implementation available in
> 'MdeModulePkg\Bus\Pci\S
On 5 March 2018 at 15:08, Evan Lloyd wrote:
> In that case, would you be happy to take Girish's patches with the ASSERTs
> done your (our) way?
> Leif can fulminate about it when he gets back, if he really feels that
> strongly.
Why? Because it is almost the end of the quarter? Can't it wait?
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Tuesday, March 06, 2018 4:41 PM
> To: Meenakshi Aggarwal
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers
>
> On 6 March 2018 at 05:14, Meenaksh
If enabled, NX memory protection feature will mark some types of active
memory as NX (non-executable), which includes the first page of the stack.
This will overwrite the attributes of the first page of the stack if the
stack guard feature is also enabled.
The solution is to override the attribute
If enabled, NX memory protection feature will mark some types of active
memory as NX (non-executable), which includes the first page of the stack.
This will overwrite the attributes of the first page of the stack if the
stack guard feature is also enabled.
The series will override the attributes s
The commit rewrites the logic in function
InitializeDxeNxMemoryProtectionPolicy() for handling the first page
(page 0) when NULL pointer detection feature is enabled.
Instead of skip setting the page 0, the codes will now override the
attribute setting of page 0 by adding the 'EFI_MEMORY_RP' attri
A quick minor comment.
GetHobList() could be used instead of EfiGetSystemConfigurationTable
(&gEfiHobListGuid, &HobList).
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Tuesday, March 6, 2018 8:11 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Wang, Jian J ; Zeng,
Star ; Dong, Er
On 03/02/18 16:21, Brijesh Singh wrote:
>
>
> On 03/01/2018 06:03 PM, Laszlo Ersek wrote:
> ...
>
>>
>> I regression-tested my usual non-SEV guests (with Brijesh's v2 2/2 patch
>> applied on top, from the above-referenced series), which covers i440fx
>> (no SMM, X64), q35 (SMM, IA32 and IA32X64)
Agree.
With this update, reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, March 6, 2018 8:16 PM
> To: Wu, Hao A ; edk2-devel@lists.01.org
> Cc: Wang, Jian J ; Dong, Eric ;
> Yao, Jiewen ; Ni, Ruiyu ; Zeng, Star
>
> Subject: RE: [PATCH 2/2] MdeMo
reviewed-by: jiewen@intel.com
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, March 6, 2018 8:11 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wang, Jian J ;
> Zeng, Star ; Dong, Eric ; Yao,
> Jiewen ; Ni, Ruiyu
> Subject: [PATCH 1/2] MdeModulePkg/Core: Refine handling NU
BTW: I don't think "StackBaseFound" is really needed.
We can use ASSERT (StackBase != 0); directly. :-)
Thank you
Yao Jiewen
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao,
> Jiewen
> Sent: Tuesday, March 6, 2018 9:05 PM
> To: Zeng, Star
Got it, I will send out a V2 of the series according to the comments.
Best Regards,
Hao Wu
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, March 06, 2018 9:11 PM
> To: Yao, Jiewen; Zeng, Star; Wu, Hao A; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu; Dong, Eric
> Subject: RE: [PATCH
From: Marc Zyngier
The generic timer driver only EOIs the timer interrupt if
the ISTATUS bit is set. This is completely fine if you pretend
that spurious interrupts do not exist. But as a matter of fact,
they do, and the first one will leave the interrupt activated
at the GIC level, making sure t
Hey Dandan,
Thanks for your reply.
I issued updates for the current headers because I saw activity in
edk2-platforms to implement these incomplete protocols and because I haven't
heard back for discussed changes in the specification for some time.
Sure I could help submitting the ECR, however I'
V2 changes:
A. Use Hoblib APIs to get the base of stack from Hob.
B. Remove unnecessary local variable used in function
InitializeDxeNxMemoryProtectionPolicy().
V1 history:
If enabled, NX memory protection feature will mark some types of active
memory as NX (non-executable), which includes th
The commit rewrites the logic in function
InitializeDxeNxMemoryProtectionPolicy() for handling the first page
(page 0) when NULL pointer detection feature is enabled.
Instead of skip setting the page 0, the codes will now override the
attribute setting of page 0 by adding the 'EFI_MEMORY_RP' attri
If enabled, NX memory protection feature will mark some types of active
memory as NX (non-executable), which includes the first page of the stack.
This will overwrite the attributes of the first page of the stack if the
stack guard feature is also enabled.
The solution is to override the attribute
Both patches are reviewed-by: jiewen@intel.com
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, March 6, 2018 9:33 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wang, Jian J ;
> Zeng, Star ; Dong, Eric ; Yao,
> Jiewen ; Ni, Ruiyu
> Subject: [PATCH v2 2/2] MdeModulePkg/Core
According to the SBBR Specification (ARM DEN 0044B), Section 4.2.1.1
"Within the RSDP, the RsdtAddress field must be null (zero)
and the XsdtAddresss MUST be a valid, non-null, 64-bit value."
The PcdAcpiExposedTableVersions is used to indicate the ACPI versions
that are supported. The default
On 03/06/18 14:24, Ard Biesheuvel wrote:
> From: Marc Zyngier
>
> The generic timer driver only EOIs the timer interrupt if
> the ISTATUS bit is set. This is completely fine if you pretend
> that spurious interrupts do not exist. But as a matter of fact,
> they do, and the first one will leave the
The patch series is also at
https://github.com/lzeng14/edk2 OpalPasswordNew branch.
After IOMMU is enabled in S3, original solution with SMM device
code (OpalPasswordSmm) to unlock OPAL device for S3 will not work
as the DMA operation will be aborted without granted DMA buffer.
Instead, this solut
With this flag, the LockBox can be restored in S3 resume only.
The LockBox can not be restored after SmmReadyToLock in normal boot
and after EndOfS3Resume in S3 resume.
It can not be set together with LOCK_BOX_ATTRIBUTE_RESTORE_IN_PLACE.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Ag
Cc: Jiewen Yao
Cc: Eric Dong
Cc: Chao Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalLib.inf | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/SecurityPkg/Library/TcgStorag
Cc: Jiewen Yao
Cc: Eric Dong
Cc: Chao Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCoreLib.inf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/SecurityPkg/Library/TcgStorageCor
Remove OpalPasswordSupportLib as it is not been used
anymore.
Cc: Jiewen Yao
Cc: Eric Dong
Cc: Chao Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
.../Include/Library/OpalPasswordSupportLib.h | 289
.../OpalPasswordSupportLib.c
Remove OpalPasswordExtraInfoVariable.h as it is not been used
anymore.
Cc: Jiewen Yao
Cc: Eric Dong
Cc: Chao Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
.../Include/Guid/OpalPasswordExtraInfoVariable.h | 27 --
1 file change
On 6 March 2018 at 14:25, Laszlo Ersek wrote:
> On 03/06/18 14:24, Ard Biesheuvel wrote:
>> From: Marc Zyngier
>>
>> The generic timer driver only EOIs the timer interrupt if
>> the ISTATUS bit is set. This is completely fine if you pretend
>> that spurious interrupts do not exist. But as a matte
On 06/03/18 14:25, Laszlo Ersek wrote:
> On 03/06/18 14:24, Ard Biesheuvel wrote:
>> From: Marc Zyngier
>>
>> The generic timer driver only EOIs the timer interrupt if
>> the ISTATUS bit is set. This is completely fine if you pretend
>> that spurious interrupts do not exist. But as a matter of fac
Hi,
My Duet floppy image that i compiled with Gcc 5 gets stuck when I try to run it
in Bochs or Qemu as it does not get any further than 'Welcome to Efi World'. Is
that normal or are there specific setting needed in the Bochs config to get it
emulated?
Thank you
Sent from my iPhone
__
On 02/13/18 19:48, Wu, Hao A wrote:
>> -Original Message-
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Rick
>> Warner
>> Sent: Wednesday, February 14, 2018 12:33 AM
>> To: Wu, Hao A; Andrew Fish
>> Cc: edk2-devel@lists.01.org
>> Subject: Re: [edk2] how do I use
From: Marc-André Lureau
The ZeroMem() call goes beyond the HashInterfaceHob structure, causing
HOB list corruption. Instead, just clear the HashInterface fields, as
I suppose was originally intended.
Cc: Jiewen Yao
Cc: Chao Zhang
Cc: Star Zeng
Cc: Laszlo Ersek
Contributed-under: TianoCore Co
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: marcandre.lur...@redhat.com [mailto:marcandre.lur...@redhat.com]
Sent: Wednesday, March 7, 2018 4:27 AM
To: edk2-devel@lists.01.org
Cc: Marc-André Lureau ; Yao, Jiewen
; Zhang, Chao B ; Zeng, Star
; Laszlo Ersek
Subject: [PA
Excellent. Thanks to catch that.
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: marcandre.lur...@redhat.com [mailto:marcandre.lur...@redhat.com]
> Sent: Wednesday, March 7, 2018 4:27 AM
> To: edk2-devel@lists.01.org
> Cc: Marc-André Lureau ; Yao, Jiewen
> ; Zhang, Chao B
The VirtioPciDeviceDxe was extended to support a non-discoverable
MMIO Virtio case.
The Virtio spec defines both PCI and MMIO device types with the
set of registers that are not the same between these two types
of devices. All PCI registers have corresponding MMIO registers
but the number of regis
Added PCI IO to MMIO translation for Virtio case into the PCI IO
protocol functions.
Added Virtio device type into the PCI IO protocol initialization
procedure.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Daniil Egranov
---
.../NonDiscoverablePciDeviceDxe.c
This is an attempt to add MMIO Virtio devices into the
non-discoverable device registration procedure and allow
Virtio PCI drivers to recognize and program such devices
correctly.
The main issue is that the set of MMIO registers is different
from PCI, plus the width of similar registers are not
a
Added Virtio non-discoverable device case.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Daniil Egranov
---
.../NonDiscoverableDeviceRegistrationLib.c | 3 +++
.../NonDiscoverableDeviceRegistrationLib.inf | 1 +
2 fil
Added Virtio type and GUID to the list of supported
non-discoverable devices.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Daniil Egranov
---
MdeModulePkg/Include/Guid/NonDiscoverableDevice.h | 3 +++
MdeModulePkg/Include/Library/NonDiscoverableDeviceR
Thanks for fixing the issue.
For this patch series:
Reviewed-by: Jian J Wang
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, March 06, 2018 9:33 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wang, Jian J ;
> Zeng, Star ; Dong, Eric ; Yao,
> Jiewen ; Ni, Ruiyu
> Subject: [P
Hi Ray,
Sorry to disturb, but I didn't find the patch committed. Could you help to do
that?
Thanks,
Heyi
On Thu, Mar 01, 2018 at 12:46:32PM +0800, Ni, Ruiyu wrote:
> On 3/1/2018 10:39 AM, Heyi Guo wrote:
> >Function BmRepairAllControllers may recursively call itself if some
> >driver health pro
Reviewed-by: Chao Zhang
-Original Message-
From: marcandre.lur...@redhat.com [mailto:marcandre.lur...@redhat.com]
Sent: Wednesday, March 7, 2018 4:27 AM
To: edk2-devel@lists.01.org
Cc: Marc-André Lureau ; Yao, Jiewen
; Zhang, Chao B ; Zeng, Star
; Laszlo Ersek
Subject: [PATCH 1/1] RFC
We need to set PcdShellLibAutoInitialize to FALSE for
TftpDynamicCommand, or else we will get initialization failure when
loading TftpDynamicCommand module, for EFI Shell has not been started
at this moment.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Heyi Guo
Cc: Ard B
Since D0x platforms always have network enabled, we would like to
enable tftp command by default so that we can download something in
EFI Shell.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Heyi Guo
Cc: Ard Biesheuvel
Cc: Leif Lindholm
---
Platform/Hisilicon/D03/D03.d
The example of UNION storage is not good, now update it.
Cc: Eric Dong
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi
---
MdeModulePkg/Universal/DriverSampleDxe/NVDataStruc.h | 6 +++---
MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr|
On 3/6/2018 9:33 PM, Hao Wu wrote:
V2 changes:
A. Use Hoblib APIs to get the base of stack from Hob.
B. Remove unnecessary local variable used in function
InitializeDxeNxMemoryProtectionPolicy().
V1 history:
If enabled, NX memory protection feature will mark some types of active
memory as
Regards,
Jian
> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, March 07, 2018 11:17 AM
> To: Wu, Hao A ; edk2-devel@lists.01.org
> Cc: Wang, Jian J ; Zeng, Star ;
> Dong, Eric ; Yao, Jiewen
> Subject: Re: [PATCH v2 0/2] Resolve feature conflict between NX and Stack
> guard
>
Reviewed-by: Michael D Kinney
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-
> boun...@lists.01.org] On Behalf Of Ruiyu Ni
> Sent: Monday, March 5, 2018 7:40 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 0/2] Fix bug in
> CompatibleRangeTest
>
>
> Ruiyu Ni (2):
I think the original patch is fine.
StackBase is already checked by using ASSERT before.
> +ASSERT ((StackBase & EFI_PAGE_MASK) == 0);
MemMap entry must be page aligned.
No additional check is required here.
Thank you
Yao Jiewen
> -Original Message-
> From: Wang, Jian J
> Sent
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Kinney, Michael D
>Sent: Wednesday, March 07, 2018 12:09 PM
>To: Ni, Ruiyu ; edk2-devel@lists.01.org; Kinney, Michael
>D
>Subject: Re: [edk2] [PATCH 0/2] Fix bug in Compat
Hi Ray,
Below are the answers to your feedbacks:
> -Original Message-
> From: Yao, Jiewen
> Sent: Wednesday, March 07, 2018 12:14 PM
> To: Wang, Jian J; Ni, Ruiyu; Wu, Hao A; edk2-devel@lists.01.org
> Cc: Zeng, Star; Dong, Eric
> Subject: RE: [PATCH v2 0/2] Resolve feature conflict betwee
On 3/6/2018 10:44 AM, Guo Heyi wrote:
Hi Ray,
Any comments for v5?
Heyi,
Some backward compatibility concerns were received from internal
production teams. Current change will cause silent failure on old
platforms because TranslationOffset might be random if uninitialized.
I will solve the c
On 3/7/2018 12:28 PM, Wu, Hao A wrote:
Hi Ray,
Below are the answers to your feedbacks:
-Original Message-
From: Yao, Jiewen
Sent: Wednesday, March 07, 2018 12:14 PM
To: Wang, Jian J; Ni, Ruiyu; Wu, Hao A; edk2-devel@lists.01.org
Cc: Zeng, Star; Dong, Eric
Subject: RE: [PATCH v2 0/2] R
The root cause is an unnecessary check to Size parameter in function
AdjustMemoryS(). It will cause one standalone free page (happen to have
Guard page around) in the free memory list cannot be allocated, even if
the requested memory size is less than a page.
//
// At least one more page neede
Boolean values do not need to use explicit comparisons
to TRUE or FALSE.
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi
---
UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 2 +-
1 file changed, 1 insertion(
Boolean values do not need to use explicit comparisons
to TRUE or FALSE.
Cc: Chao Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi
---
.../Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On 3/7/2018 1:53 PM, Dandan Bi wrote:
Boolean values do not need to use explicit comparisons
to TRUE or FALSE.
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi
---
UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineChe
Thanks. Please let me know if any further changes are needed.
Regards,
Heyi
On Wed, Mar 07, 2018 at 12:30:59PM +0800, Ni, Ruiyu wrote:
> On 3/6/2018 10:44 AM, Guo Heyi wrote:
> >Hi Ray,
> >
> >Any comments for v5?
>
> Heyi,
> Some backward compatibility concerns were received from internal prod
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star
> Zeng
> Sent: Tuesday, March 6, 2018 10:28 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Zeng, Star
> Subject: [edk2] [PATCH 1/7] MdeModulePkg LockB
Laszlo:
We just find this change causes XCODE5 build failure, because XCODE compiler
doesn't know these two options. So, could you provide the patch to remove the
change in BUILD_CFLAGS for MAC?
ifeq ($(DARWIN),Darwin)
# assume clang or clang compatible flags on OS X
BUILD_CFLAGS =
else
Thank
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, March 6, 2018 10:28 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Yao, Jiewen ;
> Dong, Eric ; Zhang, Chao B
> Subject: [PATCH 2/7] SecurityPkg TcgStorageOpalLib: Make it be base type
> reall
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, March 6, 2018 10:28 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Yao, Jiewen ;
> Dong, Eric ; Zhang, Chao B
> Subject: [PATCH 3/7] SecurityPkg TcgStorageCoreLib: Make it be base type
> reall
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, March 6, 2018 10:28 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Yao, Jiewen ;
> Dong, Eric ; Zhang, Chao B
> Subject: [PATCH 6/7] SecurityPkg OpalPasswordSupportLib: Remove it
>
> Remove Op
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, March 6, 2018 10:28 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Yao, Jiewen ;
> Dong, Eric ; Zhang, Chao B
> Subject: [PATCH 7/7] SecurityPkg OpalPasswordExtraInfoVariable.h: Remove it
>
>
From: gongchengya
Hi1616 GIC does not fully support GICv2 legacy mode, and SBSA watchdog
interrupts 400 and 496 cannot be signaled to CPU, so we switch to pure
GICv3 mode.
For other Hisilicon platforms, we suppose they don't need V2 legacy
mode either if they have GICv3. D03 also works for this
From: Jason Zhang
Timer is always working on Hisilicon D0x, even system enters WFI/WFE,
and there is no other low power status, so we set "always-on" flag in
ACPI GTDT.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jason Zhang
Signed-off-by: Heyi Guo
Cc: Ard Biesheuvel
From: Chenhui Sun
Add description of SBSA watchdogs to ACPI GTDT on D05.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chenhui Sun
Signed-off-by: Heyi Guo
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Graeme Gregory
---
Platform/Hisilicon/D05/D05.dsc
Reviewed-by: Liming Gao
> -Original Message-
> From: Bi, Dandan
> Sent: Wednesday, March 7, 2018 11:06 AM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric ; Gao, Liming
> Subject: [patch] MdeModulePkg/DriverSampleDxe: Refine the sample case for
> UNION type
>
> The example of UNION stora
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Wang, Jian J
> Sent: Wednesday, March 7, 2018 12:41 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Dong, Eric ; Yao,
> Jiewen
> Subject: [PATCH] MdeModulePkg/Core: fix too many available pages between
> BS_Data
>
> The r
Reviewed-by: Chao Zhang
-Original Message-
From: Bi, Dandan
Sent: Wednesday, March 7, 2018 1:54 PM
To: edk2-devel@lists.01.org
Cc: Zhang, Chao B
Subject: [patch] SecurityPkg/SmmTcg2PhysicalPresenceLib: Fix coding style issue
Boolean values do not need to use explicit comparisons to TRU
70 matches
Mail list logo
