Re: [edk2] [PATCH 00/45] ArmVirtPkg, OvmfPkg: list module-internal headers in INF files

Hi Laszlo, On 11 March 2018 at 01:48, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: hdr_inf_cleanup > > In > , > Mike explained why it's a good idea to list module-inter

Re: [edk2] [PATCH 00/45] ArmVirtPkg, OvmfPkg: list module-internal headers in INF files

On 03/11/18 09:15, Ard Biesheuvel wrote: > Hi Laszlo, > > On 11 March 2018 at 01:48, Laszlo Ersek wrote: >> Repo: https://github.com/lersek/edk2.git >> Branch: hdr_inf_cleanup >> >> In >> , >> Mik

Re: [edk2] [PATCH 00/45] ArmVirtPkg, OvmfPkg: list module-internal headers in INF files

On 11 March 2018 at 11:48, Laszlo Ersek wrote: > On 03/11/18 09:15, Ard Biesheuvel wrote: >> Hi Laszlo, >> >> On 11 March 2018 at 01:48, Laszlo Ersek wrote: >>> Repo: https://github.com/lersek/edk2.git >>> Branch: hdr_inf_cleanup >>> >>> In >>>

Re: [edk2] [PATCH 15/45] OvmfPkg/IoMmuDxe: list "AmdSevIoMmu.h" in the INF file

On 3/10/18 7:48 PM, Laszlo Ersek wrote: > The header file declares the AmdSevInstallIoMmuProtocol() function, which > is implemented in "AmdSevIoMmu.c" and called from "IoMmuDxe.c". > > Cc: Ard Biesheuvel > Cc: Brijesh Singh > Cc: Jordan Justen > Suggested-by: Michael Kinney > Ref: > http://

[edk2] [PATCH 2/3] SourceLevelDebugPkg DebugCommUsb3: Realloc granted DXE DMA buffer

For the case that the USB3 debug port instance and DMA buffers are from PEI HOB with IOMMU enabled, de8373fa07f8 is to reallocate the DMA buffers by AllocateAddress with the memory type accessible by SMM environment. But reallocating the DMA buffers by AllocateAddress may fail. Instead, this patc

[edk2] [PATCH 3/3] SourceLevelDebugPkg DebugCommUsb3: Use the Handle from DebugAgentLib

For notifications to get the Instance, de8373fa07f8 was to build HOB/SystemTable in DebugCommunicationLibUsb3 itself, that works well at normal boot, but will fail at S3 resume. At S3 resume, after the code is transferred to PiSmmCpuDxeSmm from S3Resume2Pei, HOB is still needed to be used for DMA o

[edk2] [PATCH 1/3] SourceLevelDebugPkg DebugCommUsb3: Refine some formats

Refine some formats and remove some unused prototypes. Cc: Jiewen Yao Cc: Ruiyu Ni Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- .../DebugCommunicationLibUsb3Common.c | 10 ++--- .../DebugCommunicationLibUsb3Dxe.inf

[edk2] [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU

Please get detailed information in the separated patches. Cc: Jiewen Yao Cc: Ruiyu Ni Cc: Hao Wu Star Zeng (3): SourceLevelDebugPkg DebugCommUsb3: Refine some formats SourceLevelDebugPkg DebugCommUsb3: Realloc granted DXE DMA buffer SourceLevelDebugPkg DebugCommUsb3: Use the Handle from

[edk2] HELP: Qemu not able to load Duet image

Just wanted to followup on my experimentation with Qemu and EDK2's DuetPkg. So far I have successfully been able to load the Duet image in Qemu after refining my image making skills. Though having an issue with UDK2010 NOT being able to load the 'Bootx64' or 'BootIa32' efi boot loader. I also compi

Re: [edk2] [PATCH 3/3] Hisilicon/D05: Support SBSA watchdog

On Wed, Mar 07, 2018 at 04:10:23PM +, Ard Biesheuvel wrote: > On 7 March 2018 at 06:55, Heyi Guo wrote: > > From: Chenhui Sun > > > > Add description of SBSA watchdogs to ACPI GTDT on D05. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Chenhui Sun > > Sign

Re: [edk2] [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU

One minor comment: For patch 3, within changes in function Usb3PciIoNotify(): Usb3NamedEventListen ( &gEfiDxeSmmReadyToLockProtocolGuid, TPL_NOTIFY, Usb3DxeSmmReadyToLockNotify, &SmmReadyToLockEvent <--- Does this change related with patch 2? ); Otherwise, for me, patch 2 is storing t

[edk2] [Patch] MdeModulePkg/Mtftp4Dxe: Fix the incorrect return status.

The incorrect return status was caused by the commit of 39b0867d, which was to resolve the token status error that does not compliance with spec definition, but it results the protocol status not compliance with spec definition. This patch is to resolve above issue. Cc: Wang Fan Cc: Fu Siyuan C

Re: [edk2] [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU

Hao, Good catch. :) It is a mistake when splitting patch. Thanks, Star -Original Message- From: Wu, Hao A Sent: Monday, March 12, 2018 10:10 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Yao, Jiewen ; Ni, Ruiyu Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements a

Re: [edk2] [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU

I have handled the mistake at https://github.com/lzeng14/edk2/tree/DebugCommUsb3AfterIOMMUV2_WIP. If you need, I can resend V2 patch. :) Thanks, Star -Original Message- From: Zeng, Star Sent: Monday, March 12, 2018 10:28 AM To: Wu, Hao A ; edk2-devel@lists.01.org Cc: Yao, Jiewen ; Ni, R

Re: [edk2] [PATCH v2 0/8] RFC: ovmf: preliminary TPM2 support

It works in my side after specify the full path to swtpm tpmemu.sock in qemu command options. Thanks! Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522 > -Original Message- > From: Stefan Berger [mailto:stef...@linux.vnet.ibm.com] > Sent: Friday, March 9, 2018

Re: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use Pcd for UsbBootIoBlocks

Any comments about this patch? On 2018/3/2 14:36, Ming Huang wrote: > > On 2018/2/27 18:01, Ni, Ruiyu wrote: >> On 2/27/2018 5:25 PM, Ming Huang wrote: >>> >>> On 2018/2/27 13:25, Ni, Ruiyu wrote: I don't prefer to add PCD, unless we cannot find: 1. spec content  to describe the max/min

Re: [edk2] [PATCH 0/4] Virtio non-discoverable devices

Hello Ard, On 03/08/2018 02:29 AM, Ard Biesheuvel wrote: Hello Daniil, Could you please use a text based email client? Gmail does not consider the indentation as threading, so the context below is unintelligible I forced Thunderbird to plain text. I assumed it should follow a previous email

Re: [edk2] [Patch] MdeModulePkg/Mtftp4Dxe: Fix the incorrect return status.

Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Monday, March 12, 2018 10:22 AM > To: edk2-devel@lists.01.org > Cc: Wang, Fan ; Fu, Siyuan ; Ye, > Ting > Subject: [Patch] MdeModulePkg/Mtftp4Dxe: Fix the incorrect return status. > > The incorrect return status was

Re: [edk2] [Patch] MdeModulePkg/Mtftp4Dxe: Fix the incorrect return status.

Reviewed-by: Wang, Fan . Best Regards Fan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Monday, March 12, 2018 10:22 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Wang, Fan ; Fu, Siyuan Subject: [edk2] [Patch] MdeModulePkg/Mtft

[edk2] [PATCH 0/1] ArmPkg/TimerDxe: Add DSB for timer compare value reload

After rebasing to edk2 commit 5e3719a, we found D05 would hang after printing a lot of "Spurious interrupt" messages. The issue would gone away if we restored the removal of "enable interrupt source": gInterrupt->EnableInterruptSource (gInterrupt, Source); It can also be fixed if we add a "DSB"

[edk2] [PATCH 1/1] ArmPkg/TimerDxe: Add DSB for timer compare value reload

Resetting timer compare register has a side effect of clearing GIC pending status, if timer interrupt is level sensitive, so a "DSB SY" is needed to make sure this change effect is synchronized. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo Signed-off-by: Yi Li