This issue is caused by FileInfoBuffer variable. This is a pointer array
and each elements also pointer to a memory buffer that is allocated and
returned by AllocateCopyPool function.
Cc: Jian J Wang
Cc: Hao Wu
Cc: Zhang Chao B
Cc: Liming Gao
Contributed-under: TianoCore Contribution
Liming,
Agree with you. There are no other usages now.
Thanks
On 2/11/2019 10:15 PM, Gao, Liming wrote:
> Ming:
> So, there is no common CRC16 algorithm in edk2. I suggest to collect all
> CRC16 request in the firmware code, then discussion how to add
> CalculateCrc16() API in BaseLib.
I agree to use debug message. No need to interrupt boot process.
Thanks,
Ting
-Original Message-
From: Wu, Jiaxin
Sent: Tuesday, February 12, 2019 8:48 AM
To: Fu, Siyuan
Cc: edk2-devel@lists.01.org; Mike Turner ; Ye,
Ting
Subject: RE: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Wednesday, February 6, 2019 1:34 AM
> To: Kubacki, Michael A ;
> edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Sinha, Ankit
> ; Chiu, Chasel ; Oram, Isaac W
> ; Gao, Liming
> Subject: Re:
Hi, Jiaxin
I think the Ip6Cfg->SetData() may return other error, which not only because
invalid config data is used. Why not just check the config data in
Ip6ConfigReadConfigData()?
BestRegards
Fu Siyuan
> -Original Message-
> From: Wu, Jiaxin
> Sent: Tuesday, February 12, 2019 8:47
Looks it's enough to add the warning debug message. I have sent the version 2
patch to do that.
Thanks,
Jiaxin
> -Original Message-
> From: Fu, Siyuan
> Sent: Tuesday, February 12, 2019 8:28 AM
> To: Wu, Jiaxin
> Cc: edk2-devel@lists.01.org; Mike Turner ;
> Ye, Ting
> Subject: RE:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1448
*v2: Add the warning debug message.
This patch is to clean the invalid data and continue to start IP6 driver.
Cc: Michael Turner
Cc: Ye Ting
Cc: Fu Siyuan
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin
Yes, Jiaxin. You should not use popup messages unless you 100 percent sure the
code is running in setup browser.
BestRegards
Fu Siyuan
> -Original Message-
> From: Mike Turner [mailto:michael.tur...@microsoft.com]
> Sent: Monday, February 11, 2019 11:10 PM
> To: Wu, Jiaxin ; Ye, Ting ;
Ard:
I agree your comments not to add PCD until there is the real problem.
Thanks
Liming
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
>Biesheuvel
>Sent: Tuesday, February 12, 2019 1:32 AM
>To: Leif Lindholm
>Cc: Kinney, Michael D ;
On Fri, Feb 01, 2019 at 10:25:03PM +0800, Ming Huang wrote:
> As chip group suggestions, update Mbigen and gic RAS configuration
> flow.
Update how?
/
Leif
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
> ---
>
On Fri, Feb 01, 2019 at 10:25:02PM +0800, Ming Huang wrote:
> As suggestion of community, 'AP' is a bit unfortunate to use in EDK2
> context. PI specifies 'BSP' for Boot-strap Processor, as the one
> executing all of the EDK2 code. It then uses 'AP' to refer to
> Additional Processors, which can
On Fri, Feb 01, 2019 at 10:29:07PM +0800, Ming Huang wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
> ---
> Platform/Hisilicon/D03/D03.dsc | 4 ++--
> Platform/Hisilicon/D05/D05.dsc | 4 ++--
>
On Fri, Feb 01, 2019 at 10:29:06PM +0800, Ming Huang wrote:
> This patch is relative with "Add new API CalculateCrc16()" in edk2.
The commit message should describe what the patch does.
I don't mind keeping the above line in, but we also need the
description.
Obviously, this patch depends on the
On Fri, Feb 01, 2019 at 09:34:34PM +0800, Ming Huang wrote:
> SP805 watchdog is no used for D0x, so remove it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
> ---
> Platform/Hisilicon/D03/D03.dsc
On Fri, Feb 01, 2019 at 09:34:33PM +0800, Ming Huang wrote:
> As secure boot is not ready, remove SECURE_BOOT_ENABLE and
> relative code.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
> ---
> Platform/Hisilicon/D06/D06.dsc
On Fri, Feb 01, 2019 at 09:34:31PM +0800, Ming Huang wrote:
> Add setup item "Support DPC" to enable or disable PCIe DPC
> (Downstream Port Containment).
This patch also seems to disable the SRIOV configuration and delete a
lot of ports. Can you explain how this is related?
/
Leif
>
On Fri, Feb 01, 2019 at 09:34:30PM +0800, Ming Huang wrote:
> As new M7(Cortex-M7) firmware support self-adapte, so do not
> need BIOS to implement some function, remove useless funtions
> and report CPU0/CPU1 Nic NCL offset to M7.
I don't really care that some other device in the system is a
On Mon, Feb 11, 2019 at 07:33:22PM +0100, Ard Biesheuvel wrote:
> AArch64 binutils support AArch32 seamlessly when running natively,
> which allowed us to drop the -I objcopy argument specifying that
> the input format is elf64-little, which is no longer accurate now
> that the module can be built
On Mon, Feb 11, 2019 at 07:03:09PM +0100, Ard Biesheuvel wrote:
> On Mon, 11 Feb 2019 at 19:02, Leif Lindholm wrote:
> >
> > Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe
> > .vfr rather than local definitions.
> >
> > Contributed-under: TianoCore Contribution Agreement
On Fri, Feb 01, 2019 at 09:34:29PM +0800, Ming Huang wrote:
> Add PCI_OSC_SUPPORT for remaining host bridges to remove fail
> output in kernel:
> [ 103.478893] acpi PNP0A08:01: _OSC failed (AE_NOT_FOUND);
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
>
On Fri, Feb 01, 2019 at 09:34:28PM +0800, Ming Huang wrote:
> Follow chip team suggestion to change HCCS(Huawei Cache-Coherent
> System) speed from 30G to 26G, this modification can avoid some
> unstable stress issue.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by:
AArch64 binutils support AArch32 seamlessly when running natively,
which allowed us to drop the -I objcopy argument specifying that
the input format is elf64-little, which is no longer accurate now
that the module can be built in 32-bit mode as well (which makes no
difference whatsoever given that
On Fri, Feb 01, 2019 at 09:34:27PM +0800, Ming Huang wrote:
> As suggestion of community, 'AP' is a bit unfortunate to use in EDK2
> context. PI specifies 'BSP' for Boot-strap Processor, as the one
> executing all of the EDK2 code. It then uses 'AP' to refer to
> Additional Processors, which can
On Mon, 11 Feb 2019 at 19:02, Leif Lindholm wrote:
>
> Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe
> .vfr rather than local definitions.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm
Reviewed-by: Ard Biesheuvel
> ---
>
Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe
.vfr rather than local definitions.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm
---
.../Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr | 9 +
1 file changed, 1
On Mon, 11 Feb 2019 at 15:41, Leif Lindholm wrote:
>
> On Wed, Feb 06, 2019 at 12:08:22AM +, Ard Biesheuvel wrote:
> > Replace the dummy C implementation of SpeculationBarrier() with
> > implementations consisting of the recommended DSB SY + ISB sequence,
> > as recommended by ARM in the
On Mon, 11 Feb 2019 at 13:53, Laszlo Ersek wrote:
>
> OVMF can be built with a significant amount of TPM2 code now; add
> Marc-André and Stefan as Reviewers for TPM2-related patches.
>
> Keep the list of "R" entries alphabetically sorted.
>
> Cc: Andrew Fish
> Cc: Ard Biesheuvel
> Cc: Jordan
On Fri, Feb 01, 2019 at 09:34:26PM +0800, Ming Huang wrote:
> From: xingjiang tang
>
> Implementation OemGetCpuFreq() to get cpu frequency from cpld to
> encapsulate project difference, for some projects don't support
> get cpu frequency by this way.
>
> Contributed-under: TianoCore
On Fri, Feb 01, 2019 at 09:34:25PM +0800, Ming Huang wrote:
> From: Jason Zhang
>
> Since NVMe riser width is 6*X4, need add the related
> port's INT-x support to match OS driver.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
> ---
>
On Mon, Jan 14, 2019 at 06:52:07PM +0100, Ard Biesheuvel wrote:
> On Mon, 14 Jan 2019 at 18:02, Ard Biesheuvel
> wrote:
> >
> > The static stage2 page tables don't contain any code, but we are
> > relying on the linker to resolve the references to the next level
> > tables, so we can only use
On 02/11/19 14:06, Leif Lindholm wrote:
> On Mon, Feb 11, 2019 at 01:53:43PM +0100, Laszlo Ersek wrote:
>> OVMF can be built with a significant amount of TPM2 code now; add
>> Marc-André and Stefan as Reviewers for TPM2-related patches.
>>
>> Keep the list of "R" entries alphabetically sorted.
>
Leif:
I will check BaseTools implementation and share more information on how to
handle ARCH when multiple ARCH are specified.
Thanks
Liming
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, February 5, 2019
On Fri, Feb 01, 2019 at 09:34:22PM +0800, Ming Huang wrote:
> DriverHealthManagerDxe Collect driver health form of third party
> drivers to repair no healthy card.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
Reviewed-by: Leif Lindholm
> ---
>
On Fri, Feb 01, 2019 at 09:34:21PM +0800, Ming Huang wrote:
> SerdesLib is useless for SmbiosMiscDxe and D06, so remove it.
Should it not then also delete #include from
Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c,
Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c
On Fri, Feb 01, 2019 at 09:34:32PM +0800, Ming Huang wrote:
> In new flash layout, BIOS fd change from offset 1M to 8M in 16M
> spi flash.
This bit
> Use the new CustomData.Fv which indicate the offset
> of fd and which flash area can be updated for BMC.
is of critical importance. Should be its
*bangs head on desk*
That question I just asked as a reply to
("Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot")
was meant to be a comment on this patch.
So - was this change one that was meant to happen together with
edk2-platforms "Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot"?
On Tue, Nov 20, 2018 at 05:01:49PM +0800, Ming Huang wrote:
> Linux kernel will recognize NUMA node by processor order,
> and the Node and proximity domain (PXM) will be not identical
> between BIOS and OS kernel after changing to TA(Totem A) boot,
> so adjust the NUMA node number and proximity
On Wed, Feb 06, 2019 at 12:08:22AM +, Ard Biesheuvel wrote:
> Replace the dummy C implementation of SpeculationBarrier() with
> implementations consisting of the recommended DSB SY + ISB sequence,
> as recommended by ARM in the whitepaper "Cache Speculation Side-channels"
> version 2.4, dated
Ard:
I have no comments on this patch. Reviewed-by: Liming Gao
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, February 6, 2019 8:08 AM
> To: edk2-devel@lists.01.org
> Cc: leif.lindh...@linaro.org; Gao, Liming ; Kinney,
> Michael D ;
Ming:
So, there is no common CRC16 algorithm in edk2. I suggest to collect all
CRC16 request in the firmware code, then discussion how to add CalculateCrc16()
API in BaseLib. There may be more than one CalculateCrc16() API with the
different postfix for the different algorithm. Besides eeprom
ChenChen:
Please add FileInfoBuffer[Index] NULL check before free
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen A
Chen
Sent: Monday, February 11, 2019 2:17 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Gao, Liming ; Zhang,
Chao B
On 2/11/19 7:53 AM, Laszlo Ersek wrote:
OVMF can be built with a significant amount of TPM2 code now; add
Marc-André and Stefan as Reviewers for TPM2-related patches.
Keep the list of "R" entries alphabetically sorted.
Cc: Andrew Fish
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Leif Lindholm
On Mon, Feb 11, 2019 at 01:53:43PM +0100, Laszlo Ersek wrote:
> OVMF can be built with a significant amount of TPM2 code now; add
> Marc-André and Stefan as Reviewers for TPM2-related patches.
>
> Keep the list of "R" entries alphabetically sorted.
For this patch:
Reviewed-by: Leif Lindholm
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen
> A Chen
> Sent: Monday, February 11, 2019 2:11 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A; Gao, Liming
> Subject: [edk2] [PATCH] MdeModulePkg/CapsuleApp: Fix potential NULL pointer
>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen
> A Chen
> Sent: Monday, February 11, 2019 2:17 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A; Gao, Liming; Zhang, Chao B
> Subject: [edk2] [PATCH] MdeModulePkg/CapsuleApp: Fix memory leak
OVMF can be built with a significant amount of TPM2 code now; add
Marc-André and Stefan as Reviewers for TPM2-related patches.
Keep the list of "R" entries alphabetically sorted.
Cc: Andrew Fish
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Marc-André Lureau
Cc: Michael D
On 01/25/19 22:30, Stefan Berger wrote:
> This patch adds the TCG2 Configuration menu to the Device Manager
> menu. We can apparently reuse the sample Tcg2ConfigDxe from
> SecurityPkg/Tcg/Tcg2Config without obvious adverse effects. The
> added TCG2 Configuration menu now shows details about the
Hi
On Fri, Jan 25, 2019 at 10:30 PM Stefan Berger wrote:
>
> This patch adds the TCG2 Configuration menu to the Device Manager
> menu. We can apparently reuse the sample Tcg2ConfigDxe from
> SecurityPkg/Tcg/Tcg2Config without obvious adverse effects. The
> added TCG2 Configuration menu now shows
On 02/11/19 03:48, Shenglei Zhang wrote:
> Remove UNIXGCC in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc
> and OvmfPkgX64.dsc.
> Remove content related to UNIXGCC in README.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1377
>
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc:
On 02/11/19 08:57, Hao Wu wrote:
> The previous commit:
> MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox()
>
> adds the support to enlarge a LockBox when using the LockBoxLib API
> UpdateLockBox().
>
> This commit is to sync the API description comment of UpdateLockBox()
Hi Mike,
Sorry to say I have not yet filed a BZ. Would you like me to, or are you happy
doing it?
Cheers,
Tom
On 08/02/2019 17:59, Kinney, Michael D wrote:
> Hi Thomas,
>
> I have been looking into this topic of multiple controllers this
> week. I have some prototype code that I think
(+ Ilias)
On Mon, 11 Feb 2019 at 10:19, Sumit Garg wrote:
>
> On Mon, 11 Feb 2019 at 14:30, Ard Biesheuvel
> wrote:
> >
> > On Mon, 11 Feb 2019 at 05:55, Sumit Garg wrote:
> > >
> > > On Sat, 9 Feb 2019 at 17:18, Ard Biesheuvel
> > > wrote:
> > > >
> > > > On Tue, 5 Feb 2019 at 09:01, Sumit
On Mon, 11 Feb 2019 at 14:30, Ard Biesheuvel wrote:
>
> On Mon, 11 Feb 2019 at 05:55, Sumit Garg wrote:
> >
> > On Sat, 9 Feb 2019 at 17:18, Ard Biesheuvel
> > wrote:
> > >
> > > On Tue, 5 Feb 2019 at 09:01, Sumit Garg wrote:
> > > >
> > > > Update TF-A to upstream v2.0 release (Commit:
Pushed@2a784a2cc356df5a8958afe88bc7e844dc0fb7cc
Regards,
Jian
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ye,
> Ting
> Sent: Monday, February 11, 2019 9:52 AM
> To: Antoine Coeur ; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH v2]
On Mon, 11 Feb 2019 at 02:48, Shenglei Zhang wrote:
>
> Remove UNIXGCC in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc
> and OvmfPkgX64.dsc.
> Remove content related to UNIXGCC in README.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1377
>
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
On Mon, 11 Feb 2019 at 05:55, Sumit Garg wrote:
>
> On Sat, 9 Feb 2019 at 17:18, Ard Biesheuvel wrote:
> >
> > On Tue, 5 Feb 2019 at 09:01, Sumit Garg wrote:
> > >
> > > Update TF-A to upstream v2.0 release (Commit: dbc8d9496ead). Also update
> > > OP-TEE to upstream v3.4.0 release (Commit:
56 matches
Mail list logo
