Re: [edk2] Data Structure alignment

2019-03-14 Thread Tim Lewis
I believe the option ROM header itself has an alignment requirement greater than a DWORD. This is true whether it is from the option ROM BAR or whether it is copied into allocated memory via AllocatePool. In this case, the check you showed will still be adequate. But I am going from memory. Thanks

Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment variable

2018-10-05 Thread Tim Lewis
Jaben -- Following on this: shouldn't this be a spec issue? If you are asking people to depend on the behavior. Thanks, Tim -Original Message- From: edk2-devel On Behalf Of Laszlo Ersek Sent: Friday, October 5, 2018 4:33 AM To: Carsey, Jaben ; Andrew Fish Cc: edk2-devel@lists.01.org Su

Re: [edk2] FFS Alignment and the FDF Specification

2018-07-26 Thread Tim Lewis
t;1K"} {"4K"} {"32K"} {"64K"} This is the version from the EDK2 specs page. -Original Message- From: edk2-devel On Behalf Of Zhu, Yonghong Sent: Thursday, July 26, 2018 5:59 PM To: Tim Lewis ; edk2-devel@lists.01.org Subject: Re: [edk2] FFS Alignment and the FDF

[edk2] FFS Alignment and the FDF Specification

2018-07-26 Thread Tim Lewis
Is my understanding correct: the FDF specification only supports a maximum of 64KB alignment for files (section 2.5.6), but the PI specification supports (table 7), up to 16MB alignment. Or am I misreading it? Thanks, Tim -Original Message- From: edk2-devel On Behalf Of Andrew Fish Sent

Re: [edk2] Does __attribute__ ((selectany)) make sense now for GCC?

2018-05-18 Thread Tim Lewis
pple.com Sent: Friday, May 18, 2018 3:39 PM To: Tim Lewis Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Does __attribute__ ((selectany)) make sense now for GCC? Tim, Looks like that is only available on Windows versions of GCC, and is more about compatible behavior. selectany

[edk2] Does __attribute__ ((selectany)) make sense now for GCC?

2018-05-18 Thread Tim Lewis
In Visual Studio we have __declspec(selectany) to limit the impact of unused data. I see that GCC for Windows has __attribute__ ((selectany)). Should we me using this for GLOBAL_REMOVE_IF_UNREFERENCED in MdePkg\Include\Base.h? Tim ___ edk2-de

Re: [edk2] Query regarding hole in EFI Memory Map

2018-05-14 Thread Tim Lewis
And now you see it again with 64-bit machines, where the flash and PCI config space (and MMIO) appear below 4GB, but there is DRAM above and below 4GB. Tim -Original Message- From: edk2-devel On Behalf Of Bill Paul Sent: Monday, May 14, 2018 6:13 PM To: edk2-devel@lists.01.org Cc: Neri,

Re: [edk2] [PATCH] MdePkg/BaseLib: Globally include ChkStk.c

2018-05-09 Thread Tim Lewis
Marvin - My suggestion would be the same as yours: to generate a runtime error. Tim -Original Message- From: edk2-devel On Behalf Of Marvin Häuser Sent: Wednesday, May 9, 2018 1:45 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Tim Lewis Subject: Re: [edk2] [PATCH] MdePkg/BaseLib

Re: [edk2] [PATCH] MdePkg/BaseLib: Globally include ChkStk.c

2018-05-08 Thread Tim Lewis
I think that this is a fatal error in EDK2. It basically says, "we are out of stack space." The alternative is: the system hangs in an unexpected way since the stack overflows into other pages. Tim -Original Message- From: edk2-devel On Behalf Of Yao, Jiewen Sent: Tuesday, May 8, 2018 5:

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

2018-04-11 Thread Tim Lewis
If we start to see UEFI drivers that are using this, then it is a spec issue, because it means that systems which do not implement the event will not function correctly. Tim -Original Message- From: edk2-devel On Behalf Of Bi, Dandan Sent: Wednesday, April 11, 2018 9:53 PM To: Tim Lewis

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

2018-04-11 Thread Tim Lewis
This is starting to sound like something that requires a UEFI spec update. Tim -Original Message- From: edk2-devel On Behalf Of Bi, Dandan Sent: Wednesday, April 11, 2018 8:47 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Bi, Dandan ; Dong, Eric ; Gao, Liming Subject: Re: [edk2]

Re: [edk2] RFC: Proposal to halt automatic builds of Windows BaseTools executables

2018-03-08 Thread Tim Lewis
heavily enough IMO to change the current situation. Regards, Tim -Original Message- From: Laszlo Ersek Sent: Thursday, March 8, 2018 1:19 PM To: Tim Lewis ; 'Bjorge, Erik C' ; edk2-devel@lists.01.org Subject: Re: [edk2] RFC: Proposal to halt automatic builds of Windows Ba

Re: [edk2] RFC: Proposal to halt automatic builds of Windows BaseTools executables

2018-03-08 Thread Tim Lewis
Erik -- What is the justification? Moving from more immediately usable to less immediately usable doesn't seem, on the surface, to be a good direction. Why not go the other direction and pre-build the binaries for the other environments? Thanks, Tim -Original Message- From: edk2-devel

Re: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex.

2018-01-25 Thread Tim Lewis
Supreeth -- Doesn't Appendix A of the PI 1.6 define this as: #define EFI_FV_FILETYPE_SMM EFI_FV_FILETYPE_MM #define EFI_FV_FILETYPE_SMM_CORE EFI_FV_FILETYPE_MM_CORE Thanks, Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Supreeth Venkatesh S

Re: [edk2] Build error in StdLib with VS 2015 compiler

2017-11-01 Thread Tim Lewis
Are you building C++ (.cpp)? Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Karunakar P Sent: Wednesday, November 1, 2017 8:27 PM To: 'edk2-devel@lists.01.org' Cc: 'Ye, Ting' ; 'Fu, Siyuan' ; 'Wu, Jiaxin' Subject: Re: [edk2] Build error in S

Re: [edk2] Shell Non-conformity to the Spec

2017-10-24 Thread Tim Lewis
Ah, now I remember. It was about aliases and case sensitivity, not environment variables. Tim Sent from my Windows 10 phone From: Carsey, Jaben Sent: Tuesday, October 24, 2017 1:11 PM To: Tim Lewis; jim.dai...@dell.com; Ni, Ruiyu Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Shell Non

Re: [edk2] Shell Non-conformity to the Spec

2017-10-24 Thread Tim Lewis
Jaben -- Wasn't there are previous e-mail thread about this? Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey, Jaben Sent: Tuesday, October 24, 2017 11:29 AM To: jim.dai...@dell.com; Ni, Ruiyu Cc: edk2-devel@lists.01.org Subject: Re: [

Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color

2017-10-16 Thread Tim Lewis
And we always turn off the multiple colors. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jarlstrom, Laurie Sent: Monday, October 16, 2017 12:47 PM To: Carsey, Jaben ; Ni, Ruiyu ; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] ShellPkg

Re: [edk2] [PATCH 0/2] Implement NULL pointer detection feature

2017-08-29 Thread Tim Lewis
Just a +1 for 4 separate PCDs. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Johnson, Brian (EXL - Eagan) Sent: Tuesday, August 29, 2017 10:12 AM To: Kinney, Michael D ; Yao, Jiewen ; Wang, Jian J ; edk2-devel@lists.01.org Subject: Re: [e

Re: [edk2] Using NULL| style library linkable in EDK2

2017-07-20 Thread Tim Lewis
Mike -- Ok, I will enter it into Bugzilla later today. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney, Michael D Sent: Thursday, July 20, 2017 10:57 AM To: Tim Lewis ; edk2-devel@lists.01.org; Kinney, Michael D Subject: Re: [edk2

[edk2] Using NULL| style library linkable in EDK2

2017-07-20 Thread Tim Lewis
." Thanks, Tim Lewis CTO, Insyde Software www.insyde.com<http://www.insyde.com> ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [RFC] PCD: Database size optimization for multi-SKU

2017-05-16 Thread Tim Lewis
01.org<mailto:edk2-devel@lists.01.org> Cc: Star Zeng<mailto:star.z...@intel.com>; Michael Kinney<mailto:michael.d.kin...@intel.com>; Liming Gao<mailto:liming@intel.com>; Tim Lewis<mailto:tim.le...@insyde.com>; Yonghong Zhu<mailto:yonghong@intel.com> Subj

Re: [edk2] [PATCH] ShellPkg/Touch: Create file if it doesn't exist

2017-05-15 Thread Tim Lewis
I don't think it is good to change the behavior of the tool beyond what is in the specification. Further, this tool has existed for quite a long time in the EDK shell and now the UEFI shell without this behavior. So the de-facto standard of this environment is "don't create". Leaving behind stra

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-05-15 Thread Tim Lewis
Star -- Thanks for your work on this. I have reviewed this and it looks good, addressing all of our concerns. Tim -Original Message- From: Zeng, Star [mailto:star.z...@intel.com] Sent: Monday, May 15, 2017 2:46 AM To: Tim Lewis ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Gao

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-05-05 Thread Tim Lewis
can decide not to use this, but we actually like it. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zeng, Star Sent: Friday, May 05, 2017 3:08 AM To: Tim Lewis ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Zeng, Star ; Gao, Liming S

Re: [edk2] [RFC 0/3] Structure PCD value assignment in DEC/DSC

2017-05-04 Thread Tim Lewis
Mike -- Sorry for the delay. We have reviewed this RFC internally and we believe it is a useful change. Thanks, Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, Liming Sent: Tuesday, April 11, 2017 8:17 AM To: edk2-devel@lists.01.org

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-05-04 Thread Tim Lewis
...@intel.com] Sent: Thursday, May 04, 2017 6:42 AM To: Tim Lewis ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Gao, Liming ; Zeng, Star Subject: RE: [RFC] PCD: Extended SKU support 1 - inheritance Tim, To avoid misunderstanding, I think I need to clarify more about this RFC. :) This RFC is NOT to

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-05-03 Thread Tim Lewis
s not found in array } Resource = NULL; while (!GetResourceForSkuId(*SkuId, &Resource) && *SkuId == 0) { *SkuId++; } If (Resource == NULL) { // error, no resource found for any of the SKU IDs } From: Zeng, Star [mailto:star.z...@intel.com] Sent: Wednesday, May 03, 2017 7:03

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

2017-04-28 Thread Tim Lewis
-boun...@lists.01.org] On Behalf Of Tim Lewis Sent: Wednesday, April 26, 2017 5:27 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Carsey, Jaben ; Shaw, Kevin W Subject: Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM Mike -- No, the meta-data

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-27 Thread Tim Lewis
, Star<mailto:star.z...@intel.com> Sent: Thursday, April 27, 2017 6:53 PM To: Tim Lewis<mailto:tim.le...@insyde.com>; Kinney, Michael D<mailto:michael.d.kin...@intel.com>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> Cc: Gao, Liming<mailto:liming@intel.com&

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-27 Thread Tim Lewis
abase. Tim -Original Message- From: Zeng, Star [mailto:star.z...@intel.com] Sent: Thursday, April 27, 2017 6:00 PM To: Tim Lewis ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Gao, Liming ; Zeng, Star Subject: RE: [RFC] PCD: Extended SKU support 1 - inheritance Tim, Could you share

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-27 Thread Tim Lewis
Mike -- For the one-logo case, yes, that would work. But this is the simplest case. Consider HII string packages. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 5:28 PM To: Tim Lewis ; Zeng, Star ; edk2-devel@lists

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

2017-04-26 Thread Tim Lewis
ve the previous behavior. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 5:02 PM To: Tim Lewis ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Carsey, Jaben ; Shaw, Kevin W Subject: RE: [edk2] [edk2-UniSpecificati

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

2017-04-26 Thread Tim Lewis
d. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 3:47 PM To: Tim Lewis ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Carsey, Jaben ; Shaw, Kevin W Subject: RE: [edk2] [edk2-UniSpecification PATCH] Allow .uni fil

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-26 Thread Tim Lewis
...@intel.com] Sent: Wednesday, April 26, 2017 3:57 PM To: Tim Lewis ; Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Gao, Liming Subject: RE: [RFC] PCD: Extended SKU support 1 - inheritance Hi Tim, How would this relationship information be used in a module? Do you have an example use case

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-26 Thread Tim Lewis
riginal Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 12:04 PM To: Tim Lewis ; Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Gao, Liming Subject: RE: [RFC] PCD: Extended SKU support 1 - inheritance Hi Tim, If multiple SKUs a

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

2017-04-26 Thread Tim Lewis
, April 26, 2017 11:47 AM To: Tim Lewis ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Carsey, Jaben ; Shaw, Kevin W Subject: RE: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM Tim, If you look at the entire file history of the EDK II, you will see

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-26 Thread Tim Lewis
Mike -- I am saying that creating a relationship between SKUs that cannot be determined at runtime is a confusing thing to add to the DSC. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 11:40 AM To: Tim Lewis ; Zeng

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

2017-04-26 Thread Tim Lewis
kward compatible for these files. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 11:11 AM To: Tim Lewis ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Carsey, Jaben ; Shaw, Kevin W Subject: RE: [edk2]

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-26 Thread Tim Lewis
d.kin...@intel.com] Sent: Wednesday, April 26, 2017 11:05 AM To: Tim Lewis ; Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Gao, Liming Subject: RE: [RFC] PCD: Extended SKU support 1 - inheritance Tim, Can you please provide more details on your specific concerns along with some use

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

2017-04-26 Thread Tim Lewis
when one is not present won't help the vast quantities of existing UNI files out there. Tim -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Wednesday, April 26, 2017 10:45 AM To: Tim Lewis ; Kinney, Michael D ; edk2-devel@lists.01.org Cc: Shaw, Kevin W Su

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

2017-04-26 Thread Tim Lewis
Star -- This assumes that the SKU ID is only used for PCDs, which is not the case. The SKU ID may be used by other components, and other components may use the 0|DEFAULT rule as well. 1) There is no way to read this defaulting rule at runtime. The information is buried in the PCD database, bu

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

2017-04-26 Thread Tim Lewis
Mike -- This breaks our existing build tools, which assume that a file without a BOM is UTF-16. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Kinney Sent: Tuesday, April 25, 2017 6:07 PM To: edk2-devel@lists.01.org Cc: Jaben Cars

Re: [edk2] UEFI Shell Lib Constructor and Shell Parameters Protocol

2017-04-05 Thread Tim Lewis
There are "load options" that are passed to drivers (as a part of the EFI_LOADED_IMAGE_PROTOCOL), but there is no guarantee as to their format (binary data or ASCII string or UCS-2 string). It is possible for "load" to be modified to create this data and populate it between the calls to LoadImag

Re: [edk2] Print from DXE_DRIVER

2017-02-08 Thread Tim Lewis
Also, on many systems, the output will be invisible, since boot screen output is a platform policy. In general, using DEBUG() is better, since it can either be redirected to StdErr() or through the serial port. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.

Re: [edk2] [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1

2017-01-23 Thread Tim Lewis
: Monday, January 23, 2017 1:59 PM To: Tim Lewis ; Ni, Ruiyu ; Zeng, Star ; edk2-devel@lists.01.org Cc: Carsey, Jaben Subject: RE: [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1 I was wondering if some replaced version of HiiLib could use the StrDefs.h differently and save the

Re: [edk2] [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1

2017-01-23 Thread Tim Lewis
: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Monday, January 23, 2017 1:48 PM To: Tim Lewis ; Ni, Ruiyu ; Zeng, Star ; edk2-devel@lists.01.org Cc: Carsey, Jaben Subject: RE: [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1 Tim, I meant some customers do localize the shell

Re: [edk2] [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1

2017-01-23 Thread Tim Lewis
tional shell in a much more restricted environment. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey, Jaben Sent: Monday, January 23, 2017 1:15 PM To: Tim Lewis ; Ni, Ruiyu ; Zeng, Star ; edk2-devel@lists.01.org Cc: Carsey, Jaben Sub

Re: [edk2] [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1

2017-01-23 Thread Tim Lewis
Also, in some cases, the text is taken directly from the specification. Introducing HII strings in order to make these translatable when the source material is normative doesn't help, IMO. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cars

Re: [edk2] [shell] Pipe causes pool failure in Shell.c

2016-12-02 Thread Tim Lewis
Jaben -- I'm not sure. In the debugger, it clearly showed the memory as having already been freed at the pointer. But I didn't track down who had done it. Tim -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, December 02, 2016 8:39 AM To:

[edk2] [shell] shift generates errors with no command-line options

2016-12-02 Thread Tim Lewis
In a script that looks like this: :start if not %1 == "" then echo %1 shift goto start endif 'shift' will generate an error message. The spec doesn't describe any behavior like this and it is annoying to write scripts that must avoid it. Of course you can work around it... Tim __

[edk2] [shell] @ does not work before if, endif, for and many other command.

2016-12-02 Thread Tim Lewis
Try this: :start @if %1 == "" then @goto Done @endif @echo Parameter: %1 @shift goto start :Done Per Chapter 4 Also, additional '@' before a command in a script file can prevent the current command from being echoed. ___

[edk2] [shell] Redirected Environment Variables Are Not Saved Correctly

2016-12-02 Thread Tim Lewis
Test by doing this, immediately after booting: Notice that echo has created a new environment variable _key to the value 4, But this variable does not show up when running "set" Why? It is because the FileHandleWrappers does not use SetEnvironmentVariable. Instead, it tries to read and write th

[edk2] [shell] Pipe causes pool failure in Shell.c

2016-12-01 Thread Tim Lewis
.01.org] On Behalf Of Tim Lewis Sent: Thursday, December 01, 2016 5:48 PM To: edk2-devel@lists.01.org Subject: [edk2] Pipe causes pool failure in Shell.c Using the latest Shell build, try: ls -sfo | parse FileInfo 2 This ends up with a breakpoint when FreePool is called on Shell.c, line 1756.

[edk2] Root Cause of Parse Failure With Redirected Input

2016-12-01 Thread Tim Lewis
if (StrStr (TempLine, L"ShellCommand,") == TempLine) { LoopVariable++; } This line fails because, with redirected input, the file has the UCS-2 byte order mark, so the string "ShellCommand," is not at the beginning of the line. With the file, the byte order mark is not presen

[edk2] Pipe causes pool failure in Shell.c

2016-12-01 Thread Tim Lewis
Using the latest Shell build, try: ls -sfo | parse FileInfo 2 This ends up with a breakpoint when FreePool is called on Shell.c, line 1756. I'm still debugging, but I wondered if anyone else has seen this? Also: ls -sfo > tmp parse FileInfo 2 < tmp prints nothing, but parse tmp FileInfo 2 w

[edk2] [shell] Redirection to environment variable used on command-line not working.

2016-12-01 Thread Tim Lewis
I have a command like this: X %_key% >v _key and X %_key% _key These two commands should do, essentially the same thing, since the command 'X' calls ShellSetEnvironmentVariable() if the 2nd parameter is present. Any thoughts? Tim ___ edk2-devel ma

Re: [edk2] [shell] AliasLower never used in InternalSetAlias

2016-10-28 Thread Tim Lewis
Sure. I think we should adjust the specification in this case. My problem has been when someone says "but the EDK2 version does X" Tim -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, October 28, 2016 9:59 AM To: Tim Lewis ; edk2-devel@li

Re: [edk2] [shell] AliasLower never used in InternalSetAlias

2016-10-28 Thread Tim Lewis
[mailto:jaben.car...@intel.com] Sent: Friday, October 28, 2016 8:20 AM To: Tim Lewis ; edk2-devel@lists.01.org Cc: Carsey, Jaben Subject: RE: [shell] AliasLower never used in InternalSetAlias Tim, Given that all commands are case insensitive, I couldn't imagine why we would want case-sensit

Re: [edk2] [shell] AliasLower never used in InternalSetAlias

2016-10-27 Thread Tim Lewis
.org] On Behalf Of Tim Lewis Sent: Thursday, October 27, 2016 2:11 PM To: edk2-devel@lists.01.org Subject: [edk2] [shell] AliasLower never used in InternalSetAlias In the function InternalSetAlias, it appears that AliasLower is duplicated (fromAlias), converted to lower case and freed ,but never

[edk2] [shell]cd.. and cd\ are not valid alias

2016-10-27 Thread Tim Lewis
But the EDK2 registers them as a part of Level 2 supported command initialization. ShellCommandRegisterAlias(L"cd ..", L"cd.."); ShellCommandRegisterAlias(L"cd \\", L"cd\\"); According to the SetAlias() description: An alias is a C-style identifier The same language is repeated in 3.6.4.

[edk2] [shell] AliasLower never used in InternalSetAlias

2016-10-27 Thread Tim Lewis
In the function InternalSetAlias, it appears that AliasLower is duplicated (fromAlias), converted to lower case and freed ,but never actually used. Am I missing something? // Convert to lowercase to make aliases case-insensitive if (Alias != NULL) { AliasLower = AllocateCopyPool (StrSize

Re: [edk2] [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()

2016-10-18 Thread Tim Lewis
Reviewed-by: Tim Lewis -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, October 18, 2016 4:07 AM To: edk2-devel-01 Cc: Jaben Carsey ; Ruiyu Ni ; Tim Lewis Subject: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName() The

[edk2] FW: [shell] Problems in EfiShellGetGuidFromName

2016-10-18 Thread Tim Lewis
Did anyone have a chance to look at this EFI_SHELL_PROTOCOL bug in the EDK2 implementation? Thanks, Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tim Lewis Sent: Thursday, October 13, 2016 11:16 AM To: edk2-devel-01 Subject: [edk2

Re: [edk2] [PATCH 1/5] ShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h

2016-10-14 Thread Tim Lewis
Glad to see this is finally being done! -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Friday, October 14, 2016 2:44 AM To: edk2-devel@lists.01.org Cc: Jaben Carsey ; Michael D Kinney ; Jiewen Yao Subject: [edk2] [PATCH 1/5] Shell

Re: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg

2016-10-14 Thread Tim Lewis
I prefer the renamed .h file, even though I have substantial investment in the current infrastructure. Why? Because engineers don't have time to remember "how does protocol X translate to header file Y" It should be a consistent rule. How many times have I needed to grep the header file name ju

Re: [edk2] AsciiPrint behavior with \n linefeed characters.

2016-10-13 Thread Tim Lewis
Liming -- And I agree that this should be the behavior. I was surprised by the lack of translation for the other string printed via %s. Tim -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Thursday, October 13, 2016 6:24 PM To: Tim Lewis ; edk2-devel-01

[edk2] AsciiPrint behavior with \n linefeed characters.

2016-10-13 Thread Tim Lewis
In using AsciiPrint (I'm presuming the behavior is also in Print, but I haven't tested), I found an interesting behavior for linefeed characters embedded in strings that are parameters. I post it here just so people who are mystified by their output can understand it. Consider this example: CO

[edk2] [shell] Problems in EfiShellGetGuidFromName

2016-10-13 Thread Tim Lewis
In EfiShellGetGuidFromName (ShellProtocol.c), we see: EfiShellGetGuidFromName( IN CONST CHAR16 *GuidName, OUT EFI_GUID *Guid ) { EFI_GUID*NewGuid; EFI_STATUS Status; if (Guid == NULL || GuidName == NULL) { return (EFI_INVALID_PARAMETER); } Status = GetGuidFromSt

[edk2] SetCurDir() doesn't allow '\\' in Dir?

2016-10-07 Thread Tim Lewis
I did a simple break apart of a path into map-name and directory. fs0:\MdeModulePkg So FileSystem was "fs0:" and Dir was "\MdeModulePkg" and the resulting working directory was: "fs0:MdeModulePkg" (with escape characters).. It seems the culprit is in EfiShellSetCurDir: if (DirectoryNa

Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform

2016-10-05 Thread Tim Lewis
ileInfo(*FileHandle, FileInfo); FreePool(FileInfo); if (EFI_ERROR (Status2)) { gEfiShellProtocol->CloseFile(*FileHandle); } Status = Status2; } -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Wednesday, October 05, 2016 2:17

Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform

2016-10-05 Thread Tim Lewis
to:af...@apple.com] Sent: Wednesday, October 05, 2016 1:59 PM To: Laszlo Ersek Cc: Tim Lewis ; Carsey, Jaben ; Shah, Tapan ; Daniil Egranov ; edk2-devel-01 ; Leif Lindholm Subject: Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform > On Oct 5, 2016, at

Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform

2016-10-05 Thread Tim Lewis
Is it possible that Daniil has UnicodeCollation and not UnicodeCollation2? The shell itself can handle this case, but the ShellLib cannot. Tim -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, October 05, 2016 1:58 PM To: Tim Lewis ; Carsey, Jaben

Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform

2016-10-05 Thread Tim Lewis
Jaben -- In which cases would you have the Shell protocol present and not have the Unicode Collation protocol? By my count, the Shell itself cannot function without it (see ProcessCommandLine()). Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Beh

Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform

2016-10-05 Thread Tim Lewis
Daniil -- Per your point about modules: Adding a dependency expression to a library should NOT have any effect on an application, since applications do not have dependency expressions. So this would indicate that you are trying to link a driver against the UefiShellLib. Is this correct? This

Re: [edk2] RFC: ProtocolLib for cross DXE and SMM Protocol and Handle Services

2016-09-30 Thread Tim Lewis
Eugene -- Since the standalone file type isn't yet in the EDK2 code, the build system will not be able to make this distinction in the library's INF file. Tim -Original Message- From: Cohen, Eugene [mailto:eug...@hp.com] Sent: Friday, September 30, 2016 9:51 AM To:

Re: [edk2] RFC: ProtocolLib for cross DXE and SMM Protocol and Handle Services

2016-09-30 Thread Tim Lewis
Eugene -- Since SMM drivers today are actually DXE drivers during the initialization phase, are you going to (a) have your library check InSmm? or (b) only work with pure SMM stand-alone drivers? Thanks, Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]

Re: [edk2] Protocol EFI_FORM_BROWSER_EXTENSION_PROTOCOL - included in UDK code but not part of the spec

2016-09-21 Thread Tim Lewis
Liming -- Could you change the protocol name, and then use a typedef with the old name for compatibility? Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, Liming Sent: Tuesday, September 20, 2016 8:57 PM To: Boaz Kahana ; edk2-devel@lis

Re: [edk2] Shell version 2.2

2016-08-05 Thread Tim Lewis
Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey, Jaben Sent: Friday, August 05, 2016 12:10 PM To: Tim Lewis ; Meenakshi Aggarwal ; edk2-devel@lists.01.org Cc: Carsey, Jaben Subject: Re: [edk2] Shell version 2.2 Tim, Yes, ver command would output

Re: [edk2] Shell version 2.2

2016-08-05 Thread Tim Lewis
Jaben -- Are there no shell commands where the standard command-line parameters have changed? Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey, Jaben Sent: Friday, August 05, 2016 10:26 AM To: Meenakshi Aggarwal ; edk2-devel@lists.01

Re: [edk2] [PATCH] add top-level .gitattributes file, dealing with .depex

2016-08-01 Thread Tim Lewis
[mailto:jordan.l.jus...@intel.com] Sent: Monday, August 01, 2016 12:03 AM To: Kinney, Michael D ; Leif Lindholm ; Tim Lewis ; Kinney, Michael D Cc: Laszlo Ersek ; edk2-devel@lists.01.org; Andrew Fish Subject: RE: [edk2] [PATCH] add top-level .gitattributes file, dealing with .depex On 2016-07-31

Re: [edk2] [PATCH] add top-level .gitattributes file, dealing with .depex

2016-07-29 Thread Tim Lewis
It appears that this file is not actually used. It is only referenced in the [Rule.Common.UEFI_DRIVER.NATIVE_BINARY] rule in PlatformPkg.fdf. A little further research shows that an alternate method was used for the actual GOP binary (see below). A grep of the entire tree shows that no one uses

Re: [edk2] [PATCH] MdePkg: Add DmaRemappingReportingTable.h

2016-07-28 Thread Tim Lewis
endorsement of an "industry standard" any more than XENV. (XEN Project Table). They are just vendor links. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Thursday, July 28, 2016 9:51 AM To: Tim Lewis ; Laszlo Ersek ; Mudusuru, Gir

Re: [edk2] [PATCH] MdePkg: Add DmaRemappingReportingTable.h

2016-07-28 Thread Tim Lewis
y, July 28, 2016 9:29 AM To: Tim Lewis ; Giri P Mudusuru ; edk2-devel@lists.01.org Cc: Michael Kinney ; Jiewen Yao ; Liming Gao Subject: Re: [edk2] [PATCH] MdePkg: Add DmaRemappingReportingTable.h On 07/28/16 18:00, Tim Lewis wrote: > Giri -- > > Is MdePkg the right place for this? Th

Re: [edk2] [PATCH] MdePkg: Add DmaRemappingReportingTable.h

2016-07-28 Thread Tim Lewis
Giri -- Is MdePkg the right place for this? This appears to be an Intel-specific definition, right? I understand that it was in IndustryStandard for EdkCompatibilityPkg, but it might do better now in the IntelSiliconPkg. Regards, Tim -Original Message- From: edk2-devel [mailto:edk2-de

Re: [edk2] StdLib usage for drivers?

2016-07-06 Thread Tim Lewis
. It makes smaller and cleaner shell applications. Tim -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Wednesday, July 06, 2016 2:12 PM To: Tim Lewis ; af...@apple.com Cc: edk2-devel@lists.01.org; Michael Zimmermann ; Daryl McDaniel (edk2-li...@mc2re

Re: [edk2] StdLib usage for drivers?

2016-07-06 Thread Tim Lewis
-Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Wednesday, July 06, 2016 2:02 PM To: Tim Lewis ; af...@apple.com Cc: edk2-devel@lists.01.org; Michael Zimmermann ; Daryl McDaniel (edk2-li...@mc2research.org) ; Carsey, Jaben Subject: RE: [edk2] StdLib usage for

Re: [edk2] StdLib usage for drivers?

2016-07-06 Thread Tim Lewis
Jaben -- I can certainly recall instances where drivers that publish HII setup pages load things from the disk (such as when checking for specific file names). I also seem to recall that the original EDK shell library was designed to that volume names were simply ignored if the shell protocol w

Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files

2016-06-14 Thread Tim Lewis
d) UINT8(0x4B), "S4BKn_ComDataRead00",UINT8(0x80) } } -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Tuesday, June 14, 2016 6:56 PM To: Tim Lewis ; Zhu, Yonghong ; edk2-devel@lists.01.org; Kinney, Michael D Subject: RE: [

Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files

2016-06-14 Thread Tim Lewis
alf Of Kinney, Michael D Sent: Tuesday, June 14, 2016 5:22 PM To: Tim Lewis ; Zhu, Yonghong ; edk2-devel@lists.01.org; Kinney, Michael D Subject: Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files Tim, No problem. Glad to see the feedback. Would the multi-char '' or

Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files

2016-06-14 Thread Tim Lewis
handle data structures where offsets or sizes are required to be embedded. Doesn't work cross-PCDs, but does in more complicated data structures. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Tuesday, June 14, 2016 4:50 PM To: Tim Lewis

Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files

2016-06-14 Thread Tim Lewis
[mailto:michael.d.kin...@intel.com] Sent: Tuesday, June 14, 2016 4:50 PM To: Tim Lewis ; Zhu, Yonghong ; edk2-devel@lists.01.org; Kinney, Michael D Subject: RE: [RFC] Add more flexible PCD value formats in DEC/DSC files Tim, Good suggestions. I like L'' for single a multi-chara

Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files

2016-06-14 Thread Tim Lewis
it is not distinguishable from subtraction expressions. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Tuesday, June 14, 2016 4:50 PM To: Tim Lewis ; Zhu, Yonghong ; edk2-devel@lists.01.org; Kinney, Michael D Subject: RE: [RFC] Add more

Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files

2016-06-14 Thread Tim Lewis
Mike -- We have traditionally used a preprocessor to convert the following into byte arrays: UINT8(xx), UINT16(xx), UINT32(xx), UINT64(xx), BOOLEAN(TRUE|FALSE), GUID(struct-style {} or registry style "xx-yyy..."), "" (ASCII string no-nullterminator), L"" (UCS16 string no null-terminator),

Re: [edk2] propose 3 new UserExtensions in the INF specification

2016-06-10 Thread Tim Lewis
Jaben -- For the record, I think that continuing to add meta-build information to the .inf files is counter-productive. As a company that has written tools that conform to the grammar, these extensions to an .ini style file format are becoming more and more arcane to parse and process. Some com

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

2016-05-10 Thread Tim Lewis
Yes. Tim -Original Message- From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Monday, May 09, 2016 6:42 PM To: Kinney, Michael D ; Tim Lewis ; Mudusuru, Giri P ; edk2-devel@lists.01.org Cc: Mudusuru, Giri P ; Zimmer, Vincent ; Rangarajan, Ravi P Subject: RE: [edk2] [PATCH 17/19

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

2016-05-05 Thread Tim Lewis
final file resides. That leads to bad bug reports, etc. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Thursday, May 05, 2016 6:14 PM To: Tim Lewis ; Mudusuru, Giri P ; Yao, Jiewen ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Mudusuru, Giri P

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

2016-05-05 Thread Tim Lewis
That works well, thank you Tim Sent from my Windows 10 phone From: Mudusuru, Giri P<mailto:giri.p.mudus...@intel.com> Sent: Thursday, May 5, 2016 12:07 PM To: Tim Lewis<mailto:tim.le...@insyde.com>; Yao, Jiewen<mailto:jiewen@intel.com>; edk2-devel@lists.01.org<mailt

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

2016-05-04 Thread Tim Lewis
Thank you. Tim Sent from my Windows 10 phone From: Mudusuru, Giri P<mailto:giri.p.mudus...@intel.com> Sent: Tuesday, May 3, 2016 11:06 PM To: Tim Lewis<mailto:tim.le...@insyde.com>; Yao, Jiewen<mailto:jiewen@intel.com>; edk2-devel@lists.01.org<mailto:edk2-d

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

2016-05-03 Thread Tim Lewis
product launch. Because of features and security concerns, we continually upgrade our chipsets to use newer kernel code. This puts an extra variable. Regards, Tim Lewis CTO, Insyde Software www.insyde.com From: Mudusuru, Giri P [mailto:giri.p.mudus...@intel.com] Sent: Tuesday, May 03, 2016 4:07 PM

  1   2   >