On 10/06/16 00:17, Carsey, Jaben wrote:
> Laszlo,
>
> As Tim clarified, the API already fail when the shell protocol was
> not present and the shell already needs the UnicodeCollation
> protocol.
>
> The goal here is not to allow the library to function without the
> shell protocol (and thereby t
..@apple.com; Laszlo Ersek
>
> Cc: edk2-devel-01 ; Leif Lindholm
>
> Subject: RE: [edk2] Assert in ShellPkg with latest tianocore edk2 source on
> the Reference Platform
> Importance: High
>
> Jaben --
>
> Here is the relevant piece of code. There is *no way* for
v
>> Cc: Carsey, Jaben ; edk2-devel-01
>> ;
>> Leif Lindholm
>> Subject: Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on
>> the
>> Reference Platform
>>
>> On 10/05/16 23:05, Andrew Fish wrote:
>>
>>> I'm
ilto:edk2-devel-boun...@lists.01.org] On Behalf Of
Andrew Fish
Sent: Wednesday, October 05, 2016 2:06 PM
To: Daniil Egranov
Cc: Carsey, Jaben ; edk2-devel-01 ; Leif Lindholm
Subject: Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on
the Reference Platform
Importance: High
On Oc
ailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, October 5, 2016 2:18 PM
> To: Andrew Fish ; Daniil Egranov
> Cc: Carsey, Jaben ; edk2-devel-01
> ;
> Leif Lindholm
> Subject: Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source
PM
To: Tim Lewis ; af...@apple.com; Laszlo Ersek
Cc: edk2-devel-01 ; Leif Lindholm
; Carsey, Jaben
Subject: RE: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the
Reference Platform
That is not enough. That gets called by the constructor. We need to not check
in either constru
On 10/05/16 23:15, Carsey, Jaben wrote:
> All,
> What are your thoughts about Tapan's suggestion to move the protocol location
> to the only function that needs it?
As I wrote elsewhere in the thread, that will eliminate the assert, but
it will break ShellOpenFileByName() for good (under the same
Behalf Of
> Tim Lewis
> Sent: Wednesday, October 05, 2016 2:07 PM
> To: af...@apple.com; Laszlo Ersek
> Cc: Carsey, Jaben ; edk2-devel-01 de...@ml01.01.org>; Leif Lindholm
> Subject: Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on
> the Reference Platform
&g
--
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>> Andrew Fish
>> Sent: Wednesday, October 05, 2016 2:06 PM
>> To: Daniil Egranov
>> Cc: Carsey, Jaben ; edk2-devel-01 > de...@lists.01.org>; Leif Lindholm
>> Subject: Re: [edk2] Asse
On 10/05/16 23:05, Andrew Fish wrote:
> I'm guessing that your DXE Driver is dispatching prior UEFI Driver that
> publishes the protocol.
BTW... Why is EnglishDxe a UEFI_DRIVER rather than a DXE_DRIVER? It
doesn't conform to the UEFI driver model. (I'm not saying it *must* not
be a UEFI_DRIVER,
t; Andrew Fish
> Sent: Wednesday, October 05, 2016 2:06 PM
> To: Daniil Egranov
> Cc: Carsey, Jaben ; edk2-devel-01 de...@lists.01.org>; Leif Lindholm
> Subject: Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on
> the Reference Platform
> Importance: High
&
to:af...@apple.com]
Sent: Wednesday, October 05, 2016 1:59 PM
To: Laszlo Ersek
Cc: Tim Lewis ; Carsey, Jaben ;
Shah, Tapan ; Daniil Egranov ;
edk2-devel-01 ; Leif Lindholm
Subject: Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the
Reference Platform
> On Oct 5, 2016, at
On 10/05/16 22:59, Andrew Fish wrote:
>
>> On Oct 5, 2016, at 1:58 PM, Laszlo Ersek wrote:
>>
>> On 10/05/16 22:44, Tim Lewis wrote:
>>> Jaben --
>>>
>>> In which cases would you have the Shell protocol present and not have the
>>> Unicode Collation protocol?
>>
>> That's exactly the question!
>
t;>>> Tapan,
>>>>
>>>> Could this be a side effect of your patch? Should we allow the
>>>> UefiShellLib to continue without this protocol and then return an error
>>>> only when the OpenFile is called?
>>>>
>>>&
;
Shah, Tapan ; Andrew Fish ; Daniil Egranov
Cc: edk2-devel-01 ; Leif Lindholm
Subject: Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the
Reference Platform
On 10/05/16 22:44, Tim Lewis wrote:
> Jaben --
>
> In which cases would you have the Shell protocol present and
On 10/05/16 22:53, Daniil Egranov wrote:
>
>
> On 10/05/2016 02:48 PM, Andrew Fish wrote:
>>> On Oct 5, 2016, at 12:24 PM, Daniil Egranov
>>> wrote:
>>>
>>> I have the same ASSERT issue on Juno platform even the EnglishDxe.inf
>>> is included to the platform build. If UefiShellLib has such
>>> d
day, October 04, 2016 3:51 PM
To: edk2-devel-01
Cc: Leif Lindholm
Subject: [edk2] Assert in ShellPkg with latest tianocore edk2 source
on the Reference Platform
Importance: High
All,
Recently, I updated to latest edk2 master (yesterday's) and I am
actually encountering assert in
ShellPkg/
un...@lists.01.org] On Behalf Of
>> Carsey, Jaben
>> Sent: Wednesday, October 05, 2016 1:35 PM
>> To: Shah, Tapan ; Laszlo Ersek ;
>> Andrew Fish ; Daniil Egranov
>> Cc: Carsey, Jaben ; edk2-devel-01
>> ; Leif Lindholm
>> Subject: Re: [edk2] Assert in Shell
ailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Carsey, Jaben
> Sent: Wednesday, October 05, 2016 1:35 PM
> To: Shah, Tapan ; Laszlo Ersek ;
> Andrew Fish ; Daniil Egranov
> Cc: Carsey, Jaben ; edk2-devel-01
> ; Leif Lindholm
> Subject: Re: [edk2] Assert in ShellPkg
Lindholm ; Shah, Tapan
>
> Subject: Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on
> the Reference Platform
>
> On 10/05/16 21:48, Andrew Fish wrote:
>> >
>>> >> On Oct 5, 2016, at 12:24 PM, Daniil Egranov
>>> >> wrot
Behalf Of Carsey,
Jaben
Sent: Wednesday, October 05, 2016 1:35 PM
To: Shah, Tapan ; Laszlo Ersek ; Andrew
Fish ; Daniil Egranov
Cc: Carsey, Jaben ; edk2-devel-01
; Leif Lindholm
Subject: Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the
Reference Platform
That should work
, Jaben
Subject: RE: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the
Reference Platform
That should work. We also need to initialize the variable to NULL in the
constructor.
Do we need to be case insensitive for this? Can we use memcmp instead of the
prototol?
-Jaben
ctober 05, 2016 1:25 PM
> To: Laszlo Ersek ; Andrew Fish ;
> Daniil Egranov
> Cc: Carsey, Jaben ; edk2-devel-01 de...@ml01.01.org>; Leif Lindholm
> Subject: RE: [edk2] Assert in ShellPkg with latest tianocore edk2 source on
> the Reference Platform
> Importance: High
>
> H
; Daniil Egranov
Cc: Carsey, Jaben ; edk2-devel-01
; Leif Lindholm ; Shah, Tapan
Subject: Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the
Reference Platform
On 10/05/16 21:48, Andrew Fish wrote:
>
>> On Oct 5, 2016, at 12:24 PM, Daniil Egranov wrote:
>>
>
On 10/05/16 21:48, Andrew Fish wrote:
>
>> On Oct 5, 2016, at 12:24 PM, Daniil Egranov wrote:
>>
>> I have the same ASSERT issue on Juno platform even the EnglishDxe.inf is
>> included to the platform build. If UefiShellLib has such dependency on the
>> protocol then according to EDKII Module W
en
>>
>>> -----Original Message-
>>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>>> Supreeth Venkatesh
>>> Sent: Tuesday, October 04, 2016 3:51 PM
>>> To: edk2-devel-01
>>> Cc: Leif Lindholm
>>>
Behalf Of Daniil
Egranov
Sent: Wednesday, October 05, 2016 12:24 PM
To: Shah, Tapan ; Carsey, Jaben ;
Supreeth Venkatesh ; edk2-devel-01
Cc: Leif Lindholm
Subject: Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the
Reference Platform
I have the same ASSERT issue on Juno
riginal Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Supreeth Venkatesh
Sent: Tuesday, October 04, 2016 3:51 PM
To: edk2-devel-01
Cc: Leif Lindholm
Subject: [edk2] Assert in ShellPkg with latest tianocore edk2 source
on the Reference Platform
Importance: High
Al
rg] On Behalf Of
> Supreeth Venkatesh
> Sent: Tuesday, October 04, 2016 3:51 PM
> To: edk2-devel-01
> Cc: Leif Lindholm
> Subject: [edk2] Assert in ShellPkg with latest tianocore edk2 source
> on the Reference Platform
> Importance: High
>
> All,
>
> Recently, I
nothing else...
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Supreeth Venkatesh
> Sent: Tuesday, October 04, 2016 3:51 PM
> To: edk2-devel-01
> Cc: Leif Lindholm
> Subject: [edk2] Assert in ShellPkg with
All,
Recently, I updated to latest edk2 master (yesterday's) and I am actually
encountering assert in ShellPkg/Library/UefiShellLib/UefiShellLib.c
if (mUnicodeCollationProtocol == NULL) {
Status = gBS->LocateProtocol (&gEfiUnicodeCollation2ProtocolGuid, NULL,
(VOID**)&mUnicodeCollationProto
31 matches
Mail list logo
