Generally, the patch is good to me.
Some comments below.
On 2018/6/14 19:38, Sami Mujawar wrote:
The SATA controller driver crashes while accessing the
PCI memory, as the PCI memory space is not enabled.
The code "accessing the PCI memory" you mentioned here is
the AhciReadReg in the following
: Saturday, June 16, 2018 12:13 AM
To: Evan Lloyd
Cc: Ni, Ruiyu ; nd ; Stephanie Hughes-Fitt
; Dong, Eric ; Ard
Biesheuvel ; edk2-devel@lists.01.org; Zeng, Star
Subject: Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem
space
On Fri, Jun 15, 2018 at 03:26:54PM +, Evan Lloyd
;
ard.biesheu...@linaro.org; leif.lindh...@linaro.org; nd ; Zeng,
Star
Subject: Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem
space
Hi Laszlo, Star.
Looking at the e-mail thread, I think I also made the mistake of getting Star's
name inverted.
I'm sorry, especially as in th
Hi Sami,
I will have feedback in the V1 patch thread based on your response there.
Thanks,
Star
-Original Message-
From: Sami Mujawar [mailto:sami.muja...@arm.com]
Sent: Friday, June 15, 2018 10:14 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric ; Ni,
Ruiyu ; ard.biesheu
Hi Sami,
My feedback are inline.
On 2018/6/15 21:51, Sami Mujawar wrote:
Hi Zeng,
Please find my response marked [SAMI] below.
Regards,
Sami Mujawar
-Original Message-
From: Zeng, Star
Sent: 15 June 2018 10:42 AM
To: Sami Mujawar ; edk2-devel@lists.01.org
Cc: ruiyu...@intel.com
Reviewed-by: Star Zeng
-Original Message-
From: Gao, Liming
Sent: Monday, June 18, 2018 10:58 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Zeng, Star
Subject: [Patch] MdeModulePkg BdsDxe: Correct VariableLockProtocol usage to
match code logic
BdsEntry marks the read-only variables
If you agree, you do not need resend new patch.
I will help update it simply and push the patch.
Thanks,
Star
-Original Message-
From: Sami Mujawar [mailto:sami.muja...@arm.com]
Sent: Tuesday, June 19, 2018 7:58 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric ; Ni,
Ruiyu
Pushed at 24fee0528c32b240720547afdd737ca928b34e60.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Sami
Mujawar
Sent: Wednesday, June 20, 2018 4:23 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; nd ; Stephanie Hughes
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi
Sent: Tuesday, June 19, 2018 3:39 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Yao, Jiewen
; Zeng, Star
Subject: [edk2] [patch] SignedCapsulePkg
Please fix typo 'DevicePathLenth' to 'DevicePathLength'.
With that, Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Friday, June 15, 2018 3:04 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Zeng, Star ; Dong,
Eric ; Ni, Ruiyu ; Y
Reviewed-by: Star Zeng
-Original Message-
From: Wu, Hao A
Sent: Friday, June 15, 2018 3:04 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Zeng, Star ; Dong,
Eric ; Ni, Ruiyu ; Yao, Jiewen
Subject: [PATCH 3/4] MdeModulePkg: Add GUID for recovery capsule on NVM Express
devices
Cc
I think the code needs
1. Remove the check to S3 boot mode.
2. Use DEBUG_BLKIO in block read function.
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Friday, June 15, 2018 3:04 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Zeng, Star ; Dong,
Eric ; Ni, Ruiyu ; Yao, Jiewen
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu
Sent: Friday, June 22, 2018 10:39 AM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Ni, Ruiyu ; Yao, Jiewen
; Dong, Eric ; Zeng, Star
Subject: [edk2] [PATCH v2 2/4
Reviewed-by: Star Zeng
-Original Message-
From: Bi, Dandan
Sent: Monday, June 25, 2018 9:08 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [patch] MdeModulePkg/CapsuleRuntimeDxe: Fix ECC issue
Add guard macro for new added header file.
Cc: Star Zeng
Contributed-under
Behalf Of Laszlo
Ersek
Sent: Wednesday, June 27, 2018 8:54 PM
To: Brijesh Singh ; edk2-devel@lists.01.org
Cc: Tom Lendacky ; Dong, Eric ;
Zeng, Star ; Justen, Jordan L
Subject: Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable
access when SEV is enabled
On 06/26/18 21:46
2018 1:50 AM
To: Laszlo Ersek ; edk2-devel@lists.01.org
Cc: Tom Lendacky ; brijesh.si...@amd.com; Dong, Eric
; Zeng, Star ; Justen, Jordan L
Subject: Re: [edk2] [RFC PATCH 1/1] OvmfPkg/QemuFlash: Fix Runtime variable
access when SEV is enabled
On 06/27/2018 11:59 AM, Laszlo Ersek wrote:
> O
FvbRuntimeDxe + FvbSmm.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Thursday, June 28, 2018 9:14 PM
To: Zeng, Star ; Brijesh Singh ;
edk2-devel@lists.01.org
Cc: Tom Lendacky ; Dong, Eric ;
Justen, Jordan L
Subject: Re
Reviewed-by: Star Zeng
-Original Message-
From: Wu, Hao A
Sent: Thursday, June 28, 2018 9:41 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Shi, Steven ; Dong,
Eric
Subject: RE: [PATCH v2] MdeModulePkg/AtaPassThru: Add missing NULL ptr check in
BindingStart
Correction:
Should be V1
Reviewed-by: Star Zeng
-Original Message-
From: Wu, Hao A
Sent: Thursday, June 28, 2018 9:42 AM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Anbazhagan Baraneedharan
; Zeng, Star ; Dong, Eric
Subject: [PATCH] MdeModulePkg/Sd: Fix type when adding model name string
REF:https
Reviewed-by: Star Zeng
-Original Message-
From: Ni, Ruiyu
Sent: Monday, July 2, 2018 11:21 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [PATCH 2/3] MdeModulePkg/[Pei|Dxe]ResetSystemLib: Add PPI/Protocol
dependency
Contributed-under: TianoCore Contribution Agreement 1.1
Reviewed-by: Star Zeng
-Original Message-
From: Ni, Ruiyu
Sent: Monday, July 2, 2018 11:21 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [PATCH 1/3] MdeModulePkg/ResetUtilityLib: Add pack(1) for reset data
structure
RESET_UTILITY_GUID_SPECIFIC_RESET_DATA structure should be
Reviewed-by: Star Zeng
How about doing same update in ResetSystemPei in an updated patch or a
separated patch?
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Monday, July 2, 2018 11:21 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [PATCH 3/3] MdeModulePkg
: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Zeng, Star
Subject: [edk2] [PATCH 1/2] MdeModulePkg/BmpSupportLib: Correct debug message
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Michael D Kinney
Cc: Star Zeng
---
MdeModulePkg/Library
== 0) || (PixelWidth == 0)) { " ???
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Monday, June 25, 2018 3:37 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Kinney, Michael D
Subject: [PATCH 2/2] MdeModulePkg/BmpSupportLib: Check PixelHeight/PixelWidth
against 0
The patc
Good idea, I agree.
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Tuesday, July 3, 2018 9:05 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Bi, Dandan ; Zeng, Star
Subject: RE: [edk2] [PATCH] MdeModulePkg SataControllerDxe: Use compare logic
in if condition
Maybe:
if ((Data32
So, you mean caller knows ((PixelHeight == 0) || (PixelWidth == 0)), and caller
knows TranslateGopBltToBmp will return RETURN_UNSUPPORTED for that?
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Tuesday, July 3, 2018 10:03 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Kinney
Ok. Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Tuesday, July 3, 2018 10:17 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Kinney, Michael D
Subject: Re: [PATCH 2/2] MdeModulePkg/BmpSupportLib: Check
PixelHeight/PixelWidth against 0
On 7/3/2018 10
; Dong, Eric ; Justen, Jordan L
; Zeng, Star ; Laszlo Ersek
Subject: [PATCH 1/2] MdeModulePkg/Variable: Check EFI_MEMORY_RUNTIME attribute
before setting it
Set the EFI_MEMORY_RUNTIME attribute in FtwNotificationEvent() only if the
attribute is not already present. This will ensure
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Brijesh Singh [mailto:brijesh.si...@amd.com]
Sent: Wednesday, July 4, 2018 10:02 AM
To: edk2-devel@lists.01.org
Cc: Tom Lendacky ; Brijesh Singh
; Dong, Eric ; Justen, Jordan L
; Zeng, Star ; Laszlo Ersek
Subject: [PATCH
: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [edk2] [Patch] MdeModulePkg/S3SmmInitDone.h: Fix copyright coding
style error.
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
MdeModulePkg/Include/Guid/S3SmmInitDone.h | 2 +-
1 file changed
Pushed at f88290964fe528ffeb67ff108e8174fc2ce52741.
Thanks,
Star
-Original Message-
From: Zeng, Star
Sent: Wednesday, July 4, 2018 10:00 PM
To: Brijesh Singh ; edk2-devel@lists.01.org
Cc: Tom Lendacky ; Dong, Eric ;
Justen, Jordan L ; Laszlo Ersek ;
Zeng, Star
Subject: RE: [PATCH v2 1
Reviewed-by: Star Zeng
-Original Message-
From: Thomas Palmer [mailto:thomas.pal...@hpe.com]
Sent: Wednesday, July 4, 2018 12:41 AM
To: edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star ;
gar...@hpe.com; joseph.shiffl...@hpe.com; Thomas Palmer
Subject: [PATCH 1/1] MdeModulePkg
g
Cc: Dong, Eric ; Zeng, Star ; Ni,
Ruiyu ; gar...@hpe.com; joseph.shiffl...@hpe.com; Thomas
Palmer
Subject: [PATCH 1/1] MdeModulePkg/PciBusDxe: Fix small memory leak in
FreePciDevice
When cleaning the PciIoDevice, also free the BusNumberRange
Contributed-under: TianoCore Contribution Agreement 1
Pushed at 4d76bbcce62e3b972cd226e5f0e43d21db48a3f7.
Thanks,
Star
-Original Message-
From: Zeng, Star
Sent: Friday, July 6, 2018 3:30 PM
To: Thomas Palmer ; edk2-devel@lists.01.org
Cc: Dong, Eric ; gar...@hpe.com; joseph.shiffl...@hpe.com;
Zeng, Star
Subject: RE: [PATCH 1/1
Reviewed-by: Star Zeng
And pushed patch at 9090c8b533013078c6df773e128070c76d917830.
Thanks,
Star
-Original Message-
From: Bi, Dandan
Sent: Friday, July 6, 2018 4:11 PM
To: Thomas Palmer ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: RE: [edk2] [PATCH 1/1] MdeModulePkg
edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin
H?user
Sent: Friday, July 13, 2018 7:19 AM
To: edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: [edk2] Inquiry regarding early DxeIplPeim loading.
Good day developers,
While checking out which edk2 modules request bein
-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin
H?user
Sent: Friday, July 13, 2018 9:26 PM
To: edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: Re: [edk2] Inquiry regarding early DxeIplPeim loading.
Hey Star,
Thank you very much for your reply
2-devel-01
Cc: Dong, Eric ; Wu, Jiaxin ; Ni,
Ruiyu ; Fu, Siyuan ; Zeng, Star
Subject: [PATCH 2/6] MdeModulePkg/RamDiskDxe: replace OpenFileByDevicePath()
with UefiLib API
Replace the OpenFileByDevicePath() function with EfiOpenFileByDevicePath() from
UefiLib, correcting the following issues:
-
Oh, you are right. The flag mDescriptorPopulated means populated or not, but
not populating needed or not.
Will send new patch soon.
Thanks,
Star
-Original Message-
From: Kinney, Michael D
Sent: Friday, July 20, 2018 3:02 PM
To: Zeng, Star ; edk2-devel@lists.01.org; Kinney, Michael
D
That is fine, then I am ok with the patch, Reviewed-by: Star Zeng
.
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, July 19, 2018 9:21 PM
To: Zeng, Star ; edk2-devel-01
Cc: Dong, Eric ; Wu, Jiaxin ; Ni,
Ruiyu ; Fu, Siyuan
Subject: Re
Reviewed-by: Star Zeng to this patch series.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu
Sent: Friday, July 20, 2018 1:26 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [edk2] [PATCH 0/6] Check untested memory and
On 2016/1/7 10:55, Tian Feng wrote:
Two drivers are involved:
1. UfsBlockIoPei
2. NvmExpressDxe
Tian Feng (2):
MdeModulePkg/UfsBlockIoPei: Fix MS toolchain /Od 32bit build failure
MdeModulePkg/NvmExpressDxe: Fix MS toolchain /Od 32bit build failure
MdeModulePkg/Bus/Pci/NvmExpressDxe/Nvm
Hao,
Could you also do the similar fix for
PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c?
Thanks,
Star
On 2016/1/7 12:40, Hao Wu wrote:
When overriding compiler options '/GL' with '/GL-', VS2010 will report
warning C4701 potentially uninitialized local variable for 'LcrParity'
and 'LcrS
On 2016/1/8 10:42, Hao Wu wrote:
When overriding compiler options '/GL' with '/GL-', VS2010 will report
warning C4701 potentially uninitialized local variable in SerialPort
libraries.
Hao Wu (2):
MdeModulePkg BaseSerialPortLib: Fix VS2010 build error
PcAtChipsetPkg SerialIoLib: Fix VS2010
Hi Ryan,
On 2016/1/15 3:10, Ryan Harkin wrote:
Hi Star,
This patch breaks the serial terminal for ARM FVP and Juno platforms.
I assume it also breaks TC2 and other such "vexpress" platforms
effected by this change.
Whilst simple text input seems to work ok, cursor support does not.
And we need
On 2016/1/15 14:36, Ryan Harkin wrote:
On 15 Jan 2016 01:41, "Zeng, Star" wrote:
Hi Ryan,
On 2016/1/15 3:10, Ryan Harkin wrote:
Hi Star,
This patch breaks the serial terminal for ARM FVP and Juno platforms.
I assume it also breaks TC2 and other such "vexpress" platfo
On 2016/1/15 16:08, Ryan Harkin wrote:
On 15 January 2016 at 06:50, Zeng, Star wrote:
On 2016/1/15 14:36, Ryan Harkin wrote:
On 15 Jan 2016 01:41, "Zeng, Star" wrote:
Hi Ryan,
On 2016/1/15 3:10, Ryan Harkin wrote:
Hi Star,
This patch breaks the serial terminal for ARM FV
On 2016/1/15 16:56, Ryan Harkin wrote:
"
On 15 January 2016 at 08:51, Zeng, Star wrote:
On 2016/1/15 16:08, Ryan Harkin wrote:
On 15 January 2016 at 06:50, Zeng, Star wrote:
On 2016/1/15 14:36, Ryan Harkin wrote:
On 15 Jan 2016 01:41, "Zeng, Star" wrote:
Hi Ryan,
On 2016/1/16 1:39, Laszlo Ersek wrote:
On 01/15/16 18:33, Ryan Harkin wrote:
On 15 January 2016 at 17:05, Laszlo Ersek wrote:
Hi,
snipping context liberally...
Whilst simple text input seems to work ok, cursor support does not.
And we need cursor support for Intel BDS.
(1) I think this is
[...]
The above analysis is very clear, thanks. I am a little concern about if
the code changes below follow the comments in the code.
In Terminal.c:
//
// Set the timeout value of serial buffer for
// keystroke response performance issue
//
In TerminalConIn.c:
//
//
On 2016/1/18 14:51, jiewen yao wrote:
Microsoft published secure MOR implementation at
https://msdn.microsoft.com/en-us/library/windows/hardware/mt270973(v=vs.85).aspx
with revision 2 update.
This series patches add MOR lock revision 2
to variable driver.
jiewen yao (3):
MdeModulePkg: Add Mor
On 2016/1/18 15:37, jiewen yao wrote:
This module only handles MOR lock v1.
Now MOR lock V2 solution is published and added in variable
driver. So this module can be deprecated.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: "Yao, Jiewen"
Cc: "Zhang, Cha
[...]
The above analysis is very clear, thanks. I am a little concern about if
the code changes below follow the comments in the code.
In Terminal.c:
//
// Set the timeout value of serial buffer for
// keystroke response performance issue
//
In TerminalConIn.c:
//
//
On 2016/1/18 19:33, Laszlo Ersek wrote:
On 01/18/16 11:24, Zeng, Star wrote:
[...]
The above analysis is very clear, thanks. I am a little concern about if
the code changes below follow the comments in the code.
In Terminal.c:
//
// Set the timeout value of serial buffer for
On 2016/1/19 18:04, Laszlo Ersek wrote:
On 01/18/16 07:02, Star Zeng wrote:
This enhancement is to use the FilePath field in the loaded image
protocol to find the name of an image as a fallback for when the
loaded image device path protocol is not installed on the image handle.
This is necessary
On 2016/1/19 21:53, Laszlo Ersek wrote:
In this series I've rounded up the ideas & fixes from the recent
discussion, started by Ryan's problem report. The commit messages are
verbose and contain references to the mailing list, so this blurb is
long enough already. :)
I'd highly appreciate if ARM
S3BootScriptLib(I guess you are using
DxeS3BootScriptLib.inf in MdeModulePkg) and S3BootScriptLib link SmbusLib.
You may could check the PCD usage in your SmbusLib instance.
Thanks,
Star
From: 王晓峰 [mailto:winggundu...@163.com]
Sent: Thursday, January 21, 2016 5:40 PM
To: edk2-de...@ml01.01.org
Cc: Zeng
.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 王晓峰
Sent: Thursday, January 21, 2016 7:48 PM
To: Zeng, Star
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] S3SaveStateDxe.inf doesn't explicitly include SmbusLib, is
it a bug?
HI
Good idea. I can use it in the V2 patch if no better proposal from others.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Palmer,
Thomas
Sent: Tuesday, January 26, 2016 5:26 PM
To: Zeng, Star; edk2-devel@lists.01.org
Cc: Tian, Feng
On 2016/1/27 15:45, Cinnamon Shia wrote:
(HandoffInformationTable->EfiFreeMemoryBottom - Private->HobList.Raw)
is the PEI temp heap used instead of the length of PEI temp heap.
The length of PEI temp heap should be:
(HandoffInformationTable->EfiFreeMemoryTop - Private->HobList.Raw)
Contributed-
.
EFI_INVALID_PARAMETER The DataSize is not too small and Data is NULL.
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Thursday, January 28, 2016 10:12 AM
To: Zeng, Star; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH 0/3] Minor update to the Data parameter for
GetVariable
On 2016/1/27 16:02, Zeng, Star wrote:
On 2016/1/27 15:45, Cinnamon Shia wrote:
(HandoffInformationTable->EfiFreeMemoryBottom - Private->HobList.Raw)
is the PEI temp heap used instead of the length of PEI temp heap.
The length of PEI temp heap should be:
(HandoffInformatio
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Chao B
Sent: Friday, January 29, 2016 2:18 PM
To: edk2-de...@ml01.01.org
Cc: Zeng, Star; Fu, Siyuan; Zhang, Chao B
Subject: [PATCH 1/2] MdeModulePkg: Add BS+RT+AT variable attribute definition
Add BS+RT+AT variable attribute
I will send V2 patch series to cover it soon. And I will not wait for comments
for a whole day to this first patch series since the patch changes are simple.
Thanks,
Star
-Original Message-
From: Gao, Liming
Sent: Friday, January 29, 2016 4:54 PM
To: Zeng, Star; edk2-devel@lists.01
Just get back from Chinese New Year holiday.
On 2016/2/6 1:55, Laszlo Ersek wrote:
On 02/05/16 13:37, Laszlo Ersek wrote:
On 02/05/16 13:18, Gerd Hoffmann wrote:
Hi,
So, my question is: is this intended and supported behavior (that is,
going from a Secure Boot-capable build to a Secure Bo
On 2016/2/6 4:41, Laszlo Ersek wrote:
Before the merger of the authenticated and non-authenticated variable
drivers (commit fa0737a839d0), we had to match the varstore header GUID in
"OvmfPkg/VarStore.fdf.inc" to SECURE_BOOT_ENABLE, because the opposite
GUID would cause either driver to fail an a
Mike,
Could one PCD be accessed using both methods Dynamic and DynamicEx in one build?
As I know, it could not.
Another problem is about where the default PCD value stores. Currently, PEI and
PEI+DXE phase consumed PCDs are stored in PEI PCD database, and only DXE phase
consumed PCDs are stored
not
work with old PEI.
Thanks,
Star
-Original Message-
From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Monday, February 15, 2016 1:45 PM
To: Zeng, Star; Kinney, Michael D; edk2-devel@lists.01.org
Subject: RE: PCD Local Token Numbers in PEI/DXE
Star --
Consider the case where PEI FV
Cinnamon:
On 2016/2/9 1:38, Cinnamon Shia wrote:
Replace gBS->LocateHandle with gBS->LocateHandleBuffer
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cinnamon Shia
---
ShellPkg/Library/UefiDpLib/DpTrace.c | 40
1 file changed, 9
On 2016/2/9 4:53, Alcantara, Paulo wrote:
Cc: Feng Tian
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Paulo Alcantara
---
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c | 2 ++
1 file changed, 2 insertions(+)
Reviewed-by: Star Zeng
diff --git a/MdeM
On 2016/2/15 17:07, Cinnamon Shia wrote:
Replace gBS->LocateHandle with gBS->LocateHandleBuffer
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cinnamon Shia
---
ShellPkg/Library/UefiDpLib/DpTrace.c | 40
1 file changed, 9 insertion
On 2016/2/15 17:07, Cinnamon Shia wrote:
Replace gBS->LocateHandle with gBS->LocateHandleBuffer
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cinnamon Shia
---
PerformancePkg/Dp_App/DpTrace.c | 40 +---
1 file changed, 9 insertions
On 2016/2/16 2:52, Laszlo Ersek wrote:
On 01/29/16 09:37, Star Zeng wrote:
At the end of CoreFreePoolI(), the check to see if it is a specific
memory type should also cover OEM reserved memory type.
It was missed when adding OEM reserved memory type support at R17460.
Cc: Liming Gao
Cc: Feng T
On 2016/2/15 17:49, Zeng, Star wrote:
On 2016/2/15 17:07, Cinnamon Shia wrote:
Replace gBS->LocateHandle with gBS->LocateHandleBuffer
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cinnamon Shia
---
PerformancePkg/Dp_App/DpTrace.
On 2016/2/15 17:49, Zeng, Star wrote:
On 2016/2/15 17:07, Cinnamon Shia wrote:
Replace gBS->LocateHandle with gBS->LocateHandleBuffer
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cinnamon Shia
---
ShellPkg/Library/UefiDpLib/DpTrace.
al Message-
From: Kinney, Michael D
Sent: Thursday, February 18, 2016 1:21 AM
To: Zeng, Star; Tim Lewis; edk2-devel@lists.01.org; Kinney, Michael D
Subject: RE: PCD Local Token Numbers in PEI/DXE
Star,
I agree if PCDs are added to PEI Database that are also present in DXE
Database, there
Jeremy,
On 2016/2/19 5:07, Jeremy Linton wrote:
Update the BDS frontpage to pull the RAM ranges from the
smbios extended size fields when applicable. The RAM calculation
also needs to take into account all the RAM ranges being provided
as many machines have multiple physical address ranges.
Con
Ard,
On 2016/2/19 21:15, Ard Biesheuvel wrote:
AARCH64 systems never require compatibility with legacy ACPI OSes, and
may not have any 32-bit addressable system RAM. To support ACPI on these
systems, we need to be able to relax the 4 GB allocation restriction.
So add a PCD PcdAcpiExposedTableVe
lePkg, for example, BDS or ACPI.
Thank you
Yao Jiewen
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Monday, February 22, 2016 8:43 PM
To: Yao, Jiewen
Cc: Ni, Ruiyu; Laszlo Ersek; edk2-de...@ml01.01.org; Tian, Feng; Zeng, Star;
leif.lindh...@linaro.org; graeme.greg...@linaro.org;
.org>
<1456248932-28109-2-git-send-email-ard.biesheu...@linaro.org>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Trace: ger.gmane.org 1456297851 22905 80.91.229.3 (24 Feb 2016 07:10:51 GMT)
X
On 2016/2/26 0:25, Ard Biesheuvel wrote:
The assignment of CurrentRsdtEntry and its subsequent dereference are
subject to the same condition, but for some reason, VS2008 does not see
that and warns about the dereference possibly involving an uninitialized
pointer. Since the single statememt betwe
On 2016/2/6 9:07, Liming Gao wrote:
When PcdShadowPeimOnBoot is FALSE, they are not copied to memory and
execute from their original locations. Here, this policy should only
apply for PEIM and PEI_CORE, not for other file type, such as DXE_CORE.
Do we need to include EFI_FV_FILETYPE_COMBINED_PE
On 2016/2/26 16:42, Qiu Shumin wrote:
For new PCDs add their usage information strings in UNI file.
Cc: Ard Biesheuvel
Cc: "Yao, Jiewen"
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
---
MdeModulePkg/MdeModulePkg.uni | 13 -
1
On 2016/2/29 14:10, Feng Tian wrote:
From: "Tian, Feng"
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Feng Tian
---
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Star Zeng
di
On 2016/3/1 0:16, Ard Biesheuvel wrote:
When the DXE core is loaded, it invokes the PeCoffExtraActionLib library
function 'PeCoffLoaderRelocateImageExtraAction' explicitly, which may be
in addition to the same function having been called by the DxeIpl PE/COFF
loader instance.
The ImageContext th
Samer,
Was your code not asserted at below if BDS ARCH PROTOCOL not installed?
//
// Assert if the Architectural Protocols are not present.
//
Status = CoreAllEfiServicesAvailable ();
if (EFI_ERROR(Status)) {
//
// Report Status code that some Architectural Protocols are not
p
ks,
--Samer
-----Original Message-
From: Zeng, Star [mailto:star.z...@intel.com]
Sent: Thursday, March 3, 2016 8:25 PM
To: El-Haj-Mahmoud, Samer ;
edk2-devel@lists.01.org
Cc: El-Haj-Mahmoud, Samer ; feng.t...@intel.com
Subject: Re: [edk2] [PATCH] MdeModulePkg: Add DEBUG and ASSERT on failed BDS
Cinnamon,
Since you have updated code to replace gBS->LocateHandle with
gBS->LocateHandleBuffer at previous commits. How about to update the
"gBS->LocateHandle" to "gBS->LocateHandleBuffer" in the new added
comments for this patch series?
Other parts of this patch series are good to me.
Th
Series: Reviewed-by: Star Zeng
On 2016/3/7 11:23, Cinnamon Shia wrote:
Support UEFI shell execution break.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cinnamon Shia
---
PerformancePkg/Dp_App/Dp.c | 36 --
PerformancePkg/Dp_App/DpIntern
Cinnamon,
Some comments below.
On 2016/3/8 3:38, Cinnamon Shia wrote:
The maximum number of PEI performance log entries is 255.
Add a new PCD, PcdMaxPeiPerformanceLogEntries16, to increase the maximum
number of PEI performance log entries.
Contributed-under: TianoCore Contribution Agreement 1.
Reviewed-by: Star Zeng
On 2016/3/8 14:00, Cinnamon Shia wrote:
The maximum number of PEI performance log entries is 255.
Add a new PCD, PcdMaxPeiPerformanceLogEntries16, to increase the maximum
number of PEI performance log entries.
Contributed-under: TianoCore Contribution Agreement 1.0
Signe
Series committed at 3e9de670ec3f18d0211a72d28fedb5dfce93442a and
196ccda08fc481dae4fc97db8f2938df87801edb.
On 2016/3/7 15:09, Zeng, Star wrote:
Series: Reviewed-by: Star Zeng
On 2016/3/7 11:23, Cinnamon Shia wrote:
Support UEFI shell execution break.
Contributed-under: TianoCore
patch committed at 7c50b3434377cbb49ce4514ee31339000a5cadc0.
On 2016/3/8 14:32, Zeng, Star wrote:
Reviewed-by: Star Zeng
On 2016/3/8 14:00, Cinnamon Shia wrote:
The maximum number of PEI performance log entries is 255.
Add a new PCD, PcdMaxPeiPerformanceLogEntries16, to increase the maximum
:22 AM
To: Zeng, Star ; edk2-devel-01
Cc: Dong, Eric ; Yao, Jiewen
Subject: Re: [PATCH] MdeModulePkg/Variable/RuntimeDxe: delete & lock MOR in the
absence of SMM
On 10/10/17 15:54, Zeng, Star wrote:
> Could you help make the code consistent to call
> VariableServiceSetVariable
Reviewed-by: Star Zeng
-Original Message-
From: Yao, Jiewen
Sent: Friday, October 20, 2017 5:07 PM
To: edk2-devel@lists.01.org; Zeng, Star
Subject: Re: [edk2] [PATCH] IntelSiliconPkg/VtdInfoSample: Fix IGD RMRR memory.
Correct email address
thank you!
Yao, Jiewen
> 在 2017年10月20日
rom: Ni, Ruiyu
Sent: Thursday, October 19, 2017 11:03 AM
To: Laszlo Ersek ; Julien Grall ;
Zeng, Star ; Dong, Eric ;
pankaj.ban...@nxp.com; leif.lindh...@linaro.org
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH] MdeModulePkg/SerialDxe: Do not fail reset when
SetAttributes is not suppor
//
// Attempt to use content from SMRAM first
//
GuidHob = GetFirstGuidHob (&gEfiAcpiVariableGuid);
if (GuidHob != NULL) {
The code may could use this condition above to skip SignalEndOfS3Resume().
We can see two places already in S3Resume.c.
Thanks,
Star
-Original Message-
Fro
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Tuesday, October 24, 2017 11:38 PM
To: edk2-devel-01
Cc: Yao, Jiewen ; Dong, Eric ; Zeng,
Star
Subject: [edk2] [PATCH v2] MdeModulePkg/Variable
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen
Yao
Sent: Thursday, October 26, 2017 10:14 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [edk2] [PATCH] IntelSiliconPkg/VTdDxe: return unsupported for
Some device driver may also have exit boot service event at CALLBACK, for
example AtaPassThruExitBootServices() that was added by Laszlo.
Thanks,
Star
-Original Message-
From: Yao, Jiewen
Sent: Thursday, October 26, 2017 10:14 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject
901 - 1000 of 1395 matches
Mail list logo
