[edk2] EDKII_WRITE FUNCTION TO A FILE DOES NOT WORK(for me)

2014-08-27 Thread Gabor Puha
All, I am developing an efi loader and having problem to write an allocated mem or text to a file on efi partition. I can create and del but I am not able to write a file. I have checked all doc but example with declaration was not found. Please, help with an example(or correct my one)...regards G

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Sergey Isakov
Is it possible to include new family? --- Ia32/Thunk16.s| CLANG Ia32/Thunk16.nasm | GCC --- On 28.08.2014, at 8:27, Andrew Fish wrote: > > On Aug 27, 2014, at 8:51 PM, Jordan Justen wrote: > >> On Wed, Aug 27, 2014 at 8:43 PM, Sergey Isakov wrote: >>> Jordan, >>> There was

Re: [edk2] [Patch]ShellPkg: Remove 'STATIC' from function declarations to avoid source level debugging problem

2014-08-27 Thread Andrew Fish
On Aug 27, 2014, at 9:35 PM, Scott Duplichan wrote: > A couple of more points on this unusual policy of avoiding static functions: > > 1) Wouldn't it make more sense for the debugger vendor to fix their bug > rather than endlessly code around it? > 2) If static functions are not banned, then

[edk2] Bitwise OR operator problems

2014-08-27 Thread Tim Lewis
It appears that this should prevent the display of the text statement. However, to my surprise, it works on NT32. Per operator precedence, it should be 8|8 is 8, and 8 == 8 is TRUE. suppressif 8|8 == 0x8; text help = STRING_TOKEN(STR_BITWISE_OR_HELP),

Re: [edk2] Endless Loop when DEBUG_POOL used with ReportStatusCode version of DebugLib

2014-08-27 Thread Tim Lewis
Mike - Using a non-RSC version of debug lib isn't an option for these customers. Is it possible to handle the allocation outside of the RSC call itself? And get notification if a new handler is installed to update Tim From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Thursday, Aug

Re: [edk2] [Patch]ShellPkg: Remove 'STATIC' from function declarations to avoid source level debugging problem

2014-08-27 Thread Scott Duplichan
A couple of more points on this unusual policy of avoiding static functions: 1) Wouldn't it make more sense for the debugger vendor to fix their bug rather than endlessly code around it? 2) If static functions are not banned, then why are they getting removed? I view it as an unsound engi

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Andrew Fish
On Aug 27, 2014, at 8:51 PM, Jordan Justen wrote: > On Wed, Aug 27, 2014 at 8:43 PM, Sergey Isakov wrote: >> Jordan, >> There was no issue with gcc49 toolchain in x86_64. >> I made an attempt to use nasm with XCLANG toolset but failed on ld: >> I seems have to wait while Andrew make XCODE5 full

Re: [edk2] Endless Loop when DEBUG_POOL used with ReportStatusCode version of DebugLib

2014-08-27 Thread Kinney, Michael D
Tim, Yes. This issue has been around a while. The workaround when you want to monitor every single pool operation in the DXE Core is to use a DebugLib instance that sends debug messages directly to a debug device such as MdePkg/Library/BaseDebugLibSerialPort. The issue with using a DebugLib in

[edk2] Endless Loop when DEBUG_POOL used with ReportStatusCode version of DebugLib

2014-08-27 Thread Tim Lewis
Symptom: If "DEBUG_POOL" bit is set in PcdDebugPrintErrorLevel, BIOS will enter recursive loop. (A call B, B call C, C call A, ) Description: This happens when the PeiDxeDebugLibReportStatusCode.inf version of DebugLib is used. We found it can be duplicated with revision 15913, although it ap

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Andrew Fish
On Aug 27, 2014, at 8:43 PM, Sergey Isakov wrote: > Jordan, > There was no issue with gcc49 toolchain in x86_64. > I made an attempt to use nasm with XCLANG toolset but failed on ld: > I seems have to wait while Andrew make XCODE5 fully working. __USER_LABEL_PREFIX__ is set to _ on clang (XCOD

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Jordan Justen
On Wed, Aug 27, 2014 at 8:43 PM, Sergey Isakov wrote: > Jordan, > There was no issue with gcc49 toolchain in x86_64. > I made an attempt to use nasm with XCLANG toolset but failed on ld: > I seems have to wait while Andrew make XCODE5 fully working. Since this change will affect all toolchains ex

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Sergey Isakov
Jordan, There was no issue with gcc49 toolchain in x86_64. I made an attempt to use nasm with XCLANG toolset but failed on ld: I seems have to wait while Andrew make XCODE5 fully working. Sergey On 28 авг. 2014 г., at 7:32, Andrew Fish wrote: > > On Aug 27, 2014, at 8:08 PM, Gao, Liming wrote:

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Andrew Fish
On Aug 27, 2014, at 8:08 PM, Gao, Liming wrote: > Hi, > What change do you make? In previous mail, you mention x86_64 there is no > issue. > Liming, On the various GNU (including clang) toolchains __USER_LABEL_PREFIX__ is the prefix applied to user labels (symbols visible to C) in assemb

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Jordan Justen
On Wed, Aug 27, 2014 at 8:08 PM, Gao, Liming wrote: > Hi, > > What change do you make? In previous mail, you mention x86_64 there is no > issue. Sergey, also, which toolchain are you looking at? -Jordan > From: Sergey Isakov [mailto:isakov...@bk.ru] > Sent: Thursday, August 28, 2014 4:42 AM >

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Gao, Liming
Hi, What change do you make? In previous mail, you mention x86_64 there is no issue. Thanks Liming From: Sergey Isakov [mailto:isakov...@bk.ru] Sent: Thursday, August 28, 2014 4:42 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for

Re: [edk2] [EmulatorPkg][PATCH]EmulatorPkg:Host: Port emulator to Xcode5

2014-08-27 Thread Andrew Fish
On Aug 27, 2014, at 7:42 PM, Jordan Justen wrote: > It appeared to build fine with gcc 4.9 and gcc 4.4. > Thanks for testing. Andrew Fish > -Jordan > > On Wed, Aug 27, 2014 at 5:53 PM, Andrew Fish wrote: >> Jordan, >> >> Could you make this change and make sure the BaseTools still compile

Re: [edk2] Bug in EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_STRUCTURE

2014-08-27 Thread Yao, Jiewen
Thank, Star. This patch looks good to me. Reviewed by: Jiewen Yao From: Zeng, Star [mailto:star.z...@intel.com] Sent: Wednesday, August 27, 2014 8:29 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] Bug in EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_STRUCTURE Hi Alexei, Thanks for your f

Re: [edk2] [EmulatorPkg][PATCH]EmulatorPkg:Host: Port emulator to Xcode5

2014-08-27 Thread Jordan Justen
It appeared to build fine with gcc 4.9 and gcc 4.4. -Jordan On Wed, Aug 27, 2014 at 5:53 PM, Andrew Fish wrote: > Jordan, > > Could you make this change and make sure the BaseTools still compile with > GCC49? I want to figure out if we can share the flags, or if I need to add > and if? > > cd Ba

[edk2] [Patch]ShellPkg: Remove 'STATIC' from function declarations to avoid source level debugging problem

2014-08-27 Thread Qiu, Shumin
Hi Jaben, Can you help to review this patch? Internal linkage (ie. STATIC) functions have caused problems with source level debugging before, so we generally avoid STATIC in ShellPkg. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin mailto:shumin@intel.com>>

Re: [edk2] ShellPkg: shell can't recognize 'ren' command

2014-08-27 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey From: Bjorge, Erik C Sent: Monday, August 25, 2014 2:44 PM To: Shah, Tapan; Carsey, Jaben; edk2-devel@lists.sourceforge.net Subject: RE: ShellPkg: shell can't recognize 'ren' command Importance: High Reviewed-by: Erik Bjorge From: Shah, Tapan [mailto:tapands...@hp.co

Re: [edk2] [EmulatorPkg][PATCH]EmulatorPkg:Host: Port emulator to Xcode5

2014-08-27 Thread Andrew Fish
Jordan, I don’t seem to have commit access after the svn move. Can you commit these patches for me? I attempted to fix all the issues in your comments. Thanks, Andrew Fish On Aug 27, 2014, at 4:39 PM, Jordan Justen wrote: > 0001-EmulatorPkg-Unix-Add-support-for-X11-on-Mac-OS-X-via.patch > co

Re: [edk2] [EmulatorPkg][PATCH]EmulatorPkg:Host: Port emulator to Xcode5

2014-08-27 Thread Andrew Fish
Jordan, Could you make this change and make sure the BaseTools still compile with GCC49? I want to figure out if we can share the flags, or if I need to add and if? cd BaseTools make clean make Index: Source/C/Makefiles/header.makefile ==

Re: [edk2] [EmulatorPkg][PATCH]EmulatorPkg:Host: Port emulator to Xcode5

2014-08-27 Thread Jordan Justen
0001-EmulatorPkg-Unix-Add-support-for-X11-on-Mac-OS-X-via.patch commit message: * Line lengths are a bit long 0002-EmulatorPkg-Unix-Host-Add-LLDB-support-for-Xcode-5.patch commit message: * Missing Contributed-under/Signed-off-by * Line lengths are a bit long * hte => the * Do you expect the lldb

Re: [edk2] [PATCH v3 09/10] ArmPlatformPkg: add support for a QEMU/mach-virt target

2014-08-27 Thread Laszlo Ersek
On 08/27/14 17:12, Ard Biesheuvel wrote: > create mode 100644 ArmPlatformPkg/AArch64VirtualizationPkg/Driver/VirtFdt.inf > create mode 100644 > ArmPlatformPkg/AArch64VirtualizationPkg/Driver/VirtFdtDxe.c sorry, forgot to say: please rename the Driver pathname component (the directory name) to

Re: [edk2] [PATCH v3 09/10] ArmPlatformPkg: add support for a QEMU/mach-virt target

2014-08-27 Thread Laszlo Ersek
Some comments below On 08/27/14 17:12, Ard Biesheuvel wrote: > This adds support for executing UEFI in a QEMU/mach-virt emulated environment. > The following assumptions are made about the target: > - ARM architected timer > - PL011 UART at 0x900 > - at least 1 MB of DRAM at 0x4000, contai

Re: [edk2] [EmulatorPkg][PATCH]EmulatorPkg:Host: Port emulator to Xcode5

2014-08-27 Thread Andrew Fish
Jordan,Here is the updated patch set for the emulator. Please review.Thanks,Andrew Fish 0001-EmulatorPkg-Unix-Add-support-for-X11-on-Mac-OS-X-via.patch Description: Binary data 0002-EmulatorPkg-Unix-Host-Add-LLDB-support-for-Xcode-5.patch Description: Binary data 0004-BaseTools-Add-support-

[edk2] [PATCH] ShellPkg: SmbiosView updates

2014-08-27 Thread El-Haj-Mahmoud, Samer
Jaben, Can you please review this and submit it? Update SmbiosView Shell command to display additional CPU Family and Socket designations, and fix a couple of typos Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud el...@hp.com

[edk2] [PATCH] MdeModulePkg , NetworkPkg: Speed up network stack : check for IPsec only once

2014-08-27 Thread El-Haj-Mahmoud, Samer
Dear MdeModulePkg and NetworkPkg maintainers, Please find the attached patch that speeds up network stack by removing unnecessary IPSEC protocol locate in the main IPv4 and IPv6 packet processing paths. Do not try to locate gEfiIpSec2ProtocolGuid on every IPv4 datagram TX/RX. The locate proto

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Sergey Isakov
The error disappeared but I still have other mistakes ld: illegal text-relocation to '_NullSeg' in … BaseLib.lib(Thunk16.obj) from '_16GdtrBase’ in … BaseLib.lib(Thunk16.obj) for architecture x86_64 Still in work On 28 авг. 2014 г., at 0:33, Jordan Justen wrote: > On Wed, Aug 27, 2014 at 1:08

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Andrew Fish
On Aug 27, 2014, at 1:33 PM, Jordan Justen wrote: > On Wed, Aug 27, 2014 at 1:08 PM, Sergey Isakov wrote: >> And one new question. Why _16GdtrBase with underscore while m16Start without >> it? > > Does replacing m16Start with ASM_PFX(m16Start) help? > > It looks like I didn't convert this up

Re: [edk2] [PATCH] MdeModulePkg: Add HiiCreateGuidLabelOpCode to HiiLib

2014-08-27 Thread El-Haj-Mahmoud, Samer
Any objection to adding this to IntelFrameworkModulePkg? From: El-Haj-Mahmoud, Samer Sent: Monday, August 25, 2014 8:57 PM To: edk2-devel@lists.sourceforge.net Subject: RE: [edk2] [PATCH] MdeModulePkg: Add HiiCreateGuidLabelOpCode to HiiLib Fair enough. How about an HiiExLib library in IntelFram

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Jordan Justen
On Wed, Aug 27, 2014 at 1:08 PM, Sergey Isakov wrote: > And one new question. Why _16GdtrBase with underscore while m16Start without > it? Does replacing m16Start with ASM_PFX(m16Start) help? It looks like I didn't convert this up properly. The MASM code didn't use ASM_PFX... -Jordan > —— > ;

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Andrew Fish
On Aug 27, 2014, at 1:08 PM, Sergey Isakov wrote: > And one new question. Why _16GdtrBase with underscore while m16Start without > it? > —— > ; > ; These are global constant to convey information to C code. > ; > ASM_PFX(m16Size) DW InternalAsmThunk16 - m16Start > ASM_PFX(mThunk16A

Re: [edk2] [PATCH v3 10/10] AArch64-KVM: add support for non-volatile variable store

2014-08-27 Thread Laszlo Ersek
some comments below On 08/27/14 17:12, Ard Biesheuvel wrote: > This adds support for retaining UEFI environment variables in the second > emulated NOR flash which resides at phys address 0x0400 (64 MB). > > Note that this requires booting QEMU with two -pflash arguments, each of which > point

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Sergey Isakov
And one new question. Why _16GdtrBase with underscore while m16Start without it? —— ; ; These are global constant to convey information to C code. ; ASM_PFX(m16Size) DW InternalAsmThunk16 - m16Start ASM_PFX(mThunk16Attr)DW _BackFromUserCode.ThunkAttrEnd - 4 - m16Start ASM_PFX(

Re: [edk2] [PATCH v3 08/10] ArmPlatformPkg: separate PlatformPei and PlatformPeiLib

2014-08-27 Thread Laszlo Ersek
On 08/27/14 17:12, Ard Biesheuvel wrote: > This separates PlatformPei and PlatformPeiLib so the latter can be > overridden by a specific platform. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > ArmPlatformPkg/PlatformPei/PlatformPeim.inf | 2 +

Re: [edk2] [PATCH v3 07/10] ArmPkg: introduce PCD gArmTokenSpaceGuid.PcdDeviceTreeBaseAddress

2014-08-27 Thread Laszlo Ersek
On 08/27/14 17:12, Ard Biesheuvel wrote: > Introduce gArmTokenSpaceGuid.PcdDeviceTreeBaseAddress, which will be used by > virtual machine ports that discover the system configuration from a flattened > device tree DTB image. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-

Re: [edk2] [PATCH v3 09/10] ArmPlatformPkg: add support for a QEMU/mach-virt target

2014-08-27 Thread Laszlo Ersek
On 08/27/14 21:02, Ard Biesheuvel wrote: > On 27 August 2014 20:17, Peter Maydell wrote: >> On 27 August 2014 19:15, Olivier Martin wrote: >>> I have been through the patchset yet. But I noticed the name of the platform >>> in another email. >>> Is this new platform AArch64 specific? Could we ima

Re: [edk2] [PATCH v3 06/10] ArmPkg, ArmPlatformPkg: allow dynamic PCDs for memory base and size

2014-08-27 Thread Laszlo Ersek
On 08/27/14 17:12, Ard Biesheuvel wrote: > This changes the definition and a bunch of references to > gArmTokenSpaceGuid.PcdSystemMemoryBase and > gArmTokenSpaceGuid.PcdSystemMemorySize so they can be declared as dynamic PCDs > by the platform. Also, move the non-SEC call to > ArmPlatformInitialize

Re: [edk2] [PATCH v3 03/10] ArmPkg: allow dynamic GIC base addresses

2014-08-27 Thread Laszlo Ersek
On 08/27/14 17:12, Ard Biesheuvel wrote: > Allow the PCDs gArmTokenSpaceGuid.PcdGicDistributorBase and > gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase to be redeclared > as PcdsDynamic by the platform, so virtual machines can set these > properties during boot. As the PcdGet32() calls now call in

Re: [edk2] [PATCH v3 09/10] ArmPlatformPkg: add support for a QEMU/mach-virt target

2014-08-27 Thread Ard Biesheuvel
On 27 August 2014 20:17, Peter Maydell wrote: > On 27 August 2014 19:15, Olivier Martin wrote: >> I have been through the patchset yet. But I noticed the name of the platform >> in another email. >> Is this new platform AArch64 specific? Could we imagine this platform being >> easily ported to AR

Re: [edk2] [PATCH v2 8/8] AArch64-KVM: add support for non-volatile variable store

2014-08-27 Thread Laszlo Ersek
On 08/27/14 20:09, Peter Maydell wrote: > On 27 August 2014 17:58, Ard Biesheuvel wrote: >> On 27 August 2014 18:03, Laszlo Ersek wrote: >>> - Why require a 64MB flash drive, if we only use 768 KB of it? >>> >> >> The ARM Versatile Express development hardware is set up like this, >> that is the

Re: [edk2] [PATCH v3 09/10] ArmPlatformPkg: add support for a QEMU/mach-virt target

2014-08-27 Thread Olivier Martin
I have been through the patchset yet. But I noticed the name of the platform in another email. Is this new platform AArch64 specific? Could we imagine this platform being easily ported to ARMv7 (with Virtualization extension)? If yes, we should maybe rename it 'ArmVirtualizationPkg' to avoid to dup

Re: [edk2] [PATCH v3 09/10] ArmPlatformPkg: add support for a QEMU/mach-virt target

2014-08-27 Thread Peter Maydell
On 27 August 2014 19:15, Olivier Martin wrote: > I have been through the patchset yet. But I noticed the name of the platform > in another email. > Is this new platform AArch64 specific? Could we imagine this platform being > easily ported to ARMv7 (with Virtualization extension)? No, it's not 64

Re: [edk2] [PATCH v2 8/8] AArch64-KVM: add support for non-volatile variable store

2014-08-27 Thread Peter Maydell
On 27 August 2014 17:58, Ard Biesheuvel wrote: > On 27 August 2014 18:03, Laszlo Ersek wrote: >> I'll mention in passing that >> "MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf" is >> good for a non-authenticated variable store only, ie. no secure boot >> support. For secure bo

Re: [edk2] [PATCH v2 8/8] AArch64-KVM: add support for non-volatile variable store

2014-08-27 Thread Peter Maydell
On 27 August 2014 17:58, Ard Biesheuvel wrote: > On 27 August 2014 18:03, Laszlo Ersek wrote: >> - Why require a 64MB flash drive, if we only use 768 KB of it? >> > > The ARM Versatile Express development hardware is set up like this, > that is the whole and only reason. > I guess we could change

Re: [edk2] [PATCH v2 8/8] AArch64-KVM: add support for non-volatile variable store

2014-08-27 Thread Laszlo Ersek
On 08/27/14 18:58, Ard Biesheuvel wrote: > The ARM Versatile Express development hardware is set up like this, > that is the whole and only reason. > I guess we could change it if there is a strong reason to do so, but > parity with the other emulated machines makes the maintenance job a > bit eas

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Jordan Justen
On Wed, Aug 27, 2014 at 5:18 AM, Sergey Isakov wrote: > Hi sirs, > I tested Thunk16.nasm too. For x86_64 there is no issue. > For ia32 compilation disasm shows not good codes > - > : >0: 00 00 add%al,(%eax) >2: 00 00 add%al,(%eax) >

Re: [edk2] [EmulatorPkg][PATCH]EmulatorPkg:Host: Port emulator to Xcode5

2014-08-27 Thread Jordan Justen
On Wed, Aug 27, 2014 at 9:50 AM, Andrew Fish wrote: > > On Aug 26, 2014, at 11:17 PM, Jordan Justen wrote: > > On Tue, Aug 26, 2014 at 9:34 PM, Andrew Fish wrote: > > EmulatorPkg:Host: Port emulator to Xcode5 > > Xcode5 retired gdb, so this patch adds support for using, and loading > symbols in,

Re: [edk2] [PATCH v2 8/8] AArch64-KVM: add support for non-volatile variable store

2014-08-27 Thread Ard Biesheuvel
On 27 August 2014 18:03, Laszlo Ersek wrote: > some comments > > On 08/26/14 15:03, Ard Biesheuvel wrote: >> This adds support for retaining UEFI environment variables in the second >> emulated NOR flash which resides at phys address 0x0400 (64 MB). >> >> Note that this requires booting QEMU w

Re: [edk2] BuildMemoryAllocationHob() vs. gEfiPeiMemoryDiscoveredPpiGuid

2014-08-27 Thread Andrew Fish
On Aug 27, 2014, at 2:07 AM, Laszlo Ersek wrote: > Hi All, > > based on Chapter 11, PEI Physical Memory Usage, in the PI spec, I think > that any PEIM that wants to call BuildMemoryAllocationHob() must make > sure that it runs on permanent PEI RAM. > > In other words, it seems like BuildMemory

Re: [edk2] [EmulatorPkg][PATCH]EmulatorPkg:Host: Port emulator to Xcode5

2014-08-27 Thread Andrew Fish
On Aug 26, 2014, at 11:17 PM, Jordan Justen wrote: > On Tue, Aug 26, 2014 at 9:34 PM, Andrew Fish wrote: >> EmulatorPkg:Host: Port emulator to Xcode5 >> >> Xcode5 retired gdb, so this patch adds support for using, and loading >> symbols in, lldb. > > Cool, but I don't think the subject is ri

Re: [edk2] [Patch 2/2] [MdePkg] INF/DEC file updates to EDK II packages

2014-08-27 Thread Jordan Justen
On Tue, Aug 26, 2014 at 10:38 PM, Gao, Liming wrote: > Jordan: > After UPT clean up, those files can still edit easily. UPT tool just > changes section Order and Alignment. The source package can > still directly be compared. So, daily work is no change. No, they cannot be directly compared. Ju

Re: [edk2] [PATCH 4/4] OvmfPkg: AcpiPlatformDxe: implement QEMU's full ACPI table loader interface

2014-08-27 Thread Laszlo Ersek
On 08/27/14 11:47, Paolo Bonzini wrote: > Il 26/08/2014 18:49, Laszlo Ersek ha scritto: >> The problem is that a number of tables are not linked into the RSDT, >> they are referenced by other tables. Basically, all the pointer fields >> in all tables that are updated (relocated / absolutized) by Ad

Re: [edk2] [PATCH v2 8/8] AArch64-KVM: add support for non-volatile variable store

2014-08-27 Thread Laszlo Ersek
some comments On 08/26/14 15:03, Ard Biesheuvel wrote: > This adds support for retaining UEFI environment variables in the second > emulated NOR flash which resides at phys address 0x0400 (64 MB). > > Note that this requires booting QEMU with two -pflash arguments, each of which > points to a

Re: [edk2] [Patch RFC] Fix formatting of four more c-based tool's --version option

2014-08-27 Thread Gao, Liming
Larry: The patch is good. Reviewed-by: Gao, Liming From: Hauch, Larry Sent: Wednesday, August 27, 2014 4:44 AM To: edk2-devel@lists.sourceforge.net; Gao, Liming Subject: [Patch RFC] Fix formatting of four more c-based tool's --version option Liming, Please review the attached patch. Updated G

Re: [edk2] Bug in EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_STRUCTURE

2014-08-27 Thread Zeng, Star
Hi Alexei, Thanks for your finding, attach the patch for your review. MdePkg Acpi51.h: Correct the declaration of EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_STRUCTURE. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng mailto:star.z...@intel.com>> Thanks, Star From

[edk2] [PATCH v3 10/10] AArch64-KVM: add support for non-volatile variable store

2014-08-27 Thread Ard Biesheuvel
This adds support for retaining UEFI environment variables in the second emulated NOR flash which resides at phys address 0x0400 (64 MB). Note that this requires booting QEMU with two -pflash arguments, each of which points to a NOR image file of exactly 64 MB in size. The second one will be u

[edk2] [PATCH v3 09/10] ArmPlatformPkg: add support for a QEMU/mach-virt target

2014-08-27 Thread Ard Biesheuvel
This adds support for executing UEFI in a QEMU/mach-virt emulated environment. The following assumptions are made about the target: - ARM architected timer - PL011 UART at 0x900 - at least 1 MB of DRAM at 0x4000, containing the device tree blob The following information is retrieved from t

[edk2] [PATCH v3 08/10] ArmPlatformPkg: separate PlatformPei and PlatformPeiLib

2014-08-27 Thread Ard Biesheuvel
This separates PlatformPei and PlatformPeiLib so the latter can be overridden by a specific platform. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/PlatformPei/PlatformPeim.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[edk2] [PATCH v3 06/10] ArmPkg, ArmPlatformPkg: allow dynamic PCDs for memory base and size

2014-08-27 Thread Ard Biesheuvel
This changes the definition and a bunch of references to gArmTokenSpaceGuid.PcdSystemMemoryBase and gArmTokenSpaceGuid.PcdSystemMemorySize so they can be declared as dynamic PCDs by the platform. Also, move the non-SEC call to ArmPlatformInitializeSystemMemory() earlier, so a platform has a chance

[edk2] [PATCH v3 04/10] ArmPlatformPkg/PrePeiCore: remove GIC related PCDs from unicore

2014-08-27 Thread Ard Biesheuvel
Remove the PCDs gArmTokenSpaceGuid.PcdGicDistributorBase and gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase from PrePeiCoreUniCore.inf, as they are not in fact used by the module. Contributed-under: TianoCore Contribution Agreement 1.0 Acked-by: Laszlo Ersek Signed-off-by: Ard Biesheuvel --- A

[edk2] [PATCH v3 02/10] ArmPkg: allow dynamically discovered virtual timer interrupt

2014-08-27 Thread Ard Biesheuvel
To support booting on virtual machines whose interrupt routing is discovered from the device tree, allow the interrupt numbers to be redeclared as PcdsDynamic by the platform .dsc Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/ArmPkg.dec

[edk2] [PATCH v3 05/10] ArmPlatformPkg: allow dynamically discovered PL031 RTC

2014-08-27 Thread Ard Biesheuvel
Allow the PCDs gArmPlatformTokenSpaceGuid.PcdPL031RtcBase and gArmPlatformTokenSpaceGuid.PcdPL031RtcPpmAccuracy PCDs to be declared as PcdsDynamic by the platform so they can be overridden during boot. Contributed-under: TianoCore Contribution Agreement 1.0 Acked-by: Laszlo Ersek Signed-off-by: A

[edk2] [PATCH v3 00/10] add support for AArch64 QEMU/KVM

2014-08-27 Thread Ard Biesheuvel
This is v3 of the series that adds a platform config to support QEMU based virtual machines, either in TCG or KVM mode. These virtual machines declare their platform configuration by passing a device tree which needs to be parsed by Tianocore rather than relying on hardcoded peripherals. Currentl

[edk2] [PATCH v3 07/10] ArmPkg: introduce PCD gArmTokenSpaceGuid.PcdDeviceTreeBaseAddress

2014-08-27 Thread Ard Biesheuvel
Introduce gArmTokenSpaceGuid.PcdDeviceTreeBaseAddress, which will be used by virtual machine ports that discover the system configuration from a flattened device tree DTB image. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/ArmPkg.dec | 2 ++ 1

[edk2] [PATCH v3 03/10] ArmPkg: allow dynamic GIC base addresses

2014-08-27 Thread Ard Biesheuvel
Allow the PCDs gArmTokenSpaceGuid.PcdGicDistributorBase and gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase to be redeclared as PcdsDynamic by the platform, so virtual machines can set these properties during boot. As the PcdGet32() calls now call into the PCD database, cache the values that are re

[edk2] [PATCH v3 01/10] ArmPkg/TimerDxe: allow virtual timer to be selected

2014-08-27 Thread Ard Biesheuvel
From: Michael Casadevall For virtual machines, the physical architected timer may not be available, so we need to allow the virtual timer to be used instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Casadevall Acked-by: Laszlo Ersek Signed-off-by: Ard Bies

[edk2] Bug in EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_STRUCTURE

2014-08-27 Thread Alexei Fedorov
EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_STRUCTURE declaration in \edk2\MdePkg\Include\IndustryStandard\Acpi51.h has wrong field lengths: /// /// SBSA Generic Watchdog Structure /// typedef struct { UINT8 Type; UINT8 Length; UINT16 Reserved; ... This should be typedef str

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Sergey Isakov
Hi sirs, I tested Thunk16.nasm too. For x86_64 there is no issue. For ia32 compilation disasm shows not good codes - : 0: 00 00 add%al,(%eax) 2: 00 00 add%al,(%eax) ... 0006 <_BackFromUserCode>: 6: 16

Re: [edk2] [PATCH v2 6/8] ArmPkg, ArmPlatformPkg: allow dynamic PCDs for memory base and size

2014-08-27 Thread Ard Biesheuvel
On 27 August 2014 13:53, Laszlo Ersek wrote: > On 08/27/14 13:12, Ard Biesheuvel wrote: >> On 27 August 2014 12:36, Laszlo Ersek wrote: >>> On 08/27/14 11:35, Ard Biesheuvel wrote: On 27 August 2014 11:07, Laszlo Ersek wrote: > On 08/27/14 09:10, Ard Biesheuvel wrote: >> On 27 Augus

Re: [edk2] [PATCH v2 6/8] ArmPkg, ArmPlatformPkg: allow dynamic PCDs for memory base and size

2014-08-27 Thread Laszlo Ersek
On 08/27/14 13:12, Ard Biesheuvel wrote: > On 27 August 2014 12:36, Laszlo Ersek wrote: >> On 08/27/14 11:35, Ard Biesheuvel wrote: >>> On 27 August 2014 11:07, Laszlo Ersek wrote: On 08/27/14 09:10, Ard Biesheuvel wrote: > On 27 August 2014 00:24, Laszlo Ersek wrote: >> >> (b) Pred

Re: [edk2] [PATCH v2 7/8] ArmPlatformPkg: add support for a QEMU/mach-virt target

2014-08-27 Thread Laszlo Ersek
On 08/27/14 10:27, Ard Biesheuvel wrote: > On 27 August 2014 01:36, Laszlo Ersek wrote: >> On 08/26/14 15:03, Ard Biesheuvel wrote: >>> +#pragma pack (1) >>> +typedef struct { >>> + VENDOR_DEVICE_PATH Vendor; >>> + UINT32 Instance; >>> + EFI_DEVICE

Re: [edk2] [PATCH v2 6/8] ArmPkg, ArmPlatformPkg: allow dynamic PCDs for memory base and size

2014-08-27 Thread Ard Biesheuvel
On 27 August 2014 12:36, Laszlo Ersek wrote: > On 08/27/14 11:35, Ard Biesheuvel wrote: >> On 27 August 2014 11:07, Laszlo Ersek wrote: >>> On 08/27/14 09:10, Ard Biesheuvel wrote: On 27 August 2014 00:24, Laszlo Ersek wrote: > > (b) Predictably, my second question is about the second w

Re: [edk2] [PATCH 4/6] MdeModulePkg: IdeMode should not depend on SataController

2014-08-27 Thread Zeng, Star
DUET platform is a emulate platform that has chipset and platform specific initialization done before its boot. SataControllerDxe was introduced for it to support AHCI mode. Now OVMF is a virtual platform that wants to leverage the SataControllerDxe in DuetPkg. And sharing code is a good point i

Re: [edk2] [PATCH v2 6/8] ArmPkg, ArmPlatformPkg: allow dynamic PCDs for memory base and size

2014-08-27 Thread Laszlo Ersek
On 08/27/14 11:35, Ard Biesheuvel wrote: > On 27 August 2014 11:07, Laszlo Ersek wrote: >> On 08/27/14 09:10, Ard Biesheuvel wrote: >>> On 27 August 2014 00:24, Laszlo Ersek wrote: (b) Predictably, my second question is about the second world. The permanent PEI memory must be distinct

Re: [edk2] [PATCH 4/4] OvmfPkg: AcpiPlatformDxe: implement QEMU's full ACPI table loader interface

2014-08-27 Thread Paolo Bonzini
Il 26/08/2014 18:49, Laszlo Ersek ha scritto: > The problem is that a number of tables are not linked into the RSDT, > they are referenced by other tables. Basically, all the pointer fields > in all tables that are updated (relocated / absolutized) by AddPointer > commands, point *potentially* to f

Re: [edk2] [PATCH v2 6/8] ArmPkg, ArmPlatformPkg: allow dynamic PCDs for memory base and size

2014-08-27 Thread Ard Biesheuvel
On 27 August 2014 11:07, Laszlo Ersek wrote: > On 08/27/14 09:10, Ard Biesheuvel wrote: >> On 27 August 2014 00:24, Laszlo Ersek wrote: >>> On 08/26/14 15:03, Ard Biesheuvel wrote: This changes the definition and a bunch of references to gArmTokenSpaceGuid.PcdSystemMemoryBase and g

[edk2] BuildMemoryAllocationHob() vs. gEfiPeiMemoryDiscoveredPpiGuid

2014-08-27 Thread Laszlo Ersek
Hi All, based on Chapter 11, PEI Physical Memory Usage, in the PI spec, I think that any PEIM that wants to call BuildMemoryAllocationHob() must make sure that it runs on permanent PEI RAM. In other words, it seems like BuildMemoryAllocationHob() is restricted to PEI code that runs after permanen

Re: [edk2] [PATCH v2 6/8] ArmPkg, ArmPlatformPkg: allow dynamic PCDs for memory base and size

2014-08-27 Thread Laszlo Ersek
On 08/27/14 09:10, Ard Biesheuvel wrote: > On 27 August 2014 00:24, Laszlo Ersek wrote: >> On 08/26/14 15:03, Ard Biesheuvel wrote: >>> This changes the definition and a bunch of references to >>> gArmTokenSpaceGuid.PcdSystemMemoryBase and >>> gArmTokenSpaceGuid.PcdSystemMemorySize so they can be

Re: [edk2] [PATCH v2 7/8] ArmPlatformPkg: add support for a QEMU/mach-virt target

2014-08-27 Thread Ard Biesheuvel
On 27 August 2014 01:36, Laszlo Ersek wrote: > I'll skip the DSC, FDF and INF files; I assume those are customized > copies from existing platform files. I'll also skip the INF files for now. > > On 08/26/14 15:03, Ard Biesheuvel wrote: >> This adds support for executing UEFI in a QEMU/mach-virt e

Re: [edk2] [PATCH v2 6/8] ArmPkg, ArmPlatformPkg: allow dynamic PCDs for memory base and size

2014-08-27 Thread Ard Biesheuvel
On 27 August 2014 00:24, Laszlo Ersek wrote: > On 08/26/14 15:03, Ard Biesheuvel wrote: >> This changes the definition and a bunch of references to >> gArmTokenSpaceGuid.PcdSystemMemoryBase and >> gArmTokenSpaceGuid.PcdSystemMemorySize so they can be declared as dynamic >> PCDs >> by the platform