Re: [edk2] Please Help: `_PCD_GET_MODE_16_PcdOvmfHostBridgePciDevId' undeclared

Somlo: Your patch shows four AcpiTimerLib instances: AcpiTimerLib.inf, BaseAcpiTimerLib.inf, BaseRomAcpiTimerLib.inf and DxeAcpiTimerLib.inf. I find BaseAcpiTimerLib.inf includes DxeAcpiTimerLib.c that uses PCD. But it doesn't add gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId in its IN

Re: [edk2] [PATCH 0/7] OvmfPkg: PlatformBdsLib cleanups and improvements

This timeout value is used to wait for user input, if we set this value to 0, it means we will not wait for the user input and directly boot the first boot option. Actually I don't clear what's the request now? Boot as fast as possible and also need get possible user input? Thanks, Eric -

Re: [edk2] Firmware Volume Block Protocol

Hi Guys, So, the eMMC flash is not formatted. I would like to be able to read/write to offsets in the flash device. I added the controller device path and this is what 'dh' command generates on UEFI shell. Shell> dh -v 70 70: 7F335D18 DevicePath PciRoot(0x0)/Pci(0x1,0x0)/Pci(0x1,0x4)/Ctrl(0x0) Un

Re: [edk2] Firmware Volume Block Protocol

> On Oct 22, 2014, at 6:07 PM, Tian, Hot wrote: > > Can we use this? > > 9.3.6.7 PIWG Firmware Volume This type is used by systems implementing the > UEFI PI Specification to describe a firmware volume. The exact format and > usage are defined in that specification. > I thought eMMC cards we

Re: [edk2] Firmware Volume Block Protocol

Can we use this? 9.3.6.7 PIWG Firmware Volume This type is used by systems implementing the UEFI PI Specification to describe a firmware volume. The exact format and usage are defined in that specification. From: Igor Sharovar [mailto:igor.sharo...@gmail.com] Sent: Thursday, October 23, 2014 12

Re: [edk2] [PATCH v3 0/5] enable SataController in OVMF

On 2014-10-22 16:01:29, wrote: > From: Reza Jelveh > > The SataController is copied to OvmfPkg where the IdeController > resides and enabled for OvmfPkg In http://permalink.gmane.org/gmane.comp.bios.tianocore.devel/10187 you wrote: "The PcAtChipsetPkg/DuetPkg remains untouched. The copy of Sata

[edk2] [PATCH v3 1/5] OvmfPkg: copy SataControllerDxe to OvmfPkg

From: Reza Jelveh SataController is copied to OvmfPkg for use in other packages. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Reza Jelveh --- OvmfPkg/SataControllerDxe/ComponentName.c | 176 OvmfPkg/SataControllerDxe/SataController.c | 1007 ++

[edk2] [PATCH v3 3/5] OvmfPkg: read host capabilities on ChannelInfo

From: Reza Jelveh SataController reads host capabalities when the module is first loaded. SataControllerStart is called before AhciMode.c resets the bus and enables AE. If SataControllerStart would do this itself, it would break AhciMode. The Initialize method should only install the protocol.

[edk2] [PATCH v3 5/5] MdeModulePkg; IdeMode select master/slave before diagnostics command

From: Reza Jelveh Some Ide controllers only update ID fields such as sector information on specific commands such as the DIAG command. The master/slave device is therefore selected before sending the DIAG command otherwise reading the IDE registers yields the masters ID fields. Contributed-unde

[edk2] [PATCH v3 0/5] enable SataController in OVMF

From: Reza Jelveh The SataController is copied to OvmfPkg where the IdeController resides and enabled for OvmfPkg Because SataController needs AE to be enabled before reading Ahci registers, GetChannelInfo is used to accomodate for initializations after AhciMode initialization. IdeMode of AtaAt

[edk2] [PATCH v3 4/5] MdeModulePkg: AhciMode calls GetChannelInfo when enumerating

From: Reza Jelveh Calling GetChannelInfo allows the Controller to initialize things that depend on previous Ahci mode initialization. Outside of DuetPkg AE needs to be enabled before accessing AHCI registers. AhciModeInitialization is called after the IdeControllerInitProtocol is initialized. G

[edk2] [PATCH v3 2/5] OvmfPkg: enable SATA controller

From: Reza Jelveh Removed: - IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBusDxe.inf (provides gEfiDiskInfoProtocolGuid, gEfiBlockIoProtocolGuid) - PcAtChipsetPkg/Bus/Pci/IdeControllerDxe/IdeControllerDxe.inf (provides gEfiIdeControllerInitProtocolGuid) Added: - MdeModulePkg/Bus/Ata/AtaBusDxe/At

Re: [edk2] [PATCH 0/7] OvmfPkg: PlatformBdsLib cleanups and improvements

On 10/22/2014 09:17 PM, Laszlo Ersek wrote: > Sigh. If I set PcdPlatformBootTimeOut to 0, then the progress bar is not > shown, but a user keypress is also not picked up. > > Therefore the minimum I could set is 1 second, which would increase the > boot time by 0.7 seconds. Let me know how you w

Re: [edk2] Please Help: `_PCD_GET_MODE_16_PcdOvmfHostBridgePciDevId' undeclared

> On Oct 22, 2014, at 12:07 PM, Gabriel Somlo wrote: > > On Wed, Oct 22, 2014, Andrew Fish mailto:af...@apple.com>> > wrote: > >>> After doing this, things build just fine. But after further adding: >>> >>> >>> OvmfPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf: >>> [Pcd] >>> gUefiOvmfPkgToke

Re: [edk2] Please Help: `_PCD_GET_MODE_16_PcdOvmfHostBridgePciDevId' undeclared

On Wed, Oct 22, 2014 at 08:30:00PM +0200, Laszlo Ersek wrote: > On 10/22/14 20:09, Gabriel Somlo wrote: > > On Wed, Oct 22, 2014 at 07:42:21PM +0200, Laszlo Ersek wrote: > >> On 10/22/14 18:24, Gabriel Somlo wrote: > > >>> I now get this error: > >>> /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include

Re: [edk2] Print(L"0x%.16x", Value) not working as expected

On 10/17/2014 5:04 AM, Nikolai Saoukh wrote: > IMHO, correct usage is > > Print (L"0x%.16lx", Value); // lower case L Using an upper-case 'L' might be better to avoid potential confusion with the number '1'. -- Bruce

Re: [edk2] [PATCH 0/7] OvmfPkg: PlatformBdsLib cleanups and improvements

On Wed, Oct 22, 2014 at 12:17 PM, Laszlo Ersek wrote: > On 10/22/14 21:02, Laszlo Ersek wrote: >> On 10/22/14 20:47, Jordan Justen wrote: >>> On Wed, Oct 22, 2014 at 11:28 AM, Laszlo Ersek wrote: On 10/22/14 20:05, Jordan Justen wrote: > Laszlo, > > Seabios starts to boot the OS

Re: [edk2] [PATCH 0/7] OvmfPkg: PlatformBdsLib cleanups and improvements

On 10/22/14 21:02, Laszlo Ersek wrote: > On 10/22/14 20:47, Jordan Justen wrote: >> On Wed, Oct 22, 2014 at 11:28 AM, Laszlo Ersek wrote: >>> On 10/22/14 20:05, Jordan Justen wrote: Laszlo, Seabios starts to boot the OS nearly instantaneously. OVMF takes several seconds. >

Re: [edk2] Please Help: `_PCD_GET_MODE_16_PcdOvmfHostBridgePciDevId' undeclared

On Wed, Oct 22, 2014, Andrew Fish wrote: > > After doing this, things build just fine. But after further adding: > > > > > > OvmfPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf: > > [Pcd] > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId > > > > > > OvmfPkg/Library/AcpiTimerLib/DxeAcpiT

Re: [edk2] [PATCH 5/7] OvmfPkg LoadLinuxLib: Convert X64/JumpToKernel.asm to NASM

On Wed, Oct 22, 2014 at 11:51 AM, Laszlo Ersek wrote: > On 10/18/14 20:25, Jordan Justen wrote: >> The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert >> X64/JumpToKernel.asm to X64/JumpToKernel.nasm >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by:

Re: [edk2] [PATCH 0/7] OvmfPkg: PlatformBdsLib cleanups and improvements

On 10/22/14 20:47, Jordan Justen wrote: > On Wed, Oct 22, 2014 at 11:28 AM, Laszlo Ersek wrote: >> On 10/22/14 20:05, Jordan Justen wrote: >>> Laszlo, >>> >>> Seabios starts to boot the OS nearly instantaneously. OVMF takes >>> several seconds. >>> >>> I think in OVMF today this is mainly due to t

Re: [edk2] [PATCH 3/7] OvmfPkg Sec: Convert X64/SecEntry.asm to NASM

On 10/22/14 20:53, Jordan Justen wrote: > On Wed, Oct 22, 2014 at 11:32 AM, Laszlo Ersek wrote: >> On 10/18/14 20:25, Jordan Justen wrote: >>> The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert >>> X64/SecEntry.asm to X64/SecEntry.nasm >>> >>> Contributed-under: TianoCore Contri

Re: [edk2] [PATCH 3/7] OvmfPkg Sec: Convert X64/SecEntry.asm to NASM

On Wed, Oct 22, 2014 at 11:32 AM, Laszlo Ersek wrote: > On 10/18/14 20:25, Jordan Justen wrote: >> The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert >> X64/SecEntry.asm to X64/SecEntry.nasm >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Jordan J

Re: [edk2] [PATCH 5/7] OvmfPkg LoadLinuxLib: Convert X64/JumpToKernel.asm to NASM

On 10/18/14 20:25, Jordan Justen wrote: > The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert > X64/JumpToKernel.asm to X64/JumpToKernel.nasm > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- > OvmfPkg/Library/LoadLinuxLib/LoadLinu

Re: [edk2] [PATCH 0/7] OvmfPkg: PlatformBdsLib cleanups and improvements

On Wed, Oct 22, 2014 at 11:28 AM, Laszlo Ersek wrote: > On 10/22/14 20:05, Jordan Justen wrote: >> Laszlo, >> >> Seabios starts to boot the OS nearly instantaneously. OVMF takes >> several seconds. >> >> I think in OVMF today this is mainly due to timeouts waiting for a >> non-existent floppy and/

Re: [edk2] [PATCH 4/7] OvmfPkg LoadLinuxLib: Convert Ia32/JumpToKernel.asm to NASM

On 10/18/14 20:25, Jordan Justen wrote: > The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert > Ia32/JumpToKernel.asm to Ia32/JumpToKernel.nasm > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- > OvmfPkg/Library/LoadLinuxLib/Ia32/J

Re: [edk2] [PATCH 3/7] OvmfPkg Sec: Convert X64/SecEntry.asm to NASM

On 10/18/14 20:25, Jordan Justen wrote: > The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert > X64/SecEntry.asm to X64/SecEntry.nasm > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- > OvmfPkg/Sec/SecMain.inf

Re: [edk2] Please Help: `_PCD_GET_MODE_16_PcdOvmfHostBridgePciDevId' undeclared

On 10/22/14 20:09, Gabriel Somlo wrote: > On Wed, Oct 22, 2014 at 07:42:21PM +0200, Laszlo Ersek wrote: >> On 10/22/14 18:24, Gabriel Somlo wrote: >>> I now get this error: >>> /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Library/PcdLib.h:377:45: >>> error: `_PCD_GET_MODE_16_PcdOvmfHostBridgePc

Re: [edk2] [PATCH 0/7] OvmfPkg: PlatformBdsLib cleanups and improvements

On 10/22/14 20:05, Jordan Justen wrote: > Laszlo, > > Seabios starts to boot the OS nearly instantaneously. OVMF takes > several seconds. > > I think in OVMF today this is mainly due to timeouts waiting for a > non-existent floppy and/or CD ROM. > > This series adds a few more seconds waiting on

Re: [edk2] [PATCH 2/7] OvmfPkg Sec: Convert Ia32/SecEntry.asm to NASM

On 10/18/14 20:25, Jordan Justen wrote: > The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert > Ia32/SecEntry.asm to Ia32/SecEntry.nasm > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- > OvmfPkg/Sec/Ia32/SecEntry.S

Re: [edk2] Please Help: `_PCD_GET_MODE_16_PcdOvmfHostBridgePciDevId' undeclared

On Wed, Oct 22, 2014 at 07:42:21PM +0200, Laszlo Ersek wrote: > On 10/22/14 18:24, Gabriel Somlo wrote: > > I managed to add (and write to) a dynamic PCD from OVMF PEI: > > > > > > OvmfPkg/OvmfPkg.dec: > > [PcdsDynamic, PcdsDynamicEx] > >gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0

Re: [edk2] [PATCH 0/7] OvmfPkg: PlatformBdsLib cleanups and improvements

Laszlo, Seabios starts to boot the OS nearly instantaneously. OVMF takes several seconds. I think in OVMF today this is mainly due to timeouts waiting for a non-existent floppy and/or CD ROM. This series adds a few more seconds waiting on the boot screen timeout. This seems to be heading in the

Re: [edk2] Please Help: `_PCD_GET_MODE_16_PcdOvmfHostBridgePciDevId' undeclared

On 10/22/14 18:24, Gabriel Somlo wrote: > I managed to add (and write to) a dynamic PCD from OVMF PEI: > > > OvmfPkg/OvmfPkg.dec: > [PcdsDynamic, PcdsDynamicEx] >gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0|UINT16|0x1b > > > OvmfPkg/OvmfPkgX64.dsc: > [PcdsDynamicDefault] >gU

Re: [edk2] Please Help: `_PCD_GET_MODE_16_PcdOvmfHostBridgePciDevId' undeclared

> On Oct 22, 2014, at 9:24 AM, Gabriel Somlo wrote: > > I managed to add (and write to) a dynamic PCD from OVMF PEI: > > > OvmfPkg/OvmfPkg.dec: > [PcdsDynamic, PcdsDynamicEx] > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0|UINT16|0x1b > > > OvmfPkg/OvmfPkgX64.dsc: > [PcdsDynamicDe

Re: [edk2] Firmware Volume Block Protocol

You likely need to add an additional entry in the DevicePath representing your "Media Type". For example, you may add "Vendor GUID"( not recomended) or LUN. On Tue, Oct 21, 2014 at 9:37 PM, Andrew Fish wrote: > > On Oct 21, 2014, at 8:08 PM, Narinder Dhillon > wrote: > > Hi Andrew, > > It is a

[edk2] Please Help: `_PCD_GET_MODE_16_PcdOvmfHostBridgePciDevId' undeclared

I managed to add (and write to) a dynamic PCD from OVMF PEI: OvmfPkg/OvmfPkg.dec: [PcdsDynamic, PcdsDynamicEx] gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0|UINT16|0x1b OvmfPkg/OvmfPkgX64.dsc: [PcdsDynamicDefault] gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0 OvmfPkg

Re: [edk2] [PATCH 01/14] OvmfPkg: initialize Q35 platform

On 10/06/14 21:54, Gabriel L. Somlo wrote: > On Mon, Sep 29, 2014 at 02:52:30PM +0200, Laszlo Ersek wrote: >> On 09/29/14 14:30, Paolo Bonzini wrote: >>> Il 29/09/2014 14:07, Laszlo Ersek ha scritto: Apparently so, for 00:01.3 on the PIIX4. But for other PCI devices, I think it's wri

Re: [edk2] [PATCH v2 3/6] OvmfPkg: enable SATA controller

On 08/21/14 11:55, reza.jel...@tuhh.de wrote: > From: Reza Jelveh > > Removed: > - IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBusDxe.inf > (provides gEfiDiskInfoProtocolGuid, gEfiBlockIoProtocolGuid) > - PcAtChipsetPkg/Bus/Pci/IdeControllerDxe/IdeControllerDxe.inf > (provides gEfiIdeControllerI

Re: [edk2] EDK2 Developer Tools for Windows

Jordan Justen [mailto:jljus...@gmail.com] wrote: ]On Tue, Oct 21, 2014 at 1:22 AM, Gao, Liming wrote: ]> Scott: ]> I will download them and try again. ]> ]> For the patch, I provide another compatible version in previous mail. Have you any comment for it? ]> ]> Linux user doesn't need to se

[edk2] [PATCH 7/7] OvmfPkg: set video resolution of text setup to 640x480

On a physical screen such a low graphics resolution would lead to huge glyphs (the text resolution is 80x25, centered, with 8x19 pixel glyphs). But in a virtual machine it just saves screen real estate on the client, by removing the black bands. Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH 4/7] OvmfPkg: BDS: optimize second argument in PlatformBdsEnterFrontPage() call

The second parameter of said function is "ConnectAllHappened", and if set to TRUE, the function sets "gConnectAllHappened" to TRUE. This global variable in turn controls whether Intel BDS code *itself* calls BdsLibConnectAllDriversToAllControllers() in various places -- if the indicator is TRUE, t

[edk2] [PATCH 6/7] OvmfPkg: BDS: drop custom boot timeout, revert to IntelFrameworkModulePkg's

PlatformBdsEnterFrontPage() already implements a keypress wait (for entering the setup utility at boot) with a nice progress bar, only OVMF has not been using it. Removing our custom code and utilizing PlatformBdsEnterFrontPage()'s builtin wait has the following benefits: - It simplifies OVMF's B

[edk2] [PATCH 1/7] OvmfPkg: BDS: remove dead call to PlatformBdsEnterFrontPage()

This call has been dead since the conception of OvmfPkg (git commit 49ba9447 / SVN r8398), and only confuses readers -- let's remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 8 1 file chang

[edk2] [PATCH 5/7] OvmfPkg: BDS: drop superfluous "connect first boot option" logic

This is again obviated by our earlier BdsLibConnectAll() call. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 23 --- 1 file changed, 23 deletions(-) diff --git a/OvmfPkg/Library/Platform

[edk2] [PATCH 0/7] OvmfPkg: PlatformBdsLib cleanups and improvements

The main motivation for this series is -- OVMF's PlatformBdsPolicyBehavior() currently prevents Intel BDS from handling the "OsIndications" variable correctly. (See "7.5.4 Exchanging information between the OS and Firmware" in the UEFI spec.) P

[edk2] [PATCH 3/7] OvmfPkg: BDS: don't overwrite the BDS Front Page timeout

The PlatformBdsEnterFrontPage() function's first parameter, "TimeoutDefault", determines the behavior of the setup utility: - If (TimeoutDefault == 0), then the setup utility is not supposed to be entered (ie. PlatformBdsEnterFrontPage() is not supposed to be called in the first place), and th

[edk2] [PATCH 2/7] OvmfPkg: BDS: drop useless return statement

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c index b1f5b7f..9a0

Re: [edk2] [PATCH v2 0/6] enable SataController in OVMF

On 10/09/14 13:57, Tian, Feng wrote: > Hi, Reza and Laszlo > > Sorry for late response due to PRC holiday. > > For #1 (MdeModulePkg: Check D2H register status in AhciPioTransfer), I have > refined the patch according to Sava's feedback. I will check it in after > passing unit test. As far as I

Re: [edk2] [RFC PATCH v5 00/22] Introduce Mp Service protocol to UefiCpuPkg

On Thu, 2014-10-16 at 01:48 +, Chen, Fan wrote: > On Thu, 2014-10-16 at 01:32 +, Chen, Fan wrote: > > On Wed, 2014-10-15 at 18:11 +0800, Chen Fan wrote: > > > This series patchset try to implement Mp Service protocol in UefiCpuPkg, > > > Jordan had implemented the startup APs code, and I

Re: [edk2] BDS: should BootOrder or OsIndications take priority?

On 10/22/14 10:25, Dong, Eric wrote: > Laszlo, > > The OsIndications will be processed before boot the first boot > option, detail process is in PlatformBdsEnterFrontPage function. > (IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c) > BdsEntry() -> PlatformBdsPolicyBehavior() -> > PlatformBd

Re: [edk2] [PATCH] MdeModulePkg DebugSupportDxe: Fix build error with GNU assembler

Jordan, Your patch is: -movw%es, %rax +mov %es, %rax The disassemble code through https://defuse.ca/online-x86-assembler.htm is (I change it from AT&T syntax to Masm): 66 8c c0movw rax, es 48 8c c0mov rax, es I am not su

Re: [edk2] BDS: should BootOrder or OsIndications take priority?

Laszlo, The OsIndications will be processed before boot the first boot option, detail process is in PlatformBdsEnterFrontPage function. (IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c) BdsEntry() -> PlatformBdsPolicyBehavior() -> PlatformBdsEnterFrontPage(). // // goto FrontPage dire

Re: [edk2] [PATCH] MdeModulePkg DebugSupportDxe: Fix build error with GNU assembler

I agree eax is better (0 extended and small size) Jordan, I could clean up the incorrect usage in other packages.:-) Jeff From: Andrew Fish [mailto:af...@apple.com] Sent: Wednesday, October 22, 2014 2:55 PM To: edk2-devel@lists.sourceforge.net Cc: Fan, Jeff; Tian, Feng Subject: Re: [edk2] [PATCH]