Re: [edk2] [PATCH] MdeModulePkg: enforce 8 byte alignment for pool allocations

2015-05-09 Thread Ard Biesheuvel
On 10 May 2015 at 07:30, Jordan Justen wrote: > On 2015-05-09 13:15:42, Ard Biesheuvel wrote: >> According to the UEFIv2.5 spec section 6.2, the allocations returned >> by the AllocatePool () boot service must be 8 byte aligned. >> >> So make our implementation conform to the spec, by rearranging

Re: [edk2] [PATCH] MdeModulePkg: enforce 8 byte alignment for pool allocations

2015-05-09 Thread Jordan Justen
On 2015-05-09 13:15:42, Ard Biesheuvel wrote: > According to the UEFIv2.5 spec section 6.2, the allocations returned > by the AllocatePool () boot service must be 8 byte aligned. > > So make our implementation conform to the spec, by rearranging the > pool head struct so that its size is always a

Re: [edk2] [Patch] MdePkg: Add EFI_LOAD_OPTION definition.

2015-05-09 Thread Ni, Ruiyu
OK. I will commit the patch using the NOTES provide by Felix. Thanks, Ray -Original Message- From: Kinney, Michael D Sent: Saturday, May 9, 2015 12:06 AM To: Felix Poludov; Ni, Ruiyu; edk2-devel@lists.sourceforge.net; Andrew Fish; Kinney, Michael D Subject: RE: [edk2] [Patch] MdePkg: Ad

Re: [edk2] [Patch] Nt32Pkg: Enable new BDS in NT32 platform.

2015-05-09 Thread Ni, Ruiyu
>From BDS side, there is no feature gap. >From the UI/Firmware Setup side, the standalone UI/Firmware Setup (provided by >MdeModulePkg/Application/BootManagerMenuApp) only lists all boot options. So >there is feature gap. We need to develop a feature equivalent UI/Firmware >Setup. Sure I will pr

[edk2] Multiple devices with the same driver

2015-05-09 Thread Andreas Galauner
Hi all, I'm currently porting UEFI to the Xilinx Zynq (ARM) platform because I was interested in UEFI in general and wanted to get a feeling for the internals and the concepts behind the whole platform. I have a working port which boots as a 2nd stage bootloader, starts the 2nd core and has prett

Re: [edk2] [PATCH] MdeModulePkg: enforce 8 byte alignment for pool allocations

2015-05-09 Thread Andrew Fish
> On May 9, 2015, at 1:43 PM, Ard Biesheuvel wrote: > > On 9 May 2015 at 22:39, Andrew Fish > wrote: >> Ard, >> >> Would removing the Reserved field and making Size a UINT64 also fix the >> issue? >> > > Yes, but since the Size field is assigned to POOL_TAIL::Size as

Re: [edk2] [PATCH] MdeModulePkg: enforce 8 byte alignment for pool allocations

2015-05-09 Thread Ard Biesheuvel
On 9 May 2015 at 22:39, Andrew Fish wrote: > Ard, > > Would removing the Reserved field and making Size a UINT64 also fix the issue? > Yes, but since the Size field is assigned to POOL_TAIL::Size as well, and used in comparisons in CoreFreePoolI(), I thought this would be the cleaner approach. Bu

Re: [edk2] [PATCH] MdeModulePkg: enforce 8 byte alignment for pool allocations

2015-05-09 Thread Andrew Fish
Ard, Would removing the Reserved field and making Size a UINT64 also fix the issue? Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Andrew Fish Thanks, Andrew Fish > On May 9, 2015, at 1:15 PM, Ard Biesheuvel wrote: > > According to the UEFIv2.5 spec section 6.2, the a

[edk2] [PATCH] MdeModulePkg: enforce 8 byte alignment for pool allocations

2015-05-09 Thread Ard Biesheuvel
According to the UEFIv2.5 spec section 6.2, the allocations returned by the AllocatePool () boot service must be 8 byte aligned. So make our implementation conform to the spec, by rearranging the pool head struct so that its size is always a multiple of 8 bytes. Contributed-under: TianoCore Contr