Re: [edk2] Query UEFI : PCIE Driver for Armv8 platform

2015-06-02 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Leekha Shaveta had to walk into mine at 20:41:11 on Tuesday 02 June 2015 and say: > Thanks Eugene! > > Few more doubts: > > > (1)What exactly this "case EfiPciHostBridgeAllocateResources" of > NotifyPhase does? > > (2)In "StartB

Re: [edk2] Query UEFI : PCIE Driver for Armv8 platform

2015-06-02 Thread Leekha Shaveta
Thanks Eugene! Few more doubts: (1)What exactly this "case EfiPciHostBridgeAllocateResources" of NotifyPhase does? (2)In "StartBusEnumeration" function of PCI_HOST_BRIDGE, it / Fill an ACPI descriptor table with the Bus Number Range. This information will be used by the PCI Bus drive

Re: [edk2] [Patch] IntelFspPkg: correct comments and rename a label

2015-06-02 Thread Yao, Jiewen
Good catch. Reviewed-by: Yao, Jiewen -Original Message- From: Dong, Guo [mailto:guo.d...@intel.com] Sent: Tuesday, June 02, 2015 10:07 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [Patch] IntelFspPkg: correct comments and rename a label Yes. Will check in "Initialize". /

Re: [edk2] NVMe question

2015-06-02 Thread Tian, Feng
Hi, Laszlo Most of us are using MS outlook as mail client. So top-posting is inevitable per my knowledge. If you know how to avoid top posting, please let us know. Thanks Feng -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, June 02, 2015 15:46 To: edk2-d

Re: [edk2] NVMe question

2015-06-02 Thread Tian, Feng
Hi, Keith I agree your explanation does make sense. But could you let me know where speaks the host driver must initialize these two fields of CC register before any I/O operation in NVMe spec? Thanks Feng -Original Message- From: Busch, Keith Sent: Wednesday, June 03, 2015 03:11 To:

Re: [edk2] Accessing SMBios' System Event Log through GPNV functions

2015-06-02 Thread Andrew Fish
> On Jun 2, 2015, at 12:47 PM, Andrew Fish wrote: > > >> On Jun 2, 2015, at 11:50 AM, Tomaz Fogaça > > wrote: >> >> Hello everyone, >> >> I'm writing this application for UEFI using the UDK and in it I'm trying to >> gather some information from the SMBios table.

Re: [edk2] Problem with PiSmmCore Dispatcher.c

2015-06-02 Thread Zachary Bobroff
Yao, Thanks. Sure, I will create a patch file tomorrow and attach it here. Best Regards, Zach From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Tuesday, June 02, 2015 6:22 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] Problem with PiSmmCore Dispatcher.c Thanks. Yes, this is a

Re: [edk2] Problem with PiSmmCore Dispatcher.c

2015-06-02 Thread Yao, Jiewen
Thanks. Yes, this is an issue, and should be fixed. Using SmmTypeIndex and AprioriIndex seems good way for 2nd and 3rd loop. How about use "HandleIndex" for the 1st loop? Will you generate a patch? Or we can help generate patch. Thank you Yao Jiewen From: Zachary Bobroff [mailto:zacha...@ami.com

[edk2] AArch64 Debugger Global Variable Correlation Issues

2015-06-02 Thread Cohen, Eugene
Dear ArmPkg maintainers, I'm trying to debug AArch64 code built with Linaro GCC and don't have proper correlation for global variables. I'm digging into how .data/.bss is correlated across ELF and PE-COFF and I see different offsets (in ELF the data appears to be 64KB higher up than PE-COFF).

Re: [edk2] Accessing SMBios' System Event Log through GPNV functions

2015-06-02 Thread Andrew Fish
> On Jun 2, 2015, at 11:50 AM, Tomaz Fogaça wrote: > > Hello everyone, > > I'm writing this application for UEFI using the UDK and in it I'm trying to > gather some information from the SMBios table. > > I'm trying to reach the System Event Log, and in order to do that I've > decoded the Sys

[edk2] Problem with PiSmmCore Dispatcher.c

2015-06-02 Thread Zachary Bobroff
All, I hope I am proving this issue the right way, please correct me if I am not. I also am not sure if this has been already reported. I have come across a problem in Dispatcher.c within PiSmmCore of MdeModulePkg linked here: https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/PiS

[edk2] Accessing SMBios' System Event Log through GPNV functions

2015-06-02 Thread Tomaz Fogaça
Hello everyone, I'm writing this application for UEFI using the UDK and in it I'm trying to gather some information from the SMBios table. I'm trying to reach the System Event Log, and in order to do that I've decoded the System Event Log(Type 15) structure and found that, in my machine, the fiel

Re: [edk2] [RFC] edk2 support for a new QEMU device - PXB (PCI Expander Device)

2015-06-02 Thread Laszlo Ersek
On 06/02/15 17:04, Marcel Apfelbaum wrote: > Hi, > > The following series: >- [Qemu-devel] [PATCH V8 00/17] hw/pc: implement multiple primary > busses for pc machines >- https://www.mail-archive.com/qemu-devel@nongnu.org/msg300089.html > adds a PCI Expander Device to QEMU that exp

[edk2] [RFC] edk2 support for a new QEMU device - PXB (PCI Expander Device)

2015-06-02 Thread Marcel Apfelbaum
Hi, The following series: - [Qemu-devel] [PATCH V8 00/17] hw/pc: implement multiple primary busses for pc machines - https://www.mail-archive.com/qemu-devel@nongnu.org/msg300089.html adds a PCI Expander Device to QEMU that exposes a new PCI root bus. The PXB is a "light-weight" host bri

Re: [edk2] [Patch] IntelFspPkg: correct comments and rename a label

2015-06-02 Thread Dong, Guo
Yes. Will check in "Initialize". /Guo -Original Message- From: Haojian Zhuang [mailto:haojian.zhu...@linaro.org] Sent: Tuesday, June 02, 2015 9:51 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [Patch] IntelFspPkg: correct comments and rename a label On Tue, 2015-06-02 at 2

Re: [edk2] [Patch] SourceLevelDebugPkg/DebugAgent: Check PcdDebugPortHandleBufferSize

2015-06-02 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey -Original Message- From: Jeff Fan [mailto:jeff@intel.com] Sent: Tuesday, June 02, 2015 12:01 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch] SourceLevelDebugPkg/DebugAgent: Check PcdDebugPortHandleBufferSize Check PcdDebugPortHandleBufferSi

Re: [edk2] Executing Signtool When Building Applications

2015-06-02 Thread Cohen, Eugene
Yes, indeed it would be helpful to having signing support integrated in the build. It would be nice if we had a place to put these requests (edk2 up for grabs or whatever). I would appreciate a response from the BaseTools developers on this question since it seems like a need that others have

Re: [edk2] [Patch] IntelFspPkg: correct comments and rename a label

2015-06-02 Thread Haojian Zhuang
On Tue, 2015-06-02 at 21:42 +0800, Guo Dong wrote: > This patch corrects a word typo and a comment error. > It also rename a label to match its function name. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Guo Dong > --- > IntelFspPkg/FspSecCore/Ia32/FspApiEntry.asm

Re: [edk2] Query UEFI : PCIE Driver for Armv8 platform

2015-06-02 Thread Cohen, Eugene
? Is all of the following functions have platform specific code, or they can be re-used from any of the PCI code like ARmJunoPkg etc? Are all these functions definitions mendatory? You have to implement the host bridge and root bridge protocols. When you implement a protocol you must implemen

[edk2] [Patch] IntelFspPkg: correct comments and rename a label

2015-06-02 Thread Guo Dong
This patch corrects a word typo and a comment error. It also rename a label to match its function name. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Dong --- IntelFspPkg/FspSecCore/Ia32/FspApiEntry.asm | 10 +- IntelFspPkg/FspSecCore/SecMain.c|

Re: [edk2] [PATCH 6/7] ArmVirtPkg: record GIC revision in dynamic PCD

2015-06-02 Thread Ard Biesheuvel
On 1 June 2015 at 20:11, Laszlo Ersek wrote: > On 05/29/15 14:33, Ard Biesheuvel wrote: >> In order to allow a ArmGicArchLib to be implemented that returns >> the supported GIC revision based on the device tree, add handling >> to VirtFdtDxe to record the GIC revision at DT parsing time. >> >> Con

[edk2] Fwd: Problems with firmware image building and with multiple BootXXXX

2015-06-02 Thread Дмитрий Оботуров
Hello. I have one more question what we can't answer. In the attachment you will find two files of firmware image that we get from the same source code uefi. One of the firmware images was built on the notebook but the other on the desktop. image №1 https://drive.google.com/file/d/0B6BUWzw-c4Q7V

[edk2] [Patch] PcAtChipSetPkg/PcRtc: Use PcdMinimalValidYear as the initial year value

2015-06-02 Thread Ruiyu Ni
RTC_INIT_YEAR was defined as 2001 so when PcdMinimalValidYear is 2002 the RtcTimeFieldsValid() returns failure resulting the PcRtc driver not work. The fix is to remove the RTC_INIT_YEAR definition and directly use PcdMinimalValidYear as the initial year value. Contributed-under: TianoCore Contr

Re: [edk2] [Patch] MdeModulePkg: Provide EfiBootManagerRegisterBootDescriptionHandler

2015-06-02 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Ni, Ruiyu Sent: Friday, May 29, 2015 5:46 PM To: edk2-devel@lists.sourceforge.net Cc: Ni, Ruiyu; Dong, Eric Subject: [Patch] MdeModulePkg: Provide EfiBootManagerRegisterBootDescriptionHandler This API can be used for platform to customize

Re: [edk2] NVMe question

2015-06-02 Thread Laszlo Ersek
On 06/02/15 09:19, Tian, Feng wrote: > Thanks for the info. > > > > I didn’t test it on NVMe-Qemu, I just run the change on a real > production. I will do bigger scope test to see if it’s valuable to add > it back. This email thread is a perfect example why top-posting is a horrible practice.

Re: [edk2] NVMe question

2015-06-02 Thread Tian, Feng
Thanks for the info. I didn't test it on NVMe-Qemu, I just run the change on a real production. I will do bigger scope test to see if it's valuable to add it back. Thanks Feng From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Tuesday, June 02, 2015 06:22 To: Tian, Feng; edk2-deve

Re: [edk2] [PATCH 3/3] OvmfPkg: PlatformDxe: Add ConfigHdrMatch check in RouteConfig

2015-06-02 Thread Laszlo Ersek
On 06/02/15 04:58, Heyi Guo wrote: > Hi Laszlo, > > First, thanks for your time to review the code and reply with such > details (always learned from your replies), and it is OK to NAK these > patches if you are not happy to do so :) > > If we are sure it is the bug of SCT, I agree it is better t

Re: [edk2] Query UEFI : PCIE Driver for Armv8 platform

2015-06-02 Thread Leekha Shaveta
Hi, I am writing a PCI driver(Host Bridge) code for ARM platform with real devices like e1000 NIC card on PCI bus. I have written a part of PCI Root Complex Initialization code, but have few doubts : (1)Is all of the following functions have platform specific code, or they can be re-used

[edk2] [Patch] SourceLevelDebugPkg/DebugAgent: Check PcdDebugPortHandleBufferSize

2015-06-02 Thread Jeff Fan
Check PcdDebugPortHandleBufferSize before allocate buffer. PeriodicMode is BOOLEAN type, needn't to use == TRUE in if condition. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan CC: Ruiyu Ni --- .../Library/DebugAgent/SecPeiDebugAgent/SecPeiDebugAgentLib.c