Re: [edk2] [patch] SecurityPkg: Calculate the length of the String.

Reviewed-by: jiaxinwu -Original Message- From: Zhang Lubo [mailto:lubo.zh...@intel.com] Sent: Friday, July 3, 2015 9:33 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [patch] SecurityPkg: Calculate the length of the String. From: "Zhang, Lubo" When the two concatenated string

Re: [edk2] [PATCH] CryptoPkg: Allow the depth zero self-signed certificate

Hi, Gary, Is it one new issue brought by 1.0.2c? X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT will also be issued in 0.9.8xx. The 1.0.2c just add one new function cert_self_signed() to simplify the self-signed certificate checking (by checking the flag only, instead of issuer checking). Best Regards

Re: [edk2] [PATCH] CryptoPkg: Allow the depth zero self-signed certificate

On Fri, Jul 03, 2015 at 11:37:22AM +0800, Gary Ching-Pang Lin wrote: > After updating openssl from 0.9.8zf to 1.0.2c(*), all images with the depth > zero self-signed certificates were rejected since X509_verify_cert() issued > this error: X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT. This commit relaxes

[edk2] [patch] BaseTool : Fix the range expression evaluation error.

Hi, Here is the patch to fix the BaseTools the range expression evaluation error. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bob Feng < bob.c.f...@intel.com > Best Regards, Bob Feng 0001-BaseTools-Build-Fix-the-range-expression-evalu

[edk2] [PATCH v4] ShellPkg: Update ping/ifconfig library.

Version4 include small update from reviewer's comments: Change and add some help messages in uni file. Revert copyright year in UefiShellNetwork1CommandsLib.c file since there is no code change in this file. This patch update ShellPkg ping/ifconfig library source code to consume Ip4Config2 prot

[edk2] [PATCH] CryptoPkg: Allow the depth zero self-signed certificate

After updating openssl from 0.9.8zf to 1.0.2c(*), all images with the depth zero self-signed certificates were rejected since X509_verify_cert() issued this error: X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT. This commit relaxes the check in X509VerifyCb() to allow the self-signed images pass the verifi

Re: [edk2] [PATCH] SourceLevelDebugPkg: Fix PEI debug timer regression

Thanks! Reviewed-by: Jeff Fan -Original Message- From: Brian J. Johnson [mailto:bjohn...@sgi.com] Sent: Thursday, July 02, 2015 11:56 PM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH] SourceLevelDebugPkg: Fix PEI debug timer regression Recent changes to debug timer handli

Re: [edk2] [patch] MdeModulePkg:Modify the incorrect DestStr length in safe string functions

Reviewed-by: Qiu Shumin -Original Message- From: Bi, Dandan Sent: Thursday, July 02, 2015 6:24 PM To: Gao, Liming; Dong, Eric; Qiu, Shumin; edk2-devel@lists.sourceforge.net Subject: [patch] MdeModulePkg:Modify the incorrect DestStr length in safe string functions Contributed-under: T

[edk2] [patch] SecurityPkg: Calculate the length of the String.

From: "Zhang, Lubo" When the two concatenated strings are both not null, the total length in bytes of them should calculate the character '\0' once. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- .../UserIdentification/UserProfileManagerDxe/UserProfileMo

[edk2] [PATCH] SourceLevelDebugPkg: Fix PEI debug timer regression

Recent changes to debug timer handling ended up leaving the timer disabled in PEI. This made it impossible to stop execution in PEI externally via the debugger. Enable the timer when InitializeDebugAgent calls InitializeDebugAgentPhase2, as well as when it returns directly. Contributed-under: Ti

[edk2] [RFC PATCH] MdeModulePkg: account for disjoint code and data regions in runtime relocations

Hello all, This is a proof of concept patch that fixes the problems that occur when enabling the EFI_PROPERTIES_RUNTIME_MEMORY_PROTECTION_NON_EXECUTABLE_PE_DATA MemoryProtectionAttribute, which may split PE/COFF memory images into disjoint regions in virtual memory. It is not a complete solution,

Re: [edk2] [PATCH v2] SecurityPkg:Replace unsafe string functions.

Got it, I just found the true and some unsafe functions had also been changed to safe ones in them. I will not apply them when I commit. Thanks Lubo -Original Message- From: Zeng, Star [mailto:star.z...@intel.com] Sent: Thursday, July 02, 2015 5:17 PM To: edk2-devel@lists.sourceforge.

[edk2] [patch] MdeModulePkg:Modify the incorrect DestStr length in safe string functions

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- MdeModulePkg/Universal/HiiDatabaseDxe/Database.c | 2 +- MdeModulePkg/Universal/HiiDatabaseDxe/String.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePk

Re: [edk2] [PATCH v2 1/2] MdeModulePkg: Add HttpLib to MdeModulePkg.

Hi Siyuan, The include protection macro name in HttpLib.h is not consistent with the file name; is it better to use _HTTP_LIB_H_ instead? +#ifndef _HTTP_H_ +#define _HTTP_H_ On 07/02/2015 05:02 PM, Fu Siyuan wrote: > This patch add the header file and DXE implementation for the HttpLib. > > C

Re: [edk2] [PATCH v2] SecurityPkg:Replace unsafe string functions.

.../VariableAuthenticated/RuntimeDxe/VarCheck.c| 2 +- .../VariableAuthenticated/RuntimeDxe/Variable.c| 8 +- They are not needed as the auth variable driver has been merged to variable driver in MdeModulePkg. Thanks, Star > -Original Message- > From: Zhang Lubo [mailto:lubo.zh..

[edk2] [PATCH v2 1/2] MdeModulePkg: Add HttpLib to MdeModulePkg.

This patch add the header file and DXE implementation for the HttpLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan --- MdeModulePkg/Include/Library/HttpLib.h | 323 ++ MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 1359

[edk2] [PATCH v2 0/2] Add HttpLib and HTTP boot driver.

This patch add the implementation of the HttpLib and HTTP boot driver. Fu Siyuan (2): MdeModulePkg: Add HttpLib to MdeModulePkg. NetworkPkg: Add UEFI HTTP boot driver. MdeModulePkg/Include/Library/HttpLib.h | 323 ++ MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 1359

[edk2] [PATCH v2] MdeModulePkg: Replace unsafe string functions.

Replace unsafe string functions with new added safe string functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 7 +++ .../Universal/Network/IScsiDxe/IScsiConfig.c | 4 ++-- .../Universal

[edk2] [PATCH v2] SecurityPkg:Replace unsafe string functions.

Replace unsafe string functions with new added safe string functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- .../DxeTcgPhysicalPresenceLib.c| 90 +++--- .../DxeTrEEPhysicalPresenceLib.c | 18 ++--

[edk2] [PATCH v2] NetworkPkg:Replace unsafe string functions.

Replace unsafe string functions with new added safe string functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- NetworkPkg/Application/IfConfig6/IfConfig6.c | 13 ++ NetworkPkg/Application/IpsecConfig/Indexer.c | 4 +- .../Application/

Re: [edk2] URGENT SVN screwup [Re: [PATCH 0/5] MdeModulePkg: clean up Properties Table implementation and adapt it to AArch64]

On 2 July 2015 at 09:29, Jordan Justen wrote: > On 2015-07-02 00:10:40, Jordan Justen wrote: >> On 2015-07-01 23:51:19, Ard Biesheuvel wrote: >> > On 2 July 2015 at 08:38, Ard Biesheuvel wrote: >> > > Liming, Jordan, Jiewen. >> > > >> > > I appeared to have screwed up something performing the pus

Re: [edk2] URGENT SVN screwup [Re: [PATCH 0/5] MdeModulePkg: clean up Properties Table implementation and adapt it to AArch64]

On 2015-07-02 00:10:40, Jordan Justen wrote: > On 2015-07-01 23:51:19, Ard Biesheuvel wrote: > > On 2 July 2015 at 08:38, Ard Biesheuvel wrote: > > > Liming, Jordan, Jiewen. > > > > > > I appeared to have screwed up something performing the push > > > > > > Could you please rewind SVN to r17801 ?

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

On 2 July 2015 at 09:21, Gao, Liming wrote: > Jordan: > For now, this feature will break older OSes. The platform requires to add > feature flag to enable/disable it. So, DSC BuildOptions extension is added to > configure it. In future, if more and more platforms enable it, we could > figure

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

Jordan: For now, this feature will break older OSes. The platform requires to add feature flag to enable/disable it. So, DSC BuildOptions extension is added to configure it. In future, if more and more platforms enable it, we could figure out the solution to extent tools_def.txt to configure t

Re: [edk2] URGENT SVN screwup [Re: [PATCH 0/5] MdeModulePkg: clean up Properties Table implementation and adapt it to AArch64]

On 2015-07-01 23:51:19, Ard Biesheuvel wrote: > On 2 July 2015 at 08:38, Ard Biesheuvel wrote: > > Liming, Jordan, Jiewen. > > > > I appeared to have screwed up something performing the push > > > > Could you please rewind SVN to r17801 ? > > > > Apologies for sounding a bit panicky, but it would

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

> On Jul 2, 2015, at 12:03 AM, Jordan Justen wrote: > > On 2015-07-01 23:22:37, Andrew Fish wrote: >>> On Jul 1, 2015, at 11:08 PM, Jordan Justen >>> wrote: >>> On 2015-07-01 22:35:12, Gao, Liming wrote: Ard: Good to know --script option can be appended and work fine. >>> >>>

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

On 2015-07-01 23:22:37, Andrew Fish wrote: > > On Jul 1, 2015, at 11:08 PM, Jordan Justen > > wrote: > > > >> On 2015-07-01 22:35:12, Gao, Liming wrote: > >> Ard: > >> Good to know --script option can be appended and work fine. > > > > So, --script will be specified twice to ld. This seems lik