Re: [edk2] [PATCH v7] OvmfPkg: PlatformBdsLib: Dynamic PCI Interrupt Line register setup

2014-11-14 Thread Gabriel Somlo
On Fri, Nov 14, 2014 at 03:25:51PM +0100, Laszlo Ersek wrote: > On 11/14/14 15:12, Paolo Bonzini wrote: > > > > > > On 14/11/2014 14:40, Laszlo Ersek wrote: > >> Now where is my thought process wrong? You might want to add an assert > >> somewhere. > > I don't think your thought

Re: [edk2] qemu + osx + smp vs. dee9376ffc6e5522bb5e50512b521952a5421fa5

2014-11-14 Thread Gabriel Somlo
caused a 0x0c4 error (see attached file). so I made a > code as jordan's suggestion to fix it. and then installing test works > ok. > > Gabriel, > > please use the attached patch to test your osx env. Yep, that fixed it for me -- Thanks ! Tested-by: Gabriel Somlo -

Re: [edk2] [PATCH v7] OvmfPkg: PlatformBdsLib: Dynamic PCI Interrupt Line register setup

2014-11-14 Thread Gabriel Somlo
On Fri, Nov 14, 2014 at 10:26:55AM +0100, Laszlo Ersek wrote: > One question. > > On 11/14/14 04:01, Gabriel L. Somlo wrote: > > + > > + Status = EFI_SUCCESS; > > + > > + if (PciHdr->Device.InterruptPin != 0) { > > so here InterruptPin >= 1 Same as in SeaBIOS pci_bios_init_device() under "/* m

[edk2] qemu + osx + smp vs. dee9376ffc6e5522bb5e50512b521952a5421fa5

2014-11-13 Thread Gabriel Somlo
Jordan, Commit dee9376ffc6e5522bb5e50512b521952a5421fa5 appears to break osx smp mode (single-cpu on Mavericks seems to still work fine). Fedora 20 and 21 live still work fine in either single- or multi-cpu configurations. I realize this must be an annoying bug report, since starting a qemu osx

Re: [edk2] [PATCH v6 0/9] OVMF: Add support for Qemu Q35 machine type

2014-11-13 Thread Gabriel Somlo
On Thu, Nov 13, 2014 at 04:50:05PM -0800, Jordan Justen wrote: > On 2014-11-13 12:12:54, Gabriel L. Somlo wrote: > > New in v.6: > > > > - ASSERT(FALSE) in default branch of HostBridgeDevID switch followed > > by return statement to suppress unused variable gcc warnings > > (Jordan, than

Re: [edk2] [PATCH v5 2/9] OvmfPkg: PlatformPei: Platform specific ACPI power management setup

2014-11-13 Thread Gabriel Somlo
On Thu, 13 Nov 2014 09:27:09 -0600, Scott Duplichan wrote: > Gabriel Somlo [mailto:gso...@gmail.com] wrote: > ]On Sun, Nov 09, 2014 at 05:00:38PM -0800, Jordan Justen wrote: > ]> On 2014-11-08 14:01:56, Gabriel L. Somlo wrote: > ]> > @@ -228,6 +229,11 @@ MiscInitializa

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-12 Thread Gabriel Somlo
On Wednesday, November 12, 2014 5:26 PM, Jordan Justen wrote: >On 2014-11-12 03:23:04, Laszlo Ersek wrote: >> SEC always runs, but whether or not SEC depends on TimerLib is >> conditional on -D SOURCE_DEBUG_ENABLE. If it is absent, then the debug >> agent is not pulled in (*), and then SEC doesn't

Re: [edk2] [PATCH v5 2/9] OvmfPkg: PlatformPei: Platform specific ACPI power management setup

2014-11-12 Thread Gabriel Somlo
On Tue, Nov 11, 2014 at 07:54:30PM -0800, Jordan Justen wrote: > > > When I build IA32 (OvmfPkg/build.sh -a IA32) I get warnings about > > > possibly uninitialized variables. > > > > > > It seems to happen basically everwhere that you switch on > > > HostBridgeDevId. > > > > I wonder why it's onl

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global

2014-11-12 Thread Gabriel Somlo
On Wed, 12 Nov 2014 12:23:04 +0100, Laszlo Ersek wrote: > On 11/11/14 22:34, Gabriel Somlo wrote: > > On Sun, Nov 09, 2014 at 10:13:54AM -0800, Jordan Justen wrote: > >> On 2014-11-08 14:02:00, Gabriel L. Somlo wrote: > >>> + // > >>> + // Check to s

Re: [edk2] [PATCH v5 2/9] OvmfPkg: PlatformPei: Platform specific ACPI power management setup

2014-11-11 Thread Gabriel Somlo
On Sun, Nov 09, 2014 at 05:00:38PM -0800, Jordan Justen wrote: > On 2014-11-08 14:01:56, Gabriel L. Somlo wrote: > > @@ -228,6 +229,11 @@ MiscInitialization ( > >VOID > >) > > { > > + UINT16 HostBridgeDevId; > > + UINTN PmCmd; > > + UINTN Pmba; > > + UINTN PmRegMisc; > > + > >//

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-11 Thread Gabriel Somlo
seRom) to take advantage of the improved efficiency > > of storing the timer register IO address in a global variable. > > > > This leaves only SEC using the BaseRomAcpiTimerLib instance. > > > > Contributed-under: TianoCor

Re: [edk2] [PATCH v4 6/6] OvmfPkg: PlatformBdsLib: Platform dependent PCI/IRQ initialization

2014-11-07 Thread Gabriel Somlo
On Fri, Nov 07, 2014 at 05:55:59PM +0100, Paolo Bonzini wrote: > On 07/11/2014 17:40, Gabriel Somlo wrote: > > > > I don't know how I could bring a bus number into the mix (I just > > assume the bus number is 0 and stop after the first device path node, > > which h

Re: [edk2] [PATCH v4 6/6] OvmfPkg: PlatformBdsLib: Platform dependent PCI/IRQ initialization

2014-11-07 Thread Gabriel Somlo
On Mon, Nov 03, 2014 at 08:59:34PM +0100, Laszlo Ersek wrote: > > Additionally, initialize PCI_INTERRUPT_LINE registers for the typical > > set of PCI devices included by QEMU with the Q35 machine type. The > > corresponding PIIX4 initialization of PCI_INTERRUPT_LINE registers is > > cleaned up and

Re: [edk2] [PATCH v4 4/6] OvmfPkg: AcpiTimerLib: Split into multiple phase-specific instances

2014-11-03 Thread Gabriel Somlo
On Mon, Nov 03, 2014 at 08:09:28PM +0100, Laszlo Ersek wrote: > comments below: > > On 11/01/14 23:20, Gabriel L. Somlo wrote: > > Remove local power management register access macros in favor of > > factored-out ones in OvmfPkg/Include/OvmfPlatforms.h > > > > Next, AcpiTimerLib is split out into

Re: [edk2] [PATCH v3 6/6] OvmfPkg: PlatformBdsLib: Platform dependent PCI/IRQ initialization

2014-10-28 Thread Gabriel Somlo
On Tue, Oct 28, 2014 at 08:30:29AM +0100, Gerd Hoffmann wrote: > > + // FIXME: This should be accomplished programmatically by enumerating > > + //all PCI devices present in the system and computing > > + //PCI_INTERRUPT_LINE from PCI_INTERRUPT_PIN, the slot/position > > + //

Re: [edk2] [PATCH 01/14] OvmfPkg: initialize Q35 platform

2014-10-23 Thread Gabriel Somlo
On Thu, Oct 23, 2014 at 07:31:27PM +0200, Laszlo Ersek wrote: > But, referring to > > http://thread.gmane.org/gmane.comp.bios.tianocore.devel/10156/focus=10197 > > On 09/30/14 00:17, Jordan Justen wrote: > > In OvmfPkg*.dsc: > > * [...] > > * Replace BasePcdLibNull.inf with DxePcdLib.inf as neede

Re: [edk2] [PATCH 01/14] OvmfPkg: initialize Q35 platform

2014-10-23 Thread Gabriel Somlo
Jordan, Laszlo: On Mon, Oct 06, 2014 at 11:42:53AM -0400, Gabriel L. Somlo wrote: > So, to decide how I feel about further splitting out DxeAcpiTimerLib > into a version which does use PCDs and another version which does not, > I added some DEBUG statements to track every time the host bridge > ge

Re: [edk2] Please Help: `_PCD_GET_MODE_16_PcdOvmfHostBridgePciDevId' undeclared

2014-10-23 Thread Gabriel Somlo
Liming, Laszlo: On Thu, Oct 23, 2014 at 01:07:22PM +0200, Laszlo Ersek wrote: > On 10/23/14 08:05, Gao, Liming wrote: > > Somlo: > > > > Your patch shows four AcpiTimerLib instances: AcpiTimerLib.inf, > > BaseAcpiTimerLib.inf, BaseRomAcpiTimerLib.inf and DxeAcpiTimerLib.inf. > > > > I find Ba

Re: [edk2] Please Help: `_PCD_GET_MODE_16_PcdOvmfHostBridgePciDevId' undeclared

2014-10-22 Thread Gabriel Somlo
On Wed, Oct 22, 2014 at 08:30:00PM +0200, Laszlo Ersek wrote: > On 10/22/14 20:09, Gabriel Somlo wrote: > > On Wed, Oct 22, 2014 at 07:42:21PM +0200, Laszlo Ersek wrote: > >> On 10/22/14 18:24, Gabriel Somlo wrote: > > >>> I now get this error: > >>

Re: [edk2] Please Help: `_PCD_GET_MODE_16_PcdOvmfHostBridgePciDevId' undeclared

2014-10-22 Thread Gabriel Somlo
On Wed, Oct 22, 2014, Andrew Fish wrote: > > After doing this, things build just fine. But after further adding: > > > > > > OvmfPkg/Library/AcpiTimerLib/DxeAcpiTimerLib.inf: > > [Pcd] > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId > > > > > > OvmfPkg/Library/AcpiTimerLib/DxeAcpiT

Re: [edk2] Please Help: `_PCD_GET_MODE_16_PcdOvmfHostBridgePciDevId' undeclared

2014-10-22 Thread Gabriel Somlo
On Wed, Oct 22, 2014 at 07:42:21PM +0200, Laszlo Ersek wrote: > On 10/22/14 18:24, Gabriel Somlo wrote: > > I managed to add (and write to) a dynamic PCD from OVMF PEI: > > > > > > OvmfPkg/OvmfPkg.dec: > > [PcdsDynamic, PcdsDynamicEx] > >gUefiOvmfPkgT

[edk2] Please Help: `_PCD_GET_MODE_16_PcdOvmfHostBridgePciDevId' undeclared

2014-10-22 Thread Gabriel Somlo
I managed to add (and write to) a dynamic PCD from OVMF PEI: OvmfPkg/OvmfPkg.dec: [PcdsDynamic, PcdsDynamicEx] gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0|UINT16|0x1b OvmfPkg/OvmfPkgX64.dsc: [PcdsDynamicDefault] gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0 OvmfPkg