Re: [edk2] [PATCH] ShellPkg: Fix the wrong value got from 'for' command.

2015-07-15 Thread Leif Lindholm
On Wed, Jul 15, 2015 at 09:40:12AM +0800, Qiu Shumin wrote: > In 'For.c' return error status instead of a wrong number when fail to convert > a string to UINT64. No objection to content of patch, but the above line is too long. Can you break it up please? Regards, Leif > Contributed-under: Tia

Re: [edk2] [PATCH] SecurityPkg: Fix DBX Variable Read Error in ImageVerificationLib

2015-07-15 Thread Leif Lindholm
On Wed, Jul 15, 2015 at 08:42:49AM +0800, Zhang, Chao B wrote: > ImageVerificationLib passes wrong data buffer size when reading DBX variable, > causing heap crash. No objection to content of patch, but the above line is too long. Can you break it up please? Regards, Leif > Contributed-under:

Re: [edk2] [Patch] BaseTools: Fixed incorrect alignment bug.

2015-07-15 Thread Leif Lindholm
On Wed, Jul 15, 2015 at 10:17:31AM +0800, Yingke Liu wrote: > The alignment in rule section is shared by modules that use this rule to > generate FFS, it should not be modified by certain module. No objection to content of patch, but the above line is too long. Can you break it up before committi

Re: [edk2] [PATCH] ShellPkg: Increase PcdShellFileOperationSize

2015-07-14 Thread Leif Lindholm
On Tue, Jul 14, 2015 at 02:59:00PM +0100, Olivier Martin wrote: > From: Brendan Jackman > > This improves performance for dumb filesystem drivers > as block sizes tend to be more 4Kb size than 1000bit OK, so serious nitpicking, but: 4KB and 1000 bytes. Change those, and Revie

Re: [edk2] [Patch] MdeModulePkg: Remove two unnecessary protocols

2015-07-14 Thread Leif Lindholm
Hi Wang Fan, On Tue, Jul 14, 2015 at 10:13:11AM +0800, Wang Fan wrote: > Remove two protocols never used in MdeModulePkg.dec. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: fanwang2 > --- > MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf | 2 -- > MdeModulePkg/MdeModu

Re: [edk2] [PATCH] EmbeddedPkg: fix PcdTimerPeriod value

2015-07-14 Thread Leif Lindholm
On Tue, Jul 14, 2015 at 10:05:14AM +0800, Haojian Zhuang wrote: > > > In GRUB, the required timer granularity is only 1ms. If interval of > > > hardware timer interrupt is 10ms in UEFI, GRUB will only get all > > > timer granularity >= 10ms. At least, the timeout of boot menu in > > > GRUB is much

Re: [edk2] [PATCH] EmbeddedPkg: fix PcdTimerPeriod value

2015-07-13 Thread Leif Lindholm
Thanks Haojian, A few comments below. It looks sane to me, but the patches to individual platforms may need some testing. As a note to my future self, I should go through these platforms and delete the default timer period from the platform-specific config files and get it from a central config f

Re: [edk2] [Patch] NetworkPkg: Do some formatting for Dhcp6Dxe.inf

2015-07-13 Thread Leif Lindholm
On Mon, Jul 13, 2015 at 02:23:06PM +0800, Wang Fan wrote: > Formatting pcd field of Dhcp6Dxe.inf. This is not formatting, it is adding a comment. It is a good thing, but the commit message is misleading. Regards, Leif > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: fa

Re: [edk2] [Linaro-uefi] [PATCH] MdePkg: ensure SafeString length functions don't access beyond MaxSize

2015-07-13 Thread Leif Lindholm
t; -Original Message- > From: Yao, Jiewen > Sent: Monday, July 13, 2015 12:11 PM > To: Leif Lindholm; edk2-devel@lists.sourceforge.net > Cc: Kinney, Michael D; Gao, Liming; linaro-u...@lists.linaro.org > Subject: RE: [Linaro-uefi] [PATCH] MdePkg: ensure SafeString length functions >

Re: [edk2] [Patch 1/2] NetworkPkg: Code logic optimization for DnsDxe and HttpDxe driver

2015-07-10 Thread Leif Lindholm
On Fri, Jul 10, 2015 at 04:19:08PM +0800, Wang Fan wrote: > Revise some errors which may lead NULL pointer be dereferenced: > * DnsDhcp.c: Paralist may be used without any initialized > * DnsHeader and RcvString may be null but be dereferenced > * HttpDriver.c: revise an if judgment > * HttpImpl.c:

[edk2] [PATCH] MdePkg: ensure SafeString length functions don't access beyond MaxSize

2015-07-10 Thread Leif Lindholm
ess.) Flip the order of the tests to prevent this behaviour. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- MdePkg/Library/BaseLib/SafeString.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdePkg/Library/BaseLib/SafeString.c

Re: [edk2] [PATCH] BaseTools: aarch64: add -fno-asynchronous-unwind-tables to gcc cflags

2015-07-09 Thread Leif Lindholm
ment in the gmane > archive, but I'm attaching it. > > Thanks > Laszlo > Date: Wed, 04 Mar 2015 11:28:20 -0600 > From: Wei Huang > To: Laszlo Ersek , edk2-devel@lists.sourceforge.net > CC: linaro-u...@lists.linaro.org, "Leif Lindholm (Linaro address)" >

[edk2] [PATCH] BaseTools: aarch64: add -fno-asynchronous-unwind-tables to gcc cflags

2015-07-09 Thread Leif Lindholm
(): ... unsupported ELF EM_AARCH64 relocation 0x0. I am aware of no current use of these tables, so explicitly disable their generation for aarch64. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- BaseTools/Conf/tools_def.template | 2 +- 1 file

Re: [edk2] [Patch] UefiCpuPkg/Library/CpuExceptionHandlerLib: Add exception type decoder

2015-07-09 Thread Leif Lindholm
ed IntelCpuPkg? Regards, Leif > For STATIC, I agree with it. I will update it then. > > Thanks! > Jeff > > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Thursday, July 09, 2015 12:04 AM > To: edk2-devel@lists.sourceforge.

Re: [edk2] [PATCH 0/2] Refine the function comments.

2015-07-08 Thread Leif Lindholm
Hi Qui, On Tue, Jul 07, 2015 at 04:41:35PM +0800, Qiu Shumin wrote: > > Qiu Shumin (2): > SecurityPkg: Refine the function comments. > CryptoPkg: Refine the function comments. > > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyNull.c| 2 +- > .../BaseCryptLibRuntimeCryptProto

Re: [edk2] [Patch] UefiCpuPkg/Library/CpuExceptionHandlerLib: Add exception type decoder

2015-07-08 Thread Leif Lindholm
Hi Jeff, I notice that this patch has already been committed, but some comments below: On Mon, Jul 06, 2015 at 04:02:06PM +0800, Jeff Fan wrote: > Add exception type decoder to print exception name string beside print > exception type value. The exception names are from IA32 SDM. > > Contributed

Re: [edk2] Proposal of Git Repo Layout for EDKII project

2015-06-03 Thread Leif Lindholm
On Wed, Jun 03, 2015 at 09:50:27AM +, Gao, Liming wrote: > Hi, all > > Now, EDKII project Git mirror is ready in GitHub > > (https://github.com/tianocore). > There > are EDKII project Repo and each package Repo. After migrate E

Re: [edk2] [PATCH] Maintainers.txt: Added Leif Lindholm as a co-maintainer

2015-05-29 Thread Leif Lindholm
On Fri, May 29, 2015 at 03:54:00PM +0100, Olivier Martin wrote: > Leif becomes a co-maintainer for the ARM Packages. Thanks! Reviewed-by: Leif Lindholm > Change-Id: Ia5380dabb993ab262285aed2c9ac12bfc19c2697 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off

[edk2] UNDI example network drivers

2015-05-21 Thread Leif Lindholm
Hi all, Does anyone know where I could find an example UNDI Ethernet device driver? / Leif -- One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+

Re: [edk2] [Patch] ArmPkg: Fix ARM assembly for BaseSynchronizationLib Increment/Decrement functions

2015-03-19 Thread Leif Lindholm
om>> >> >> Reviewed-by: Eugene Cohen mailto:eug...@hp.com>> >> >> Thanks, >> >> Tyler Smith > > I can help check in this patch once it gets an R-b from Ronald or Leif. I'd prefer a more descriptive commit message. For the code portion

Re: [edk2] Two Node ARM64 SoC Memory Corruption

2015-03-16 Thread Leif Lindholm
Hi Narinder, Is this an architectural L2 cache or an external one? If the former, you should not need any platform-specific invalidation. Can you try without your modifications, but with the patch Leo Duran sent this morning? Regards, Leif On 13 March 2015 at 03:24, Narinder Dhillon wrote: >

Re: [edk2] [PATCH v2 1/4] ArmVirtualizationPkg: build UEFI shell from source

2015-03-13 Thread Leif Lindholm
Reviewed-by: Leif Lindholm On 13/03/15 14:36, Laszlo Ersek wrote: > Including a prebuilt shell executable in the firmware binary is suboptimal > practice, especially given that the source code of the UEFI shell resides > in the same edk2 tree. Benefits of building the shell from s

Re: [edk2] [PATCH v2 2/4] ArmVirtualizationPkg/ArmVirtualizationQemu: include XHCI driver

2015-03-13 Thread Leif Lindholm
arn about XHCI support in ArmVirtualizationQemu by reading > this commit message, they (or their packagers) will also know to update > qemu to aa685789 or later (in practice that means the upcoming 2.3 > release), at least if they want to use '-device nec-usb-xhci' with edk2, >

Re: [edk2] [PATCH 0/4] ArmVirtualizationPkg, OvmfPkg: build tweaks

2015-03-11 Thread Leif Lindholm
On 11/03/15 11:28, Alexander Graf wrote: > Note that qemu commit aa685789 [1] mentioned in patches #2 and #4 is > pending a pull [2]. The commit hash is expected to stay stable [3]. >>> >>> (Meanwhile the qemu patch in question has been merged, indeed with the >>> same commit hash.) >>> >>>

Re: [edk2] [PATCH 0/4] ArmVirtualizationPkg, OvmfPkg: build tweaks

2015-03-11 Thread Leif Lindholm
On 10/03/15 13:11, Laszlo Ersek wrote: >>> Note that qemu commit aa685789 [1] mentioned in patches #2 and #4 is >>> pending a pull [2]. The commit hash is expected to stay stable [3]. > > (Meanwhile the qemu patch in question has been merged, indeed with the > same commit hash.) > >> Will enabling

Re: [edk2] [PATCH v2 0/4] ArmVirtualizationPkg: unclutter EFI_D_ERROR log

2015-03-02 Thread Leif Lindholm
.dsc > | 2 -- > 7 files changed, 20 insertions(+), 14 deletions(-) > > -- > 1.8.3.1 Of course, Olivier asked me to review patches with my ARM hat on, and out of habit I still used Leif Lindholm . For this series only, please treat my Reviewed-by: Leif L

Re: [edk2] [PATCH v2 4/4] ArmVirtualizationPkg: expose debug message bitmask on build command line

2015-03-02 Thread Leif Lindholm
On Mon, Mar 02, 2015 at 01:03:53PM +0100, Laszlo Ersek wrote: > This enables -D DEBUG_PRINT_ERROR_LEVEL=0x8040004F style command line > options. Should also mention that it clarifies some comments. > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > --- >

Re: [edk2] [PATCH v2 3/4] ArmVirtualizationPkg: PlatformIntelBdsLib: lack of QEMU kernel is no error

2015-03-02 Thread Leif Lindholm
FOUND; > +goto FreeBlobs; > + } > + Minor nitpick: This test could go directly after KernelBlob = &mKernelBlob[KernelBlobTypeKernel]; > // >// Create a new handle with a single VenHw() node device path protocol on > it, >// plus a custom Simp

Re: [edk2] [PATCH v2 2/4] ArmPlatformPkg: PEIM startup is not an error

2015-03-02 Thread Leif Lindholm
to EFI_D_LOAD | > EFI_D_INFO. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > Reviewed-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c | 2 +- > ArmPlatformPkg/PlatformPei/PlatformPei

Re: [edk2] [PATCH v2 1/4] ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors

2015-03-02 Thread Leif Lindholm
vel > (bitmask, actually) to EFI_D_LOAD | EFI_D_INFO, because the messages are > printed in relation to image loading, and they are informative. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > Reviewed-by: Ard Biesheuvel Reviewed-by: Leif Li

Re: [edk2] Structuring of ARM based SoC and Board Packages

2015-02-27 Thread Leif Lindholm
On Fri, Feb 27, 2015 at 12:08:32PM +, bhupesh.sha...@freescale.com wrote: > Sure. We understand the same. However, it seems that as we add support for > new ARM based platforms to this tree, the source code would un-necessarily > bloat > and we might end up in the same situation as we had in u

Re: [edk2] Structuring of ARM based SoC and Board Packages

2015-02-27 Thread Leif Lindholm
Hi Sakar, On Thu, Feb 26, 2015 at 10:36:18AM +, sakar.ar...@freescale.com wrote: > I see that by and large, the contents of SoC and Board Packages (ARM based) > in EDK2, are like this: > > > - Most drivers like mmc, sd, flash, timer, etc and certain Libraries > like Serial port,

[edk2] [PATCH] BaseTools: aarch64: add -fno-asynchronous-unwind-tables to cflags

2015-02-06 Thread Leif Lindholm
(): ... unsupported ELF EM_AARCH64 relocation 0x0. I am aware of no current use of these tables, so explicitly disable their generation for aarch64. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- BaseTools/Conf/tools_def.template | 2 +- 1 file

Re: [edk2] [Linaro-uefi] [PATCH 0/5] ArmPlatformPkg: Add Lan91x Dxe driver, and networking support for A15/A15 MPcore/FVP AArch64

2015-01-28 Thread Leif Lindholm
On Wed, Jan 28, 2015 at 09:33:44AM +, Ryan Harkin wrote: > On 27 January 2015 at 10:56, Leif Lindholm wrote: > > > On Tue, Jan 27, 2015 at 10:36:23AM -, Olivier Martin wrote: > > > Any reason to make the Network stack conditional? > > > One reason to

Re: [edk2] [Linaro-uefi] [PATCH 0/5] ArmPlatformPkg: Add Lan91x Dxe driver, and networking support for A15/A15 MPcore/FVP AArch64

2015-01-27 Thread Leif Lindholm
https://git.linaro.org/people/fu.wei/uefi.git/shortlog/refs/heads/LAN91 > > x_Dxe_driver_upstream > > > > Fu Wei (2): > > ArmPlatformPkg: Add conditionalised networking support for RTSM A15 > > MPcore > > ArmPlatformPkg: Add conditionalised networking supp

[edk2] [PATCH] ArmPlatformPkg: detect correct pl011 fifo depth

2015-01-20 Thread Leif Lindholm
select 16 or 32 on port initialization by checking the component revision. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- ArmPlatformPkg/Drivers/PL011Uart/PL011Uart.c | 7 +-- ArmPlatformPkg/Include/Drivers/PL011Uart.h | 8 2 files changed

[edk2] [PATCH v2 4/5] ArmVirtualizationPkg: don't use BdsLib with PlatformIntelBdsLib and INTEL_BDS

2015-01-15 Thread Leif Lindholm
With the Intel Bds, the built-in LinuxLoader is no longer accessible (or required). Use the new ArmBdsHelperLib instead of the whole of BdsLib, since the former contains the bits we need. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- ArmPlatformPkg

[edk2] [PATCH v2 3/5] ArmPkg/ArmPlatformPkg: don't use BdsLib with PlatformIntelBdsLib

2015-01-15 Thread Leif Lindholm
There is no longer a requirement for the whole of BdsLib to be included when building with -D INTEL_BDS, so conditionalise its inclusion in various places, and use ArmBdsHelperLib instead in PlatformIntelBdsLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm

[edk2] [PATCH v2 5/5] ArmPlatformPkg: enable use of IntelBds on Juno

2015-01-15 Thread Leif Lindholm
Select IntelBds instead of the ARM Bds when building with -D INTEL_BDS. This also updates ArmJunoDxe to use ArmBdsHelperLib instead of the BdsLib directly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- ArmPlatformPkg/ArmJunoPkg/ArmJuno.dsc

[edk2] [PATCH v2 1/5] ARM: conditionalise inclusion of LinuxLoader/AndroidFastboot

2015-01-15 Thread Leif Lindholm
, invert the logic and use a NO_LINUX_LOADER option to remove these components. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- ArmPkg/ArmPkg.dsc | 4 ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 4 EmbeddedPkg

[edk2] [PATCH 0/3] Improve Bds selectability on Arm

2015-01-14 Thread Leif Lindholm
The Arm ports support running the IntelBds these days, but still depend on the ArmPkg BdsLib. Break this out into a separate library, and fix up some loose ends causing problems when that happens. Leif Lindholm (3): ArmPkg: break out common Bds functions ArmPkg/ArmPlatformPkg: remove

[edk2] [PATCH 2/3] ArmPkg/ArmPlatformPkg: remove components when using PlatformIntelBdsLib

2015-01-14 Thread Leif Lindholm
: Leif Lindholm --- ArmPkg/ArmPkg.dsc | 4 ArmPlatformPkg/ArmPlatformPkg.dsc | 2 ++ ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 4 ArmPlatformPkg/Library/PlatformIntelBdsLib

Re: [edk2] [Linaro-uefi] kernel memory allocation issue with uefi

2015-01-05 Thread Leif Lindholm
On Sun, Jan 04, 2015 at 06:11:02PM +0530, varadgau...@gmail.com wrote: > I get the following error while loading the LEG-UEFI kernel [1] on a > BeagleBone Black (omap2plus_defconfig + efi stub support) when the kernel > requests memory from UEFI.: > > Shell> zImage > EFI stub: Booting Linux Kern

Re: [edk2] SetVirtualAddressMap() accesses via virtmap being installed

2014-12-22 Thread Leif Lindholm
On Mon, Dec 22, 2014 at 09:08:36AM -0800, Andrew Fish wrote: > > An issue has come up while developing the EFI support for the arm64 > > linux kernel, in particular the support for kexec which requires > > changes with respect to how we handle the virtual to physical mapping > > of runtime services

Re: [edk2] [PATCH] Increase more ARM address Pcd entries to 64-bit.

2014-11-08 Thread Leif Lindholm
Err, and I probably should have included the platform updates in the same patch... Ignore that patch, and please consider the below instead: >From 628787ae75dfb71218d6fa8551a102a0ebb95567 Mon Sep 17 00:00:00 2001 From: Leif Lindholm Date: Sat, 8 Nov 2014 10:26:53 + Subject: [PATCH] Incre

[edk2] [PATCH] Increase more ARM address Pcd entries to 64-bit.

2014-11-08 Thread Leif Lindholm
Some AArch64 platforms have RAM and flash devices >4GB. Update some additional Pcd entries to 64-bit, and change the corresponding PcdGet32 calls to PcdGet64. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- ArmPkg/ArmPkg.

[edk2] [PATCH] GenFw: don't bail out on (certain) relative relocations

2014-10-14 Thread Leif Lindholm
R_AARCH64_JUMP26/R_AARCH64_JUMP26 do not need fixups by GenFw, but these are sometimes generated by GCC 4.9. Delete the check aborting due to unhandled relocations. Signed-off-by: Leif Lindholm --- BaseTools/Source/C/GenFw/Elf64Convert.c |9 + 1 file changed, 1 insertion(+), 8

[edk2] [PATCH] ArmVExpressPkg: enable specifying firmware version string on build

2014-10-14 Thread Leif Lindholm
If FIRMWARE_VER is defined on the build command line, set gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString based on it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc |3 +++ 1 file changed, 3

Re: [edk2] [PATCH] Add .gitignore

2014-10-14 Thread Leif Lindholm
aintained in SVN, Many edk2 developers use git for their main workflow, using the official mirrors. Add a .gitignore and a BaseTools/.gitignore to prevents files generated as part of the build from cluttering up "git status" output. Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH] Add .gitignore

2014-10-10 Thread Leif Lindholm
On Fri, Oct 10, 2014 at 01:46:04PM -0700, Jordan Justen wrote: > On Fri, Oct 10, 2014 at 11:38 AM, Leif Lindholm > wrote: > > On Fri, Oct 10, 2014 at 07:09:22AM -0700, Jordan Justen wrote: > > > >> > I guess that should be in addition to keeping it here? > >

Re: [edk2] [PATCH] Add .gitignore

2014-10-10 Thread Leif Lindholm
under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ryan Harkin [removed Linaro-specific bits, rework for upstream] Signed-off-by: Leif Lindholm --- .gitignore |6 ++ BaseTools/.gitignore | 11 +++ 2 files changed, 17 insertions(+) create mode 100644 .gitigno

Re: [edk2] [PATCH] Add .gitignore

2014-10-10 Thread Leif Lindholm
On Thu, Oct 09, 2014 at 03:08:14PM -0700, Jordan Justen wrote: > On Thu, Oct 9, 2014 at 7:45 AM, Leif Lindholm > wrote: > > On Thu, Oct 09, 2014 at 06:23:18AM -0700, Jordan Justen wrote: > >> >>> diff --git a/.gitignore b/.gitignore > >> >>> new

Re: [edk2] [PATCH] Add .gitignore

2014-10-09 Thread Leif Lindholm
fied) and wildcard Conf/ (which still displays any modified tracked files). >From 6739e685e68f482512e946d38e40c542e3434103 Mon Sep 17 00:00:00 2001 From: Ryan Harkin Date: Wed, 8 May 2013 16:18:34 +0100 Subject: [PATCH] Add .gitignore While edk2 is still maintained in SVN, Many edk2 develop

Re: [edk2] [PATCH] Add .gitignore

2014-10-08 Thread Leif Lindholm
On 8 October 2014 17:56, Laszlo Ersek wrote: > Please consider adding "tags" as well. Good call. Not added as it isn't a build artefact as such, but if people would accept taking this patch to begin with, I agree that tags would be a useful addition. Regards, Leif -

[edk2] [PATCH] Add .gitignore

2014-10-08 Thread Leif Lindholm
TianoCore Contribution Agreement 1.0 Signed-off-by: Ryan Harkin [removed Linaro-specific bits] Signed-off-by: Leif Lindholm --- .gitignore | 20 1 file changed, 20 insertions(+) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 ind

Re: [edk2] [PATCH] ArmVExpressPkg: enable specifying firmware version string on build

2014-10-08 Thread Leif Lindholm
Sigh, and I generated that against the wrong branch. Here is one that actually applies on current master: >From 34f8069eb293d524824fe10efba30993c2cb1eb4 Mon Sep 17 00:00:00 2001 From: Leif Lindholm Date: Wed, 8 Oct 2014 15:20:04 +0100 Subject: [PATCH] ArmVExpressPkg: enable specifying firmw

[edk2] [PATCH] ArmVExpressPkg: enable specifying firmware version string on build

2014-10-08 Thread Leif Lindholm
If FIRMWARE_VER is defined on the build command line, set gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString based on it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc |3 +++ 1 file changed, 3

[edk2] [PATCH] Actually plug in BaseTools build on AArch64

2014-08-12 Thread Leif Lindholm
Support for building BaseTools on AArch64 is available in the tree, but not currently "plugged in". This patch adds the required snippet. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- Source/C/Makefiles/header.makefile |4 1 file

[edk2] [PATCH] Whitespace fixup for ARM Directories

2014-07-09 Thread Leif Lindholm
The result of running: find ArmP* -not -name "*.sh" -not -name "*.patch" -not -name "*.py" -exec unix2dos {} \; Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- ArmPkg/Drivers/ArmGic/ArmGicLib.c |2 +

[edk2] [PATCH 2/2] ArmPlatformPkg CRLF fixup.

2014-02-11 Thread Leif Lindholm
The result of 'find . -type f -exec unix2dos {} \;'. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- .../Scripts/uefi-aarch64-bootstrap/LICENSE.TXT | 56 +-- .../Scripts/uefi-aarch64-bootstrap/Makefile| 192 +- .../Sc

[edk2] [PATCH 1/2] ArmPkg CRLF fixup.

2014-02-11 Thread Leif Lindholm
The result of 'find . -type f -exec unix2dos {} \;'. Affects only one file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm --- ArmPkg/Library/ArmLib/AArch64/AArch64Mmu.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --gi

Re: [edk2] edk2/edksetup.sh patch to solve command line parameter

2014-01-30 Thread Leif Lindholm
On Wed, Jan 29, 2014 at 01:59:58PM -0800, Jordan Justen wrote: > Whoops. Looks like I also submitted a patch for the > missing s on BaseTools. > > On 2014-01-29 08:50:50, Leif Lindholm wrote: > > Actually, there is another issue with the new edksetup.sh - it returns

Re: [edk2] edk2/edksetup.sh patch to solve command line parameter

2014-01-29 Thread Leif Lindholm
Hi Liming, This commit (15192) does not do what was described. It permits '. edksetup.sh BaseTool', rather than what was described in the text - '. edksetup.sh BaseTools'. (missing a trailing 's') Regards, Leif On 27 January 2014 07:46, Gao, Liming wrote: > Parmeshwr: > > Your patch is g

Re: [edk2] edk2/edksetup.sh patch to solve command line parameter

2014-01-29 Thread Leif Lindholm
Actually, there is another issue with the new edksetup.sh - it returns success (0) regardless of whether the executions succeeds or not. The attached patch resolves both of these issues. Contributed-under: TianoCore Contribution Agreement 1.0 On 29 January 2014 16:31, Leif Lindholm wrote

Re: [edk2] PE/COFF machine type for ARM V7 binaries

2014-01-15 Thread Leif Lindholm
(I responded to the original thread on linux-kernel, but I'll respond here to so as not to leave it hanging.) On 15 January 2014 03:06, Roy Franz wrote: > I'm trying to nail down what the proper Machine Type value in the > PE/COFF header should be for ARM linux images with the stub. > > The PE/CO

Re: [edk2] GUID for Flattened Device Tree in configuration table.

2013-12-09 Thread Leif Lindholm
) further qualifying the name > to make it clear which agent in the ecosystem "owns" the definition of the > device tree. > > Tim > > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, December 09, 2013 9:41 AM > To:

Re: [edk2] GUID for Flattened Device Tree in configuration table.

2013-12-09 Thread Leif Lindholm
> So, I suggest to remove prefix EFI_. > > -Original Message- > From: Grant Likely [mailto:grant.lik...@secretlab.ca] > Sent: Monday, December 9, 2013 8:45 PM > To: Leif Lindholm; edk2-devel@lists.sourceforge.net; Roy Franz > Subject: [edk2] GUID for Flattened Device T

Re: [edk2] ARM/BDS: skip initrd if not found

2013-11-19 Thread Leif Lindholm
Hi Ryan, On Tue, Nov 19, 2013 at 08:30:25AM +, Ryan Harkin wrote: > Hi Olivier/Steve/Leif/whoever is interested, > > I have a problem I'm trying to solve and I don't think there is a proper > solution using the current ARM BDS. > > Basically, some of Linaro's releases are failing to boot "ou

Re: [edk2] [PATCH] MdeModulePkg: fix compilation errors

2013-06-24 Thread Leif Lindholm
On 24 June 2013 10:08, Ryan Harkin wrote: > On 24 June 2013 08:44, Dong, Eric wrote: >> This change is not correct, the "Buffer" variable is not defined. > > Hmmm, isn't that curious! I've not really looked that this change > before, which is my mistake for accepting it, but you're right, Buffer