Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-02 Thread Ard Biesheuvel
he list that fix that) Regards, Ard. > From: Jordan Justen [mailto:jordan.l.jus...@intel.com] > Sent: Thursday, July 02, 2015 3:04 PM > To: Andrew Fish; edk2-devel@lists.sourceforge.net > Subject: Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU > ld linker scrip

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-02 Thread Gao, Liming
those settings as the default one. Thanks Liming -Original Message- From: Jordan Justen [mailto:jordan.l.jus...@intel.com] Sent: Thursday, July 02, 2015 3:04 PM To: Andrew Fish; edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-02 Thread Andrew Fish
> On Jul 2, 2015, at 12:03 AM, Jordan Justen wrote: > > On 2015-07-01 23:22:37, Andrew Fish wrote: >>> On Jul 1, 2015, at 11:08 PM, Jordan Justen >>> wrote: >>> On 2015-07-01 22:35:12, Gao, Liming wrote: Ard: Good to know --script option can be appended and work fine. >>> >>>

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-02 Thread Jordan Justen
On 2015-07-01 23:22:37, Andrew Fish wrote: > > On Jul 1, 2015, at 11:08 PM, Jordan Justen > > wrote: > > > >> On 2015-07-01 22:35:12, Gao, Liming wrote: > >> Ard: > >> Good to know --script option can be appended and work fine. > > > > So, --script will be specified twice to ld. This seems lik

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-01 Thread Ard Biesheuvel
On 2 July 2015 at 08:22, Andrew Fish wrote: > > > Sent from my iPhone > >> On Jul 1, 2015, at 11:08 PM, Jordan Justen wrote: >> >>> On 2015-07-01 22:35:12, Gao, Liming wrote: >>> Ard: >>> Good to know --script option can be appended and work fine. >> >> So, --script will be specified twice to ld

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-01 Thread Gao, Liming
Jordan: On VS tool chain, we override /ALIGN option to configure 4K alignment for runtime driver. [BuildOptions.X64.EDKII.DXE_RUNTIME_DRIVER] MSFT:*_*_*_DLINK_FLAGS = /ALIGN:4096 Thanks Liming -Original Message- From: Justen, Jordan L Sent: Thursday, July 02, 2015 2:08 PM To: Gao,

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-01 Thread Andrew Fish
Sent from my iPhone > On Jul 1, 2015, at 11:08 PM, Jordan Justen wrote: > >> On 2015-07-01 22:35:12, Gao, Liming wrote: >> Ard: >> Good to know --script option can be appended and work fine. > > So, --script will be specified twice to ld. This seems like a very > fragile implementation of a

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-01 Thread Ard Biesheuvel
On 2 July 2015 at 08:08, Jordan Justen wrote: > On 2015-07-01 22:35:12, Gao, Liming wrote: >> Ard: >> Good to know --script option can be appended and work fine. > > So, --script will be specified twice to ld. This seems like a very > fragile implementation of a new UEFI feature. > > Is this the

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-01 Thread Jordan Justen
On 2015-07-01 22:35:12, Gao, Liming wrote: > Ard: > Good to know --script option can be appended and work fine. So, --script will be specified twice to ld. This seems like a very fragile implementation of a new UEFI feature. Is this the long term plan? Do Visual Studio based builds do somethi

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-01 Thread Gao, Liming
Ard: Good to know --script option can be appended and work fine. Thanks Liming -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, July 02, 2015 1:05 PM To: Justen, Jordan L Cc: Gao, Liming; Liu, Yingke D; edk2-devel@lists.sourceforge.net Subject:

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-01 Thread Ard Biesheuvel
On 2 July 2015 at 02:54, Jordan Justen wrote: > On 2015-07-01 17:41:11, Gao, Liming wrote: >> Jordan: >> Agree. We will follow this rule, apply the patch and push it >> without any modification. > > My point is that if there is a mistake, we should not bother to update > the log message to fix

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-01 Thread Gao, Liming
This feature is complete. But, there is no example now. So, I plan to add the example in OVMF to show how to enable it. -Original Message- From: Justen, Jordan L Sent: Thursday, July 2, 2015 8:54 AM To: Gao, Liming; Liu, Yingke D; Ard Biesheuvel Cc: edk2-devel@lists.sourceforge.net Subj

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-01 Thread Jordan Justen
On 2015-07-01 17:41:11, Gao, Liming wrote: > Jordan: > Agree. We will follow this rule, apply the patch and push it > without any modification. My point is that if there is a mistake, we should not bother to update the log message to fix that mistake. Hopefully we can just be more careful with

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-01 Thread Gao, Liming
Jordan: Agree. We will follow this rule, apply the patch and push it without any modification. gcc-4k is added for new UEFI2.5 Properties Table. When enable this feature, gcc-4k script will be required for RUNTIME driver. It can be configured in [BuildOptions] of DSC file for RUNTIME drive

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-01 Thread Jordan Justen
On 2015-07-01 01:34:56, Liu, Yingke D wrote: > Hi Ard, > > Thanks for the comments, I have updated the log message. For future reference, I think you should not bother to update the log message. It is a bad practice, and the git archive will not see the updated log message anyhow. It should also

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-01 Thread Liu, Yingke D
Hi Ard, Thanks for the comments, I have updated the log message. Thanks, Dennis -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Wednesday, July 01, 2015 16:12 To: Liu, Yingke D Cc: edk2-devel@lists.sourceforge.net; Justen, Jordan L; Gao, Liming Subject:

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-07-01 Thread Ard Biesheuvel
On 30 June 2015 at 13:02, Gao, Liming wrote: > Reviewed-by: Liming Gao > Hello Dennis, Thanks for merging this. Next time, could you please keep the subject line as well? > Subject: [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker > script You have used this instead: > T

Re: [edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-06-30 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday, June 30, 2015 7:00 PM To: Liu, Yingke D; Gao, Liming; edk2-devel@lists.sourceforge.net Cc: Ard Biesheuvel Subject: [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU l

[edk2] [PATCH] BaseTools: fix a syntax error in 4 KB aligned GNU ld linker script

2015-06-30 Thread Ard Biesheuvel
There needs to be a space between the output section name and the colon, i.e., .text : ALIGN(0x1000) ^ Fix this for all output sections Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- BaseTools/Scripts/gcc-4K-align-ld-script | 10 +- 1