Re: [Bug] isearch errors when org-fold-core-style is 'overlays

2022-12-29 Thread Samuel Wales
more below. On 12/29/22, Ihor Radchenko wrote: > Samuel Wales writes: > >> possibly related: are links still not searchable with iserch without >> being in reveal mode or similar? [9.4 here.) > > Unrelated. > The reported issue is related to the new org-fold implementation. ok didn't men to

Re: ob-shell intentions and paperwork (was Bash results broken?)

2022-12-29 Thread Matt
On Thu, 29 Dec 2022 06:08:59 -0500 Ihor Radchenko wrote --- > Does it mean that you are willing to maintain lisp/ob-shell.el? > We usually give write access to the maintainers and regular > contributors. AFAIR, you previously contributed to WORG but not to Org > core. You're

Re: [BUG] ob-R.el: extra empty data.frame columns generated from plain lists after recent change [9.6 (release_9.6-3-ga4d38e @ /usr/share/emacs/30.0.50/lisp/org/)]

2022-12-29 Thread Berry, Charles
Bastien et al, > On Dec 29, 2022, at 8:00 AM, Bastien Guerry wrote: > > I think it would make sense to convert Elisp lists into R lists > directly. Jeremie, would you be okay with this? > Perhaps there are some hiccups. The R `data.frame' type is a list with some added attributes. In that

Re: [PATCH] oc-csl: Improve LaTeX bibliography formatting

2022-12-29 Thread András Simonyi
Dear All, On Thu, 29 Dec 2022 at 11:14, Ihor Radchenko wrote: > LGTM! > Feel free to push upstream. thanks Ihor, I've pushed the changes to main as commit https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=29103fc60 best wishes, András

Re: For your consideration: Extending org-info-js with additional hooks

2022-12-29 Thread David O'Toole
Ok, I will get started on this :) On Thu, Dec 29, 2022 at 10:38 AM Bastien Guerry wrote: > Ihor Radchenko writes: > > > Bastien, since the activity around org-info-js revived after a long > > delay, should we move the code out of worg into a separate repo? > > Yes, definitely. David, would

Re: [PATCH] ob-core: add org-confirm-babel-evaluate-cell custom variable

2022-12-29 Thread Ihor Radchenko
Bastien Guerry writes: > I've skimmed through the discussion but I'm not entirely clear about > the situation. > > Has the situation changed between 9.5 and 9.6? Tom first message > seems to suggest it did, but etc/ORG-NEWS does not say. I considered this change as a bugfix. Though it was more

Re: [PATCH] ob-core: add org-confirm-babel-evaluate-cell custom variable

2022-12-29 Thread Max Nikulin
On 29/12/2022 22:58, Bastien Guerry wrote: From: Tom Gillespie Date: Sat, 10 Dec 2022 12:11:17 -0800 Subject: [PATCH 1/2] ob-core: add org-confirm-babel-evaluate-cell custom variable ... Has the situation changed between 9.5 and 9.6? Yes, it has. In 9.6 C-c C-c for #+begin_src elisp :var

Re: [MAINTENANCE] Org orphanage?

2022-12-29 Thread Bastien
Ihor Radchenko writes: > Bastien writes: > >> I think it is a very good idea and a natural evolution of org-contrib, >> thanks for suggesting this. >> ... >> We can announce this along with the Org 9.6 release. > > So, we now have https://orgmode.org/worg/org-orphanage.html > > It is very bare

Re: [BUG] ob-R.el: extra empty data.frame columns generated from plain lists after recent change [9.6 (release_9.6-3-ga4d38e @ /usr/share/emacs/30.0.50/lisp/org/)]

2022-12-29 Thread Bastien Guerry
I think it would make sense to convert Elisp lists into R lists directly. Jeremie, would you be okay with this? Ihor Radchenko writes: > Or I may need to put a special clause regarding ob-R into the NEWS > item. ... that way we don't need such a special clause regarding ob-R. 2 cts, --

Re: [PATCH] ob-core: add org-confirm-babel-evaluate-cell custom variable

2022-12-29 Thread Bastien Guerry
Ihor Radchenko writes: > Tom Gillespie writes: > >> From 4a78e1b5ea98dee569ff690037c661ab5c300194 Mon Sep 17 00:00:00 2001 >> From: Tom Gillespie >> Date: Sat, 10 Dec 2022 12:11:17 -0800 >> Subject: [PATCH 1/2] ob-core: add org-confirm-babel-evaluate-cell custom >> variable > > Bastien, may

Re: [PATCH] oc-csl: Improve LaTeX bibliography formatting

2022-12-29 Thread Bastien Guerry
Ihor Radchenko writes: > I don't think we have an example. > Probably, we can create etc/org-news-images folder, set :DIR: property > in etc/ORG-NEWS to that folder, and then use attachments. I suggest we don't go in that direction: I'd rather keep etc/ORG-NEWS as a self-contained file. Can we

Re: For your consideration: Extending org-info-js with additional hooks

2022-12-29 Thread Bastien Guerry
Ihor Radchenko writes: > Bastien, since the activity around org-info-js revived after a long > delay, should we move the code out of worg into a separate repo? Yes, definitely. David, would you like to set up a new repository with the code from the org-info-js directory here:

Re: Babel (scheme): Evaluation errors are not shown

2022-12-29 Thread Bastien Guerry
Hi Rudolf and Ihor, Ihor Radchenko writes: > Rudolf Adamkovič writes: > >> Ihor Radchenko writes: >> >>> Note that we currently have no maintainer for ob-scheme and hence can >>> only provide very limited support. New features are hard for us >>> without experience with scheme and geiser. >>

Re: org-insert-structure-template

2022-12-29 Thread Ihor Radchenko
Ihor Radchenko writes: > C-c C-x , is actually not available (it is bound to timer). > I went with C-c C-x s. > > See the attached patch. Applied onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5bc5add32 -- Ihor Radchenko // yantar92, Org mode contributor, Learn

Re: [PATCH] Display ?? for missing citations on export (was: [BUG] Exporting non-existent citations in oc-basic [9.6-pre (release_9.5.5-989-gd972cf @ /home/yantar92/.emacs.d/straight/build/org/)])

2022-12-29 Thread Ihor Radchenko
Ihor Radchenko writes: > The problem with error has been solved in another patch. > > However, the non-existing keys are exported awkwardly as "(, )". > > I suggest approaching the missing citations similar to LaTeX and > highlight them with ??: (??, ) by default. > > See the attached patch.

[PATCH] Throw an error when bibliography field is not properly parsed (was: [PATCH] oc-basic.el: Fix wrong type for the editors field when parsing JSON.)

2022-12-29 Thread Ihor Radchenko
Ihor Radchenko writes: >> As explained in the ChangeLog entry, this points to a more general issue >> where >> `org-cite-basic--get-field' is expected to return nil or a string, but calls >> `org-cite-basic--get-entry' that may return an association list. I am not >> sure >> how to fix that

Re: [DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python?

2022-12-29 Thread Bastien
Ihor Radchenko writes: > Marked for future removal in ob-python.el. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=21741a469 Thanks! -- Bastien

Re: ob-shell intentions and paperwork (was Bash results broken?)

2022-12-29 Thread Bastien Guerry
Ihor Radchenko writes: > Bastien, could you please check Matt's copyright paperwork record in > FSF? Matt's copyright paperwork are OK, I added him as FSF-copyrighted contributor on Worg. > Does it mean that you are willing to maintain lisp/ob-shell.el? Until Matt wants to be the maintainer

Re: [FR] Add support for racket images in org-babel

2022-12-29 Thread Ihor Radchenko
dalanicolai writes: >> You likely need to extend `org-babel-scheme--table-or-string' to >> understand Image: type. >> > > It looks to me that when `org-babel-execute:scheme` gets executed, then the > result will not get inserted as a link, as that would require the results > type 'file', right?

Re: [DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python?

2022-12-29 Thread Ihor Radchenko
Bastien Guerry writes: > Ihor Radchenko writes: > >> I am leaning towards announcing the deprecation in the coming >> release. > > Agreed, let's move forward in this direction for the release. Marked for future removal in ob-python.el.

Re: [Bug] isearch errors when org-fold-core-style is 'overlays

2022-12-29 Thread Ihor Radchenko
Ihor Radchenko writes: > Part of the problem is some undocumented behaviour of isearch. > I will need to consult Emacs devs before fixing. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60399 -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at

Re: Problems with LaTeX export for $x\text{foo $x$}$-like construts?

2022-12-29 Thread Ihor Radchenko
Ihor Radchenko writes: > Unfortunately, I do not see an easy solution without hitting parser > performance. Our general approach is to avoid forward-parsing as much as > possible with an exception to paired brackets (because Elisp allows > parsing paired brackets fast using C-level code).

Re: ob-shell intentions and paperwork (was Bash results broken?)

2022-12-29 Thread Ihor Radchenko
Bastien, could you please check Matt's copyright paperwork record in FSF? Matt writes: > On Wed, 21 Dec 2022 01:17:50 -0500 Matt wrote --- > > > Currently, though, I'm refactoring the ob-shell tests to remove dependency > on ob-shell-test.org and to stop the suite from littering. >

Re: Problems with LaTeX export for $x\text{foo $x$}$-like construts?

2022-12-29 Thread Ihor Radchenko
alain.coch...@unistra.fr writes: > (I don't understand why you quoted the part of my message related to > things which work as expected, though.) (because I skipped them mentally :]) -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at .

Re: Problems with LaTeX export for $x\text{foo $x$}$-like construts?

2022-12-29 Thread Alain . Cochard
Ihor Radchenko writes on Thu 29 Dec 2022 10:04: > This is to be expected because [...] Thanks for taking the time to explain. (I don't understand why you quoted the part of my message related to things which work as expected, though.) -- EOST (École et Observatoire des Sciences de la Terre)

Re: [PATCH] oc-csl: Improve LaTeX bibliography formatting

2022-12-29 Thread Ihor Radchenko
András Simonyi writes: > Dear All, > I have attached a new version of the patch with added ascii "illustrations". > best wishes, > András LGTM! Feel free to push upstream. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org

Re: Problems with LaTeX export for $x\text{foo $x$}$-like construts?

2022-12-29 Thread Ihor Radchenko
alain.coch...@unistra.fr writes: > Version used: release_9.6-149-g554935 > > With an org file containing only > >#+begin_export latex >$x \text{foo $y$}$ > >\(x \text{foo \(y\)}\) > >$x \text{foo \(y\)}$ > >\(x \text{foo $y$}\) >#+end_export > > the pdf generated upon

Re: Problem with multi-occur search when restricted to region

2022-12-29 Thread Ihor Radchenko
alain.coch...@unistra.fr writes: > Ihor Radchenko writes on Tue 27 Dec 2022 13:43: > > > Can you try the attached patch? > > It did not work with the version I initially used: > >release_9.6-149-g554935.dirty > > but it works OK with > >release_9.6-149-g554935 Fixed on main then. For

Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

2022-12-29 Thread Ihor Radchenko
Ihor Radchenko writes: >> There is a race condition between writing the contents of the graphics >> file to disk and emacs checking the file size. My guess is that this is >> causing the problem (and that the same failure applies for emacs-2{6,7}, >> since only the emacs-28 reports the exact

Re: [Bug] isearch errors when org-fold-core-style is 'overlays

2022-12-29 Thread Ihor Radchenko
Samuel Wales writes: > possibly related: are links still not searchable with iserch without > being in reveal mode or similar? [9.4 here.) Unrelated. The reported issue is related to the new org-fold implementation. The old issue with searching links is known. It is simply because isearch

org-table: mark a cell

2022-12-29 Thread Uwe Brauer
Hi Does anybody know about a way (or a package) that allows me to mark a cell of table, even if it is multi-line? Like | mark the cell below| || | This is text but | | more text, and more| | that is enough.| | Please mark this cell. |