Re: [PATCH] Allow external libraries (org-roam) to supply org-id locations

2024-03-17 Thread Rick Lupton
Thanks, I hadn't understood the significance of named functions vs variables for advice. But now I realise this is not solving the same problem as the original patch. The point is that I was thinking org-roam should advise/modify/hook the specific function `org-id-find' [to find ids in its

Re: [BUG] [PATCH] ox-odt: Avoid warning when everything is fine [9.6.21 ( @ /nix/store/m6x04fr6nmhxk44qr0m8xsyr8vapppgr-emacs-packages-deps/share/emacs/site-lisp/elpa/org-9.6.21/)]

2024-03-17 Thread Damien Cassou
Ihor Radchenko writes: > It would be nice to attach the patch :) I'm sorry. Here it is. -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill >From 9dd17fcb7c774f148166d999fd1d021dae9fda3b Mon Sep 17 00:00:00 2001 From:

Re: Org-attach risks

2024-03-17 Thread Kepa
Kepa writes: >/Each time I change the DIR property for attachments, I have to answer / >/correctly two questions: if I want to move every file to the new path, and if / >/I want to delete the old folder./ > >/Is it possible to not receive these questions?/ >/For me, it's a big risk I don't

bug? org-babel-comint-with-output return value type

2024-03-17 Thread Matt
Looking at the last patch of https://list.orgmode.org/18e4deaa1bd.ff0f87fa694858.5955779335024266...@excalamus.com/, I would expect a reaction of something like, "WTF is all that weird org-trim string-join stuff on the prompt filter?" --- lisp/ob-comint.el | 7 --- 1 file changed, 4

Re: [BUG] Prompt appears in async shell results

2024-03-17 Thread Matt
On Mon, 19 Feb 2024 12:07:55 +0100 Ihor Radchenko wrote --- > Matt m...@excalamus.com> writes: > > > - Split prompt filtering and input echoing into two filters > > + this seems to imply a =-hook= or =-functions= type implementation > > Not necessarily. You may just split the

Re: [BUG] [PATCH] ox-odt: Avoid warning when everything is fine [9.6.21 ( @ /nix/store/m6x04fr6nmhxk44qr0m8xsyr8vapppgr-emacs-packages-deps/share/emacs/site-lisp/elpa/org-9.6.21/)]

2024-03-17 Thread Ihor Radchenko
Damien Cassou writes: > In my unit tests, I don't want to see any LaTeX-related warnings because > they don't use that. I thus changed my unit-tests to force :with-latex > to be 'verbatim. But this still requires this patch. It would be nice to attach the patch :) -- Ihor Radchenko //

Re: Things got very slow: profiler output

2024-03-17 Thread Ihor Radchenko
William Denton writes: > On Saturday, March 16th, 2024 at 14:56, Ihor Radchenko > wrote: > >> Did you try setting org-highlight-latex-and-related to nil? > > That did it! Thank you! Org is back to normal, fast and responsive. What > do you make of all this? Was it just something about my

[BUG] [PATCH] ox-odt: Avoid warning when everything is fine [9.6.21 ( @ /nix/store/m6x04fr6nmhxk44qr0m8xsyr8vapppgr-emacs-packages-deps/share/emacs/site-lisp/elpa/org-9.6.21/)]

2024-03-17 Thread Damien Cassou
Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See https://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org mailing list.

Re: How do I link to a specific line in an org-babel block?

2024-03-17 Thread Ihor Radchenko
Rudi C writes: > Thanks, that works great. Can these work with ID links, too? > (`[[id:9bbb6468-2907-4e74-a4d1-2e391e33e0fe::...]]`) Yes, on the latest main, where we support search strings in id: links. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at

Re: Things got very slow: profiler output

2024-03-17 Thread William Denton
On Saturday, March 16th, 2024 at 14:56, Ihor Radchenko wrote: > Did you try setting org-highlight-latex-and-related to nil? That did it! Thank you! Org is back to normal, fast and responsive. What do you make of all this? Was it just something about my individual setup? (In fact I now

Re: Subject: cannot export asynchronously because of org-fold-core--update-buffer-folds

2024-03-17 Thread Nasser Alkmim
Alan Schmitt writes: > > The document header was not the problem, as it happened with any > file. The core of the issue is that the org version used to initiate the > export must be the same than the org version run in the asynchronous > export process, as bytecode from org is passed between

Re: Subject: cannot export asynchronously because of org-fold-core--update-buffer-folds

2024-03-17 Thread Nasser Alkmim
Alan Schmitt writes: > > The document header was not the problem, as it happened with any > file. The core of the issue is that the org version used to initiate the > export must be the same than the org version run in the asynchronous > export process, as bytecode from org is passed between

Re: How do I link to a specific line in an org-babel block?

2024-03-17 Thread Rudi C
Thanks, that works great. Can these work with ID links, too? (`[[id:9bbb6468-2907-4e74-a4d1-2e391e33e0fe::...]]`) On Sun, Mar 17, 2024 at 4:47 PM Ihor Radchenko wrote: > Rudi C writes: > > > How do I link to a specific line in an org-babel block? > > a.org: > > #+begin_src emacs-lisp >

Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

2024-03-17 Thread Matt
On Sun, 17 Mar 2024 17:26:48 +0100 Max Nikulin wrote --- > On 17/03/2024 20:42, Matt wrote: > > On Sun, 17 Mar 2024 11:31:00 +0100 Ihor Radchenko wrote --- > > > > > > (1) revert the commit; (2) re-apply the > > > commit version with the correct author attribution.

Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

2024-03-17 Thread Max Nikulin
On 17/03/2024 20:42, Matt wrote: On Sun, 17 Mar 2024 11:31:00 +0100 Ihor Radchenko wrote --- > > (1) revert the commit; (2) re-apply the > commit version with the correct author attribution. Done. 1. git revert 2. make changes (e.g. emacs followed by *type-type-type* or some

Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

2024-03-17 Thread Ihor Radchenko
Matt writes: > > We should avoid force pushing unless something is terribly broken. > > What you may do instead is (1) revert the commit; (2) re-apply the > > commit version with the correct author attribution. > > Done. > ... > I added a little section within copyright: >

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

2024-03-17 Thread Ihor Radchenko
Leo Butler writes: > Attached is the updated patch. In addition, I have written three > regression tests that are attached in a separate patch. Thanks! Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=80615195c

Re: [BUG] [PATCH] org-babel-execute-buffer: Prevent executing non-code blocks [9.6.20 ( @ /home/cassou/.emacs.d/lib/org/lisp/)]

2024-03-17 Thread Ihor Radchenko
Gerard Vermeulen writes: >> (setq org-babel-default-header-args:text '((:eval . "no"))) >> >> to your config. > > Is it possible to make org-lint recognize those settings? > > I have the kludge > > (defun org-babel-execute:text (_body _params) >"NO-OP to silence warnings." nil) > > in my

Re: Reproducible work with natively compiled Emacs

2024-03-17 Thread Ihor Radchenko
Pedro Andres Aranda Gutierrez writes: > Bluntly speaking, yes. There is this instance not too long ago where we had > the slow down and I was trying to isolate the source. One of my possible > suspects was that I might not have the right version of the eln file, because > the creation

Re: Things got very slow: profiler output

2024-03-17 Thread Ihor Radchenko
Bruno Cardoso writes: >> It is a few times faster. And the profiler shows no slowdown, AFAIU. >> Is the problem solved? >> > > Hi Ihor. I accidentally cut out part of my last reply, sorry. > > Yes, it looks like the situation greatly improved on latest main. I guess the > problem is solved on

Re: Table column formula with remote reference

2024-03-17 Thread Ihor Radchenko
Wu Ming writes: > Very clear now. Thank you. But I was mostly confounded by references > $0 and #0 versus the @@# (and $$#) you just described the processing > of. Don’t want to abuse your time. I can figure it out when needed. > But if you feel inclined to unravel this little detail of the

Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

2024-03-17 Thread Matt
On Sun, 17 Mar 2024 11:31:00 +0100 Ihor Radchenko wrote --- > Matt m...@excalamus.com> writes: > > > First, would you like me to update the commit? If so, I will need > > guidance. The correct procedure to change the author after committing to > > remote is unclear to me. I

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

2024-03-17 Thread Leo Butler
On Sun, Mar 17 2024, Ihor Radchenko wrote: > Leo Butler writes: > I'd prefer to keep this information in the INFO channel. It will be more consistent. >> >> Apologies, I messed up the patch in the previous email. >> >> Attached is a patch that compiles cleanly and uses INFO. > >

Re: How do I link to a specific line in an org-babel block?

2024-03-17 Thread Ihor Radchenko
Rudi C writes: > How do I link to a specific line in an org-babel block? a.org: #+begin_src emacs-lisp (message "Hello world!") (message "Hello other worlds!!!") ; (ref:greetworlds) #+end_src b:org [[./a.org::(greetworlds)]] See https://orgmode.org/manual/Literal-Examples.html > I tried

Re: Things got very slow: profiler output

2024-03-17 Thread Bruno Cardoso
On 2024-03-16, 21:14 +, Ihor Radchenko wrote: > > It is a few times faster. And the profiler shows no slowdown, AFAIU. > Is the problem solved? > Hi Ihor. I accidentally cut out part of my last reply, sorry. Yes, it looks like the situation greatly improved on latest main. I guess the

Re: [BUG] [PATCH] org-babel-execute-buffer: Prevent executing non-code blocks [9.6.20 ( @ /home/cassou/.emacs.d/lib/org/lisp/)]

2024-03-17 Thread Gerard Vermeulen
On 16.03.2024 12:48, Ihor Radchenko wrote: Yes. You can add #+property: header-args:text :eval no on top of your Org file or add (setq org-babel-default-header-args:text '((:eval . "no"))) to your config. Is it possible to make org-lint recognize those settings? I have the kludge

Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

2024-03-17 Thread Ihor Radchenko
Matt writes: > > For future, we prefer keeping the original commit author in the "author" > > field of the commits - this is important to keep track of the number of > > changed lines for contributors without FSF copyright assignment. > > Thank you for letting me know this is an issue. > >

Re: Reproducible work with natively compiled Emacs

2024-03-17 Thread Pedro Andres Aranda Gutierrez
Hi Bluntly speaking, yes. There is this instance not too long ago where we had the slow down and I was trying to isolate the source. One of my possible suspects was that I might not have the right version of the eln file, because the creation timestamp was seeing with ls-l really made me doubt

Re: [PATCH] Allow external libraries (org-roam) to supply org-id locations

2024-03-17 Thread Ihor Radchenko
"Rick Lupton" writes: > On Wed, 13 Mar 2024, at 12:30 PM, Ihor Radchenko wrote: >> I think that we can do it simpler. [...] >> The idea is to use Emacs' advice machinery to allow third-party code >> alter the functions stored in link parameters. > > I was avoiding this because I thought it was

Re: Reproducible work with natively compiled Emacs

2024-03-17 Thread Ihor Radchenko
Pedro Andres Aranda Gutierrez writes: > In practice, I was not able to delete the .eln files from a make native. I am wondering why you wanted to run make native. When I added that target, it was mostly to test inconsistencies between make single and make native. However, AFAIU, there should be

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

2024-03-17 Thread Ihor Radchenko
Leo Butler writes: >>> I'd prefer to keep this information in the INFO channel. >>> It will be more consistent. > > Apologies, I messed up the patch in the previous email. > > Attached is a patch that compiles cleanly and uses INFO. Thanks! > + (frame (let ((selection > +

How do I link to a specific line in an org-babel block?

2024-03-17 Thread Rudi C
How do I link to a specific line in an org-babel block? I tried using [[file:.../my.org::search-term]] , but this only works for jumping to a heading, not an arbitrary line. (It does work for non-org files.) PS: Please use Reply to All.

How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

2024-03-17 Thread Matt
On Sat, 16 Mar 2024 11:11:38 +0100 Ihor Radchenko wrote --- > I notice that you changed the commit author and only referenced Aaron in > Submitted By: metadata. > > For future, we prefer keeping the original commit author in the "author" > field of the commits - this is important

Re: Reproducible work with natively compiled Emacs

2024-03-17 Thread Max Nikulin
On 17/03/2024 13:13, Pedro Andres Aranda Gutierrez wrote: In practice, I was not able to delete the .eln files from a make native. In order to have a more controlled environment, I delete them _before_ I refresh my local org-mode/main directory, and then do a make native after refreshing my

Re: Reproducible work with natively compiled Emacs

2024-03-17 Thread Pedro Andres Aranda Gutierrez
Hi Ihor. In practice, I was not able to delete the .eln files from a make native. In order to have a more controlled environment, I delete them _before_ I refresh my local org-mode/main directory, and then do a make native after refreshing my local copy. Same happened when testing