Re: [Emc-developers] I would like to contribute a "modbus to hal" component, AKA mb2hal.

2012-10-27 Thread Sebastian Kuzminsky
On 10/27/2012 10:47 AM, Victor Rocco wrote: > Attached is the patch. That fixed it, thanks. Pushed to master. -- Sebastian Kuzminsky -- WINDOWS 8 is here. Millions of people. Your app in 30 days. Visit The Windows

Re: [Emc-developers] New PCI based system for LinuxCNC

2012-10-27 Thread Sebastian Kuzminsky
On 10/27/2012 09:20 AM, Bence Kovács wrote: > Thank you a lot. Could you push the changes we made based on your > comments? Thanks for the quick fixes :-) I rebased your commits on top of John Thornton's 7i77 docs commit from this morning and pushed it. Be careful of the rebase next time you w

Re: [Emc-developers] I would like to contribute a "modbus to hal" component, AKA mb2hal.

2012-10-27 Thread Victor Rocco
> -Mensaje original- > De: Les Newell [mailto:les.new...@fastmail.co.uk] > Enviado el: Jueves, 25 de Octubre de 2012 10:43 a.m. > Para: EMC developers > Asunto: Re: [Emc-developers] I would like to contribute a "modbus to hal" component, AKA mb2hal. > > >Yes. I originally wrote it to get my

Re: [Emc-developers] I would like to contribute a "modbus to hal" component, AKA mb2hal.

2012-10-27 Thread Victor Rocco
> -Mensaje original- > De: Sebastian Kuzminsky [mailto:s...@highlab.com] > Enviado el: Sábado, 27 de Octubre de 2012 11:28 a.m. > Para: EMC developers > CC: Victor Rocco > Asunto: Re: [Emc-developers] I would like to contribute a "modbus to hal" component, AKA mb2hal. > > Hi Victor, I noti

Re: [Emc-developers] New PCI based system for LinuxCNC

2012-10-27 Thread Bence Kovács
Hello > The driver builds with compile-time warnings on Lucid: > > /home/seb/emc2.git/src/hal/drivers/hal_gm.c:1142: warning: > ‘CAN_Reset’ defined but not used > /home/seb/emc2.git/src/hal/drivers/hal_gm.c:1151: warning: > ‘CAN_SetBaud’ defined but not used > I implemented all low leve

Re: [Emc-developers] I would like to contribute a "modbus to hal" component, AKA mb2hal.

2012-10-27 Thread Sebastian Kuzminsky
Hi Victor, I noticed that Clang caught a couple of issues in mb2hal. Nothing big, two instances of dead initialization (so, a variable is explicitly set at define-time, but then written to again before being read). http://buildbot.linuxcnc.org/clang/master-rt/v2.6.0-pre0-3261-g360e465/report-Wi

Re: [Emc-developers] New PCI based system for LinuxCNC

2012-10-27 Thread Sebastian Kuzminsky
On 10/26/2012 03:49 PM, Bence Kovács wrote: >> Basically what you want to do is clone the central git repo, create a new >> local branch (maybe call it general-mechatronics-driver?), add the files for >> your driver, add a manpage and whatever other docs you want, maybe add a >> sample config, t