On 10/26/2012 03:49 PM, Bence Kovács wrote:
>> Basically what you want to do is clone the central git repo, create a new
>> local branch (maybe call it general-mechatronics-driver?), add the files for
>> your driver, add a manpage and whatever other docs you want, maybe add a
>> sample config, then publish that branch somewhere (github offers free git
>> hosting).
> I added driver and documentation to github:
> https://github.com/BenceKovacs/linuxcnc-mirror
> I hope I did everything fine.
Looks very good over all.
I don't have your board so I can't test the driver, but a couple of
comments:
The driver builds with compile-time warnings on Lucid:
/home/seb/emc2.git/src/hal/drivers/hal_gm.c:1142: warning:
‘CAN_Reset’ defined but not used
/home/seb/emc2.git/src/hal/drivers/hal_gm.c:1151: warning:
‘CAN_SetBaud’ defined but not used
The new HAL manual section is titled 'General Mechatronics Driver', I
think it should be the name of your card instead. I don't know if the
name of the card *is* 'General Mechatronics' or if that's the name of
your company and the board has its own part number.
I like all the drawings you included in the docs. Looks good!
The HAL manual and the Integrator manual have duplicate information, but
I see that the same is true for many (but not all!) of our other
drivers. We should probably clean that up somehow. John Thornton, do
you have any input on this?
No manpage? That's usually the first place I look when I want to know
something, but I think that preference is more common among developers
than users, so maybe it's not so important. If you feel like writing
more docs, a manpage would be welcome.
> We are making and testing sample configurations. It takes a few days
> to make sure they are working fine. I will push it to the same place.
Sounds good, ping me on the emc-developers list when it's there.
I went ahead and pushed your changes to git.linuxcnc.org. It's in the
master branch and will be in the next packages from the buildbot.
Thanks for the driver!
--
Sebastian Kuzminsky
------------------------------------------------------------------------------
WINDOWS 8 is here.
Millions of people. Your app in 30 days.
Visit The Windows 8 Center at Sourceforge for all your go to resources.
http://windows8center.sourceforge.net/
join-generation-app-and-make-money-coding-fast/
_______________________________________________
Emc-developers mailing list
Emc-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/emc-developers
