Hello

> The driver builds with compile-time warnings on Lucid:
>
>      /home/seb/emc2.git/src/hal/drivers/hal_gm.c:1142: warning:
> ‘CAN_Reset’ defined but not used
>      /home/seb/emc2.git/src/hal/drivers/hal_gm.c:1151: warning:
> ‘CAN_SetBaud’ defined but not used
>

I implemented all low level functions for CANopen which is not in use
jet. I placed compiler switch to not compile it.

> The new HAL manual section is titled 'General Mechatronics Driver', I
> think it should be the name of your card instead.  I don't know if the
> name of the card *is* 'General Mechatronics' or if that's the name of
> your company and the board has its own part number.
>

You are right; we worked on it a lot but still forgot to give it a name :).
To avoid misunderstanding and be consequent we gave it the name
GM6-PCI and modified it in the documentation.

> The HAL manual and the Integrator manual have duplicate information, but
> I see that the same is true for many (but not all!) of our other
> drivers.  We should probably clean that up somehow.  John Thornton, do
> you have any input on this?
>

Yes, it makes no sense, it should be cleared or maybe just referenced
in one document and describe in detail in the other one. The generated
html does not have this redundancy. If a convention is made which
document should contain driver descriptions, I will modify our part
according to it.

> No manpage?  That's usually the first place I look when I want to know
> something, but I think that preference is more common among developers
> than users, so maybe it's not so important.  If you feel like writing
> more docs, a manpage would be welcome.
>

Yes, it is something to do. We will come back to it when CANopen
implementation is finished.


> I went ahead and pushed your changes to git.linuxcnc.org.  It's in the
> master branch and will be in the next packages from the buildbot.
>

Thank you a lot. Could you push the changes we made based on your comments?

Thanks,
Bence

------------------------------------------------------------------------------
WINDOWS 8 is here. 
Millions of people.  Your app in 30 days.
Visit The Windows 8 Center at Sourceforge for all your go to resources.
http://windows8center.sourceforge.net/
join-generation-app-and-make-money-coding-fast/
_______________________________________________
Emc-developers mailing list
Emc-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/emc-developers

Reply via email to