Re: [Emc-developers] PRs, CI, issue reporting

2020-05-20 Thread John Morris
On 5/20/20 6:31 PM, andy pugh wrote: On Wed, 20 May 2020 at 11:20, John Morris wrote: I see the GH org's repo has 281 branches. (!!!) Are all those branches inherited from glo (I see some of my own branches in there!), or are individuals still pushing directly to their own feature branches i

Re: [Emc-developers] PRs, CI, issue reporting

2020-05-20 Thread andy pugh
On Wed, 20 May 2020 at 11:20, John Morris wrote: > I see the GH org's repo has 281 branches. (!!!) Are all those branches > inherited from glo (I see some of my own branches in there!), or are > individuals still pushing directly to their own feature branches in the > org's repo? I think this

Re: [Emc-developers] PRs, CI, issue reporting

2020-05-20 Thread John Morris
On 5/20/20 5:30 PM, andy pugh wrote: On Wed, 20 May 2020 at 10:19, John Morris wrote: You don't need to change your feature branch workflow, and of course you can manage those however you like. It's only when you're ready to merge your feature branch into mainline that the "all contributio

Re: [Emc-developers] PRs, CI, issue reporting

2020-05-20 Thread andy pugh
On Wed, 20 May 2020 at 10:19, John Morris wrote: > You don't need to change your feature branch workflow, and of course you > can manage those however you like. It's only when you're ready to merge > your feature branch into mainline that the "all contributions must go > through a PR" requiremen

Re: [Emc-developers] PRs, CI, issue reporting

2020-05-20 Thread John Morris
On 5/20/20 4:38 PM, andy pugh wrote: On Wed, 20 May 2020 at 08:29, John Morris wrote: (B) Some changes going into mainline branches are not going through PRs. If this is not a deliberate decision and the situation evolved organically from the days of glo, the project should consider requiri

Re: [Emc-developers] strange interpreter results

2020-05-20 Thread Reinhard
Hi Andy, On Mittwoch, 20. Mai 2020, 10:28:05 CEST andy pugh wrote: > On Wed, 20 May 2020 at 03:29, Reinhard wrote: > > ... and from tool table: tool 21 is in slot 5 and tool 30 is in slot 21. > > Neither tool 21 nor tool 31 are mentioned in gcode file, so a random > > toolchanger can't use thes

Re: [Emc-developers] PRs, CI, issue reporting

2020-05-20 Thread andy pugh
On Wed, 20 May 2020 at 08:29, John Morris wrote: > (B) Some changes going into mainline branches are not going through PRs. > If this is not a deliberate decision and the situation evolved > organically from the days of glo, the project should consider requiring > all changes go through a submi

Re: [Emc-developers] strange interpreter results - was [iocontrol.0.tool-prepare]

2020-05-20 Thread andy pugh
On Wed, 20 May 2020 at 03:29, Reinhard wrote: > ... and from tool table: tool 21 is in slot 5 and tool 30 is in slot 21. > Neither tool 21 nor tool 31 are mentioned in gcode file, so a random > toolchanger can't use these slots for whatever reason. I noticed that the status in Touchy was showin

[Emc-developers] PRs, CI, issue reporting

2020-05-20 Thread John Morris
I spend a LOT of time reviewing PRs and issues, commit logs and CI build results in a number of projects on GitHub and Bitbucket, and while I'm no expert, I have some recommendations that would make these tasks easier in this project. (A) Buildbot test results aren't reported a GitHub PR's st