Some feedback on this commit... I've not tested it at all, just read
the patch.
On 08/28/2011 10:36 AM, Peter C. Wallace wrote:
> Add support for Mesa 5i21, 5i25 and 4i69 FPGA cards.
>
> Signed-off-by: Peter C. Wallace
>
>
> http://git.linuxcnc.org/?p=emc2.git;a=commitdiff;h=9c81c5b
>
> ---
>
On 29 August 2011 04:02, Sebastian Kuzminsky wrote:
> Whoops, the 5i21 has two IO Connectors named P1, and the 5i25 has no
> connectors.
Two connectors called P1 is wierd, but correct, as it is a single
connector sharing two 32 bit buffers.
I am confused by the second statement. Are you saying t
On Sun, 28 Aug 2011, Sebastian Kuzminsky wrote:
> Date: Sun, 28 Aug 2011 21:02:43 -0600
> From: Sebastian Kuzminsky
> To: emc-developers@lists.sourceforge.net
> Cc: emc-com...@lists.sourceforge.net,
> Peter C. Wallace
> Subject: Re: [Emc-developers] [Emc-commit] v2.5_branc
On 08/29/2011 05:31 AM, andy pugh wrote:
> On 29 August 2011 04:02, Sebastian Kuzminsky wrote:
>> Whoops, the 5i21 has two IO Connectors named P1, and the 5i25 has no
>> connectors.
> Two connectors called P1 is wierd, but correct, as it is a single
> connector sharing two 32 bit buffers.
> I am c
On 29 August 2011 16:48, Sebastian Kuzminsky wrote:
> I did not do the "set per-pin port and pin-within-port information at
> init-time" work, if it's not done by the end of this week by someone else
> I'll do it.
Is this what you had in mind?
This commit adds a port number and port p
On 08/29/2011 06:45 PM, andy pugh wrote:
> Is this what you had in mind?
Looks pretty good, thanks! Comments inline...
>
>
> This commit adds a port number and port pin field to the hm2_pin_t struct,
> populates it once, then uses those numbers in all the places where the
> numbering w
On 30 August 2011 03:28, Sebastian Kuzminsky wrote:
> I think I'd prefer to call hm2_set_pin_numbers() in
> hm2_read_pin_descriptors(), above, instead of initializing them to something
> invalid and hoping we don't need them too soon. At
> hm2_read_pin_descriptor()-time we have enough informatio
