[Emc-developers] [PATCH] Add support for Hostmot2 Buffered SPI and the Mesa 7i65

2011-04-26 Thread andy pugh
Attached are two patches (software and docs) that add support for the Mesa 7i65 and generic SPI functions. The specific 7i65 sub-driver depends on yesterdays pointers-in-comp patch. The SPI functionality introduces a new way for components to communicate with the Hostmot2 driver (as using HAL pin

Re: [Emc-developers] [PATCH] Add support for Hostmot2 Buffered SPI and the Mesa 7i65

2011-04-28 Thread Jeff Epler
In reading this, remember that anything I don't complain about looked fine to me. Overall this looks like pretty good code (though I haven't compiled it and of course have no hardware to test it on). Thanks for your continuing efforts on this SPI stuff. > [-- Attachment #2: > 0002-Add-Support-f

Re: [Emc-developers] [PATCH] Add support for Hostmot2 Buffered SPI and the Mesa 7i65

2011-04-28 Thread andy pugh
> It would be convenient if you could teach your mailer to attach these as > text/plain or text/x-patch. I can try not using Gmail. > but the hal function mesa_7i65 does both reading and writing in one go. I did originally start with two functions and then combined them. However, I think there i

Re: [Emc-developers] [PATCH] Add support for Hostmot2 Buffered SPI and the Mesa 7i65

2011-04-28 Thread Peter C. Wallace
On Thu, 28 Apr 2011, andy pugh wrote: > Date: Thu, 28 Apr 2011 21:26:49 +0100 > From: andy pugh > Reply-To: EMC developers > To: EMC developers > Subject: Re: [Emc-developers] [PATCH] Add support for Hostmot2 Buffered SPI > and the Mesa 7i65 > >> It would be co

Re: [Emc-developers] [PATCH] Add support for Hostmot2 Buffered SPI and the Mesa 7i65

2011-04-28 Thread andy pugh
On 28 April 2011 23:24, Peter C. Wallace wrote: > Yes, you must send to receive with SPI so unless you want to duplicate the > sending (Looking at the 7I43 timing I would think not) you need to reverse the > normal order of read write (for SPI only). This means that the read data is > always from

Re: [Emc-developers] [PATCH] Add support for Hostmot2 Buffered SPI and the Mesa 7i65

2011-04-28 Thread Peter C. Wallace
On Thu, 28 Apr 2011, andy pugh wrote: > Date: Thu, 28 Apr 2011 23:29:26 +0100 > From: andy pugh > Reply-To: EMC developers > To: EMC developers > Subject: Re: [Emc-developers] [PATCH] Add support for Hostmot2 Buffered SPI > and the Mesa 7i65 > > On 28 April 2011

Re: [Emc-developers] [PATCH] Add support for Hostmot2 Buffered SPI and the Mesa 7i65

2011-04-28 Thread Kim Kirwan
evelopers >> Subject: Re: [Emc-developers] [PATCH] Add support for Hostmot2 Buffered SPI >> and the Mesa 7i65 >> >> On 28 April 2011 23:24, Peter C. Wallace wrote: >> >>> Yes, you must send to receive with SPI so unless you want to duplicate the >>&

Re: [Emc-developers] [PATCH] Add support for Hostmot2 Buffered SPI and the Mesa 7i65

2011-04-28 Thread andy pugh
On 29 April 2011 00:36, Kim Kirwan wrote: > I have been following this thread with great interest. I presume > the 7i49 (six-input resolver) is similarly affected due to its > use of SPI to the mothercard? Is this so? I have a 7i49 here > if it will help in any way (indirectly) with the 7i65. I w

Re: [Emc-developers] [PATCH] Add support for Hostmot2 Buffered SPI and the Mesa 7i65

2011-04-28 Thread Peter C. Wallace
On Thu, 28 Apr 2011, Kim Kirwan wrote: > Date: Thu, 28 Apr 2011 18:36:35 -0500 > From: Kim Kirwan > Reply-To: EMC developers > To: emc-developers@lists.sourceforge.net > Subject: Re: [Emc-developers] [PATCH] Add support for Hostmot2 Buffered SPI > and the Mesa 7i6

Re: [Emc-developers] [PATCH] Add support for Hostmot2 Buffered SPI and the Mesa 7i65

2011-04-28 Thread Jeff Epler
On Thu, Apr 28, 2011 at 09:26:49PM +0100, andy pugh wrote: > > It would be convenient if you could teach your mailer to attach these as > > text/plain or text/x-patch. > > I can try not using Gmail. Well, the trouble on my end is not *too* bad, just a few extra keypresses. > > The implementation

Re: [Emc-developers] [PATCH] Add support for Hostmot2 Buffered SPI and the Mesa 7i65

2011-05-24 Thread andy pugh
On 29 April 2011 01:56, Jeff Epler wrote: > When committing, consider using "git gui" to do it.  It facilitates not > committing unwanted changes in the first place, and I also like the way > it makes me review my code one more time before committing it. I already do use git gui, but I had not p

Re: [Emc-developers] [PATCH] Add support for Hostmot2 Buffered SPI and the Mesa 7i65

2011-05-27 Thread andy pugh
On 28 April 2011 14:20, Jeff Epler wrote: > Looking at the mesa_7i65.comp, I am concerned about the order of > operations.  In fact, I don't see how your design can achieve the > desired order. I have looked into this, and it seems to me that is should be possible to add an extra stage to the Ho