[E-devel] printf-style new function for eina strbufs

2011-09-16 Thread Ulrich Eckhardt
Hi! I've been wondering why there are ways to append to a strbuf but no way to create one from scratch providing a format string and arguments. Actually, I've found a few places where a strbuf is created (with its default size) and then appended to, possibly causing a reallocation. I think the

Re: [E-devel] Evas generic loaders install location

2011-09-04 Thread Ulrich Eckhardt
On Friday 02 September 2011 23:25:01 Gustavo Sverzut Barbieri wrote: > Recently we added something similar to Evas' generic loaders to > Emotion. Initially Antognolli installed them to $(bindir) (/usr/bin) > and I complained and changed it to $(libdir)/emotion/utils similar to > Enlightenment's uti

Re: [E-devel] [Patch] Build on Windows - Build Error

2011-09-04 Thread Ulrich Eckhardt
On Friday 02 September 2011 09:12:07 Vincent Torri wrote: > using typedef enum _foo > { *** } foo; > > would be cleaner. I'm wondering if the c++ standard forbid such > construction Yes, but only because it uses a name with a leading underscore, which is reserved in the global namespace. That sa

Re: [E-devel] Introducing Picture widget

2011-08-29 Thread Ulrich Eckhardt
On Saturday 20 August 2011 23:13:23 Quentin Gibeaux wrote: > The images downloaded from the web are stored in the /tmp folder (is that > linuxproof only?). The canonical dir for temporary files is $TMPDIR, according to POSIX, and that should be used on anything but MS Windows, which has a special

Re: [E-devel] epp does not remove \r at the end of lines

2011-07-16 Thread Ulrich Eckhardt
On Saturday 16 July 2011 09:11:15 Vincent Torri wrote: [hexdump] > what's the difference with > > diff -u file1 file2 > > ? "diff" tries to be convenient, just like many text-based tools, so it hides different line-endings from you. "hexdump" works with bytes and doesn't try to make things eas

Re: [E-devel] epp does not remove \r at the end of lines

2011-07-15 Thread Ulrich Eckhardt
On Saturday 16 July 2011 01:04:29 Vincent Torri wrote: > On Fri, 15 Jul 2011, Ulrich Eckhardt wrote: > > Does it have multiple lines at all? > > what do you mean ? What is the file content? Is it - multiple lines terminated by CR or CRLF? - a single line terminated by CR or

Re: [E-devel] epp does not remove \r at the end of lines

2011-07-15 Thread Ulrich Eckhardt
On Thursday 14 July 2011 16:36:58 Vincent Torri wrote: > raster added a 'dos2unix' function in epp to remove trailing \r (rev > 59799). As I understand it, it converts '\r\n' to '\n' in a string. > However, when i compare the files generated by epp on Windows and > linux (just after line 751 of

Re: [E-devel] Ecore XCB

2011-07-15 Thread Ulrich Eckhardt
On Tuesday 12 July 2011 16:25:21 Christopher Michael wrote: > The old evas/ecore_x code used xcb_image_create_native to create basic x > images, but the code for xcb_image_create_native does not check for > endian-ness (it creates everything using MSB_FIRST) which is incorrect. If you need somethi

Re: [E-devel] XRender engine causes ecore build failure

2011-06-15 Thread Ulrich Eckhardt
On Saturday 11 June 2011 16:43:55 Christopher Michael wrote: > On 06/11/2011 06:11 AM, Ulrich Eckhardt wrote: > > On Saturday 11 June 2011 10:19:40 Ulrich Eckhardt wrote: > >> I'm trying to create a patch which does just that, which I'll post > >> lateron. &

Re: [E-devel] E SVN: cedric IN trunk/eina: . src/include src/lib

2011-06-15 Thread Ulrich Eckhardt
On Wednesday 15 June 2011 22:27:06 Cedric BAIL wrote: [...] > /** > + * @brief Redefine the callback that clean the data of a hash > + * > + * @param hash The given hash table > + * @param data_free_cb The function called on each value when the > + * hash table is freed. @c

Re: [E-devel] E SVN: cedric IN trunk/eina: . src/include src/lib

2011-06-15 Thread Ulrich Eckhardt
On Wednesday 15 June 2011 18:06:03 Cedric BAIL wrote: > On Wed, Jun 15, 2011 at 5:53 PM, Mike Blumenkrantz wrote: > > On Wed, 15 Jun 2011 08:46:11 -0700 > > > >> /** > >> + * @brief Redefine the callback that clean the data of a hash > >> + * > >> + * @param hash The given hash table > >> + * @

Re: [E-devel] Provide sensible errors for edje utilities

2011-06-15 Thread Ulrich Eckhardt
On Wednesday 15 June 2011 07:56:25 Mike Blumenkrantz wrote: > On Wed, 15 Jun 2011 07:55:27 +0200 (CEST) > Vincent Torri wrote: > > On Wed, 15 Jun 2011, Mike Blumenkrantz wrote: > > > I like the idea of better error messages, but using access creates a > > > permissions loophole where the file coul

[E-devel] Provide sensible errors for edje utilities

2011-06-14 Thread Ulrich Eckhardt
Hi! If you start edje_player or edje_inspector with a path to a file that doesn't exist you get a bogus error message saying that the file doesn't contain any groups. The attached patch uses access() to check if the program can read the file, giving a sensible error message if not. I have chec

[E-devel] Problems with Evas OpenGL/X11

2011-06-13 Thread Ulrich Eckhardt
Hi! I'm trying to use the OpenGL renderer of Evas on an X11 display. As a test program, I'm using edje_player. Normally it works, but this doesn't: $ edje_player -e=opengl_x11 ../../test1.edj ERR<5244>:evas-gl_x11 evas_x_main.c:802 eng_best_visual_get() glXChooseFBConfig returned no configs

Re: [E-devel] XRender engine causes ecore build failure

2011-06-11 Thread Ulrich Eckhardt
On Saturday 11 June 2011 10:19:40 Ulrich Eckhardt wrote: > I'm trying to create a patch which does just that, which I'll post lateron. Here it comes. There are a few observations which I'm not sure how to resolve: 1. configure.ac There is a check for the Xcursor support, whic

[E-devel] Patch for ecore tests

2011-06-11 Thread Ulrich Eckhardt
Greetings! The ecore tests fail to build because they need to be linked to eina, the error is that eina_log_domain_register is not found by the linker. The attached patch fixes that. Uli Index: Makefile.am === --- Makefile.am (revi

[E-devel] XRender engine causes ecore build failure

2011-06-11 Thread Ulrich Eckhardt
Hi! The error is Evas_Engine_XRender_X11.h: No such file or directory while building ecore. The problem is that this engine was removed from evas but not yet completely from ecore. I was on IRC with Vincent Torri (vtorri) and Daniel Juyung Seo (SeoZ) and the consensus was to remove the code

[E-devel] eina_strbuf_common.c, what is the meaning of "csize"

2011-06-10 Thread Ulrich Eckhardt
Hi! I hope I'm not asking too many stupid questions, but here's another one that came up while reading Eina's buffer implementation. In e.g. the function "eina_strbuf_common_new(size_t csize)", there is this undocumented parameter "csize" that is passed to various other functions, too. This see

[E-devel] weird function/macro in eina_ustrbuf.h

2011-06-10 Thread Ulrich Eckhardt
I noticed some weirdness in eina_ustrbuf.h, there is a macro called eina_ustrbuf_prepend_Eina_Unicode, which looks as if some search'n'replace operation on it had gone wrong. Looking at its documentation seems to confirm this. Some invokations of "svn blame", I find that this weirdness is presen

[E-devel] Evas code reentrant/thread-safe by design?

2011-06-07 Thread Ulrich Eckhardt
Hi! I have a question regarding the thread-safety and reentrancy of Evas. Firstly, are these actually goals or is Evas intended by design to be used in a single thread for rendering? If so, you can ignore my other questions Now, what got me started on this issue is the commit in http://tra

Re: [E-devel] Leak in _ecore_thread_win32_join()?

2011-06-07 Thread Ulrich Eckhardt
On Tuesday 07 June 2011 22:53:59 Vincent Torri wrote: > It's nice to see someone interested in the win32 code :) Thank you for writing it! Actually, I'm interested in the WinCE port even, because that's the platform I work with for a living, doing embedded programming in an industrial environmen

[E-devel] Casts in ecore_win32_window.c necessary?

2011-06-07 Thread Ulrich Eckhardt
Hi! The following code is an example from that file: EAPI void ecore_win32_window_free(Ecore_Win32_Window *window) { Ecore_Win32_Window *wnd = window; if (!window) return; INF("destroying window"); if (wnd->shape.mask) free(wnd->shape.mask); DestroyWindow(((Ecore_Win32_Wi

[E-devel] Leak in _ecore_thread_win32_join()?

2011-06-07 Thread Ulrich Eckhardt
Hi! The functions looks like this: int _ecore_thread_win32_join(win32_thread *x, void **res) { if (!PHE(x, PHS())) { WaitForSingleObject(x->thread, INFINITE); CloseHandle(x->thread); } if (res) *res = x->val; return 0; } What I'm wondering is if there shouldn't be a "f

[E-devel] Cut'n'paste error in ecore_pipe.c

2011-06-06 Thread Ulrich Eckhardt
Hi! I've been reading commits recently, and found a small buglet committed in revision 59823. The line ECORE_MAGIC_FAIL(p, ECORE_MAGIC_PIPE, "ecore_pipe_read_close"); should probably contain the function name as string, but it doesn't for the freeze/thaw functions. Uli ---